MPTCP Linux Development
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v8 0/8] mptcp: use GENL_REQ_ATTR_CHECK in userspace pm
Date: Thu, 9 Jan 2025 16:23:42 +0100	[thread overview]
Message-ID: <25bd50d1-19e8-476b-b5cf-e724e702c25b@kernel.org> (raw)
In-Reply-To: <cover.1736299989.git.tanggeliang@kylinos.cn>

Hi Geliang,

On 08/01/2025 02:44, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v8:
>  - move the set_flags() patches out of this set.
>  - differences from v6:
>   - adjust the order of the patches.
>   - keep "pernet = pm_nl_get_pernet(net);" at the beginning of
>     mptcp_pm_nl_set_flags().
>   - not use NL_SET_ERR_MSG_ATTR in mptcp_pm_nl_set_flags(), since 'attr'
>     will be removed in the commit "mptcp: add local & remote parameters for
>     set_flags".

Because there are still some discussions ongoing on that patch, and not
to block this series here that is almost ready, I think it might be
easier to keep these modifications in 'set_flags()' here. The other
series can be rebased on top of this one (with a "Based-on:" if needed).

With this modification (and moving the changelog to the comment section
+ maybe keeping GENL_REQ_ATTR_CHECK() at the top), I think we can merge
this series.

WDYT?

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


      parent reply	other threads:[~2025-01-09 15:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08  1:44 [PATCH mptcp-next v8 0/8] mptcp: use GENL_REQ_ATTR_CHECK in userspace pm Geliang Tang
2025-01-08  1:44 ` [PATCH mptcp-next v8 1/8] mptcp: drop info of userspace_pm_remove_id_zero_address Geliang Tang
2025-01-08  1:44 ` [PATCH mptcp-next v8 2/8] mptcp: pm: userspace: flags: clearer msg if no remote addr Geliang Tang
2025-01-08  1:44 ` [PATCH mptcp-next v8 3/8] mptcp: pm: more precise error messages Geliang Tang
2025-01-08  1:44 ` [PATCH mptcp-next v8 4/8] mptcp: pm: improve " Geliang Tang
2025-01-09 15:23   ` Matthieu Baerts
2025-01-08  1:44 ` [PATCH mptcp-next v8 5/8] mptcp: pm: userspace: use GENL_REQ_ATTR_CHECK Geliang Tang
2025-01-09 15:24   ` Matthieu Baerts
2025-01-08  1:44 ` [PATCH mptcp-next v8 6/8] mptcp: pm: remove duplicated error messages Geliang Tang
2025-01-08  1:44 ` [PATCH mptcp-next v8 7/8] mptcp: pm: mark missing address attributes Geliang Tang
2025-01-09 15:24   ` Matthieu Baerts
2025-01-08  1:44 ` [PATCH mptcp-next v8 8/8] mptcp: pm: use NL_SET_ERR_MSG_ATTR when possible Geliang Tang
2025-01-08  3:25 ` [PATCH mptcp-next v8 0/8] mptcp: use GENL_REQ_ATTR_CHECK in userspace pm MPTCP CI
2025-01-09 15:23 ` Matthieu Baerts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25bd50d1-19e8-476b-b5cf-e724e702c25b@kernel.org \
    --to=matttbe@kernel.org \
    --cc=geliang@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=tanggeliang@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox