Re: [PATCH mptcp-next v8 7/8] mptcp: pm: mark missing address attributes

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 08/01/2025 02:44, Geliang Tang wrote:
> From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
> 
> mptcp_pm_parse_entry() will check if the given attribute is defined. If
> not, it will return a generic error: "missing address info".
> 
> It might then not be clear for the userspace developer which attribute
> is missing, especially when the command takes multiple addresses.
> 
> By using GENL_REQ_ATTR_CHECK(), the userspace will get a hint about
> which attribute is missing, making thing clearer. Note that this is what
> was already done for most of the other MPTCP NL commands, this patch
> simply adds the missing ones.
> 
> v2:
>  - keep "pernet = pm_nl_get_pernet(net);" at the beginning of
> mptcp_pm_nl_set_flags().

Why did you move it there? The GENL_REQ_ATTR_CHECK() are usually done
first, no? There is no need to get 'pernet' if some attributes are missing.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.