MPTCP Linux Development
 help / color / mirror / Atom feed
From: Geliang Tang <geliang@kernel.org>
To: mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: [PATCH mptcp-next v8 0/8] mptcp: use GENL_REQ_ATTR_CHECK in userspace pm
Date: Wed,  8 Jan 2025 09:44:01 +0800	[thread overview]
Message-ID: <cover.1736299989.git.tanggeliang@kylinos.cn> (raw)

From: Geliang Tang <tanggeliang@kylinos.cn>

v8:
 - move the set_flags() patches out of this set.
 - differences from v6:
  - adjust the order of the patches.
  - keep "pernet = pm_nl_get_pernet(net);" at the beginning of
    mptcp_pm_nl_set_flags().
  - not use NL_SET_ERR_MSG_ATTR in mptcp_pm_nl_set_flags(), since 'attr'
    will be removed in the commit "mptcp: add local & remote parameters for
    set_flags".
  - update the code related mptcp_userspace_pm_remove_id_zero_address()
    since a new patch to drop "info" parameter of this patch is added.
  - add a comment "mptcp_pm_nl_mp_prio_send_ack() only fails in one case"
    in mptcp_userspace_pm_set_flags().

v7:
 - update set_flags() interface.
 - drop 'info' parameter of userspace_pm_remove_id_zero_address().
 - rebase v6 on top of these changes.

This is a newer version of the series started by Geliang, now making
them more uniform on how the NL errors are set, and giving more hints to
the userspace about what's wrong.

Geliang Tang (2):
  mptcp: drop info of userspace_pm_remove_id_zero_address
  mptcp: pm: userspace: use GENL_REQ_ATTR_CHECK

Matthieu Baerts (NGI0) (6):
  mptcp: pm: userspace: flags: clearer msg if no remote addr
  mptcp: pm: more precise error messages
  mptcp: pm: improve error messages
  mptcp: pm: remove duplicated error messages
  mptcp: pm: mark missing address attributes
  mptcp: pm: use NL_SET_ERR_MSG_ATTR when possible

 net/mptcp/pm_netlink.c   |  43 ++++++++---
 net/mptcp/pm_userspace.c | 149 +++++++++++++++++++++++----------------
 2 files changed, 119 insertions(+), 73 deletions(-)

-- 
2.45.2


             reply	other threads:[~2025-01-08  1:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08  1:44 Geliang Tang [this message]
2025-01-08  1:44 ` [PATCH mptcp-next v8 1/8] mptcp: drop info of userspace_pm_remove_id_zero_address Geliang Tang
2025-01-08  1:44 ` [PATCH mptcp-next v8 2/8] mptcp: pm: userspace: flags: clearer msg if no remote addr Geliang Tang
2025-01-08  1:44 ` [PATCH mptcp-next v8 3/8] mptcp: pm: more precise error messages Geliang Tang
2025-01-08  1:44 ` [PATCH mptcp-next v8 4/8] mptcp: pm: improve " Geliang Tang
2025-01-09 15:23   ` Matthieu Baerts
2025-01-08  1:44 ` [PATCH mptcp-next v8 5/8] mptcp: pm: userspace: use GENL_REQ_ATTR_CHECK Geliang Tang
2025-01-09 15:24   ` Matthieu Baerts
2025-01-08  1:44 ` [PATCH mptcp-next v8 6/8] mptcp: pm: remove duplicated error messages Geliang Tang
2025-01-08  1:44 ` [PATCH mptcp-next v8 7/8] mptcp: pm: mark missing address attributes Geliang Tang
2025-01-09 15:24   ` Matthieu Baerts
2025-01-08  1:44 ` [PATCH mptcp-next v8 8/8] mptcp: pm: use NL_SET_ERR_MSG_ATTR when possible Geliang Tang
2025-01-08  3:25 ` [PATCH mptcp-next v8 0/8] mptcp: use GENL_REQ_ATTR_CHECK in userspace pm MPTCP CI
2025-01-09 15:23 ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1736299989.git.tanggeliang@kylinos.cn \
    --to=geliang@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=tanggeliang@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox