Re: [PATCH mptcp-next v8 4/8] mptcp: pm: improve error messages

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 08/01/2025 02:44, Geliang Tang wrote:
> From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
> 
> Some error messages were:
> 
>  - too generic: "missing input", "invalid request"
> 
>  - not precise enough: "limit greater than maximum" but what's the max?
> 
>  - missing: subflow not found, or connect error.
> 
> This can be easily improved by being more precise, or adding new error
> messages.
> 
> v2: add a comment in mptcp_userspace_pm_set_flags().

Thank you for this in-line comment, I find it very helpful for the
reviewers compared to a global one in the cover-letter where we don't
know exactly which patch has been modified.

Just one thing: can you move this changelog comment below the last SoB,
under a line with '---'? ...

> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

... so here:

  ---
  - v2: (...)

(or you can also use 'git notes edit' and the '--notes' option with
'send-email' or 'format-patch'. If you use it for the first time, you
will need to set 'notes.rewriteRef' config not to lose notes after a
rebase, see: https://stackoverflow.com/a/14601464)

Same in patch 7/8 and 8/8.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.