Re: [RFC 04/11] dma-mapping: add dma_alloc_attrs_node() and dma_alloc_coherent_node()

[Marek Szyprowski <m.szyprowski@samsung.com>]

On 27.10.2026 03:25, Jakub Kicinski wrote:
> @@ -683,6 +699,14 @@ void *dma_alloc_attrs(struct device *dev, size_t size, dma_addr_t *dma_handle,
>  	debug_dma_alloc_coherent(dev, size, *dma_handle, cpu_addr, attrs);
>  	return cpu_addr;
>  }
> +EXPORT_SYMBOL_GPL(dma_alloc_attrs_node);
> +
> +void *dma_alloc_attrs(struct device *dev, size_t size, dma_addr_t *dma_handle,
> +		gfp_t flag, unsigned long attrs)
> +{
> +	return dma_alloc_attrs_node(dev, size, dma_handle, flag, attrs,
> +				    dev_to_node(dev));
> +}
>  EXPORT_SYMBOL(dma_alloc_attrs);

Do we really need two exported symbols for dma_alloc_attrs()? I would prefer
to make dma_alloc_attrs() a static inline calling dma_alloc_attrs_node().

Did I missed something obvious against that?

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland