From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: robin.murphy@arm.com, tglx@kernel.org,
dave.hansen@linux.intel.com, x86@kernel.org, joro@8bytes.org,
will@kernel.org, leon@kernel.org, mbloch@nvidia.com,
iommu@lists.linux.dev, netdev@vger.kernel.org
Subject: Re: [RFC 04/11] dma-mapping: add dma_alloc_attrs_node() and dma_alloc_coherent_node()
Date: Wed, 28 Oct 2026 10:00:16 +0100 [thread overview]
Message-ID: <de164c18-a80f-4081-a91c-c5d9e358e1f1@samsung.com> (raw)
In-Reply-To: <20261027105253.2c3d58a9@kernel.org>
On 27.10.2026 18:52, Jakub Kicinski wrote:
> On Tue, 27 Oct 2026 16:24:44 +0100 Marek Szyprowski wrote:
>>> +EXPORT_SYMBOL_GPL(dma_alloc_attrs_node);
>>> +
>>> +void *dma_alloc_attrs(struct device *dev, size_t size, dma_addr_t *dma_handle,
>>> + gfp_t flag, unsigned long attrs)
>>> +{
>>> + return dma_alloc_attrs_node(dev, size, dma_handle, flag, attrs,
>>> + dev_to_node(dev));
>>> +}
>>> EXPORT_SYMBOL(dma_alloc_attrs);
>> Do we really need two exported symbols for dma_alloc_attrs()? I would prefer
>> to make dma_alloc_attrs() a static inline calling dma_alloc_attrs_node().
>>
>> Did I missed something obvious against that?
> License, I associate DMA API with hch so I thought we'd want to make
> the new symbol GPL-only? LMK if I'm overthinking this.
Right, I missed that GPL suffix in the new API.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2026-10-28 9:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 2:25 [RFC 00/11] dma-mapping: add dma_alloc_attrs_node() and dma_alloc_coherent_node() Jakub Kicinski
2026-10-27 2:25 ` [RFC 01/11] dma-contiguous: pass the NUMA node to dma_alloc_contiguous() Jakub Kicinski
2026-10-27 2:25 ` [RFC 02/11] dma-direct: pass the NUMA node to dma_direct_alloc() Jakub Kicinski
2026-10-27 2:25 ` [RFC 03/11] iommu/dma: pass the NUMA node to iommu_dma_alloc() Jakub Kicinski
2026-10-27 2:25 ` [RFC 04/11] dma-mapping: add dma_alloc_attrs_node() and dma_alloc_coherent_node() Jakub Kicinski
2026-10-27 9:03 ` Björn Töpel
2026-10-27 15:53 ` Jakub Kicinski
2026-10-27 15:24 ` Marek Szyprowski
2026-10-27 17:52 ` Jakub Kicinski
2026-10-28 9:00 ` Marek Szyprowski [this message]
2026-10-27 2:25 ` [RFC 05/11] eth: libwx: restore the device's NUMA node after ring allocation Jakub Kicinski
2026-10-27 2:25 ` [RFC 06/11] eth: libwx: use dma_alloc_coherent_node() Jakub Kicinski
2026-10-27 2:25 ` [RFC 07/11] eth: ixgbe: " Jakub Kicinski
2026-10-27 9:06 ` Björn Töpel
2026-10-27 15:51 ` Jakub Kicinski
2026-10-27 16:06 ` Björn Töpel
2026-10-27 18:20 ` Jakub Kicinski
2026-10-29 8:47 ` Björn Töpel
2026-10-29 9:17 ` Marek Szyprowski
2026-10-27 2:25 ` [RFC 08/11] eth: xgbe: " Jakub Kicinski
2026-10-27 2:25 ` [RFC 09/11] eth: fungible: " Jakub Kicinski
2026-10-27 2:25 ` [RFC 10/11] eth: mlx5: " Jakub Kicinski
2026-10-27 2:25 ` [RFC 11/11] eth: mlx4: " Jakub Kicinski
2026-10-27 9:03 ` [RFC 00/11] dma-mapping: add dma_alloc_attrs_node() and dma_alloc_coherent_node() Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de164c18-a80f-4081-a91c-c5d9e358e1f1@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=dave.hansen@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=tglx@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox