Re: [RFC 07/11] eth: ixgbe: use dma_alloc_coherent_node()

["Björn Töpel" <bjorn@kernel.org>]

Jakub Kicinski <kuba@kernel.org> writes:

> On Tue, 27 Oct 2026 10:06:03 +0100 Björn Töpel wrote:
>> > -	set_dev_node(dev, orig_node);
>> > +	tx_ring->desc = dma_alloc_coherent_node(dev, tx_ring->size,
>> > +						&tx_ring->dma, GFP_KERNEL,
>> > +						ring_node);
>> >  	if (!tx_ring->desc)
>> >  		tx_ring->desc = dma_alloc_coherent(dev, tx_ring->size,
>> >  						   &tx_ring->dma, GFP_KERNEL);  
>> 
>> Not really this series, but the fallback here is odd, no? I thought the
>> allocator already did cross-zone fallback?
>
> Fair, I was too lazy to check. I'll remove the fallbacks in the same
> patch. Seems obvious enough. LMK if you prefer separate.

Hmm. Seems like dma_alloc_contiguous() doesn't spill over to other
nodes. It only tries the per-NUMA CMA... so keeping it is bit more
robust. (Then again, I dunno...)

I'd say keep it.


Björn