From: Jacob Keller <jacob.e.keller@intel.com>
To: Shannon Nelson <shannon.nelson@amd.com>, <netdev@vger.kernel.org>,
<davem@davemloft.net>, <kuba@kernel.org>, <edumazet@google.com>,
<pabeni@redhat.com>, <andrew+netdev@lunn.ch>
Cc: <brett.creeley@amd.com>
Subject: Re: [PATCH net-next 5/5] ionic: add support for QSFP_PLUS_CMIS
Date: Tue, 10 Dec 2024 14:53:46 -0800 [thread overview]
Message-ID: <108b6d70-cb06-4fd7-9cb8-f926a1b0e363@intel.com> (raw)
In-Reply-To: <20241210183045.67878-6-shannon.nelson@amd.com>
On 12/10/2024 10:30 AM, Shannon Nelson wrote:
> Teach the driver to recognize and decode the sfp pid
> SFF8024_ID_QSFP_PLUS_CMIS correctly.
>
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> index 272317048cb9..720092b1633a 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> @@ -968,6 +968,7 @@ static int ionic_get_module_info(struct net_device *netdev,
> break;
> case SFF8024_ID_QSFP_8436_8636:
> case SFF8024_ID_QSFP28_8636:
> + case SFF8024_ID_QSFP_PLUS_CMIS:
> modinfo->type = ETH_MODULE_SFF_8436;
> modinfo->eeprom_len = ETH_MODULE_SFF_8436_LEN;
> break;
next prev parent reply other threads:[~2024-12-10 22:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 18:30 [PATCH net-next 0/5] ionic: minor code updates Shannon Nelson
2024-12-10 18:30 ` [PATCH net-next 1/5] ionic: add asic codes to firmware interface file Shannon Nelson
2024-12-10 22:44 ` Jacob Keller
2024-12-11 3:36 ` Kalesh Anakkur Purayil
2024-12-10 18:30 ` [PATCH net-next 2/5] ionic: Use VLAN_ETH_HLEN when possible Shannon Nelson
2024-12-10 22:45 ` Jacob Keller
2024-12-11 3:32 ` Kalesh Anakkur Purayil
2024-12-10 18:30 ` [PATCH net-next 3/5] ionic: Translate IONIC_RC_ENOSUPP to EOPNOTSUPP Shannon Nelson
2024-12-10 22:45 ` Jacob Keller
2024-12-11 3:31 ` Kalesh Anakkur Purayil
2024-12-10 18:30 ` [PATCH net-next 4/5] ionic: add speed defines for 200G and 400G Shannon Nelson
2024-12-10 22:53 ` Jacob Keller
2024-12-10 23:21 ` Nelson, Shannon
2024-12-10 18:30 ` [PATCH net-next 5/5] ionic: add support for QSFP_PLUS_CMIS Shannon Nelson
2024-12-10 22:53 ` Jacob Keller [this message]
2024-12-11 3:30 ` Kalesh Anakkur Purayil
2024-12-11 10:12 ` Ido Schimmel
2024-12-11 17:15 ` Nelson, Shannon
2024-12-12 11:20 ` [PATCH net-next 0/5] ionic: minor code updates patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=108b6d70-cb06-4fd7-9cb8-f926a1b0e363@intel.com \
--to=jacob.e.keller@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox