Re: [PATCH net-next 2/5] ionic: Use VLAN_ETH_HLEN when possible

[Jacob Keller <jacob.e.keller@intel.com>]

On 12/10/2024 10:30 AM, Shannon Nelson wrote:
> From: Brett Creeley <brett.creeley@amd.com>
> 
> Replace when ETH_HLEN and VLAN_HLEN are used together with
> VLAN_ETH_HLEN since it's the same value and uses 1 define
> instead of 2.
> 
> Signed-off-by: Brett Creeley <brett.creeley@amd.com>
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
> ---
>  drivers/net/ethernet/pensando/ionic/ionic_lif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> index 40496587b2b3..052c767a2c75 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> @@ -3265,7 +3265,7 @@ int ionic_lif_alloc(struct ionic *ionic)
>  	lif->netdev->min_mtu = max_t(unsigned int, ETH_MIN_MTU,
>  				     le32_to_cpu(lif->identity->eth.min_frame_size));
>  	lif->netdev->max_mtu =
> -		le32_to_cpu(lif->identity->eth.max_frame_size) - ETH_HLEN - VLAN_HLEN;
> +		le32_to_cpu(lif->identity->eth.max_frame_size) - VLAN_ETH_HLEN;
>  
>  	lif->neqs = ionic->neqs_per_lif;
>  	lif->nxqs = ionic->ntxqs_per_lif;

Nice shorter line.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>