From: "Nelson, Shannon" <shannon.nelson@amd.com>
To: Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch
Cc: brett.creeley@amd.com
Subject: Re: [PATCH net-next 4/5] ionic: add speed defines for 200G and 400G
Date: Tue, 10 Dec 2024 15:21:06 -0800 [thread overview]
Message-ID: <b044a65f-ad68-4d30-9e98-876de8f55faf@amd.com> (raw)
In-Reply-To: <4acaaf9e-211f-4bc3-9886-a05cd5d0e7c8@intel.com>
On 12/10/2024 2:53 PM, Jacob Keller wrote:
> On 12/10/2024 10:30 AM, Shannon Nelson wrote:
>> Add higher speed defines to the ionic_if.h API and decode them
>> in the ethtool get_link_ksettings callback.
>>
>> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
>> ---
>
> You might consider refactoring the ionic driver to use the
> ethtool_forced_speed_maps_init interface at some point. See 26c5334d344d
> ("ethtool: Add forced speed to supported link modes maps"), with
> 982b0192db45 ("ice: Refactor finding advertised link speed") and
> 1d4e4ecccb11 ("qede: populate supported link modes maps on module init")
> (though it looks like the latter hasn't moved to the ethtool function).
>
> This saves a bunch of text size on the module.
Yeah, and it would get rid of the silly CamelCase code complaints as
well. We'll have to take look at this in a future opportunity.
Thanks for the Reviews,
sln
next prev parent reply other threads:[~2024-12-10 23:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 18:30 [PATCH net-next 0/5] ionic: minor code updates Shannon Nelson
2024-12-10 18:30 ` [PATCH net-next 1/5] ionic: add asic codes to firmware interface file Shannon Nelson
2024-12-10 22:44 ` Jacob Keller
2024-12-11 3:36 ` Kalesh Anakkur Purayil
2024-12-10 18:30 ` [PATCH net-next 2/5] ionic: Use VLAN_ETH_HLEN when possible Shannon Nelson
2024-12-10 22:45 ` Jacob Keller
2024-12-11 3:32 ` Kalesh Anakkur Purayil
2024-12-10 18:30 ` [PATCH net-next 3/5] ionic: Translate IONIC_RC_ENOSUPP to EOPNOTSUPP Shannon Nelson
2024-12-10 22:45 ` Jacob Keller
2024-12-11 3:31 ` Kalesh Anakkur Purayil
2024-12-10 18:30 ` [PATCH net-next 4/5] ionic: add speed defines for 200G and 400G Shannon Nelson
2024-12-10 22:53 ` Jacob Keller
2024-12-10 23:21 ` Nelson, Shannon [this message]
2024-12-10 18:30 ` [PATCH net-next 5/5] ionic: add support for QSFP_PLUS_CMIS Shannon Nelson
2024-12-10 22:53 ` Jacob Keller
2024-12-11 3:30 ` Kalesh Anakkur Purayil
2024-12-11 10:12 ` Ido Schimmel
2024-12-11 17:15 ` Nelson, Shannon
2024-12-12 11:20 ` [PATCH net-next 0/5] ionic: minor code updates patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b044a65f-ad68-4d30-9e98-876de8f55faf@amd.com \
--to=shannon.nelson@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox