Re: [PATCH net-next 3/5] ionic: Translate IONIC_RC_ENOSUPP to EOPNOTSUPP

[Jacob Keller <jacob.e.keller@intel.com>]

On 12/10/2024 10:30 AM, Shannon Nelson wrote:
> From: Brett Creeley <brett.creeley@amd.com>
> 
> Instead of reporting -EINVAL when IONIC_RC_ENOSUPP is returned use
> the -EOPNOTSUPP value. This aligns better since the FW only returns
> IONIC_RC_ENOSUPP when operations aren't supported not when invalid
> values are used.
> 
> Signed-off-by: Brett Creeley <brett.creeley@amd.com>
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
> ---

Makes sense.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

>  drivers/net/ethernet/pensando/ionic/ionic_main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_main.c b/drivers/net/ethernet/pensando/ionic/ionic_main.c
> index 0f817c3f92d8..daf1e82cb76b 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_main.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_main.c
> @@ -81,8 +81,9 @@ static int ionic_error_to_errno(enum ionic_status_code code)
>  	case IONIC_RC_EQTYPE:
>  	case IONIC_RC_EQID:
>  	case IONIC_RC_EINVAL:
> -	case IONIC_RC_ENOSUPP:
>  		return -EINVAL;
> +	case IONIC_RC_ENOSUPP:
> +		return -EOPNOTSUPP;
>  	case IONIC_RC_EPERM:
>  		return -EPERM;
>  	case IONIC_RC_ENOENT: