From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: eilong@broadcom.com, bhutchings@solarflare.com,
pstaszewski@itcare.pl, netdev@vger.kernel.org,
Thomas Graf <tgraf@infradead.org>,
Tom Herbert <therbert@google.com>,
Jamal Hadi Salim <hadi@mojatatu.com>,
Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH net-next] bnx2x: reduce skb truesize by 50%
Date: Mon, 14 Nov 2011 16:57:45 +0100 [thread overview]
Message-ID: <1321286265.2272.46.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> (raw)
In-Reply-To: <1321251945.17837.55.camel@edumazet-laptop>
Le lundi 14 novembre 2011 à 07:25 +0100, Eric Dumazet a écrit :
> Le lundi 14 novembre 2011 à 00:08 -0500, David Miller a écrit :
>
> > I fully support bringing this thing back to life :-)
>
> I'll make extensive tests today and provide two patches when ready, with
> all performance results.
>
> Some prefetch() calls will be removed, since build_skb() provides
> already cache hot skb.
Impressive results :
before : 720.000 pps
after : 820.000 pps
[ One mono threaded application receiving UDP messages on a single
socket, asking IP_PKTINFO ancillary info ]
Latencies are also a bit improved : softirq handler dirties about 320
bytes less per skb.
Definitely worth the pain.
I am sending two patches. Other drivers probably can benefit from
build_skb() as well.
[PATCH net-next 1/2] net: introduce build_skb()
[PATCH net-next 2/2] bnx2x: uses build_skb() in receive path
next prev parent reply other threads:[~2011-11-14 15:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-06 15:57 Linux Route Cache performance tests Paweł Staszewski
2011-11-06 17:29 ` Eric Dumazet
2011-11-06 18:28 ` Paweł Staszewski
2011-11-06 18:48 ` Eric Dumazet
2011-11-06 19:20 ` Paweł Staszewski
2011-11-06 19:38 ` Eric Dumazet
2011-11-06 20:25 ` Paweł Staszewski
2011-11-06 21:26 ` Eric Dumazet
2011-11-06 21:57 ` Paweł Staszewski
2011-11-06 23:08 ` Eric Dumazet
2011-11-07 8:36 ` Paweł Staszewski
2011-11-07 9:08 ` Eric Dumazet
2011-11-07 9:16 ` Eric Dumazet
2011-11-07 22:12 ` Paweł Staszewski
2011-11-07 13:42 ` Ben Hutchings
2011-11-07 14:33 ` Eric Dumazet
2011-11-09 17:24 ` [PATCH net-next] ipv4: PKTINFO doesnt need dst reference Eric Dumazet
2011-11-09 21:37 ` David Miller
2011-11-09 22:03 ` Eric Dumazet
2011-11-10 0:29 ` [PATCH net-next] bnx2x: reduce skb truesize by 50% Eric Dumazet
2011-11-10 15:05 ` Eilon Greenstein
2011-11-10 15:27 ` Eric Dumazet
2011-11-10 16:27 ` Eilon Greenstein
2011-11-10 16:45 ` Eric Dumazet
2011-11-13 18:53 ` Eilon Greenstein
2011-11-13 19:42 ` Eric Dumazet
2011-11-13 20:08 ` Eilon Greenstein
2011-11-13 22:00 ` Eric Dumazet
2011-11-14 5:08 ` David Miller
2011-11-14 6:25 ` Eric Dumazet
2011-11-14 15:57 ` Eric Dumazet [this message]
2011-11-14 19:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321286265.2272.46.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=hadi@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=pstaszewski@itcare.pl \
--cc=shemminger@vyatta.com \
--cc=tgraf@infradead.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox