Re: [PATCH net-next 24/37] can: cc770: don't discard the IRQ lookup error in probe

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit message describes a user-visible failure ("a probe
  that has to wait for its interrupt controller is never retried and the…

--

can: cc770: don't discard the IRQ lookup error in probe

This patch changes cc770_platform_probe() so that it checks the memory
resource first. It then returns the platform_get_irq() error unchanged
instead of turning every failure into -ENODEV, so -EPROBE_DEFER now
reaches the driver core.

Link: https://patch.msgid.link/20261009105556.301821-1-quchaosheng000406@163.com

> That discards -EPROBE_DEFER, so a probe that has to wait for its
> interrupt controller is never retried and the device stays unbound.

[Severity: Low]
Does any real configuration hit this failure?

The code change looks correct, and so do the technical claims in the
message:

  - platform_get_irq() passes -EPROBE_DEFER through.
  - call_driver_probe() handles -ENODEV and -ENXIO the same way.

The only in-tree users of cc770_platform are powerpc device trees.

arch/powerpc/boot/dts/tqm8548.dts and tqm8548-bigflash.dts:

    compatible = "bosch,cc770";
    interrupt-parent = <&mpic>;

arch/powerpc/boot/dts/tqm8xx.dts:

    compatible = "intc,82527";
    interrupt-parent = <&PIC>;

The MPIC and the 8xx PIC are both set up during init_IRQ, so these
boards should not see -EPROBE_DEFER. No in-tree board file registers
the device through platform data.

The message describes a failure that users would see, but it has no
Fixes: tag. Could it say whether this was seen on real hardware, or
whether it is a robustness and consistency cleanup? Without that, stable
backporters cannot tell which it is.

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261009134323.64064-2-mkl%40pengutronix.de