Re: [PATCH v27 3/5] cxl/sfc: Initialize dpa without a mailbox

[Alejandro Lucero Palau <alucerop@amd.com>]

On 6/10/26 00:24, Dan Williams (nvidia) wrote:
> alejandro.lucero-palau@ wrote:
>> From: Alejandro Lucero <alucerop@amd.com>
>>
>> Type3 relies on mailbox CXL_MBOX_OP_IDENTIFY command for initializing
>> memdev state params which end up being used for DPA initialization.
>>
>> Allow a Type2 driver to initialize DPA simply by giving the size of its
>> volatile hardware partition.
>>
>> Move related functions to memdev.
> The code movement is not strictly necessary. Just add cxl_set_capacity()
> and we can consider a move later if mbox.o and memdev.o are ever not
> both included in cxl_core.o by default.


I think it is the right thing to do as the new function uses add_part() 
(moved) and the other add_part() client is the other function moved, 
cxl_mem_dpa_fetch().

Note cxl_mem_get_partition() used by cxl_mem_dpa_fetch() is the one 
working with mbox commands and it remains in the same place inside 
core/mbox.c and the only cxl_mem_dpa_fetch() client is cxl/pci.c


This was reviewed and accepted so no reason for not doing it ...


>
>> Add sfc driver as the client.
>>
>> Signed-off-by: Alejandro Lucero <alucerop@amd.com>
>> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
>> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>> Reviewed-by: Ben Cheatham <benjamin.cheatham@amd.com>
>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> [..]
>> +/**
>> + * cxl_set_capacity: initialize dpa by a driver without a mailbox.
>> + *
>> ++ * @cxlds: pointer to cxl_dev_state
> Stray "+"?


I'll fix it.


Thanks!