Re: [BUG 2.6.12-rc4] IPv6 xfrm tunnel oops with large packets

Re: [BUG 2.6.12-rc4] IPv6 xfrm tunnel oops with large packets

[Herbert Xu]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

On Sat, May 21, 2005 at 07:10:11PM +0000, Christophe Saout wrote:
> 
> The oops occurs in line 391 in net/ipv6/icmp.c:
> 
> >        idev = in6_dev_get(skb->dev);

Here is a minimal fix.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

I wonder why I've never seen it before.

BTW, icmpv6_send seems to ignore its dev argument altogether.
Any reason why we can't just use it instead of skb->dev?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[-- Attachment #2: p --]
[-- Type: text/plain, Size: 274 bytes --]

--- a/net/ipv6/xfrm6_output.c
+++ b/net/ipv6/xfrm6_output.c
@@ -84,6 +84,7 @@ static int xfrm6_tunnel_check_size(struc
 		mtu = IPV6_MIN_MTU;
 
 	if (skb->len > mtu) {
+		skb->dev = dst->dev;
 		icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu, skb->dev);
 		ret = -EMSGSIZE;
 	}

Re: [BUG 2.6.12-rc4] IPv6 xfrm tunnel oops with large packets

[YOSHIFUJI Hideaki / 吉藤英明]

In article <20050521194932.GA10959@gondor.apana.org.au> (at Sun, 22 May 2005 05:49:32 +1000), Herbert Xu <herbert@gondor.apana.org.au> says:

> On Sat, May 21, 2005 at 07:10:11PM +0000, Christophe Saout wrote:
> > 
> > The oops occurs in line 391 in net/ipv6/icmp.c:
> > 
> > >        idev = in6_dev_get(skb->dev);
> 
> Here is a minimal fix.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>


Acked-by: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>

> BTW, icmpv6_send seems to ignore its dev argument altogether.
> Any reason why we can't just use it instead of skb->dev?

(After looking into icmpv6_send() usages,)
I don't know the reason why we needed the last argument "dev".
It seems that we already had it at the time of 2.2.16.
Probably, we can remove it.

--yoshfuji

Re: [BUG 2.6.12-rc4] IPv6 xfrm tunnel oops with large packets

[Herbert Xu]

On Sun, May 22, 2005 at 05:18:17AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
>
> > BTW, icmpv6_send seems to ignore its dev argument altogether.
> > Any reason why we can't just use it instead of skb->dev?
> 
> (After looking into icmpv6_send() usages,)
> I don't know the reason why we needed the last argument "dev".
> It seems that we already had it at the time of 2.2.16.
> Probably, we can remove it.

In a number of places (I've just created another one with my patch :)
we are setting skb->dev specifically for icmpv6_send.  If we make
icmpv6_send use its dev argument instead of skb->dev then we can
avoid those settings.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [BUG 2.6.12-rc4] IPv6 xfrm tunnel oops with large packets

[David S. Miller]

From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
Date: Sun, 22 May 2005 05:18:17 +0900 (JST)

> In article <20050521194932.GA10959@gondor.apana.org.au> (at Sun, 22 May 2005 05:49:32 +1000), Herbert Xu <herbert@gondor.apana.org.au> says:
> 
> > On Sat, May 21, 2005 at 07:10:11PM +0000, Christophe Saout wrote:
> > > 
> > > The oops occurs in line 391 in net/ipv6/icmp.c:
> > > 
> > > >        idev = in6_dev_get(skb->dev);
> > 
> > Here is a minimal fix.
> > 
> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> 
> 
> Acked-by: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>

Applied, thanks everyone.

Re: [BUG 2.6.12-rc4] IPv6 xfrm tunnel oops with large packets

[Christophe Saout]

[-- Attachment #1: Type: text/plain, Size: 121 bytes --]

Am Sonntag, den 22.05.2005, 05:49 +1000 schrieb Herbert Xu:

> Here is a minimal fix.

Yes, it fixes the problem.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]