From: Karsten Wiese <fzu@wemgehoertderstaat.de>
To: romieu@fr.zoreil.com, netdev@vger.kernel.org
Subject: [PATCH] Disable polling in rtl8169_suspend() to prevent race with rtl8169_interrupt()
Date: Tue, 16 Oct 2007 18:46:52 +0200 [thread overview]
Message-ID: <200710161846.52509.fzu@wemgehoertderstaat.de> (raw)
Hi,
Sometimes (~ 1 in 10) after suspend to disk my r8169 nic doesn't work and a
"r8169: eth0: link down" gets mingled up with those suspend messages.
First tests show nothing bad, so maybe this patch really helps.
Will post again, if it doesn't.
Karsten
------------------>
Disable polling in rtl8169_suspend() to prevent race with rtl8169_interrupt()
rtl8169_interrupt() is called during polling.
Without patch, rtl8169_interrupt() could run after rtl8169_asic_down(),
causing a disabled link state being saved later in rtl8169_suspend() by
pci_save_state().
netif_stop_queue() can go as it is called by netif_device_detach().
Signed-off-by: Karsten Wiese <fzu@wemgehoertderstaat.de>
---
drivers/net/r8169.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index c76dd29..fee6c8e 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -3024,7 +3024,7 @@ static int rtl8169_suspend(struct pci_dev *pdev, pm_message_t state)
goto out_pci_suspend;
netif_device_detach(dev);
- netif_stop_queue(dev);
+ netif_poll_disable(dev);
spin_lock_irq(&tp->lock);
@@ -3054,6 +3054,7 @@ static int rtl8169_resume(struct pci_dev *pdev)
if (!netif_running(dev))
goto out;
+ netif_poll_enable(dev);
netif_device_attach(dev);
rtl8169_schedule_work(dev, rtl8169_reset_task);
--
1.5.2.4
next reply other threads:[~2007-10-16 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 16:46 Karsten Wiese [this message]
2007-10-16 19:27 ` [PATCH] Disable polling in rtl8169_suspend() to prevent race with rtl8169_interrupt() Karsten Wiese
2007-10-16 21:04 ` Francois Romieu
2007-10-16 22:10 ` Karsten Wiese
2007-10-16 22:21 ` Karsten Wiese
2007-10-17 16:40 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710161846.52509.fzu@wemgehoertderstaat.de \
--to=fzu@wemgehoertderstaat.de \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox