From: Karsten Wiese <fzu@wemgehoertderstaat.de>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Disable polling in rtl8169_suspend() to prevent race with rtl8169_interrupt()
Date: Wed, 17 Oct 2007 00:10:36 +0200 [thread overview]
Message-ID: <200710170010.36329.fzu@wemgehoertderstaat.de> (raw)
In-Reply-To: <20071016210412.GB8049@electric-eye.fr.zoreil.com>
Am Dienstag, 16. Oktober 2007 schrieb Francois Romieu:
> Karsten Wiese <fzu@wemgehoertderstaat.de> :
> [...]
> > Forgot to say: patch is against 2.6.23. Stable material, if it gets an ACK.
> > The BUG happens since months here, if not since I hibernate this pc.
>
> Can you give the patch below a try too ?
I don't know how to reliably make the bug happen, it occured once a week
"normally". Before I try please look through this stuff:
with an unpatched r8169 after bug happened today morning i gathered some
diagnostics:
[root@a64 ~]# ethtool eth0
Settings for eth0:
Supported ports: [ TP ]
Supported link modes: 10baseT/Half 10baseT/Full
100baseT/Half 100baseT/Full
1000baseT/Full
Supports auto-negotiation: Yes
Advertised link modes: 10baseT/Half 10baseT/Full
100baseT/Half 100baseT/Full
1000baseT/Full
Advertised auto-negotiation: Yes
Speed: 100Mb/s
Duplex: Full
Port: Twisted Pair
this ^..........^ looked funny to me
PHYAD: 0
Transceiver: internal
Auto-negotiation: on
Supports Wake-on: pumbg
Wake-on: g
Current message level: 0x00000033 (51)
Link detected: no
unexpected too ^^
then i did:
[root@a64 ~]# ethtool -s eth0 port mii
[root@a64 ~]# ethtool eth0
Settings for eth0:
Supported ports: [ TP ]
Supported link modes: 10baseT/Half 10baseT/Full
100baseT/Half 100baseT/Full
1000baseT/Full
Supports auto-negotiation: Yes
Advertised link modes: 10baseT/Half 10baseT/Full
100baseT/Half 100baseT/Full
1000baseT/Full
Advertised auto-negotiation: Yes
Speed: 100Mb/s
Duplex: Full
Port: Twisted Pair
back to normal ^.........^
PHYAD: 0
Transceiver: internal
Auto-negotiation: on
Supports Wake-on: pumbg
Wake-on: g
Current message level: 0x00000033 (51)
Link detected: yes
expected value here too^.^ and eth0 worked again.
Can your patch cause the same effect as the "ethtool -s eth0 port mii" in
the bug case?
Do you agree that rtl8169_interrupt() should not be called after
rtl8169_asic_down() when in rtl8169_suspend() and before rtl8169_resume()?
If yes, how should that be achieved?
Karsten
next prev parent reply other threads:[~2007-10-16 22:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 16:46 [PATCH] Disable polling in rtl8169_suspend() to prevent race with rtl8169_interrupt() Karsten Wiese
2007-10-16 19:27 ` Karsten Wiese
2007-10-16 21:04 ` Francois Romieu
2007-10-16 22:10 ` Karsten Wiese [this message]
2007-10-16 22:21 ` Karsten Wiese
2007-10-17 16:40 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710170010.36329.fzu@wemgehoertderstaat.de \
--to=fzu@wemgehoertderstaat.de \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox