From: Karsten Wiese <fzu@wemgehoertderstaat.de>
To: romieu@fr.zoreil.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Disable polling in rtl8169_suspend() to prevent race with rtl8169_interrupt()
Date: Tue, 16 Oct 2007 21:27:51 +0200 [thread overview]
Message-ID: <200710162127.52228.fzu@wemgehoertderstaat.de> (raw)
In-Reply-To: <200710161846.52509.fzu@wemgehoertderstaat.de>
Am Dienstag, 16. Oktober 2007 schrieb Karsten Wiese:
> Hi,
>
> Sometimes (~ 1 in 10) after suspend to disk my r8169 nic doesn't work and a
> "r8169: eth0: link down" gets mingled up with those suspend messages.
> First tests show nothing bad, so maybe this patch really helps.
> Will post again, if it doesn't.
>
> Karsten
> ------------------>
>
> Disable polling in rtl8169_suspend() to prevent race with rtl8169_interrupt()
>
> rtl8169_interrupt() is called during polling.
> Without patch, rtl8169_interrupt() could run after rtl8169_asic_down(),
> causing a disabled link state being saved later in rtl8169_suspend() by
> pci_save_state().
> netif_stop_queue() can go as it is called by netif_device_detach().
>
> Signed-off-by: Karsten Wiese <fzu@wemgehoertderstaat.de>
Forgot to say: patch is against 2.6.23. Stable material, if it gets an ACK.
The BUG happens since months here, if not since I hibernate this pc.
git HEAD would need a similar fix I think, haven't tried yet.
Karsten
next prev parent reply other threads:[~2007-10-16 19:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 16:46 [PATCH] Disable polling in rtl8169_suspend() to prevent race with rtl8169_interrupt() Karsten Wiese
2007-10-16 19:27 ` Karsten Wiese [this message]
2007-10-16 21:04 ` Francois Romieu
2007-10-16 22:10 ` Karsten Wiese
2007-10-16 22:21 ` Karsten Wiese
2007-10-17 16:40 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710162127.52228.fzu@wemgehoertderstaat.de \
--to=fzu@wemgehoertderstaat.de \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox