From: Francois Romieu <romieu@fr.zoreil.com>
To: Karsten Wiese <fzu@wemgehoertderstaat.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Disable polling in rtl8169_suspend() to prevent race with rtl8169_interrupt()
Date: Wed, 17 Oct 2007 18:40:21 +0200 [thread overview]
Message-ID: <20071017164021.GA13105@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <200710170010.36329.fzu@wemgehoertderstaat.de>
Karsten Wiese <fzu@wemgehoertderstaat.de> :
[...]
> Can your patch cause the same effect as the "ethtool -s eth0 port mii" in
> the bug case?
>
> Do you agree that rtl8169_interrupt() should not be called after
> rtl8169_asic_down() when in rtl8169_suspend() and before rtl8169_resume()?
I have not thought about it too deeply.
I'd rather say that the driver must be able to handle it. Spurious/shared
irq happen.
--
Ueimor
prev parent reply other threads:[~2007-10-17 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 16:46 [PATCH] Disable polling in rtl8169_suspend() to prevent race with rtl8169_interrupt() Karsten Wiese
2007-10-16 19:27 ` Karsten Wiese
2007-10-16 21:04 ` Francois Romieu
2007-10-16 22:10 ` Karsten Wiese
2007-10-16 22:21 ` Karsten Wiese
2007-10-17 16:40 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017164021.GA13105@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=fzu@wemgehoertderstaat.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox