From: Yury Polyanskiy <ypolyans@Princeton.EDU>
To: David Miller <davem@davemloft.net>
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [IPSEC] xfrm_state locking problem in xfrm_input.c
Date: Tue, 12 May 2009 09:32:04 -0400 [thread overview]
Message-ID: <20090512093204.4c30478d@penta.localdomain> (raw)
In-Reply-To: <20090511.220723.266123145.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
On Mon, 11 May 2009 22:07:23 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> >> > Note that if the locally generated packet is sent to a local ip,
> >> > dev_queue_xmit() calls loopback_xmit() and the xfrm_input() will
> >> > be called with softirqs enabled.
> >>
> >> dev_queue_xmit always disables BH before calling the device xmit
> >> function. So how can this happen?
> >>
> >
> > Oops, you right. Thanks for the explanation!
>
> So you didn't actually hit a bug that led you to write that
> patch?
>
> Please state this explicitly next time, and tell us that you are
> "fixing" something based purely upon code inspection rather than
> hitting a bug yourself.
>
Well, I hit some bug (occasional hard lockup of the box on ipsec'ed
data transfers), and this seemed as an excellent fit, because I
frequently test it on local->local trafic. Anyways, sorry for bothering.
YP
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2009-05-12 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 22:47 [IPSEC] xfrm_state locking problem in xfrm_input.c Yury Polyanskiy
2009-05-12 3:48 ` Herbert Xu
2009-05-12 4:05 ` Yury Polyanskiy
2009-05-12 5:07 ` David Miller
2009-05-12 13:32 ` Yury Polyanskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512093204.4c30478d@penta.localdomain \
--to=ypolyans@princeton.edu \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox