* [PATCH] net/dec: Make __de_get_link_ksettings return void
@ 2017-06-04 17:08 Yuval Shaia
2017-06-04 17:22 ` Sergei Shtylyov
2017-06-05 15:01 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Yuval Shaia @ 2017-06-04 17:08 UTC (permalink / raw)
To: davem, jarod, yuval.shaia, tklauser, tremyfr, netdev,
linux-parisc
Make return value void since function never return meaningfull value
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
drivers/net/ethernet/dec/tulip/de2104x.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c
index 91b8f6f..c87b8cc 100644
--- a/drivers/net/ethernet/dec/tulip/de2104x.c
+++ b/drivers/net/ethernet/dec/tulip/de2104x.c
@@ -1483,8 +1483,8 @@ static void __de_get_regs(struct de_private *de, u8 *buf)
de_rx_missed(de, rbuf[8]);
}
-static int __de_get_link_ksettings(struct de_private *de,
- struct ethtool_link_ksettings *cmd)
+static void __de_get_link_ksettings(struct de_private *de,
+ struct ethtool_link_ksettings *cmd)
{
ethtool_convert_legacy_u32_to_link_mode(cmd->link_modes.supported,
de->media_supported);
@@ -1517,8 +1517,6 @@ static int __de_get_link_ksettings(struct de_private *de,
cmd->base.autoneg = AUTONEG_ENABLE;
/* ignore maxtxpkt, maxrxpkt for now */
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] net/dec: Make __de_get_link_ksettings return void
2017-06-04 17:08 [PATCH] net/dec: Make __de_get_link_ksettings return void Yuval Shaia
@ 2017-06-04 17:22 ` Sergei Shtylyov
2017-06-04 17:24 ` Sergei Shtylyov
2017-06-04 19:52 ` Yuval Shaia
2017-06-05 15:01 ` David Miller
1 sibling, 2 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2017-06-04 17:22 UTC (permalink / raw)
To: Yuval Shaia, davem, jarod, tklauser, tremyfr, netdev,
linux-parisc
Hello!
On 6/4/2017 8:08 PM, Yuval Shaia wrote:
> Make return value void since function never return meaningfull value
You only make 1 of 2 functions void. It looks like there should be 2 patches.
>
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> ---
> drivers/net/ethernet/dec/tulip/de2104x.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c
> index 91b8f6f..c87b8cc 100644
> --- a/drivers/net/ethernet/dec/tulip/de2104x.c
> +++ b/drivers/net/ethernet/dec/tulip/de2104x.c
> @@ -1483,8 +1483,8 @@ static void __de_get_regs(struct de_private *de, u8 *buf)
> de_rx_missed(de, rbuf[8]);
> }
>
> -static int __de_get_link_ksettings(struct de_private *de,
> - struct ethtool_link_ksettings *cmd)
> +static void __de_get_link_ksettings(struct de_private *de,
> + struct ethtool_link_ksettings *cmd)
> {
> ethtool_convert_legacy_u32_to_link_mode(cmd->link_modes.supported,
> de->media_supported);
> @@ -1517,8 +1517,6 @@ static int __de_get_link_ksettings(struct de_private *de,
> cmd->base.autoneg = AUTONEG_ENABLE;
>
> /* ignore maxtxpkt, maxrxpkt for now */
> -
> - return 0;
> }
>
> static int __de_set_link_ksettings(struct de_private *de,
> @@ -1615,13 +1613,12 @@ static int de_get_link_ksettings(struct net_device *dev,
> struct ethtool_link_ksettings *cmd)
> {
> struct de_private *de = netdev_priv(dev);
> - int rc;
>
> spin_lock_irq(&de->lock);
> - rc = __de_get_link_ksettings(de, cmd);
> + __de_get_link_ksettings(de, cmd);
> spin_unlock_irq(&de->lock);
>
> - return rc;
> + return 0;
> }
>
> static int de_set_link_ksettings(struct net_device *dev,
>
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/dec: Make __de_get_link_ksettings return void
2017-06-04 17:22 ` Sergei Shtylyov
@ 2017-06-04 17:24 ` Sergei Shtylyov
2017-06-04 19:52 ` Yuval Shaia
1 sibling, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2017-06-04 17:24 UTC (permalink / raw)
To: Yuval Shaia, davem, jarod, tklauser, tremyfr, netdev,
linux-parisc
On 6/4/2017 8:22 PM, Sergei Shtylyov wrote:
>> Make return value void since function never return meaningfull value
>
> You only make 1 of 2 functions void. It looks like there should be 2 patches.
Oh, sorry, I was just blind. B-)
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/dec: Make __de_get_link_ksettings return void
2017-06-04 17:22 ` Sergei Shtylyov
2017-06-04 17:24 ` Sergei Shtylyov
@ 2017-06-04 19:52 ` Yuval Shaia
1 sibling, 0 replies; 5+ messages in thread
From: Yuval Shaia @ 2017-06-04 19:52 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: davem, jarod, tklauser, tremyfr, netdev, linux-parisc
On Sun, Jun 04, 2017 at 08:22:05PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 6/4/2017 8:08 PM, Yuval Shaia wrote:
>
> > Make return value void since function never return meaningfull value
>
> You only make 1 of 2 functions void. It looks like there should be 2 patches.
And what would be the second function?
>
> >
> > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> > ---
> > drivers/net/ethernet/dec/tulip/de2104x.c | 11 ++++-------
> > 1 file changed, 4 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c
> > index 91b8f6f..c87b8cc 100644
> > --- a/drivers/net/ethernet/dec/tulip/de2104x.c
> > +++ b/drivers/net/ethernet/dec/tulip/de2104x.c
> > @@ -1483,8 +1483,8 @@ static void __de_get_regs(struct de_private *de, u8 *buf)
> > de_rx_missed(de, rbuf[8]);
> > }
> >
> > -static int __de_get_link_ksettings(struct de_private *de,
> > - struct ethtool_link_ksettings *cmd)
> > +static void __de_get_link_ksettings(struct de_private *de,
> > + struct ethtool_link_ksettings *cmd)
> > {
> > ethtool_convert_legacy_u32_to_link_mode(cmd->link_modes.supported,
> > de->media_supported);
> > @@ -1517,8 +1517,6 @@ static int __de_get_link_ksettings(struct de_private *de,
> > cmd->base.autoneg = AUTONEG_ENABLE;
> >
> > /* ignore maxtxpkt, maxrxpkt for now */
> > -
> > - return 0;
> > }
> >
> > static int __de_set_link_ksettings(struct de_private *de,
> > @@ -1615,13 +1613,12 @@ static int de_get_link_ksettings(struct net_device *dev,
> > struct ethtool_link_ksettings *cmd)
> > {
> > struct de_private *de = netdev_priv(dev);
> > - int rc;
> >
> > spin_lock_irq(&de->lock);
> > - rc = __de_get_link_ksettings(de, cmd);
> > + __de_get_link_ksettings(de, cmd);
> > spin_unlock_irq(&de->lock);
> >
> > - return rc;
> > + return 0;
> > }
> >
> > static int de_set_link_ksettings(struct net_device *dev,
> >
>
> MBR, Sergei
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/dec: Make __de_get_link_ksettings return void
2017-06-04 17:08 [PATCH] net/dec: Make __de_get_link_ksettings return void Yuval Shaia
2017-06-04 17:22 ` Sergei Shtylyov
@ 2017-06-05 15:01 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2017-06-05 15:01 UTC (permalink / raw)
To: yuval.shaia; +Cc: jarod, tklauser, tremyfr, netdev, linux-parisc
From: Yuval Shaia <yuval.shaia@oracle.com>
Date: Sun, 4 Jun 2017 20:08:51 +0300
> Make return value void since function never return meaningfull value
>
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-05 15:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-04 17:08 [PATCH] net/dec: Make __de_get_link_ksettings return void Yuval Shaia
2017-06-04 17:22 ` Sergei Shtylyov
2017-06-04 17:24 ` Sergei Shtylyov
2017-06-04 19:52 ` Yuval Shaia
2017-06-05 15:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox