* [PATCH] tg3: clean up redundant initialization of tnapi
@ 2017-09-14 16:01 Colin King
2017-09-14 17:00 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-09-14 16:01 UTC (permalink / raw)
To: Siva Reddy Kallam, Prashant Sreedharan, Michael Chan, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
tnapi is being initialized and then immediately updated and
hence the initialiation is redundant. Clean up the warning
by moving the declaration and initialization to the inside
of the for-loop.
Cleans up clang scan-build warning:
warning: Value stored to 'tnapi' during its initialization is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/broadcom/tg3.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index af33dc15c55f..54588809b867 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -11536,11 +11536,11 @@ static int tg3_start(struct tg3 *tp, bool reset_phy, bool test_irq,
tg3_napi_enable(tp);
for (i = 0; i < tp->irq_cnt; i++) {
- struct tg3_napi *tnapi = &tp->napi[i];
err = tg3_request_irq(tp, i);
if (err) {
for (i--; i >= 0; i--) {
- tnapi = &tp->napi[i];
+ struct tg3_napi *tnapi = &tp->napi[i];
+
free_irq(tnapi->irq_vec, tnapi);
}
goto out_napi_fini;
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tg3: clean up redundant initialization of tnapi
2017-09-14 16:01 [PATCH] tg3: clean up redundant initialization of tnapi Colin King
@ 2017-09-14 17:00 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-09-14 17:00 UTC (permalink / raw)
To: colin.king
Cc: siva.kallam, prashant, mchan, netdev, kernel-janitors,
linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 14 Sep 2017 17:01:25 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> tnapi is being initialized and then immediately updated and
> hence the initialiation is redundant. Clean up the warning
> by moving the declaration and initialization to the inside
> of the for-loop.
>
> Cleans up clang scan-build warning:
> warning: Value stored to 'tnapi' during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-14 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-14 16:01 [PATCH] tg3: clean up redundant initialization of tnapi Colin King
2017-09-14 17:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox