* bgmac-enet driver broken in 5.7
@ 2020-05-04 19:32 Jonathan Richardson
2020-05-04 20:19 ` Florian Fainelli
2020-05-05 0:30 ` Dejin Zheng
0 siblings, 2 replies; 7+ messages in thread
From: Jonathan Richardson @ 2020-05-04 19:32 UTC (permalink / raw)
To: zhengdejin5; +Cc: davem, Scott Branden, Ray Jui, netdev
Hi,
Commit d7a5502b0bb8b (net: broadcom: convert to
devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver.
probe fails with -22. idm_base and nicpm_base were optional. Now they
are mandatory. Our upstream dtb doesn't have them defined. I'm not
clear on why this change was made. Can it be reverted?
Thanks,
Jon
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: bgmac-enet driver broken in 5.7
2020-05-04 19:32 bgmac-enet driver broken in 5.7 Jonathan Richardson
@ 2020-05-04 20:19 ` Florian Fainelli
2020-05-04 20:24 ` Jonathan Richardson
2020-05-05 0:30 ` Dejin Zheng
1 sibling, 1 reply; 7+ messages in thread
From: Florian Fainelli @ 2020-05-04 20:19 UTC (permalink / raw)
To: Jonathan Richardson, zhengdejin5; +Cc: davem, Scott Branden, Ray Jui, netdev
On 5/4/2020 12:32 PM, Jonathan Richardson wrote:
> Hi,
>
> Commit d7a5502b0bb8b (net: broadcom: convert to
> devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver.
> probe fails with -22. idm_base and nicpm_base were optional. Now they
> are mandatory. Our upstream dtb doesn't have them defined. I'm not
> clear on why this change was made. Can it be reverted?
You don't get a change reverted by just asking for it, you have to
submit a revert to get that done can you do that?
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: bgmac-enet driver broken in 5.7
2020-05-04 20:19 ` Florian Fainelli
@ 2020-05-04 20:24 ` Jonathan Richardson
2020-05-04 20:36 ` Florian Fainelli
0 siblings, 1 reply; 7+ messages in thread
From: Jonathan Richardson @ 2020-05-04 20:24 UTC (permalink / raw)
To: Florian Fainelli; +Cc: zhengdejin5, davem, Scott Branden, Ray Jui, netdev
On Mon, May 4, 2020 at 1:20 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>
>
> On 5/4/2020 12:32 PM, Jonathan Richardson wrote:
> > Hi,
> >
> > Commit d7a5502b0bb8b (net: broadcom: convert to
> > devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver.
> > probe fails with -22. idm_base and nicpm_base were optional. Now they
> > are mandatory. Our upstream dtb doesn't have them defined. I'm not
> > clear on why this change was made. Can it be reverted?
>
> You don't get a change reverted by just asking for it, you have to
> submit a revert to get that done can you do that?
> --
> Florian
If the author is fine with reverting it yes I will submit the change.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: bgmac-enet driver broken in 5.7
2020-05-04 20:24 ` Jonathan Richardson
@ 2020-05-04 20:36 ` Florian Fainelli
0 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2020-05-04 20:36 UTC (permalink / raw)
To: Jonathan Richardson; +Cc: zhengdejin5, davem, Scott Branden, Ray Jui, netdev
On 5/4/2020 1:24 PM, Jonathan Richardson wrote:
> On Mon, May 4, 2020 at 1:20 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>>
>>
>> On 5/4/2020 12:32 PM, Jonathan Richardson wrote:
>>> Hi,
>>>
>>> Commit d7a5502b0bb8b (net: broadcom: convert to
>>> devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver.
>>> probe fails with -22. idm_base and nicpm_base were optional. Now they
>>> are mandatory. Our upstream dtb doesn't have them defined. I'm not
>>> clear on why this change was made. Can it be reverted?
>>
>> You don't get a change reverted by just asking for it, you have to
>> submit a revert to get that done can you do that?
>> --
>> Florian
>
> If the author is fine with reverting it yes I will submit the change.
The author clearly submitted this as a drive by contribution, so I would
not expect this to be a problem.
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: bgmac-enet driver broken in 5.7
2020-05-04 19:32 bgmac-enet driver broken in 5.7 Jonathan Richardson
2020-05-04 20:19 ` Florian Fainelli
@ 2020-05-05 0:30 ` Dejin Zheng
2020-05-05 0:37 ` Jonathan Richardson
1 sibling, 1 reply; 7+ messages in thread
From: Dejin Zheng @ 2020-05-05 0:30 UTC (permalink / raw)
To: Jonathan Richardson; +Cc: davem, Scott Branden, Ray Jui, netdev
On Mon, May 04, 2020 at 12:32:55PM -0700, Jonathan Richardson wrote:
> Hi,
>
> Commit d7a5502b0bb8b (net: broadcom: convert to
> devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver.
> probe fails with -22. idm_base and nicpm_base were optional. Now they
> are mandatory. Our upstream dtb doesn't have them defined. I'm not
> clear on why this change was made. Can it be reverted?
>
Jon, I am so sorry for that, I will submit a cl to reverted it to make
idm_base and nicpm_base as optional. sorry!
BR,
Dejin
> Thanks,
> Jon
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: bgmac-enet driver broken in 5.7
2020-05-05 0:30 ` Dejin Zheng
@ 2020-05-05 0:37 ` Jonathan Richardson
2020-05-05 2:21 ` Dejin Zheng
0 siblings, 1 reply; 7+ messages in thread
From: Jonathan Richardson @ 2020-05-05 0:37 UTC (permalink / raw)
To: Dejin Zheng; +Cc: davem, Scott Branden, Ray Jui, netdev
On Mon, May 4, 2020 at 5:30 PM Dejin Zheng <zhengdejin5@gmail.com> wrote:
>
> On Mon, May 04, 2020 at 12:32:55PM -0700, Jonathan Richardson wrote:
> > Hi,
> >
> > Commit d7a5502b0bb8b (net: broadcom: convert to
> > devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver.
> > probe fails with -22. idm_base and nicpm_base were optional. Now they
> > are mandatory. Our upstream dtb doesn't have them defined. I'm not
> > clear on why this change was made. Can it be reverted?
> >
> Jon, I am so sorry for that, I will submit a cl to reverted it to make
> idm_base and nicpm_base as optional. sorry!
No problem. I'll let you submit the fix then. Thanks for taking care of it.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: bgmac-enet driver broken in 5.7
2020-05-05 0:37 ` Jonathan Richardson
@ 2020-05-05 2:21 ` Dejin Zheng
0 siblings, 0 replies; 7+ messages in thread
From: Dejin Zheng @ 2020-05-05 2:21 UTC (permalink / raw)
To: Jonathan Richardson; +Cc: davem, Scott Branden, Ray Jui, netdev
On Mon, May 04, 2020 at 05:37:18PM -0700, Jonathan Richardson wrote:
> On Mon, May 4, 2020 at 5:30 PM Dejin Zheng <zhengdejin5@gmail.com> wrote:
> >
> > On Mon, May 04, 2020 at 12:32:55PM -0700, Jonathan Richardson wrote:
> > > Hi,
> > >
> > > Commit d7a5502b0bb8b (net: broadcom: convert to
> > > devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver.
> > > probe fails with -22. idm_base and nicpm_base were optional. Now they
> > > are mandatory. Our upstream dtb doesn't have them defined. I'm not
> > > clear on why this change was made. Can it be reverted?
> > >
> > Jon, I am so sorry for that, I will submit a cl to reverted it to make
> > idm_base and nicpm_base as optional. sorry!
>
> No problem. I'll let you submit the fix then. Thanks for taking care of it.
Thank you very much for giving me this opportunity to deal with my
mistakes. at the same time, I apologize for the trouble to bring you.
now, I have submitted a cl is here:
http://patchwork.ozlabs.org/project/netdev/patch/20200505020329.31638-1-zhengdejin5@gmail.com/
I hope it solves this problem. sorry! I will be more careful with each
new patch. Thanks!
BR,
Dejin
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-05-05 2:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-04 19:32 bgmac-enet driver broken in 5.7 Jonathan Richardson
2020-05-04 20:19 ` Florian Fainelli
2020-05-04 20:24 ` Jonathan Richardson
2020-05-04 20:36 ` Florian Fainelli
2020-05-05 0:30 ` Dejin Zheng
2020-05-05 0:37 ` Jonathan Richardson
2020-05-05 2:21 ` Dejin Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox