From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, andrew+netdev@lunn.ch,
netdev@vger.kernel.org
Cc: Kohei Enju <kohei@enjuk.jp>,
anthony.l.nguyen@intel.com, dima.ruinskiy@intel.com,
kohei.enju@gmail.com, horms@kernel.org,
Avigail Dahan <avigailx.dahan@intel.com>
Subject: [PATCH net-next 03/11] igc: allow configuring RSS key via ethtool set_rxfh
Date: Wed, 1 Jul 2026 14:02:52 -0700 [thread overview]
Message-ID: <20260701210303.1745310-4-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20260701210303.1745310-1-anthony.l.nguyen@intel.com>
From: Kohei Enju <kohei@enjuk.jp>
Change igc_ethtool_set_rxfh() to accept and save a userspace-provided
RSS key. When a key is provided, store it in the adapter and write the
RSSRK registers accordingly.
This can be tested using `ethtool -X <dev> hkey <key>`.
Signed-off-by: Kohei Enju <kohei@enjuk.jp>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Avigail Dahan <avigailx.dahan@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 30 +++++++++++---------
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index 0e76ffe7be65..fbba3e84673a 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -1539,24 +1539,28 @@ static int igc_ethtool_set_rxfh(struct net_device *netdev,
int i;
/* We do not allow change in unsupported parameters */
- if (rxfh->key ||
- (rxfh->hfunc != ETH_RSS_HASH_NO_CHANGE &&
- rxfh->hfunc != ETH_RSS_HASH_TOP))
+ if (rxfh->hfunc != ETH_RSS_HASH_NO_CHANGE &&
+ rxfh->hfunc != ETH_RSS_HASH_TOP)
return -EOPNOTSUPP;
- if (!rxfh->indir)
- return 0;
- num_queues = adapter->rss_queues;
+ if (rxfh->indir) {
+ num_queues = adapter->rss_queues;
- /* Verify user input. */
- for (i = 0; i < IGC_RETA_SIZE; i++)
- if (rxfh->indir[i] >= num_queues)
- return -EINVAL;
+ /* Verify user input. */
+ for (i = 0; i < IGC_RETA_SIZE; i++)
+ if (rxfh->indir[i] >= num_queues)
+ return -EINVAL;
- for (i = 0; i < IGC_RETA_SIZE; i++)
- adapter->rss_indir_tbl[i] = rxfh->indir[i];
+ for (i = 0; i < IGC_RETA_SIZE; i++)
+ adapter->rss_indir_tbl[i] = rxfh->indir[i];
- igc_write_rss_indir_tbl(adapter);
+ igc_write_rss_indir_tbl(adapter);
+ }
+
+ if (rxfh->key) {
+ memcpy(adapter->rss_key, rxfh->key, sizeof(adapter->rss_key));
+ igc_write_rss_key(adapter);
+ }
return 0;
}
--
2.47.1
next prev parent reply other threads:[~2026-07-01 21:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 21:02 [PATCH net-next 00/11][pull request] Intel Wired LAN Driver Updates 2026-07-01 (igc, igb) Tony Nguyen
2026-07-01 21:02 ` [PATCH net-next 01/11] igc: prepare for RSS key get/set support Tony Nguyen
2026-07-01 21:02 ` [PATCH net-next 02/11] igc: expose RSS key via ethtool get_rxfh Tony Nguyen
2026-07-01 21:02 ` Tony Nguyen [this message]
2026-07-01 21:02 ` [PATCH net-next 04/11] igb: prepare for RSS key get/set support Tony Nguyen
2026-07-01 21:02 ` [PATCH net-next 05/11] igb: expose RSS key via ethtool get_rxfh Tony Nguyen
2026-07-01 21:02 ` [PATCH net-next 06/11] igb: allow configuring RSS key via ethtool set_rxfh Tony Nguyen
2026-07-01 21:02 ` [PATCH net-next 07/11] igb: set skb hash type from RSS_TYPE Tony Nguyen
2026-07-01 21:02 ` [PATCH net-next 08/11] igc: remove unused autoneg_failed field Tony Nguyen
2026-07-01 21:02 ` [PATCH net-next 09/11] igc: move autoneg-enabled settings into igc_handle_autoneg_enabled() Tony Nguyen
2026-07-01 21:02 ` [PATCH net-next 10/11] igc: replace goto out with direct returns in igc_config_fc_after_link_up() Tony Nguyen
2026-07-01 21:03 ` [PATCH net-next 11/11] igc: add support for forcing link speed without autonegotiation Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260701210303.1745310-4-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=avigailx.dahan@intel.com \
--cc=davem@davemloft.net \
--cc=dima.ruinskiy@intel.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kohei.enju@gmail.com \
--cc=kohei@enjuk.jp \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox