From: Wang Zhan <wang.zhan@smartx.com>
To: netdev@vger.kernel.org,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, keyong.sun@smartx.com,
Wang Zhan <wang.zhan@smartx.com>,
Jason Wang <jasowangio@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Aaron Conole <aconole@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
Ilya Maximets <i.maximets@ovn.org>,
dev@openvswitch.org, Daniel Borkmann <daniel@iogearbox.net>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
Alice Mikityanska <alice@isovalent.com>,
David Laight <david.laight.linux@gmail.com>
Subject: Re: [PATCH net-next v3 0/5] net: resegment oversized TCP GSO skbs
Date: Tue, 29 Sep 2026 19:50:28 +0800 [thread overview]
Message-ID: <20260929115028.2014285-1-wang.zhan@smartx.com> (raw)
In-Reply-To: <willemdebruijn.kernel.39a32e51cb66d@gmail.com>
On Mon, 28 Sep 2026 19:34:21 -0400 Willem de Bruijn wrote:
> If 1/5 fixes a bug that is reachable today (does it?) then it needs to
> go to net on its own.
Before this series, it is reachable when the tag is already in the frame,
for example a stacked VLAN device or an OVS QinQ path. I reproduced it
with the following script:
ip netns add g1; ip netns add g2
ip link add v0 type veth peer name v1
ip link set v0 netns g1; ip link set v1 netns g2
for n in g1 g2; do
r=v0; [ $n = g2 ] && r=v1
ip -n $n link add link $r name vlan200 type vlan id 200
ip -n $n link add link vlan200 name vlan100 type vlan id 100
for d in $r vlan200 vlan100; do
ip -n $n link set $d gso_max_size 524280
done
ip -n $n link set $r up; ip -n $n link set vlan200 up
ip -n $n link set vlan100 up
done
ip -n g1 addr add 2001:db8::1/64 dev vlan100
ip -n g2 addr add 2001:db8::2/64 dev vlan100
ip netns exec g2 iperf3 -s -D
ip -n g1 link set v0 gso_ipv4_max_size 65536
ip netns exec g1 iperf3 -c 2001:db8::2 -t 6
ip -n g1 link set v0 gso_ipv4_max_size 524280
ip netns exec g1 iperf3 -c 2001:db8::2 -t 6
With gso_ipv4_max_size = 65536, iperf3 reports 442 Mbps; with 524280, it
reports 39.4 Gbps. So gso_ipv4_max_size clearly affects this IPv6 flow.
I will keep 1/5 in the series and drop the Fixes tag, as Paolo suggests.
prev parent reply other threads:[~2026-09-29 11:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 4:40 [PATCH net-next v3 0/5] net: resegment oversized TCP GSO skbs Wang Zhan
2026-09-28 4:40 ` [PATCH net-next v3 1/5] net: core: use the packet's L3 protocol for the GSO size limit Wang Zhan
2026-09-28 23:36 ` Willem de Bruijn
2026-09-29 3:44 ` Wang Zhan
2026-09-29 4:01 ` Wang Zhan
2026-09-29 14:59 ` Willem de Bruijn
2026-09-28 4:40 ` [PATCH net-next v3 2/5] net: core: factor out the GSO device limit check Wang Zhan
2026-09-28 23:37 ` Willem de Bruijn
2026-09-29 7:47 ` Paolo Abeni
2026-09-28 4:41 ` [PATCH net-next v3 3/5] net: gso: support bounded TCP segmentation Wang Zhan
2026-09-28 23:39 ` Willem de Bruijn
2026-09-30 4:41 ` netdev-bot+sashiko
2026-09-28 4:41 ` [PATCH net-next v3 4/5] net: core: resegment oversized TCP GSO skbs Wang Zhan
2026-09-28 23:47 ` Willem de Bruijn
2026-09-29 10:25 ` Wang Zhan
2026-09-29 15:00 ` Willem de Bruijn
2026-09-30 4:41 ` netdev-bot+sashiko
2026-09-28 4:41 ` [PATCH net-next v3 5/5] net: net_test: add tests for bounded GSO segmentation Wang Zhan
2026-09-28 23:59 ` Willem de Bruijn
2026-09-29 10:30 ` Wang Zhan
2026-09-29 15:01 ` Willem de Bruijn
2026-09-30 4:41 ` netdev-bot+sashiko
2026-09-28 4:45 ` [PATCH net-next v3 0/5] net: resegment oversized TCP GSO skbs netdev-bot+sinfo
2026-09-28 5:49 ` Wang Zhan
2026-09-28 23:34 ` Willem de Bruijn
2026-09-29 7:27 ` Paolo Abeni
2026-09-29 11:50 ` Wang Zhan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929115028.2014285-1-wang.zhan@smartx.com \
--to=wang.zhan@smartx.com \
--cc=aconole@redhat.com \
--cc=alice@isovalent.com \
--cc=andrew+netdev@lunn.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=david.laight.linux@gmail.com \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=jasowangio@gmail.com \
--cc=keyong.sun@smartx.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox