Netdev List
 help / color / mirror / Atom feed
From: Petr Oros <poros@redhat.com>
To: netdev-bot+sashiko@kernel.org
Cc: Petr Oros <poros@redhat.com>,
	anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org,
	pabeni@redhat.com, edumazet@kernel.org, andrew+netdev@lunn.ch,
	netdev@vger.kernel.org, michal.swiatkowski@linux.intel.com,
	david.m.ertman@intel.com, pengpeng@iscas.ac.cn,
	przemyslaw.kitszel@intel.com, vinicius.gomes@intel.com,
	sridhar.samudrala@intel.com, aleksandr.loktionov@intel.com,
	horms@kernel.org, alexander.nowlin@intel.com,
	marcin.szycik@linux.intel.com
Subject: Re: [PATCH net 2/6] ice: skip per-VLAN promisc rules when default VSI Rx rule is set
Date: Thu, 19 Nov 2026 09:23:38 +0100	[thread overview]
Message-ID: <20261119082339.674502-1-poros@redhat.com> (raw)
In-Reply-To: <179495967132.3136.6714105968141020753@kernel.org>

On Tue, 17 Nov 2026 23:54:31 +0000, netdev-bot+sashiko@kernel.org wrote:
> ice: skip per-VLAN promisc rules when default VSI Rx rule is set

All of these hold up and will be addressed in v5.

> [Severity: Medium]
> If only IFF_ALLMULTI is cleared, can a promiscuous VSI end up with no
> multicast subscription?

Yes. It happened before the patch as well, because promisc and allmulti
use the same ICE_MCAST_PROMISC_BITS rules, but the patch claims to fix
exactly this case. In v5 the allmulti branch of ice_vsi_sync_fltr() is
skipped while the VSI is promiscuous. The promisc path owns the
multicast subscription and reconciles it with IFF_ALLMULTI when promisc
is cleared. That also covers both flags changing in one pass, where the
allmulti branch would otherwise add the per-VID rules right before the
promisc branch makes them redundant.

> [Severity: Low]
> This isn't a bug, but the commit message does not mention this change to
> ice_clear_promisc().

Agreed. The v5 commit message describes the VLAN agnostic multicast
rule used while the VSI holds the DFLT rule and the clear of both
recipes in ice_clear_promisc(), and it no longer says that the DFLT
rule alone covers every VLAN.

> [Severity: Medium]
> Can leaving promiscuous mode now fail because of the FLU exhaustion this
> patch is meant to address?

Yes. In v5, if not all per-VID rules can be added again, the ones that
were added are removed, the VLAN agnostic rule stays as the multicast
subscription and the DFLT rule is removed anyway, so leaving promisc
does not depend on free rule space. The per-VID rules are also dropped
on promisc entry whenever the VSI holds the DFLT rule, not only when
the DFLT rule was installed in that pass.

> [Severity: Medium]
> Is this reached even when no DFLT rule was actually installed?

Yes, ice_set_dflt_vsi() returns 0 for a LAG with switchdev without
installing the rule. In v5 the per-VID rules are dropped only when
ice_is_vsi_dflt_vsi() is true.

> [Severity: Low]
> Separately, ice_vsi_clear_vlan_mc_promisc() above removes the per-VID
> ICE_SW_LKUP_PROMISC_VLAN multicast rules, vid=0 included, before this
> ice_set_promisc() call installs the VLAN-agnostic vid=0 replacement.

Right. In v5 ice_set_promisc() installs the VLAN agnostic rule first
and the per-VID rules are dropped after it.

> [Severity: Medium]
> The per-VID rule is skipped here for a DFLT VSI, but the conversion further
> down in ice_vlan_rx_add_vid() is not gated the same way:

Yes. v5 skips the vid 0 recipe swap in ice_vlan_rx_add_vid() while the
VSI holds the DFLT rule, so the VLAN agnostic rule stays in place.

> [Severity: Medium]
> Is the per-VID rule also skipped here when the eswitch owns the DFLT rule,
> rather than netdev promisc?

Yes. In v5 the replacement for 3/6 goes first and resyncs the uplink
after a switchdev session. It drops the multicast promisc rules, marks
allmulti as not programmed and forces a filter sync, so with
IFF_ALLMULTI set the sync installs the per-VID rules for the VLANs
added during the session. The resync takes ICE_CFG_BUSY like
ice_vlan_rx_add_vid(), so a VLAN added just before the DFLT rule is
removed is covered as well.

Regards,
Petr


  reply	other threads:[~2026-11-19  8:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 23:12 [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-11-13 (ice) Tony Nguyen
2026-11-13 23:12 ` [PATCH net 1/6] ice: use global queue index in TC to-queue offload Tony Nguyen
2026-11-17 23:54   ` netdev-bot+sashiko
2026-11-13 23:12 ` [PATCH net 2/6] ice: skip per-VLAN promisc rules when default VSI Rx rule is set Tony Nguyen
2026-11-17 23:54   ` netdev-bot+sashiko
2026-11-19  8:23     ` Petr Oros [this message]
2026-11-13 23:12 ` [PATCH net 3/6] ice: preserve uplink DFLT Rx rule on switchdev release Tony Nguyen
2026-11-17 23:54   ` netdev-bot+sashiko
2026-11-19  8:36     ` Petr Oros
2026-11-13 23:12 ` [PATCH net 4/6] ice: Fix incorrect LLDP filter assumptions Tony Nguyen
2026-11-17 23:54   ` netdev-bot+sashiko
2026-11-13 23:12 ` [PATCH net 5/6] ice: propagate ETH56G deskew poll failures Tony Nguyen
2026-11-17 23:54   ` netdev-bot+sashiko
2026-11-13 23:12 ` [PATCH net 6/6] ice: allow reading the last byte of the NVM and Shadow RAM regions Tony Nguyen
2026-11-13 23:18 ` [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-11-13 (ice) netdev-bot+sinfo
2026-11-18 11:59 ` Petr Oros
2026-11-18 13:37   ` Magnus Karlsson
2026-11-18 13:48     ` Maciej Fijalkowski
2026-11-18 13:51       ` Petr Oros
2026-11-18 23:00         ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119082339.674502-1-poros@redhat.com \
    --to=poros@redhat.com \
    --cc=aleksandr.loktionov@intel.com \
    --cc=alexander.nowlin@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=david.m.ertman@intel.com \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=marcin.szycik@linux.intel.com \
    --cc=michal.swiatkowski@linux.intel.com \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pengpeng@iscas.ac.cn \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=sridhar.samudrala@intel.com \
    --cc=vinicius.gomes@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox