From: Petr Oros <poros@redhat.com>
To: netdev-bot+sashiko@kernel.org
Cc: Petr Oros <poros@redhat.com>,
anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, edumazet@kernel.org, andrew+netdev@lunn.ch,
netdev@vger.kernel.org, michal.swiatkowski@linux.intel.com,
david.m.ertman@intel.com, pengpeng@iscas.ac.cn,
przemyslaw.kitszel@intel.com, vinicius.gomes@intel.com,
sridhar.samudrala@intel.com, aleksandr.loktionov@intel.com,
horms@kernel.org, alexander.nowlin@intel.com,
marcin.szycik@linux.intel.com
Subject: Re: [PATCH net 3/6] ice: preserve uplink DFLT Rx rule on switchdev release
Date: Thu, 19 Nov 2026 09:36:06 +0100 [thread overview]
Message-ID: <20261119083610.677491-1-poros@redhat.com> (raw)
In-Reply-To: <179495967304.3136.16113490698897758196@kernel.org>
On Tue, 17 Nov 2026 23:54:33 +0000, netdev-bot+sashiko@kernel.org wrote:
> ice: preserve uplink DFLT Rx rule on switchdev release
All four are right, and they have one cause. ice_set_rx_mode() ignores
the uplink while switchdev runs, so vsi->current_netdev_flags is stale
after the session, and nothing schedules a filter sync on teardown.
Keeping the DFLT Rx rule based on the live netdev->flags does not fix
that.
v5 drops this approach. The patch is replaced by "ice: resync uplink
filters after a switchdev session", which moves to the front of the
series. ice_eswitch_release_env() removes the DFLT Rx rule as before,
and after the session the uplink is resynced. The multicast promisc
rules are dropped, IFF_ALLMULTI is cleared in current_netdev_flags,
ICE_VSI_PROMISC_CHANGED and the MAC filter change bits are set and a
filter sync is scheduled, so ice_vsi_sync_fltr() programs the uplink
from the netdev flags as they are when it runs.
> [Severity: Medium]
> Does the "same value" claim in this comment still hold if promisc changes
> concurrently?
No. In v5 the comment and the second read of netdev->flags are gone.
> [Severity: High]
> Does this leave vsi->current_netdev_flags out of sync with the hardware
> filter state?
Yes, both cases are reachable. With the forced sync the promisc branch
runs with the current flags in either case. The promisc off branch now
enables VLAN pruning (with NETIF_F_HW_VLAN_CTAG_FILTER) also when the
VSI does not hold the DFLT rule, because the session leaves pruning
disabled. The err_def_tx unwind in ice_eswitch_setup_env() removes the
DFLT Rx rule unconditionally again and resyncs too.
> [Severity: Medium]
> Can a concurrent promisc change be lost between this check and the point
> where is_running is cleared?
Yes. In v5 the resync is scheduled after is_running is cleared, so a
change made before that is picked up by the sync, and a change made
after that goes through ice_set_rx_mode() again.
> [Severity: Medium]
> Does the uplink still lose its multicast promisc subscription after the
> session?
Yes, and the address filters as well, because ice_eswitch_setup_env()
unsyncs the unicast and multicast lists. The forced sync in v5 installs
the multicast subscription and syncs both lists again.
Regards,
Petr
next prev parent reply other threads:[~2026-11-19 8:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 23:12 [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-11-13 (ice) Tony Nguyen
2026-11-13 23:12 ` [PATCH net 1/6] ice: use global queue index in TC to-queue offload Tony Nguyen
2026-11-17 23:54 ` netdev-bot+sashiko
2026-11-13 23:12 ` [PATCH net 2/6] ice: skip per-VLAN promisc rules when default VSI Rx rule is set Tony Nguyen
2026-11-17 23:54 ` netdev-bot+sashiko
2026-11-19 8:23 ` Petr Oros
2026-11-13 23:12 ` [PATCH net 3/6] ice: preserve uplink DFLT Rx rule on switchdev release Tony Nguyen
2026-11-17 23:54 ` netdev-bot+sashiko
2026-11-19 8:36 ` Petr Oros [this message]
2026-11-13 23:12 ` [PATCH net 4/6] ice: Fix incorrect LLDP filter assumptions Tony Nguyen
2026-11-17 23:54 ` netdev-bot+sashiko
2026-11-13 23:12 ` [PATCH net 5/6] ice: propagate ETH56G deskew poll failures Tony Nguyen
2026-11-17 23:54 ` netdev-bot+sashiko
2026-11-13 23:12 ` [PATCH net 6/6] ice: allow reading the last byte of the NVM and Shadow RAM regions Tony Nguyen
2026-11-13 23:18 ` [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-11-13 (ice) netdev-bot+sinfo
2026-11-18 11:59 ` Petr Oros
2026-11-18 13:37 ` Magnus Karlsson
2026-11-18 13:48 ` Maciej Fijalkowski
2026-11-18 13:51 ` Petr Oros
2026-11-18 23:00 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119083610.677491-1-poros@redhat.com \
--to=poros@redhat.com \
--cc=aleksandr.loktionov@intel.com \
--cc=alexander.nowlin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=marcin.szycik@linux.intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pengpeng@iscas.ac.cn \
--cc=przemyslaw.kitszel@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox