[PATCH 0/3] broadcom, ethernet/marvell,cx231xx,can/dev: Remove unused values and dead code

[PATCH 0/3] broadcom, ethernet/marvell,cx231xx,can/dev: Remove unused values and dead code

[Ariel Otilibili]

Hello,

This series clears out the Coverity IDs 1487817, 1561102, 1497123, & 1269153.

Thank you,

Ariel Otilibili (3):
  drivers/firmware/broadcom, ethernet/marvell: Remove unused values
  usb/cx231xx: Remove unused value
  net/can/dev: Remove dead code

 drivers/firmware/broadcom/tee_bnxt_fw.c                   | 2 --
 drivers/media/usb/cx231xx/cx231xx-avcore.c                | 1 -
 drivers/net/can/dev/dev.c                                 | 2 --
 drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c | 2 --
 4 files changed, 7 deletions(-)

-- 
2.47.1

[PATCH 1/3] drivers/firmware/broadcom, ethernet/marvell: Remove unused values

[Ariel Otilibili]

Coverity-IDs: 1487817, 1561102
Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
---
 drivers/firmware/broadcom/tee_bnxt_fw.c                   | 2 --
 drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c | 2 --
 2 files changed, 4 deletions(-)

diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index 40e3183a3d11..e0ea4ddb9a74 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
 	prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
 
 	while (rbytes)  {
-		nbytes = rbytes;
-
 		nbytes = min_t(u32, rbytes, param[0].u.memref.size);
 
 		/* Fill additional invoke cmd params */
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
index 6cc7a78968fc..0584528485e6 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
@@ -329,11 +329,9 @@ static int cn10k_mcs_write_rx_flowid(struct otx2_nic *pfvf,
 	mac_da = ether_addr_to_u64(secy->netdev->dev_addr);
 
 	req->data[0] = FIELD_PREP(MCS_TCAM0_MAC_DA_MASK, mac_da);
-	req->mask[0] = ~0ULL;
 	req->mask[0] = ~MCS_TCAM0_MAC_DA_MASK;
 
 	req->data[1] = FIELD_PREP(MCS_TCAM1_ETYPE_MASK, ETH_P_MACSEC);
-	req->mask[1] = ~0ULL;
 	req->mask[1] &= ~MCS_TCAM1_ETYPE_MASK;
 
 	req->mask[2] = ~0ULL;
-- 
2.47.1

Re: [PATCH 1/3] drivers/firmware/broadcom, ethernet/marvell: Remove unused values

[Andrew Lunn]

On Sat, Dec 21, 2024 at 04:44:15AM +0100, Ariel Otilibili wrote:
> Coverity-IDs: 1487817, 1561102
> Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>

One patch per driver please.

> --- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
> @@ -329,11 +329,9 @@ static int cn10k_mcs_write_rx_flowid(struct otx2_nic *pfvf,
>  	mac_da = ether_addr_to_u64(secy->netdev->dev_addr);
>  
>  	req->data[0] = FIELD_PREP(MCS_TCAM0_MAC_DA_MASK, mac_da);
> -	req->mask[0] = ~0ULL;
>  	req->mask[0] = ~MCS_TCAM0_MAC_DA_MASK;
>  
>  	req->data[1] = FIELD_PREP(MCS_TCAM1_ETYPE_MASK, ETH_P_MACSEC);
> -	req->mask[1] = ~0ULL;
>  	req->mask[1] &= ~MCS_TCAM1_ETYPE_MASK;
>  

As i said to another patch, you need to argue why you change is
correct. If you have no idea what the correct fix is, you should
simply report the issue to the Maintainer, and look at the git history
for these lines and see who added them, and ask them what is the
correct fix.

	Andrew

[PATCH 2/3] usb/cx231xx: Remove unused value

[Ariel Otilibili]

Coverity-ID: 1269153
Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
---
 drivers/media/usb/cx231xx/cx231xx-avcore.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c b/drivers/media/usb/cx231xx/cx231xx-avcore.c
index 1cfec76b72f3..f2a2d0c39080 100644
--- a/drivers/media/usb/cx231xx/cx231xx-avcore.c
+++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c
@@ -1896,7 +1896,6 @@ int cx231xx_dif_set_standard(struct cx231xx *dev, u32 standard)
 		status = vid_blk_write_word(dev, DIF_SOFT_RST_CTRL_REVB,
 						0x00000000);
 		/* Save the Spec Inversion value */
-		dif_misc_ctrl_value &= FLD_DIF_SPEC_INV;
 		dif_misc_ctrl_value = 0x3A093F10;
 	} else if (standard &
 		  (V4L2_STD_SECAM_B | V4L2_STD_SECAM_D | V4L2_STD_SECAM_G |
-- 
2.47.1

[PATCH 3/3] net/can/dev: Remove dead code

[Ariel Otilibili]

The default switch case ends with a return; meaning this return is never reached.

Coverity-ID: 1497123
Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
---
 drivers/net/can/dev/dev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/can/dev/dev.c b/drivers/net/can/dev/dev.c
index 681643ab3780..5ec3170b896a 100644
--- a/drivers/net/can/dev/dev.c
+++ b/drivers/net/can/dev/dev.c
@@ -85,8 +85,6 @@ const char *can_get_state_str(const enum can_state state)
 	default:
 		return "<unknown>";
 	}
-
-	return "<unknown>";
 }
 EXPORT_SYMBOL_GPL(can_get_state_str);
 
-- 
2.47.1

Re: [PATCH 3/3] net/can/dev: Remove dead code

[Andrew Lunn]

On Sat, Dec 21, 2024 at 04:44:17AM +0100, Ariel Otilibili wrote:
> The default switch case ends with a return; meaning this return is never reached.

Not quite correct. It is the fact that all the case statement,
including the default, make a return, which makes this last return
unreachable.

    Andrew

---
pw-bot: cr

[PATCH v2 0/3] broadcom, ethernet/marvell,cx231xx,can/dev: Remove unused values and dead code

[Ariel Otilibili]

Hello,

This series clears out the Coverity IDs 1487817, 1561102, 1497123,
& 1269153.

Thank you,
--
v2:
* fixed CI warnings
* see, https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/68562001/artifacts/report.htm

Ariel Otilibili (3):
  drivers/firmware/broadcom, ethernet/marvell: Remove unused values
  usb/cx231xx: Remove unused value
  net/can/dev: Remove dead code

 drivers/firmware/broadcom/tee_bnxt_fw.c                   | 2 --
 drivers/media/usb/cx231xx/cx231xx-avcore.c                | 1 -
 drivers/net/can/dev/dev.c                                 | 2 --
 drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c | 2 --
 4 files changed, 7 deletions(-)

-- 
2.47.1

[PATCH v2 1/3] drivers/firmware/broadcom, ethernet/marvell: Remove unused values

[Ariel Otilibili]

Coverity-Ids: 1487817, 1561102
Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
---
 drivers/firmware/broadcom/tee_bnxt_fw.c                   | 2 --
 drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c | 2 --
 2 files changed, 4 deletions(-)

diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index 40e3183a3d11..e0ea4ddb9a74 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
 	prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
 
 	while (rbytes)  {
-		nbytes = rbytes;
-
 		nbytes = min_t(u32, rbytes, param[0].u.memref.size);
 
 		/* Fill additional invoke cmd params */
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
index 6cc7a78968fc..0584528485e6 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
@@ -329,11 +329,9 @@ static int cn10k_mcs_write_rx_flowid(struct otx2_nic *pfvf,
 	mac_da = ether_addr_to_u64(secy->netdev->dev_addr);
 
 	req->data[0] = FIELD_PREP(MCS_TCAM0_MAC_DA_MASK, mac_da);
-	req->mask[0] = ~0ULL;
 	req->mask[0] = ~MCS_TCAM0_MAC_DA_MASK;
 
 	req->data[1] = FIELD_PREP(MCS_TCAM1_ETYPE_MASK, ETH_P_MACSEC);
-	req->mask[1] = ~0ULL;
 	req->mask[1] &= ~MCS_TCAM1_ETYPE_MASK;
 
 	req->mask[2] = ~0ULL;
-- 
2.47.1

[PATCH v2 2/3] usb/cx231xx: Remove unused value

[Ariel Otilibili]

Coverity-ID: 1269153
Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
---
 drivers/media/usb/cx231xx/cx231xx-avcore.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c b/drivers/media/usb/cx231xx/cx231xx-avcore.c
index 1cfec76b72f3..f2a2d0c39080 100644
--- a/drivers/media/usb/cx231xx/cx231xx-avcore.c
+++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c
@@ -1896,7 +1896,6 @@ int cx231xx_dif_set_standard(struct cx231xx *dev, u32 standard)
 		status = vid_blk_write_word(dev, DIF_SOFT_RST_CTRL_REVB,
 						0x00000000);
 		/* Save the Spec Inversion value */
-		dif_misc_ctrl_value &= FLD_DIF_SPEC_INV;
 		dif_misc_ctrl_value = 0x3A093F10;
 	} else if (standard &
 		  (V4L2_STD_SECAM_B | V4L2_STD_SECAM_D | V4L2_STD_SECAM_G |
-- 
2.47.1

Re: [PATCH v2 2/3] usb/cx231xx: Remove unused value

[Hans Verkuil]

On 21/12/2024 12:06, Ariel Otilibili wrote:
> Coverity-ID: 1269153
> Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
> ---
>  drivers/media/usb/cx231xx/cx231xx-avcore.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c b/drivers/media/usb/cx231xx/cx231xx-avcore.c
> index 1cfec76b72f3..f2a2d0c39080 100644
> --- a/drivers/media/usb/cx231xx/cx231xx-avcore.c
> +++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c
> @@ -1896,7 +1896,6 @@ int cx231xx_dif_set_standard(struct cx231xx *dev, u32 standard)
>  		status = vid_blk_write_word(dev, DIF_SOFT_RST_CTRL_REVB,
>  						0x00000000);
>  		/* Save the Spec Inversion value */
> -		dif_misc_ctrl_value &= FLD_DIF_SPEC_INV;

Don't remove this line,

>  		dif_misc_ctrl_value = 0x3A093F10;

instead this should have been |=, just like is done elsewhere in this function.

>  	} else if (standard &
>  		  (V4L2_STD_SECAM_B | V4L2_STD_SECAM_D | V4L2_STD_SECAM_G |

Also, please just post this as a separate patch to linux-media. It is bad form
to mix subsystems in the same patch series if there is no reason for it.

Regards,

	Hans

[PATCH v2 3/3] net/can/dev: Remove dead code

[Ariel Otilibili]

The default switch case ends with a return; meaning this return is never
reached.

Coverity-ID: 1497123
Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
---
 drivers/net/can/dev/dev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/can/dev/dev.c b/drivers/net/can/dev/dev.c
index 681643ab3780..5ec3170b896a 100644
--- a/drivers/net/can/dev/dev.c
+++ b/drivers/net/can/dev/dev.c
@@ -85,8 +85,6 @@ const char *can_get_state_str(const enum can_state state)
 	default:
 		return "<unknown>";
 	}
-
-	return "<unknown>";
 }
 EXPORT_SYMBOL_GPL(can_get_state_str);
 
-- 
2.47.1

Re: [PATCH v2 3/3] net/can/dev: Remove dead code

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

On 21.12.2024 12:06:49, Ariel Otilibili wrote:
> The default switch case ends with a return; meaning this return is never
> reached.
> 
> Coverity-ID: 1497123
> Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>

Applied this patch only to linux-can-next/testing.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v2 3/3] net/can/dev: Remove dead code

[Ariel Otilibili-Anieli]

On Sunday, December 22, 2024 17:37 CET, Marc Kleine-Budde <mkl@pengutronix.de> wrote:

> On 21.12.2024 12:06:49, Ariel Otilibili wrote:
> > The default switch case ends with a return; meaning this return is never
> > reached.
> > 
> > Coverity-ID: 1497123
> > Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
> 
> Applied this patch only to linux-can-next/testing.

Great, Marc; thanks for the feedback.
> 
> Thanks,
> Marc
> 
> -- 
> Pengutronix e.K.                 | Marc Kleine-Budde          |
> Embedded Linux                   | https://www.pengutronix.de |
> Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Re: [PATCH v2 0/3] broadcom, ethernet/marvell,cx231xx,can/dev: Remove unused values and dead code

[Andrew Lunn]

On Sat, Dec 21, 2024 at 12:06:46PM +0100, Ariel Otilibili wrote:
> Hello,
> 
> This series clears out the Coverity IDs 1487817, 1561102, 1497123,
> & 1269153.

Always start a new thread for a new version of a patch series.

Also, please wait at least 24 hours before new revisions:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

netdev is also closed to patches until the beginning of the new year.


    Andrew

---
pw-bot: cr