Re: [PATCH v16 05/22] cxl: Add function for type2 cxl regs setup

[Dan Williams <dan.j.williams@intel.com>]

Alejandro Lucero Palau wrote:
[..]
> > The driver should know in advance if calling:
> >
> >      cxl_pci_setup_regs(pdev, CXL_REGLOC_RBI_MEMDEV, &map);
> >
> > ...will fail. Put that logic where it belongs in the probe function of
> > the type-2 driver directly. This helper is not helping, it is just
> > obfuscating.
> 
> 
> As I said in the previous email, I disagree. The CXL API should be 
> handling all this. A client only cares about certain things, let's say 
> manageable things like capabilities, without going deep into CXL specs 
> about how all that needs to be implemented. This patch introduces a 
> function embedding different calls for those innerworkings which should 
> only be handled by the CXL core.

No. Please keep this policy out of the core. Do not invent a new
"capabilities" contract that the CXL core needs to maintain, and do not
add thin "cxl_pci_accel_" helpers that just wrap existing core
functionality. Call existing core functions directly and only augment
them at the point where fundamental assumptions are violated between
the "Type-3" and "Type-2" device models.

If the fundamental assumption violation boils down to a policy
difference between Type-2 and Type-3 then move that policy out of the
core. For example, register discovery is a mechanism, what the client
does with the result of that mechanism is policy and belongs in the
leaf/client. It was an accident of implementation that mandatory Type-3
register blocks were validated in the core not in cxl_pci from the
outset.