* [iproute PATCH] link_gre6: Detect invalid encaplimit values
@ 2017-11-28 15:49 Phil Sutter
2017-11-30 13:02 ` Nicolas Dichtel
0 siblings, 1 reply; 2+ messages in thread
From: Phil Sutter @ 2017-11-28 15:49 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
Looks like a typo: get_u8() returns 0 on success and -1 on error, so the
error checking here was ineffective.
Fixes: a11b7b71a6eba ("link_gre6: really support encaplimit option")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
ip/link_gre6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/link_gre6.c b/ip/link_gre6.c
index 50c1b804ceca7..0a82eaecf2cdd 100644
--- a/ip/link_gre6.c
+++ b/ip/link_gre6.c
@@ -372,7 +372,7 @@ get_failed:
} else {
__u8 uval;
- if (get_u8(&uval, *argv, 0) < -1)
+ if (get_u8(&uval, *argv, 0))
invarg("invalid ELIM", *argv);
encap_limit = uval;
flags &= ~IP6_TNL_F_IGN_ENCAP_LIMIT;
--
2.13.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-30 13:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-28 15:49 [iproute PATCH] link_gre6: Detect invalid encaplimit values Phil Sutter
2017-11-30 13:02 ` Nicolas Dichtel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox