From: Finn Thain <fthain@telegraphics.com.au>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Subject: Re: net/sonic: Fix some resource leaks in error handling paths
Date: Wed, 13 May 2020 11:14:56 +1000 (AEST) [thread overview]
Message-ID: <alpine.LNX.2.22.394.2005131028450.20@nippy.intranet> (raw)
In-Reply-To: <3fabce05-7da9-7daa-d92c-411369f35b4a@web.de>
On Tue, 12 May 2020, Markus Elfring wrote:
> > Markus, if you were to write a patch to improve upon coding-style.rst,
> > who should review it?
>
> All involved contributors have got chances to provide constructive
> comments.
But how could someone be elevated to "involved contributor" if their
patches were to be blocked by arbitrary application of the rules?
> I would be curious who will actually dare to contribute further ideas
> for this area.
>
You seem to be uniquely positioned to do that, if only because you cited
rules which don't appear to support your objection.
>
> > If you are unable to write or review such a patch, how can you hope to
> > adjudicate compliance?
>
> I can also try to achieve more improvements here to see how the
> available software documentation will evolve.
>
When the people who write and review the coding standards are the same
people who write and review the code, the standards devolve (given the
prevailing incentives).
> Regards,
> Markus
>
next prev parent reply other threads:[~2020-05-13 1:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 6:15 [PATCH] net/sonic: Fix some resource leaks in error handling paths Markus Elfring
2020-05-09 23:45 ` Finn Thain
2020-05-10 5:30 ` Markus Elfring
2020-05-10 8:25 ` Finn Thain
2020-05-10 9:07 ` Markus Elfring
2020-05-11 0:28 ` Finn Thain
2020-05-11 6:48 ` Markus Elfring
2020-05-12 0:08 ` Finn Thain
2020-05-12 6:38 ` Markus Elfring
2020-05-13 1:14 ` Finn Thain [this message]
2020-05-13 5:07 ` net/sonic: Software evolution around the application of coding standards Markus Elfring
2020-05-13 23:16 ` Finn Thain
2020-05-11 8:20 ` net/sonic: Fix some resource leaks in error handling paths Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.22.394.2005131028450.20@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=Markus.Elfring@web.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox