From: Markus Elfring <Markus.Elfring@web.de>
To: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Finn Thain <fthain@telegraphics.com.au>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] net/sonic: Fix some resource leaks in error handling paths
Date: Sat, 9 May 2020 08:15:18 +0200 [thread overview]
Message-ID: <b7651b26-ac1e-6281-efb2-7eff0018b158@web.de> (raw)
> While at it, rename a label in order to be slightly more informative and
> split some too long lines.
Would you like to add the tag “Fixes” to the change description?
…
> +++ b/drivers/net/ethernet/natsemi/macsonic.c
> @@ -506,10 +506,14 @@ static int mac_sonic_platform_probe(struct platform_device *pdev)
>
> err = register_netdev(dev);
> if (err)
> - goto out;
> + goto undo_probe1;
>
> return 0;
>
> +undo_probe1:
> + dma_free_coherent(lp->device,
> + SIZEOF_SONIC_DESC * SONIC_BUS_SCALE(lp->dma_bitmode),
> + lp->descriptors, lp->descriptors_laddr);
> out:
…
How do you think about the possibility to use the label “free_dma”?
Regards,
Markus
next reply other threads:[~2020-05-09 6:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 6:15 Markus Elfring [this message]
2020-05-09 23:45 ` [PATCH] net/sonic: Fix some resource leaks in error handling paths Finn Thain
2020-05-10 5:30 ` Markus Elfring
2020-05-10 8:25 ` Finn Thain
2020-05-10 9:07 ` Markus Elfring
2020-05-11 0:28 ` Finn Thain
2020-05-11 6:48 ` Markus Elfring
2020-05-12 0:08 ` Finn Thain
2020-05-12 6:38 ` Markus Elfring
2020-05-13 1:14 ` Finn Thain
2020-05-13 5:07 ` net/sonic: Software evolution around the application of coding standards Markus Elfring
2020-05-13 23:16 ` Finn Thain
2020-05-11 8:20 ` net/sonic: Fix some resource leaks in error handling paths Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-05-08 17:25 [PATCH] " Christophe JAILLET
2020-05-08 23:28 ` Finn Thain
2020-05-09 0:57 ` Jakub Kicinski
2020-05-09 1:57 ` Finn Thain
2020-05-09 2:04 ` Jakub Kicinski
2020-05-09 1:54 ` Jakub Kicinski
2020-05-09 16:47 ` Christophe JAILLET
2020-05-09 18:13 ` Jakub Kicinski
2020-05-09 20:31 ` Christophe JAILLET
2020-05-09 22:42 ` Joe Perches
2020-05-09 23:32 ` David Miller
2020-05-09 23:41 ` Joe Perches
2020-05-09 23:52 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7651b26-ac1e-6281-efb2-7eff0018b158@web.de \
--to=markus.elfring@web.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=fthain@telegraphics.com.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox