From: Markus Elfring <Markus.Elfring@web.de>
To: Finn Thain <fthain@telegraphics.com.au>,
Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: net/sonic: Fix some resource leaks in error handling paths
Date: Sun, 10 May 2020 11:07:18 +0200 [thread overview]
Message-ID: <bc70e24c-dd31-75b7-6ece-2ad31982641e@web.de> (raw)
In-Reply-To: <alpine.LNX.2.22.394.2005101738510.11@nippy.intranet>
>> https://lore.kernel.org/lkml/20200427061803.53857-1-christophe.jaillet@wanadoo.fr/
>
> Do you know when these bugs were introduced?
I suggest to take another look at a provided tag “Fixes”.
To which commit would you like to refer to for the proposed adjustment of
the function “mac_sonic_platform_probe”?
> Naming goto labels is just painting another bikeshed. Yes, some
> alternatives are preferable but it takes too long to identify them and
> finding consensus is unlikely anyway, as it's a matter of taste.
Would you find numbered labels unwanted according to a possible interpretation
related to “GW-BASIC” identifier selection?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=e99332e7b4cda6e60f5b5916cf9943a79dbef902#n460
Can programming preferences evolve into the direction of “say what the goto does”?
Regards,
Markus
next prev parent reply other threads:[~2020-05-10 9:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 6:15 [PATCH] net/sonic: Fix some resource leaks in error handling paths Markus Elfring
2020-05-09 23:45 ` Finn Thain
2020-05-10 5:30 ` Markus Elfring
2020-05-10 8:25 ` Finn Thain
2020-05-10 9:07 ` Markus Elfring [this message]
2020-05-11 0:28 ` Finn Thain
2020-05-11 6:48 ` Markus Elfring
2020-05-12 0:08 ` Finn Thain
2020-05-12 6:38 ` Markus Elfring
2020-05-13 1:14 ` Finn Thain
2020-05-13 5:07 ` net/sonic: Software evolution around the application of coding standards Markus Elfring
2020-05-13 23:16 ` Finn Thain
2020-05-11 8:20 ` net/sonic: Fix some resource leaks in error handling paths Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc70e24c-dd31-75b7-6ece-2ad31982641e@web.de \
--to=markus.elfring@web.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=fthain@telegraphics.com.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox