* [PATCH 3/3] hyperv: hid-hyperv.c: fixup-of-wait_for_completion_timeout-return-type
From: Nicholas Mc Guire @ 2015-01-25 11:00 UTC (permalink / raw)
To: K. Y. Srinivasan
Cc: Jiri Kosina, Haiyang Zhang, linux-kernel, Nicholas Mc Guire,
netdev, devel
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
The return type of wait_for_completion_timeout is unsigned long not
int. This patch fixes up the declarations only.
Patch was compile tested only for x86_64_defconfig + CONFIG_X86_VSMP=y
CONFIG_HYPERV=m, CONFIG_HID_HYPERV_MOUSE=m
Patch is against 3.19.0-rc5 -next-20150123
drivers/hid/hid-hyperv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
index 31fad64..6039f07 100644
--- a/drivers/hid/hid-hyperv.c
+++ b/drivers/hid/hid-hyperv.c
@@ -381,7 +381,7 @@ static void mousevsc_on_channel_callback(void *context)
static int mousevsc_connect_to_vsp(struct hv_device *device)
{
int ret = 0;
- int t;
+ unsigned long t;
struct mousevsc_dev *input_dev = hv_get_drvdata(device);
struct mousevsc_prt_msg *request;
struct mousevsc_prt_msg *response;
--
1.7.10.4
^ permalink raw reply related
* [PATCH net v2] bnx2x: fix napi poll return value for repoll
From: Govindarajulu Varadarajan @ 2015-01-25 10:39 UTC (permalink / raw)
To: davem, netdev, ariel.elior; +Cc: edumazet, Govindarajulu Varadarajan
With the commit d75b1ade567ffab ("net: less interrupt masking in NAPI") napi
repoll is done only when work_done == budget. When in busy_poll is we return 0
in napi_poll. We should return budget.
Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
---
v2:
Remove unnecessary change for work_done >= budget return value.
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
index 1d1147c..e468ed3 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
@@ -3175,7 +3175,7 @@ static int bnx2x_poll(struct napi_struct *napi, int budget)
}
#endif
if (!bnx2x_fp_lock_napi(fp))
- return work_done;
+ return budget;
for_each_cos_in_tx_queue(fp, cos)
if (bnx2x_tx_queue_has_work(fp->txdata_ptr[cos]))
--
2.2.2
^ permalink raw reply related
* [PATCH] hyperv: else branch not necessary
From: Nicholas Mc Guire @ 2015-01-25 8:46 UTC (permalink / raw)
To: K. Y. Srinivasan
Cc: devel, Haiyang Zhang, Nicholas Mc Guire, linux-kernel, netdev
As the if completes with a unconditional goto the else branch
is not needed here.
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
All paths of execution that did not exit through the if branch will
go through the else branch so no need for an explicit else here
Patch was compile tested only for x86_64_defconfig + CONFIG_X86_VSMP=y
CONFIG_HYPERV=m, CONFIG_HYPERV_NET=m
Patch is against 3.19.0-rc5 -next-20150123
drivers/net/hyperv/rndis_filter.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index 7bd8387..efb84a9 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -833,10 +833,10 @@ int rndis_filter_set_packet_filter(struct rndis_device *dev, u32 new_filter)
* send completion for it.
*/
goto exit;
- } else {
- set_complete = &request->response_msg.msg.set_complete;
- status = set_complete->status;
- }
+ }
+
+ set_complete = &request->response_msg.msg.set_complete;
+ status = set_complete->status;
cleanup:
if (request)
--
1.7.10.4
^ permalink raw reply related
* [PATCH] hyperv: fixup of wait_for_completion_timeout return type
From: Nicholas Mc Guire @ 2015-01-25 8:46 UTC (permalink / raw)
To: K. Y. Srinivasan
Cc: devel, Haiyang Zhang, Nicholas Mc Guire, linux-kernel, netdev
return type of wait_for_completion_timeout is unsigned long not int, this
patch just fixes up the declarations.
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
The return type of wait_for_completion_timeout is unsigned long not
int. This patch fixes up the declarations only.
Patch was compile tested only for x86_64_defconfig + CONFIG_X86_VSMP=y
CONFIG_HYPERV=m, CONFIG_HYPERV_NET=m
Patch is against 3.19.0-rc5 -next-20150123
drivers/net/hyperv/rndis_filter.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index ec0c40a..7bd8387 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -470,7 +470,7 @@ static int rndis_filter_query_device(struct rndis_device *dev, u32 oid,
struct rndis_query_request *query;
struct rndis_query_complete *query_complete;
int ret = 0;
- int t;
+ unsigned long t;
if (!result)
return -EINVAL;
@@ -560,7 +560,8 @@ int rndis_filter_set_device_mac(struct hv_device *hdev, char *mac)
char macstr[2*ETH_ALEN+1];
u32 extlen = sizeof(struct rndis_config_parameter_info) +
2*NWADR_STRLEN + 4*ETH_ALEN;
- int ret, t;
+ int ret;
+ unsigned long t;
request = get_rndis_request(rdev, RNDIS_MSG_SET,
RNDIS_MESSAGE_SIZE(struct rndis_set_request) + extlen);
@@ -634,7 +635,8 @@ int rndis_filter_set_offload_params(struct hv_device *hdev,
struct ndis_offload_params *offload_params;
struct rndis_set_complete *set_complete;
u32 extlen = sizeof(struct ndis_offload_params);
- int ret, t;
+ int ret;
+ unsigned long t;
u32 vsp_version = nvdev->nvsp_version;
if (vsp_version <= NVSP_PROTOCOL_VERSION_4) {
@@ -708,7 +710,8 @@ int rndis_filter_set_rss_param(struct rndis_device *rdev, int num_queue)
struct ndis_recv_scale_param *rssp;
u32 *itab;
u8 *keyp;
- int i, t, ret;
+ int i, ret;
+ unsigned long t;
request = get_rndis_request(
rdev, RNDIS_MSG_SET,
@@ -792,7 +795,8 @@ int rndis_filter_set_packet_filter(struct rndis_device *dev, u32 new_filter)
struct rndis_set_request *set;
struct rndis_set_complete *set_complete;
u32 status;
- int ret, t;
+ int ret;
+ unsigned long t;
struct net_device *ndev;
ndev = dev->net_dev->ndev;
@@ -848,7 +852,8 @@ static int rndis_filter_init_device(struct rndis_device *dev)
struct rndis_initialize_request *init;
struct rndis_initialize_complete *init_complete;
u32 status;
- int ret, t;
+ int ret;
+ unsigned long t;
request = get_rndis_request(dev, RNDIS_MSG_INIT,
RNDIS_MESSAGE_SIZE(struct rndis_initialize_request));
@@ -998,7 +1003,7 @@ int rndis_filter_device_add(struct hv_device *dev,
struct netvsc_device_info *device_info = additional_info;
struct ndis_offload_params offloads;
struct nvsp_message *init_packet;
- int t;
+ unsigned long t;
struct ndis_recv_scale_cap rsscap;
u32 rsscap_size = sizeof(struct ndis_recv_scale_cap);
u32 mtu, size;
--
1.7.10.4
^ permalink raw reply related
* Re: [PATCH net] ipvlan: fix incorrect usage of IS_ERR() macro in IPv6 code path.
From: David Miller @ 2015-01-25 8:24 UTC (permalink / raw)
To: maheshb; +Cc: netdev, edumazet, dan.carpenter
In-Reply-To: <1422165223-13496-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Sat, 24 Jan 2015 21:53:43 -0800
> The ip6_route_output() always returns a valid dst pointer unlike in IPv4
> case. So the validation has to be different from the IPv4 path. Correcting
> that error in this patch.
>
> This was picked up by a static checker with a following warning -
>
> drivers/net/ipvlan/ipvlan_core.c:380 ipvlan_process_v6_outbound()
> warn: 'dst' isn't an ERR_PTR
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] net: llc: use correct size for sysctl timeout entries
From: David Miller @ 2015-01-25 8:23 UTC (permalink / raw)
To: sasha.levin; +Cc: linux-kernel, acme, netdev
In-Reply-To: <1422064020-22080-1-git-send-email-sasha.levin@oracle.com>
From: Sasha Levin <sasha.levin@oracle.com>
Date: Fri, 23 Jan 2015 20:47:00 -0500
> The timeout entries are sizeof(int) rather than sizeof(long), which
> means that when they were getting read we'd also leak kernel memory
> to userspace along with the timeout values.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Applied, thank you.
^ permalink raw reply
* Re: [PATCH net] netxen: fix netxen_nic_poll() logic
From: David Miller @ 2015-01-25 8:22 UTC (permalink / raw)
To: eric.dumazet; +Cc: umgwanakikbuti, netdev, manish.chopra
In-Reply-To: <1421942178.3471.10.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 22 Jan 2015 07:56:18 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> NAPI poll logic now enforces that a poller returns exactly the budget
> when it wants to be called again.
>
> If a driver limits TX completion, it has to return budget as well when
> the limit is hit, not the number of received packets.
>
> Reported-and-tested-by: Mike Galbraith <umgwanakikbuti@gmail.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Fixes: d75b1ade567f ("net: less interrupt masking in NAPI")
Applied and queued up for -stable, thanks Eric.
^ permalink raw reply
* Re: [PATCH] net:wireless:Add proper locking for the function, b43_op_beacon_set_tim in main.c
From: Rafał Miłecki @ 2015-01-25 8:14 UTC (permalink / raw)
To: Nicholas Krause
Cc: Stefano Brivio, Network Development,
linux-wireless@vger.kernel.org, b43-dev, Kalle Valo,
Linux Kernel Mailing List
In-Reply-To: <1422169574-8451-1-git-send-email-xerofoify@gmail.com>
On 25 January 2015 at 08:06, Nicholas Krause <xerofoify@gmail.com> wrote:
> Adds proper locking for the function, b43_op_beacon_set_tim in main.c that internally calls b43_update_templates.
> Due to the function that is being called internally,b43_update_templates needing the mutex lock of the structure
> pointer wl passed it to run successfully and without issues we add the calls to mutex_lock before and mutex_unlock
> after it's call internally in b43_op_beacon_set_tim in order to allow the function,,b43_update_templates to run
> successfully and without issues related to concurrent access.
Nack
^ permalink raw reply
* Re: [PATCH v1] cxgb3: re-use native hex2bin()
From: David Miller @ 2015-01-25 8:10 UTC (permalink / raw)
To: andy.shevchenko; +Cc: netdev, santosh
In-Reply-To: <1421962659-25885-1-git-send-email-andy.shevchenko@gmail.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Thu, 22 Jan 2015 23:37:39 +0200
> Call hex2bin() library function instead of doing conversion here.
>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH v1] usbnet: re-use native hex2bin()
From: David Miller @ 2015-01-25 8:09 UTC (permalink / raw)
To: andy.shevchenko; +Cc: oneukum, netdev
In-Reply-To: <1421962032-25497-1-git-send-email-andy.shevchenko@gmail.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Thu, 22 Jan 2015 23:27:12 +0200
> Call hex2bin() library function, instead of doing conversion here.
>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] atheros/atlx: Simplify bit manipulations
From: David Miller @ 2015-01-25 7:35 UTC (permalink / raw)
To: linux; +Cc: jcliburn, chris.snook, netdev, linux-kernel
In-Reply-To: <1422011212-30095-1-git-send-email-linux@rasmusvillemoes.dk>
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Date: Fri, 23 Jan 2015 12:06:52 +0100
> The code 'if (foo & X) foo &= ~X;' is semantically equivalent to
> simply 'foo &= ~X;', but gcc generates about four instructions for the
> former, one for the latter. Similarly, if X consists of a single bit,
> 'if (!(foo & X)) X |= X;' can be replaced by 'foo |= X;'.
>
> In the atl2 case, gcc does know how to merge the new adjacent
> operations, so altogether this gives a nice little code size
> reduction of about 80 bytes.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
I agree with the feedback given that these open-coded sequences should
be replaced with the appropriate PCI helpers instead of edited
further.
^ permalink raw reply
* Re: [PATCH v3 net-next] net: ipv6: Add sysctl entry to disable MTU updates from RA
From: Vadim Kochan @ 2015-01-25 7:21 UTC (permalink / raw)
To: David Miller; +Cc: harouth, netdev
In-Reply-To: <20150124.231432.1788575004982971514.davem@davemloft.net>
On Sat, Jan 24, 2015 at 11:14:32PM -0800, David Miller wrote:
> From: Harout Hedeshian <harouth@codeaurora.org>
> Date: Tue, 20 Jan 2015 10:06:05 -0700
>
> > The kernel forcefully applies MTU values received in router
> > advertisements provided the new MTU is less than the current. This
> > behavior is undesirable when the user space is managing the MTU. Instead
> > a sysctl flag 'accept_ra_mtu' is introduced such that the user space
> > can control whether or not RA provided MTU updates should be applied. The
> > default behavior is unchanged; user space must explicitly set this flag
> > to 0 for RA MTUs to be ignored.
> >
> > Signed-off-by: Harout Hedeshian <harouth@codeaurora.org>
>
> Under what circumstances would userland ignore a router advertized
> MTU, and are the RFCs ok with this?
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
I don't know if it make sense but I had the same use case when was
working on supporting IPv6 infrastructure for home gateway.
One of the provider had requirements to have ability set force IPv6 MTU
value via TR parameters and disable update it via RA.
Regards,
^ permalink raw reply
* Re: [PATCH net-next 0/9] mlx4: Fix and enhance the device reset flow
From: David Miller @ 2015-01-25 7:31 UTC (permalink / raw)
To: ogerlitz; +Cc: netdev, matanb, amirv, talal, roland
In-Reply-To: <54C103B2.2090406@mellanox.com>
From: Or Gerlitz <ogerlitz@mellanox.com>
Date: Thu, 22 Jan 2015 16:05:38 +0200
> On 1/21/2015 4:45 PM, Or Gerlitz wrote:
>> This series from Yishai Hadas fixes the device reset flow and adds
>> SRIOV support.
>>
>> Reset flows are required whenever a device experiences errors, is
>> unresponsive,
>> or is not in a deterministic state. In such cases, the driver is
>> expected to
>> reset the HW and continue operation. When SRIOV is enabled, these
>> requirements
>> apply both to PF and VF devices.
>
> So we spotted some problem in the SRIOV flow and prefer to fix it in a
> V1, which will be sent next week, please don't take this one.
Ok, I'll toss this series and wait for the new version. Thanks.
^ permalink raw reply
* Re: [net-next 00/15][pull request] Intel Wired LAN Driver Updates 2015-01-22
From: David Miller @ 2015-01-25 7:24 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, nhorman, sassmann, jogreene
In-Reply-To: <1421980631-1955-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 22 Jan 2015 18:36:56 -0800
> This series contains updates to e1000, e1000e, igb, fm10k and virtio_net.
Pulled, thanks a lot Jeff.
^ permalink raw reply
* Re: [PATCH v2 net-next 0/2] vxlan: Don't use UDP socket for transmit
From: David Miller @ 2015-01-25 7:16 UTC (permalink / raw)
To: therbert; +Cc: tgraf, jesse, netdev
In-Reply-To: <1421781785-24557-1-git-send-email-therbert@google.com>
From: Tom Herbert <therbert@google.com>
Date: Tue, 20 Jan 2015 11:23:03 -0800
> UDP socket is not pertinent to transmit for UDP tunnels, checksum
> enablement can be done without a socket. This patch set eliminates
> reference to a socket in udp_tunnel_xmit functions and in VXLAN
> transmit.
>
> Also, make GBP, RCO, can CSUM6_RX flags visible to receive socket
> and only match these for shareable socket.
>
> v2: Fix geneve to call udp_tunnel_xmit with good arguments.
Series applied, thanks Tom.
^ permalink raw reply
* Re: [PATCH v3 net-next] net: ipv6: Add sysctl entry to disable MTU updates from RA
From: David Miller @ 2015-01-25 7:14 UTC (permalink / raw)
To: harouth; +Cc: netdev
In-Reply-To: <1421773565-5181-1-git-send-email-harouth@codeaurora.org>
From: Harout Hedeshian <harouth@codeaurora.org>
Date: Tue, 20 Jan 2015 10:06:05 -0700
> The kernel forcefully applies MTU values received in router
> advertisements provided the new MTU is less than the current. This
> behavior is undesirable when the user space is managing the MTU. Instead
> a sysctl flag 'accept_ra_mtu' is introduced such that the user space
> can control whether or not RA provided MTU updates should be applied. The
> default behavior is unchanged; user space must explicitly set this flag
> to 0 for RA MTUs to be ignored.
>
> Signed-off-by: Harout Hedeshian <harouth@codeaurora.org>
Under what circumstances would userland ignore a router advertized
MTU, and are the RFCs ok with this?
^ permalink raw reply
* [PATCH] net:wireless:Add proper locking for the function, b43_op_beacon_set_tim in main.c
From: Nicholas Krause @ 2015-01-25 7:06 UTC (permalink / raw)
To: stefano.brivio-hl5o88x/ua9eoWH0uzbU5w
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
kvalo-sgV2jX0FEOL9JmXXK+q4OQ, linux-kernel-u79uwXL29TY76Z2rM5mHXA
Adds proper locking for the function, b43_op_beacon_set_tim in main.c that internally calls b43_update_templates.
Due to the function that is being called internally,b43_update_templates needing the mutex lock of the structure
pointer wl passed it to run successfully and without issues we add the calls to mutex_lock before and mutex_unlock
after it's call internally in b43_op_beacon_set_tim in order to allow the function,,b43_update_templates to run
successfully and without issues related to concurrent access.
Signed-off-by: Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/net/wireless/b43/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index 47731cb..b807958 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -5094,8 +5094,9 @@ static int b43_op_beacon_set_tim(struct ieee80211_hw *hw,
{
struct b43_wl *wl = hw_to_b43_wl(hw);
- /* FIXME: add locking */
+ mutex_lock(&wl->mutex);
b43_update_templates(wl);
+ mutex_unlock(&wl->mutex);
return 0;
}
--
2.1.0
^ permalink raw reply related
* Re: [PATCH net-next 1/7] r8152: adjust rx_bottom
From: David Miller @ 2015-01-25 6:43 UTC (permalink / raw)
To: hayeswang; +Cc: sfeldma, netdev, nic_swsd, linux-kernel, linux-usb
In-Reply-To: <0835B3720019904CB8F7AA43166CEEB2EE6E9F@RTITMBSV03.realtek.com.tw>
From: Hayes Wang <hayeswang@realtek.com>
Date: Tue, 20 Jan 2015 03:24:52 +0000
> David Miller [mailto:davem@davemloft.net]
>> Sent: Tuesday, January 20, 2015 10:52 AM
> [...]
>> agg->list is not local, you have to use a spinlock to protect
>> modifications to it, some other sites which modify agg->list do take
>> the lock properly.
>>
>> You cannot modify a list like agg->list without proper locking.
>
> Excuse me. I don't understand.
>
> Before step1
> tp_rx_done->listA->listB->listC->listD->...
> rx_queue->
> Because the other function would chage tp->rx_done,
> I need move the lists with spin lock.
>
> After step1
> tp_rx_done->
> rx_queue->listA->listB->listC->listD->...
>
> Now I dequeue one of the lists from the list_head and
> deal with it.
> tp_rx_done->
> rx_queue->listA->listC->listD->...
> listB
>
> Then, if I want to put it back to rx_queue, I have to
> use spin lock. Why? No other function would chage
> rx_queue and the items in it.
What keeps rtl_start_rx() from running in parallel with
r8152_submit_rx(), or any other accessor of the RX agg->list?
You also keep using different terminology from me when
discussing what lists do or do not need protection, and that
is going to make it difficult for anyone to follow our
conversation at all.
We're talking specifically about RX agg->list objects and
whether access to them need synchronization or not.
^ permalink raw reply
* Re: [PATCH net 2/2] bnx2x: fix napi poll return value for repoll
From: David Miller @ 2015-01-25 6:40 UTC (permalink / raw)
To: _govind; +Cc: netdev, ariel.elior, ssujith, benve
In-Reply-To: <1421759776-376-3-git-send-email-_govind@gmx.com>
From: Govindarajulu Varadarajan <_govind@gmx.com>
Date: Tue, 20 Jan 2015 18:46:16 +0530
> With the commit d75b1ade567ffab ("net: less interrupt masking in NAPI") napi repoll
> is done only when work_done == budget. When in busy_poll is we return 0 in
> napi_poll. We should return budget. Also do not return workdone > budget.
>
> Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
This seems like it needs some adjustments, please make those corrections
and respin this patch.
Thanks.
^ permalink raw reply
* Re: [PATCH net 1/2] enic: fix rx napi poll return value
From: David Miller @ 2015-01-25 6:39 UTC (permalink / raw)
To: _govind; +Cc: netdev, ariel.elior, ssujith, benve
In-Reply-To: <1421759776-376-2-git-send-email-_govind@gmx.com>
From: Govindarajulu Varadarajan <_govind@gmx.com>
Date: Tue, 20 Jan 2015 18:46:15 +0530
> With the commit d75b1ade567ffab ("net: less interrupt masking in NAPI") napi repoll
> is done only when work_done == budget. When we are in busy_poll we return 0 in
> napi_poll. We should return budget.
>
> Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
Applied.
^ permalink raw reply
* Question about FIXME in the function,ath10k_htc_send_complete_check for the file htc.c
From: nick @ 2015-01-25 6:32 UTC (permalink / raw)
To: kvalo; +Cc: netdev, linux-wireless, linux-kernel, ath10k
Greetings Again Kalle and others,
I am wondering about the fix me in the function,ath10k_htc_send_complete_check
for the file,htc.c. I am wondering if there is a hardware limitation and the
line for reserving 20 bytes for the sk_buff used is need in this function. I
am assuming this is needed due to hardware limitations and therefore can't be
removed but should be commented explaining this limitation. Please let me known
otherwise if I am missing something.
Thanks,
Nick
^ permalink raw reply
* CONFIG_NF_CONNTRACK_PROCFS
From: Oleg @ 2015-01-25 5:51 UTC (permalink / raw)
To: netdev
Hi, all.
net/netfilter/nf_conntrack procfs file is marked as obsolete in the recent
kernels. What's wrong with it? Or it's simply a new fashion to replace
simple file interface with anything else?
--
Nemanov Oleg
^ permalink raw reply
* Re: pull-request: wireless-drivers 2015-01-20
From: David Miller @ 2015-01-25 5:55 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, netdev, linux-kernel
In-Reply-To: <87oapt3jtm.fsf@kamboji.qca.qualcomm.com>
From: Kalle Valo <kvalo@qca.qualcomm.com>
Date: Tue, 20 Jan 2015 11:03:33 +0200
> more fixes for 3.19, I hope these are still appropriate. Please let me
> know if there are any issues.
Pulled, thanks.
^ permalink raw reply
* Re: [PATCH net-next v2 1/1] ARM: dts: imx6sx: correct i.MX6sx sdb board enet phy address
From: David Miller @ 2015-01-25 5:55 UTC (permalink / raw)
To: b38611; +Cc: shawn.guo, netdev, s.hauer, stefan, linux-arm-kernel
In-Reply-To: <1421743697-26918-1-git-send-email-b38611@freescale.com>
From: Fugang Duan <b38611@freescale.com>
Date: Tue, 20 Jan 2015 16:48:17 +0800
> The commit (3d125f9c91c5) cause i.MX6SX sdb enet cannot work. The cause is
> the commit add mdio node with un-correct phy address.
>
> The patch just correct i.MX6sx sdb board enet phy address.
>
> V2:
> * As Shawn's suggestion that unit-address should match 'reg' property, so
> update ethernet-phy unit-address.
>
> Acked-by: Stefan Agner <stefan@agner.ch>
> Signed-off-by: Fugang Duan <B38611@freescale.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 1/1] net: fec: fix the warning found by dma debug
From: David Miller @ 2015-01-25 5:54 UTC (permalink / raw)
To: b38611; +Cc: netdev, festevam, christian.gmeiner, moon.linux, bhutchings,
stephen
In-Reply-To: <1421734235-6563-1-git-send-email-b38611@freescale.com>
From: Fugang Duan <b38611@freescale.com>
Date: Tue, 20 Jan 2015 14:10:35 +0800
> Enable kernel config "CONFIG_HAVE_DMA_API_DEBUG", FEC have kernel warning:
...
> There have one bug in .fec_enet_tx_queue() function to unmap the DMA memory:
> For SG or TSO, get one buffer descriptor and then unmap the related DMA memory, and then
> get the next buffer descriptor, loop to while() to check "TX_READY". If "TX_READY" bit
> still __IS__ existed in the BD (The next fraglist or next TSO packet is not transmited
> complitely), exit the current clean work. When the next work is triggered, it still repeat
> above step with the same BD. The potential issue is that unmap the same DMA memory for
> multiple times.
>
> The patch fix the clean work for SG and TSO packet.
>
> Reported-by: Anand Moon <moon.linux@yahoo.com>
> Reported-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> Signed-off-by: Fugang Duan <B38611@freescale.com>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox