PPTP conntrack w/out DEBUG is broken ???

[Marian Stagarescu <marian@ti.com>]

i run into one problem with PPTP conntrack:

run it with debug on: works
run it w/out debug on: does not.

i also turned on the patch below and configure the CONFIG_NETFILTER_DEBUG:
compile ip_conntrack_pptp with debug on: all ok
compile ip_conntrack_pptp w/out debug: does not even print the ASSERT readlock 
statements from CONFIG_NETFILTER_DEBUG, PPTP connection is not established.

this debug issue was tracked down to a single printk statement in 
ip_conntrack_pptp.c: line 244,245:

DEBUGP("%s, CID=%X, PCID=%X\n", strMName[msg]                  
                     ntohs(*cid), ntohs(*pcid));

i run this on a 2.4.17 mips little endian, single proc, latest pptp ALG files 
from netfilter, newnat13.

how this can be ? 

thanks for any input,
marian



On Sunday 22 September 2002 06:30 am, Martin Josefsson wrote:
> On Fri, 2002-09-20 at 11:11, Cédric Rivard wrote:
> > Hi all,
> >
> > As I've already reported, there is a problem with the PPTP conntrack
> > module of pom. It can't be built with the option CONFIG_NETFILTER_DEBUG.
> > And I still receive questions about the first thread I started on this
> > problem but without pointing the cause. I hope that everyone is now aware
> > of this issue.
>
> This issue came to my attention in the end of August, I produced a patch
> and I never heard from that person again. The patch is quite ugly but it
> does solve this specific problem. I was waiting for some more input from
> other developers before submitting it to cvs but now I've given up on
> that and I've submitted it. patch-o-matic in cvs now works with
> debugging enabled.
>
> or you can apply this patch on your kernel after patching with the
> patch-o-matic you are currently using:
>
> http://www.netfilter.org/~gandalf/patches/ip_conntrack_proto_gre.c-lockfix