PPTP conntrack with CONFIG_NETFILTER_DEBUG is broken (was: newnat and patch-o-matic)

PPTP conntrack with CONFIG_NETFILTER_DEBUG is broken (was: newnat and patch-o-matic)

[Cédric Rivard]

Hi all,

As I've already reported, there is a problem with the PPTP conntrack module of pom. It can't be built with the option CONFIG_NETFILTER_DEBUG. And I still receive questions about the first thread I started on this problem but without pointing the cause.
I hope that everyone is now aware of this issue.
Regards,
Cédric

Re: PPTP conntrack with CONFIG_NETFILTER_DEBUG is broken (was: newnat and patch-o-matic)

[Martin Josefsson]

On Fri, 2002-09-20 at 11:11, Cédric Rivard wrote:
> Hi all,
> 
> As I've already reported, there is a problem with the PPTP conntrack module of pom. It can't be built with the option CONFIG_NETFILTER_DEBUG. And I still receive questions about the first thread I started on this problem but without pointing the cause.
> I hope that everyone is now aware of this issue.

This issue came to my attention in the end of August, I produced a patch
and I never heard from that person again. The patch is quite ugly but it
does solve this specific problem. I was waiting for some more input from
other developers before submitting it to cvs but now I've given up on
that and I've submitted it. patch-o-matic in cvs now works with
debugging enabled.

or you can apply this patch on your kernel after patching with the
patch-o-matic you are currently using:

http://www.netfilter.org/~gandalf/patches/ip_conntrack_proto_gre.c-lockfix

-- 
/Martin

Never argue with an idiot. They drag you down to their level, then beat
you with experience.

PPTP conntrack w/out DEBUG is broken ???

[Marian Stagarescu]

i run into one problem with PPTP conntrack:

run it with debug on: works
run it w/out debug on: does not.

i also turned on the patch below and configure the CONFIG_NETFILTER_DEBUG:
compile ip_conntrack_pptp with debug on: all ok
compile ip_conntrack_pptp w/out debug: does not even print the ASSERT readlock 
statements from CONFIG_NETFILTER_DEBUG, PPTP connection is not established.

this debug issue was tracked down to a single printk statement in 
ip_conntrack_pptp.c: line 244,245:

DEBUGP("%s, CID=%X, PCID=%X\n", strMName[msg]                  
                     ntohs(*cid), ntohs(*pcid));

i run this on a 2.4.17 mips little endian, single proc, latest pptp ALG files 
from netfilter, newnat13.

how this can be ? 

thanks for any input,
marian



On Sunday 22 September 2002 06:30 am, Martin Josefsson wrote:
> On Fri, 2002-09-20 at 11:11, Cédric Rivard wrote:
> > Hi all,
> >
> > As I've already reported, there is a problem with the PPTP conntrack
> > module of pom. It can't be built with the option CONFIG_NETFILTER_DEBUG.
> > And I still receive questions about the first thread I started on this
> > problem but without pointing the cause. I hope that everyone is now aware
> > of this issue.
>
> This issue came to my attention in the end of August, I produced a patch
> and I never heard from that person again. The patch is quite ugly but it
> does solve this specific problem. I was waiting for some more input from
> other developers before submitting it to cvs but now I've given up on
> that and I've submitted it. patch-o-matic in cvs now works with
> debugging enabled.
>
> or you can apply this patch on your kernel after patching with the
> patch-o-matic you are currently using:
>
> http://www.netfilter.org/~gandalf/patches/ip_conntrack_proto_gre.c-lockfix

PPTP conntrack w/out DEBUG is broken ???

[Marian Stagarescu]

> i run into one problem with PPTP conntrack:
>
> run it with debug on: works
> run it w/out debug on: does not.
>
> i also turned on the patch below and configure the CONFIG_NETFILTER_DEBUG:
> compile ip_conntrack_pptp with debug on: all ok
> compile ip_conntrack_pptp w/out debug: does not even print the ASSERT
> readlock statements from CONFIG_NETFILTER_DEBUG, PPTP connection is not
> established.
>
> this debug issue was tracked down to a single printk statement in
> ip_conntrack_pptp.c: line 244,245:
>
> DEBUGP("%s, CID=%X, PCID=%X\n", strMName[msg]
>                      ntohs(*cid), ntohs(*pcid));
>
> i run this on a 2.4.17 mips little endian, single proc, latest pptp ALG
> files from netfilter, newnat13.
>
> how this can be ?
>
> thanks for any input,
> marian
>
> On Sunday 22 September 2002 06:30 am, Martin Josefsson wrote:
> > On Fri, 2002-09-20 at 11:11, Cédric Rivard wrote:
> > > Hi all,
> > >
> > > As I've already reported, there is a problem with the PPTP conntrack
> > > module of pom. It can't be built with the option
> > > CONFIG_NETFILTER_DEBUG. And I still receive questions about the first
> > > thread I started on this problem but without pointing the cause. I hope
> > > that everyone is now aware of this issue.
> >
> > This issue came to my attention in the end of August, I produced a patch
> > and I never heard from that person again. The patch is quite ugly but it
> > does solve this specific problem. I was waiting for some more input from
> > other developers before submitting it to cvs but now I've given up on
> > that and I've submitted it. patch-o-matic in cvs now works with
> > debugging enabled.
> >
> > or you can apply this patch on your kernel after patching with the
> > patch-o-matic you are currently using:
> >
> > http://www.netfilter.org/~gandalf/patches/ip_conntrack_proto_gre.c-lockfi
> >x

Re: PPTP conntrack w/out DEBUG is broken ???

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

On Wed, Sep 25, 2002 at 04:48:42PM -0400, Marian Stagarescu wrote:
> i run into one problem with PPTP conntrack:
> 
> run it with debug on: works
> run it w/out debug on: does not.

what do you call 'debug' ?  Does this mean the DEBUG #defines in the
respective sourcecode .c files, or are you talking about CONFIG_NETFILTER_DEBUG?

> this debug issue was tracked down to a single printk statement in 
> ip_conntrack_pptp.c: line 244,245:
> 
> DEBUGP("%s, CID=%X, PCID=%X\n", strMName[msg]                  
>                      ntohs(*cid), ntohs(*pcid));
> 

What happens?  Does the kernel oops at this statement?

> thanks for any input,
> marian

-- 
Live long and prosper
- Harald Welte / laforge@gnumonks.org               http://www.gnumonks.org/
============================================================================
"If this were a dictatorship, it'd be a heck of a lot easier, just so long as
 I'm the dictator."  --  George W. Bush Dec 18, 2000

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: PPTP conntrack w/out DEBUG is broken ???

[Marian Stagarescu]

On Wednesday 02 October 2002 09:30 am, Harald Welte wrote:
> On Wed, Sep 25, 2002 at 04:48:42PM -0400, Marian Stagarescu wrote:
> > i run into one problem with PPTP conntrack:
> >
> > run it with debug on: works
> > run it w/out debug on: does not.
>
> what do you call 'debug' ?  Does this mean the DEBUG #defines in the
> respective sourcecode .c files

yes. ip_conntrack_pptp.c, ip_nat_pptp.c, ip_conntrack_proto_gre.c, 
ip_nat_proto_gre.c are compiled with DEBUGP defined.

> or are you talking about
> CONFIG_NETFILTER_DEBUG?

i have this turned on as well

> > this debug issue was tracked down to a single printk statement in
> > ip_conntrack_pptp.c: line 244,245:
> >
> > DEBUGP("%s, CID=%X, PCID=%X\n", strMName[msg]
> >                      ntohs(*cid), ntohs(*pcid));
>
> What happens?  Does the kernel oops at this statement?

no opps but the PPTP session is not established.

I'll come back with a detailed debug log.


> > thanks for any input,
> > marian