[PATCH 0/1] Patch Description

[PATCH 0/1] Patch Description

[Yang Gu]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

I just got a new Option modem (iCON 452), and this patch is to enable several atoms for it.
The stk support is still not avaiable, for I couldn't find any appropriate manual for this part. If you happen to know this, please kindly share the info.

Yang Gu (1):
  Enable some atoms for hso modem

 plugins/hso.c |   34 ++++++++++++++++++++++++++++++++--
 1 files changed, 32 insertions(+), 2 deletions(-)

-- 
1.7.2.3

[PATCH 1/1] Enable some atoms for hso modem

[Yang Gu]

[-- Attachment #1: Type: text/plain, Size: 2945 bytes --]

---
 plugins/hso.c |   34 ++++++++++++++++++++++++++++++++--
 1 files changed, 32 insertions(+), 2 deletions(-)

diff --git a/plugins/hso.c b/plugins/hso.c
index 25ca157..1fbde58 100644
--- a/plugins/hso.c
+++ b/plugins/hso.c
@@ -34,14 +34,23 @@
 #define OFONO_API_SUBJECT_TO_CHANGE
 #include <ofono/plugin.h>
 #include <ofono/modem.h>
+#include <ofono/call-barring.h>
+#include <ofono/call-forwarding.h>
+#include <ofono/call-meter.h>
+#include <ofono/call-settings.h>
+#include <ofono/call-volume.h>
 #include <ofono/devinfo.h>
+#include <ofono/message-waiting.h>
 #include <ofono/netreg.h>
+#include <ofono/phonebook.h>
 #include <ofono/sim.h>
 #include <ofono/cbs.h>
 #include <ofono/sms.h>
+#include <ofono/ssn.h>
 #include <ofono/ussd.h>
 #include <ofono/gprs.h>
 #include <ofono/gprs-context.h>
+#include <ofono/voicecall.h>
 #include <ofono/radio-settings.h>
 #include <ofono/log.h>
 
@@ -257,24 +266,40 @@ static void hso_pre_sim(struct ofono_modem *modem)
 	ofono_devinfo_create(modem, 0, "atmodem", data->control);
 	sim = ofono_sim_create(modem, OFONO_VENDOR_OPTION_HSO,
 				"atmodem", data->control);
+	ofono_voicecall_create(modem, 0, "atmodem", data->app);
 
 	if (sim)
 		ofono_sim_inserted_notify(sim, TRUE);
 }
 
+
+static void hso_post_sim(struct ofono_modem *modem)
+{
+	struct hso_data *data = ofono_modem_get_data(modem);
+
+	DBG("%p", modem);
+
+	ofono_phonebook_create(modem, 0, "atmodem", data->app);
+}
+
 static void hso_post_online(struct ofono_modem *modem)
 {
 	struct hso_data *data = ofono_modem_get_data(modem);
+	struct ofono_message_waiting *mw;
 	struct ofono_gprs *gprs;
 	struct ofono_gprs_context *gc;
 
 	DBG("%p", modem);
 
+	ofono_call_forwarding_create(modem, 0, "atmodem", data->app);
+	ofono_call_settings_create(modem, 0, "atmodem", data->app);
 	ofono_netreg_create(modem, OFONO_VENDOR_OPTION_HSO,
 				"atmodem", data->app);
-
+	ofono_call_meter_create(modem, 0, "atmodem", data->app);
+	ofono_call_barring_create(modem, 0, "atmodem", data->app);
+	ofono_ssn_create(modem, 0, "atmodem", data->app);
+	ofono_call_volume_create(modem, 0, "atmodem", data->app);
 	ofono_radio_settings_create(modem, 0, "hsomodem", data->app);
-
 	ofono_sms_create(modem, OFONO_VENDOR_OPTION_HSO, "atmodem", data->app);
 	ofono_cbs_create(modem, OFONO_VENDOR_QUALCOMM_MSM,
 				"atmodem", data->app);
@@ -286,6 +311,10 @@ static void hso_post_online(struct ofono_modem *modem)
 
 	if (gprs && gc)
 		ofono_gprs_add_context(gprs, gc);
+
+	mw = ofono_message_waiting_create(modem);
+	if (mw)
+		ofono_message_waiting_register(mw);
 }
 
 static struct ofono_modem_driver hso_driver = {
@@ -296,6 +325,7 @@ static struct ofono_modem_driver hso_driver = {
 	.disable	= hso_disable,
 	.set_online     = hso_set_online,
 	.pre_sim	= hso_pre_sim,
+	.post_sim	= hso_post_sim,
 	.post_online	= hso_post_online,
 };
 
-- 
1.7.2.3

Re: [PATCH 1/1] Enable some atoms for hso modem

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 1957 bytes --]

Hi Yang,

>  plugins/hso.c |   34 ++++++++++++++++++++++++++++++++--
>  1 files changed, 32 insertions(+), 2 deletions(-)
> 
> diff --git a/plugins/hso.c b/plugins/hso.c
> index 25ca157..1fbde58 100644
> --- a/plugins/hso.c
> +++ b/plugins/hso.c
> @@ -34,14 +34,23 @@
>  #define OFONO_API_SUBJECT_TO_CHANGE
>  #include <ofono/plugin.h>
>  #include <ofono/modem.h>
> +#include <ofono/call-barring.h>
> +#include <ofono/call-forwarding.h>
> +#include <ofono/call-meter.h>
> +#include <ofono/call-settings.h>
> +#include <ofono/call-volume.h>
>  #include <ofono/devinfo.h>
> +#include <ofono/message-waiting.h>
>  #include <ofono/netreg.h>
> +#include <ofono/phonebook.h>
>  #include <ofono/sim.h>
>  #include <ofono/cbs.h>
>  #include <ofono/sms.h>
> +#include <ofono/ssn.h>
>  #include <ofono/ussd.h>
>  #include <ofono/gprs.h>
>  #include <ofono/gprs-context.h>
> +#include <ofono/voicecall.h>
>  #include <ofono/radio-settings.h>
>  #include <ofono/log.h>
>  
> @@ -257,24 +266,40 @@ static void hso_pre_sim(struct ofono_modem *modem)
>  	ofono_devinfo_create(modem, 0, "atmodem", data->control);
>  	sim = ofono_sim_create(modem, OFONO_VENDOR_OPTION_HSO,
>  				"atmodem", data->control);
> +	ofono_voicecall_create(modem, 0, "atmodem", data->app);
>  
>  	if (sim)
>  		ofono_sim_inserted_notify(sim, TRUE);
>  }
>  
> +
> +static void hso_post_sim(struct ofono_modem *modem)
> +{
> +	struct hso_data *data = ofono_modem_get_data(modem);
> +
> +	DBG("%p", modem);
> +
> +	ofono_phonebook_create(modem, 0, "atmodem", data->app);
> +}
> +

this part is fine with me.

However why should we enable any kind of voice call support for this
modem? It is a data dongle and until you tell me that the voice is
routed to the host PC via USB or some external microphone, it makes no
sense to enable these parts.

If they are data only dongle, I prefer to leave them like that.

Regards

Marcel

Re: [PATCH 1/1] Enable some atoms for hso modem

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 2063 bytes --]

Hi Yang,

> @@ -257,24 +266,40 @@ static void hso_pre_sim(struct ofono_modem *modem)
>  	ofono_devinfo_create(modem, 0, "atmodem", data->control);
>  	sim = ofono_sim_create(modem, OFONO_VENDOR_OPTION_HSO,
>  				"atmodem", data->control);
> +	ofono_voicecall_create(modem, 0, "atmodem", data->app);
>  

The Option hardware can never do audio, so enabling voice functionality
is not a good idea.

>  	if (sim)
>  		ofono_sim_inserted_notify(sim, TRUE);
>  }
>  
> +
> +static void hso_post_sim(struct ofono_modem *modem)
> +{
> +	struct hso_data *data = ofono_modem_get_data(modem);
> +
> +	DBG("%p", modem);
> +
> +	ofono_phonebook_create(modem, 0, "atmodem", data->app);
> +}
> +

This is OK

>  static void hso_post_online(struct ofono_modem *modem)
>  {
>  	struct hso_data *data = ofono_modem_get_data(modem);
> +	struct ofono_message_waiting *mw;
>  	struct ofono_gprs *gprs;
>  	struct ofono_gprs_context *gc;
>  
>  	DBG("%p", modem);
>  
> +	ofono_call_forwarding_create(modem, 0, "atmodem", data->app);
> +	ofono_call_settings_create(modem, 0, "atmodem", data->app);
>  	ofono_netreg_create(modem, OFONO_VENDOR_OPTION_HSO,
>  				"atmodem", data->app);
> -
> +	ofono_call_meter_create(modem, 0, "atmodem", data->app);
> +	ofono_call_barring_create(modem, 0, "atmodem", data->app);
> +	ofono_ssn_create(modem, 0, "atmodem", data->app);
> +	ofono_call_volume_create(modem, 0, "atmodem", data->app);
>  	ofono_radio_settings_create(modem, 0, "hsomodem", data->app);
> -
>  	ofono_sms_create(modem, OFONO_VENDOR_OPTION_HSO, "atmodem", data->app);
>  	ofono_cbs_create(modem, OFONO_VENDOR_QUALCOMM_MSM,
>  				"atmodem", data->app);
> @@ -286,6 +311,10 @@ static void hso_post_online(struct ofono_modem *modem)
>  
>  	if (gprs && gc)
>  		ofono_gprs_add_context(gprs, gc);
> +
> +	mw = ofono_message_waiting_create(modem);
> +	if (mw)
> +		ofono_message_waiting_register(mw);

Same thing here, since voicecalls are not enabled, all the call-*
related atoms are not needed.

Regards,
-Denis

RE: [PATCH 1/1] Enable some atoms for hso modem

[Gu, Yang]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi Denis and Marcel,

>> +
>> +static void hso_post_sim(struct ofono_modem *modem)
>> +{
>> +	struct hso_data *data = ofono_modem_get_data(modem);
>> +
>> +	DBG("%p", modem);
>> +
>> +	ofono_phonebook_create(modem, 0, "atmodem", data->app);
>> +}
>> +
>
>This is OK

So I will send the patch to enable phonebook only:)


Regards,
-Yang

[PATCH 0/1] Patch Description

[Yang Gu]

[-- Attachment #1: Type: text/plain, Size: 2196 bytes --]

Phonesim is most of time a convenient way to test oFono. For example, it can be used to test MO call, as well as MT call. 
And talking about test area, test automation is quite important regarding to both efficiency and effectiveness. In the test of MO call, scripts can be used to interact with oFono via D-Bus to make test automation possible. However, in the test of MT call, currently we have to enter the caller number and click some button in Phonesim GUI to simulate an incoming call, which makes test automation unrealistic.
This patch is to enable Qt script (JavaScript following ECMAScript spec) in Phonesim, so that we can have some script control its GUI conveniently, and satisfy the test automation.

With this patch, Phonesim can work in the following way:
1. It observes some specific directory (/tmp/scripts) to see if there is some test scripts added.
2. Once Phonesim finds a new test script is added, it will parse and execute the script.
3. You may add more and more test scripts to the specific directory with your test goes on.

Below are two examples:
# call.js (Simulate a MT call)
tabRegistration.gbIncomingCall.leCaller.text = "12345";
tabRegistration.gbIncomingCall.pbIncomingCall.click();

This script will help you enter the caller number as "12345", and click "Call" button in Phonesim GUI. Once this script is copied to the observed directory, oFono will get an incoming call.

# sms.js (Simulate a MT sms)
tabSMS.gbMessage1.leMessageSender.text = "Yang";
tabSMS.gbMessage1.leSMSClass.text = "1";
tabSMS.gbMessage1.teSMSText.setPlainText("This message is sent automatically from Phonesim");
tabSMS.gbMessage1.pbSendSMSMessage.click();

This script will help you fill the sms sender, class, text, and then click the "Send Message" button for you. Once it's added into the specific directory, oFono will get an incoming message.

Don't know if this is the best way to make Phonesim support test automation. So comments are welcome:)

-----
Yang Gu (1):
  Enable Qt Script

 configure.ac    |    2 +-
 src/control.cpp |   60 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 61 insertions(+), 1 deletions(-)

RE: [PATCH 0/1] Patch Description

[Zhang, Zhenhua]

[-- Attachment #1: Type: text/plain, Size: 2634 bytes --]

Hi,

Yang Gu wrote:
> Phonesim is most of time a convenient way to test oFono. For example,
> it can be used to test MO call, as well as MT call. 
> And talking about test area, test automation is quite important
> regarding to both efficiency and effectiveness. In the test of MO
> call, scripts can be used to interact with oFono via D-Bus to make
> test automation possible. However, in the test of MT call, currently
> we have to enter the caller number and click some button in Phonesim
> GUI to simulate an incoming call, which makes test automation
> unrealistic. This patch is to enable Qt script (JavaScript following
> ECMAScript spec) in Phonesim, so that we can have some script control
> its GUI conveniently, and satisfy the test automation.       
> 
> With this patch, Phonesim can work in the following way:
> 1. It observes some specific directory (/tmp/scripts) to see if there
> is some test scripts added. 
> 2. Once Phonesim finds a new test script is added, it will parse and
> execute the script. 
> 3. You may add more and more test scripts to the specific directory
> with your test goes on. 
> 
> Below are two examples:
> # call.js (Simulate a MT call)
> tabRegistration.gbIncomingCall.leCaller.text = "12345";
> tabRegistration.gbIncomingCall.pbIncomingCall.click();
> 
> This script will help you enter the caller number as "12345", and
> click "Call" button in Phonesim GUI. Once this script is copied to
> the observed directory, oFono will get an incoming call.  
> 
> # sms.js (Simulate a MT sms)
> tabSMS.gbMessage1.leMessageSender.text = "Yang";
> tabSMS.gbMessage1.leSMSClass.text = "1";
> tabSMS.gbMessage1.teSMSText.setPlainText("This message is sent
> automatically from Phonesim"); 
> tabSMS.gbMessage1.pbSendSMSMessage.click();
> 
> This script will help you fill the sms sender, class, text, and then
> click the "Send Message" button for you. Once it's added into the
> specific directory, oFono will get an incoming message.  
> 
> Don't know if this is the best way to make Phonesim support test
> automation. So comments are welcome:) 

It's awesome! I tried the patch and simply copy call.js to /tmp/scripts and it makes a call to oFono like a magic. ;-)

> -----
> Yang Gu (1):
>   Enable Qt Script
> 
>  configure.ac    |    2 +-
>  src/control.cpp |   60
>  +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files
> changed, 61 insertions(+), 1 deletions(-) 
> 
> _______________________________________________
> ofono mailing list
> ofono(a)ofono.org
> http://lists.ofono.org/listinfo/ofono

Regards,
Zhenhua

Re: [PATCH 0/1] Patch Description

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 1507 bytes --]

Hi Yang,

On 09/24/2010 10:49 AM, Yang Gu wrote:
> Phonesim is most of time a convenient way to test oFono. For example, it can be used to test MO call, as well as MT call. 
> And talking about test area, test automation is quite important regarding to both efficiency and effectiveness. In the test of MO call, scripts can be used to interact with oFono via D-Bus to make test automation possible. However, in the test of MT call, currently we have to enter the caller number and click some button in Phonesim GUI to simulate an incoming call, which makes test automation unrealistic.
> This patch is to enable Qt script (JavaScript following ECMAScript spec) in Phonesim, so that we can have some script control its GUI conveniently, and satisfy the test automation.
> 

I like this idea

> With this patch, Phonesim can work in the following way:
> 1. It observes some specific directory (/tmp/scripts) to see if there is some test scripts added.
> 2. Once Phonesim finds a new test script is added, it will parse and execute the script.
> 3. You may add more and more test scripts to the specific directory with your test goes on.
> 

However, using cp to run scripts seems a bit un-intuitive.  Perhaps a
simple D-Bus interface which can run the scripts would be better?

E.g. something like

org.ofono.Phonesim:

string Run(string script)

where the script contains the script to run and the return value might
return whatever is printed from the script.

Regards,
-Denis

[PATCH 0/1] Patch Description

[Yang Gu]

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

Sometimes we need to know the version of phonesim via a command. This patch is to add this support. 

By the way, oFono introduces a file named version.h.in for the macro OFONO_VERSION. Can we use VERSION directly so that this file can be removed?

Yang Gu (1):
  Add option to support version

 Makefile.am  |    2 +-
 bootstrap    |    2 +-
 configure.ac |    1 +
 src/main.cpp |   11 +++++++++--
 4 files changed, 12 insertions(+), 4 deletions(-)

-- 
1.7.2.3

[PATCH 0/1] Patch Description

[Yang Gu]

[-- Attachment #1: Type: text/plain, Size: 999 bytes --]

This patch is to cancel the pending sms via D-Bus. Till now, I'm still not sure what kind of sms should be cancelled. In theory, one message, or part of it, would be sent by oFono can be cancelled. For some examples: Any part of a message that has never been sent can be cancelled; one message was sent but failed, we can cancel before retry; One message is split into several pieces, we can cancel before all of them are sent. 
In current patch, I only cancel the sms that has never been sent. I wonder if it's enough or I should handle all the situations above. 

Another question here is about the existed code. There is a hashtable "messages" in struct ofono_sms. Can we store the state in the tx_queue_entry, and remove the hashtable thoroughly to make the code more simple?

Yang Gu (1):
  sms: Cancel pending message

 include/history.h |    1 +
 src/sms.c         |  132 ++++++++++++++++++++++++++++++++++++++++++-----------
 2 files changed, 106 insertions(+), 27 deletions(-)