public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Schmidl, Tobias" <tobiasschmidl@siemens.com>
To: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>,
	"Vijaikumar_Kanagarajan@mentor.com"
	<Vijaikumar_Kanagarajan@mentor.com>
Cc: "ch@denx.de" <ch@denx.de>,
	"Schild, Henning" <henning.schild@siemens.com>
Subject: Re: [PATCH v2] wic: added fspassno parameter to partition
Date: Tue, 17 May 2022 18:16:18 +0000	[thread overview]
Message-ID: <09076afadfa0c49f65ea4d2d113fb9c6490f49ea.camel@siemens.com> (raw)
In-Reply-To: <20220515063600.777146-1-Vijaikumar_Kanagarajan@mentor.com>

Hi all,

On Sun, May 15, 2022 at 08:36 AM, Kanagarajan, Vijaikumar wrote:
>
> From: Claudius Heine <ch@denx.de>
> 
> The `fspassno` parameter allows to overwrite the value of the last
> column (`fs_passno`) in the /etc/fstab of the target root file system.
> This allows to have periodic file system checks.
> 

I've found this to be ineffective for `/`, as the fstab update is
explicitly omitted in `scripts/lib/wic/plugins/imager/direct.py:120`:

```
for part in self.parts:
    if not part.realnum or not part.mountpoint \
       or part.mountpoint == "/" or not part.mountpoint.startswith('/'):
       ^^^^^^^^^^^^^^^^^^^^^^^^^
        continue
```

I've created a patch, originally for different reasons, that will also
address this issue.

Kind regards,

Tobias


  reply	other threads:[~2022-05-17 18:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06  9:07 [RESEND for ML] wic: imager/direct: passno is set to 0 for all entries in the fstab Claudius Heine
2020-11-06 10:02 ` Richard Purdie
2020-11-06 10:27   ` [PATCH] wic: added fspassno parameter to partition Claudius Heine
2022-05-13 14:40     ` Henning Schild
2022-05-15  6:36       ` [PATCH v2] " Vijai Kumar K
2022-05-17 18:16         ` Schmidl, Tobias [this message]
2022-05-17 18:21           ` Kanagarajan, Vijaikumar
2022-05-17 18:31             ` Henning Schild
2022-05-15  6:40       ` [PATCH] " Kanagarajan, Vijaikumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09076afadfa0c49f65ea4d2d113fb9c6490f49ea.camel@siemens.com \
    --to=tobiasschmidl@siemens.com \
    --cc=Vijaikumar_Kanagarajan@mentor.com \
    --cc=ch@denx.de \
    --cc=henning.schild@siemens.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox