RE: [PATCH v2] wic: added fspassno parameter to partition

["Kanagarajan, Vijaikumar" <Vijaikumar_Kanagarajan@mentor.com>]

> -----Original Message-----
> From: Schmidl, Tobias (T CED SES-DE) <tobiasschmidl@siemens.com>
> Sent: 17 May 2022 23:46
> To: openembedded-core@lists.openembedded.org; Kanagarajan,
> Vijaikumar <Vijaikumar_Kanagarajan@mentor.com>
> Cc: ch@denx.de; Schild, Henning (T CED SES-DE)
> <henning.schild@siemens.com>
> Subject: Re: [PATCH v2] wic: added fspassno parameter to partition
> 
Hi Tobias,

> Hi all,
> 
> On Sun, May 15, 2022 at 08:36 AM, Kanagarajan, Vijaikumar wrote:
> >
> > From: Claudius Heine <ch@denx.de>
> >
> > The `fspassno` parameter allows to overwrite the value of the last
> > column (`fs_passno`) in the /etc/fstab of the target root file system.
> > This allows to have periodic file system checks.
> >
> 
> I've found this to be ineffective for `/`, as the fstab update is explicitly
> omitted in `scripts/lib/wic/plugins/imager/direct.py:120`:

I believe wic has changed much since the first appearance of this patch.

> 
> ```
> for part in self.parts:
>     if not part.realnum or not part.mountpoint \
>        or part.mountpoint == "/" or not part.mountpoint.startswith('/'):
>        ^^^^^^^^^^^^^^^^^^^^^^^^^
>         continue
> ```
> 
> I've created a patch, originally for different reasons, that will also address this
> issue.

If you can send that, we can drop this patch in favour of it.

Thanks,
Vijai Kumar K

> 
> Kind regards,
> 
> Tobias