public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Claudius Heine" <ch@denx.de>
To: openembedded-core@lists.openembedded.org,
	Henning Schild <henning.schild@siemens.com>,
	Tom Zanussi <tom.zanussi@linux.intel.com>,
	Richard Purdie <richard.purdie@linuxfoundation.org>
Subject: [RESEND for ML] wic: imager/direct: passno is set to 0 for all entries in the fstab
Date: Fri, 6 Nov 2020 10:07:55 +0100	[thread overview]
Message-ID: <d99177cb-0258-dc14-6f39-8b00e2b64415@denx.de> (raw)

Hi,

I looked into periodic file system checks for ext* partitions, in order 
to increase robustness for systems that use those file systems and was 
surprised that the fstab that wic generates that `0` hard coded as the 
passno parameter [1]. This prevents for instance systemd-fsck@(8) [2] 
from running checks on those file systems.

It seems that wic/mic generated a fstab with passno=0 from the beginning 
[3]. What is the reason for that? Was it a conscious decision to do 
that, or just copy&paste for a different project?

How would a way forward look like? Should a patch that changes passno 
from 0 to 2 be enough, or do we rather have this parameter configurable 
somehow?

regards,
Claudius Heine

[1] 
https://git.openembedded.org/openembedded-core/tree/scripts/lib/wic/plugins/imager/direct.py?id=a59c246be05ca284fa27df87b5db09a70f527cc2#n141
[2] 
https://manpages.debian.org/stretch/systemd/systemd-fsck@.service.8.en.html
[3] 
https://git.openembedded.org/openembedded-core/tree/scripts/lib/mic/imager/direct.py?id=f87acc5e59d3c2c39ff171b5557977dab4c8f4a6#n110

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

            PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
                              Keyserver: hkp://pool.sks-keyservers.net

             reply	other threads:[~2020-11-06  9:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06  9:07 Claudius Heine [this message]
2020-11-06 10:02 ` [RESEND for ML] wic: imager/direct: passno is set to 0 for all entries in the fstab Richard Purdie
2020-11-06 10:27   ` [PATCH] wic: added fspassno parameter to partition Claudius Heine
2022-05-13 14:40     ` Henning Schild
2022-05-15  6:36       ` [PATCH v2] " Vijai Kumar K
2022-05-17 18:16         ` Schmidl, Tobias
2022-05-17 18:21           ` Kanagarajan, Vijaikumar
2022-05-17 18:31             ` Henning Schild
2022-05-15  6:40       ` [PATCH] " Kanagarajan, Vijaikumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d99177cb-0258-dc14-6f39-8b00e2b64415@denx.de \
    --to=ch@denx.de \
    --cc=henning.schild@siemens.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=tom.zanussi@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox