* [PATCH V2 0/6] Fixes to get oe-core building
@ 2011-03-03 6:52 Khem Raj
2011-03-03 6:52 ` [PATCHv3 1/6] sqlite3: Update version 3.7.3 -> 3.7.5 Khem Raj
` (5 more replies)
0 siblings, 6 replies; 28+ messages in thread
From: Khem Raj @ 2011-03-03 6:52 UTC (permalink / raw)
To: openembedded-core
Hi
The attached patches are needed to get the OE core to build
Please provide feedback I have already incorporated the changes
requested thus far.
V2: Fix the sanity test case to check for new limit
Add patch to link gcc cross statically with prerequisite libs
Remove do_compile_prepend from sqlite3 upgrade
v3: Drop spurious dependency on ncurses-native for sqlite3 recipe
Check if /proc/sys/vm/mmap_min_addr is readable
Fix rpm-native build issue encountered on ubuntu natty
LINUXLIBCVERSION bump to 2.6.37.2
Thanks
-Khem
^ permalink raw reply [flat|nested] 28+ messages in thread* [PATCHv3 1/6] sqlite3: Update version 3.7.3 -> 3.7.5 2011-03-03 6:52 [PATCH V2 0/6] Fixes to get oe-core building Khem Raj @ 2011-03-03 6:52 ` Khem Raj 2011-03-03 6:52 ` [PATCHv3 2/6] distro_tracking_fields.inc: Use 2.6.37.2 instead of 2.6.36 for linux-libc-headers Khem Raj ` (4 subsequent siblings) 5 siblings, 0 replies; 28+ messages in thread From: Khem Raj @ 2011-03-03 6:52 UTC (permalink / raw) To: openembedded-core * Imported from OE commit a2c3af2d608b1b713018d688b00e03873a538993 * native version of 3.7.3 does not build Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/recipes-support/sqlite/sqlite3_3.7.3.bb | 8 -------- meta/recipes-support/sqlite/sqlite3_3.7.5.bb | 10 ++++++++++ 2 files changed, 10 insertions(+), 8 deletions(-) delete mode 100644 meta/recipes-support/sqlite/sqlite3_3.7.3.bb create mode 100644 meta/recipes-support/sqlite/sqlite3_3.7.5.bb diff --git a/meta/recipes-support/sqlite/sqlite3_3.7.3.bb b/meta/recipes-support/sqlite/sqlite3_3.7.3.bb deleted file mode 100644 index 7296aba..0000000 --- a/meta/recipes-support/sqlite/sqlite3_3.7.3.bb +++ /dev/null @@ -1,8 +0,0 @@ -require sqlite3.inc - -LIC_FILES_CHKSUM = "file://src/main.c;endline=16;md5=86c9b824e9d68f8a26343a4b57f6d85a" - -PR = "r1" - -SRC_URI[md5sum] = "5437978aae90350cf984993091e0d695" -SRC_URI[sha256sum] = "dbf352e8fbb74829f5e7a88f9f6ceeb80a709537f668c36e4b6cdfb271309ef6" diff --git a/meta/recipes-support/sqlite/sqlite3_3.7.5.bb b/meta/recipes-support/sqlite/sqlite3_3.7.5.bb new file mode 100644 index 0000000..212d9e2 --- /dev/null +++ b/meta/recipes-support/sqlite/sqlite3_3.7.5.bb @@ -0,0 +1,10 @@ +require sqlite3.inc + +LIC_FILES_CHKSUM = "file://sqlite3.c;endline=19;md5=c1b8048b783961c3ba387c43fd955dc6" + +SRC_URI = "http://www.sqlite.org/sqlite-autoconf-3070500.tar.gz" +S = "${WORKDIR}/sqlite-autoconf-3070500" +PR = "r0" + +SRC_URI[md5sum] = "a9604a82613ade2e7f4c303f233e477f" +SRC_URI[sha256sum] = "cb5b86926ec9f65882b2dddd244f2d620337d911ec73411863f77e48cf6a2f94" -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCHv3 2/6] distro_tracking_fields.inc: Use 2.6.37.2 instead of 2.6.36 for linux-libc-headers 2011-03-03 6:52 [PATCH V2 0/6] Fixes to get oe-core building Khem Raj 2011-03-03 6:52 ` [PATCHv3 1/6] sqlite3: Update version 3.7.3 -> 3.7.5 Khem Raj @ 2011-03-03 6:52 ` Khem Raj 2011-03-08 6:39 ` Khem Raj 2011-03-03 6:52 ` [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc Khem Raj ` (3 subsequent siblings) 5 siblings, 1 reply; 28+ messages in thread From: Khem Raj @ 2011-03-03 6:52 UTC (permalink / raw) To: openembedded-core Signed-off-by: Khem Raj <raj.khem@gmail.com> --- .../conf/distro/include/distro_tracking_fields.inc | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/conf/distro/include/distro_tracking_fields.inc b/meta/conf/distro/include/distro_tracking_fields.inc index 1dab90a..beb18e2 100644 --- a/meta/conf/distro/include/distro_tracking_fields.inc +++ b/meta/conf/distro/include/distro_tracking_fields.inc @@ -2884,9 +2884,9 @@ RECIPE_LAST_UPDATE_pn-libtool = "Nov 8, 2010" RECIPE_MAINTAINER_pn-libtool = "Nitin A Kamble <nitin.a.kamble@intel.com>" RECIPE_STATUS_pn-linux-libc-headers="green" -RECIPE_LATEST_VERSION_pn-linux-libc-headers="2.6.36" -RECIPE_LAST_UPDATE_pn-linux-libc-headers = "Nov 8, 2010" -RECIPE_MAINTAINER_pn-linux-libc-headers = "Nitin A Kamble <nitin.a.kamble@intel.com>" +RECIPE_LATEST_VERSION_pn-linux-libc-headers="2.6.37.2" +RECIPE_LAST_UPDATE_pn-linux-libc-headers = "Mar 1, 2011" +RECIPE_MAINTAINER_pn-linux-libc-headers = "Khem Raj <raj.khem@gmail.com>" RECIPE_STATUS_pn-lsof="green" RECIPE_LATEST_VERSION_pn-lsof="4.84" -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCHv3 2/6] distro_tracking_fields.inc: Use 2.6.37.2 instead of 2.6.36 for linux-libc-headers 2011-03-03 6:52 ` [PATCHv3 2/6] distro_tracking_fields.inc: Use 2.6.37.2 instead of 2.6.36 for linux-libc-headers Khem Raj @ 2011-03-08 6:39 ` Khem Raj 2011-03-08 18:51 ` Richard Purdie 0 siblings, 1 reply; 28+ messages in thread From: Khem Raj @ 2011-03-08 6:39 UTC (permalink / raw) To: openembedded-core ping On Wed, Mar 2, 2011 at 10:52 PM, Khem Raj <raj.khem@gmail.com> wrote: > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > .../conf/distro/include/distro_tracking_fields.inc | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meta/conf/distro/include/distro_tracking_fields.inc b/meta/conf/distro/include/distro_tracking_fields.inc > index 1dab90a..beb18e2 100644 > --- a/meta/conf/distro/include/distro_tracking_fields.inc > +++ b/meta/conf/distro/include/distro_tracking_fields.inc > @@ -2884,9 +2884,9 @@ RECIPE_LAST_UPDATE_pn-libtool = "Nov 8, 2010" > RECIPE_MAINTAINER_pn-libtool = "Nitin A Kamble <nitin.a.kamble@intel.com>" > > RECIPE_STATUS_pn-linux-libc-headers="green" > -RECIPE_LATEST_VERSION_pn-linux-libc-headers="2.6.36" > -RECIPE_LAST_UPDATE_pn-linux-libc-headers = "Nov 8, 2010" > -RECIPE_MAINTAINER_pn-linux-libc-headers = "Nitin A Kamble <nitin.a.kamble@intel.com>" > +RECIPE_LATEST_VERSION_pn-linux-libc-headers="2.6.37.2" > +RECIPE_LAST_UPDATE_pn-linux-libc-headers = "Mar 1, 2011" > +RECIPE_MAINTAINER_pn-linux-libc-headers = "Khem Raj <raj.khem@gmail.com>" > > RECIPE_STATUS_pn-lsof="green" > RECIPE_LATEST_VERSION_pn-lsof="4.84" > -- > 1.7.4.1 > > ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 2/6] distro_tracking_fields.inc: Use 2.6.37.2 instead of 2.6.36 for linux-libc-headers 2011-03-08 6:39 ` Khem Raj @ 2011-03-08 18:51 ` Richard Purdie 0 siblings, 0 replies; 28+ messages in thread From: Richard Purdie @ 2011-03-08 18:51 UTC (permalink / raw) To: Patches and discussions about the oe-core layer; +Cc: saul.wold On Mon, 2011-03-07 at 22:39 -0800, Khem Raj wrote: > On Wed, Mar 2, 2011 at 10:52 PM, Khem Raj <raj.khem@gmail.com> wrote: > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > --- > > .../conf/distro/include/distro_tracking_fields.inc | 6 +++--- > > 1 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/meta/conf/distro/include/distro_tracking_fields.inc b/meta/conf/distro/include/distro_tracking_fields.inc > > index 1dab90a..beb18e2 100644 > > --- a/meta/conf/distro/include/distro_tracking_fields.inc > > +++ b/meta/conf/distro/include/distro_tracking_fields.inc > > @@ -2884,9 +2884,9 @@ RECIPE_LAST_UPDATE_pn-libtool = "Nov 8, 2010" > > RECIPE_MAINTAINER_pn-libtool = "Nitin A Kamble <nitin.a.kamble@intel.com>" > > > > RECIPE_STATUS_pn-linux-libc-headers="green" > > -RECIPE_LATEST_VERSION_pn-linux-libc-headers="2.6.36" > > -RECIPE_LAST_UPDATE_pn-linux-libc-headers = "Nov 8, 2010" > > -RECIPE_MAINTAINER_pn-linux-libc-headers = "Nitin A Kamble <nitin.a.kamble@intel.com>" > > +RECIPE_LATEST_VERSION_pn-linux-libc-headers="2.6.37.2" > > +RECIPE_LAST_UPDATE_pn-linux-libc-headers = "Mar 1, 2011" > > +RECIPE_MAINTAINER_pn-linux-libc-headers = "Khem Raj <raj.khem@gmail.com>" > > > > RECIPE_STATUS_pn-lsof="green" > > RECIPE_LATEST_VERSION_pn-lsof="4.84" > > -- > > 1.7.4.1 With this patch, I need to work out who "owns" these tracking fields going forwards and what the policy is regarding them. I'd like some input from Saul on this although it might not happen until next week as we're both travelling. Cheers, Richard ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc. 2011-03-03 6:52 [PATCH V2 0/6] Fixes to get oe-core building Khem Raj 2011-03-03 6:52 ` [PATCHv3 1/6] sqlite3: Update version 3.7.3 -> 3.7.5 Khem Raj 2011-03-03 6:52 ` [PATCHv3 2/6] distro_tracking_fields.inc: Use 2.6.37.2 instead of 2.6.36 for linux-libc-headers Khem Raj @ 2011-03-03 6:52 ` Khem Raj 2011-03-08 6:38 ` Khem Raj 2011-03-03 6:52 ` [PATCHv3 4/6] sanity.bbclass: Check for /proc/sys/vm/mmap_min_addr to be >= 65536 Khem Raj ` (2 subsequent siblings) 5 siblings, 1 reply; 28+ messages in thread From: Khem Raj @ 2011-03-03 6:52 UTC (permalink / raw) To: openembedded-core * This is helpful to get consistent behaviour with gcc on different hosts and linking the libraries in for cross gcc recipes should not be increasing the binary size alarmingly Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/recipes-devtools/gcc/gcc-configure-common.inc | 7 +++++++ meta/recipes-devtools/gcc/gcc-configure-cross.inc | 10 ++++++++++ meta/recipes-devtools/gcc/gcc-configure-sdk.inc | 8 ++++++++ .../gcc/gcc-cross-canadian_4.3.3.bb | 2 +- .../gcc/gcc-cross-canadian_4.5.1.bb | 2 +- .../gcc/gcc-cross-initial_4.3.3.bb | 2 +- .../gcc/gcc-cross-initial_4.5.1.bb | 2 +- .../gcc/gcc-cross-intermediate_4.3.3.bb | 2 +- .../gcc/gcc-cross-intermediate_4.5.1.bb | 2 +- .../gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb | 2 +- meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb | 2 +- meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb | 2 +- .../gcc/gcc-cross_csl-arm-2008q1.bb | 2 +- .../gcc/gcc-crosssdk-initial_4.3.3.bb | 2 +- .../gcc/gcc-crosssdk-initial_4.5.1.bb | 2 +- .../gcc/gcc-crosssdk-intermediate_4.3.3.bb | 2 +- .../gcc/gcc-crosssdk-intermediate_4.5.1.bb | 2 +- meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb | 2 +- meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb | 2 +- meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +- meta/recipes-devtools/gcc/gcc_4.3.3.bb | 2 +- meta/recipes-devtools/gcc/gcc_4.5.1.bb | 2 +- meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb | 2 +- meta/recipes-devtools/gcc/libgcc_4.5.1.bb | 2 +- 24 files changed, 46 insertions(+), 21 deletions(-) diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc b/meta/recipes-devtools/gcc/gcc-configure-common.inc index 4393777..cdb69fb 100644 --- a/meta/recipes-devtools/gcc/gcc-configure-common.inc +++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc @@ -85,6 +85,11 @@ do_configure () { export CXXFLAGS_FOR_BUILD="${BUILD_CXXFLAGS}" export LDFLAGS_FOR_BUILD="${BUILD_LDFLAGS}" export ARCH_FLAGS_FOR_TARGET="${ARCH_FLAGS_FOR_TARGET}" + + # Make sure LDFLAGS are honored. + sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.in + sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.tpl + (cd ${S} && gnu-configize) || die "failure running gnu-configize" # teach gcc to find correct target includedir when checking libc ssp support @@ -108,5 +113,7 @@ do_configure () { echo "#endif /* ! GCC_DEFAULTS_H */" >> ${S}/gcc/defaults.h.new mv ${S}/gcc/defaults.h.new ${S}/gcc/defaults.h oe_runconf + # make sure that no @LDFLAG@ is left in the generated Makefile + sed -i "s/@LDFLAGS@//g" ${B}/Makefile } diff --git a/meta/recipes-devtools/gcc/gcc-configure-cross.inc b/meta/recipes-devtools/gcc/gcc-configure-cross.inc index 346d164..200cbe2 100644 --- a/meta/recipes-devtools/gcc/gcc-configure-cross.inc +++ b/meta/recipes-devtools/gcc/gcc-configure-cross.inc @@ -16,6 +16,16 @@ do_compile_prepend () { export LD_FOR_TARGET="${TARGET_SYS}-ld" export NM_FOR_TARGET="${TARGET_SYS}-nm" export CC_FOR_TARGET="${CCACHE} ${TARGET_SYS}-gcc ${TARGET_CC_ARCH}" + export OBJDUMP_FOR_TARGET="${TARGET_SYS}-objdump" + export OBJCOPY_FOR_TARGET="${TARGET_SYS}-objcopy" + export STRIP_FOR_TARGET="${TARGET_SYS}-strip" + # Make sure we use GMP/MPFR statically + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in } LIBGCCS_VAR = "-lgcc_s" diff --git a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc index 756e74e..3eb8992 100644 --- a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc +++ b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc @@ -39,6 +39,14 @@ do_configure () { export CPPFLAGS_FOR_BUILD="${BUILD_CPPFLAGS}" export CXXFLAGS_FOR_BUILD="${BUILD_CXXFLAGS}" export LDFLAGS_FOR_BUILD="${BUILD_LDFLAGS}" + export CC_FOR_TARGET="${CCACHE} ${TARGET_SYS}-gcc ${TARGET_CC_ARCH}" + # Make sure we use GMP/MPFR statically + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in (cd ${S} && gnu-configize) || die "failure running gnu-configize" oe_runconf } diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb index d420f80..8bf07d7 100644 --- a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb +++ b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb @@ -5,7 +5,7 @@ require gcc-cross-canadian.inc require gcc-configure-sdk.inc require gcc-package-sdk.inc -PR = "r20" +PR = "r21" DEPENDS += "gmp-nativesdk mpfr-nativesdk" RDEPENDS_${PN} += "mpfr-nativesdk" diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb index 3eea4bc..92708d4 100644 --- a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb +++ b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb @@ -5,7 +5,7 @@ require gcc-cross-canadian.inc require gcc-configure-sdk.inc require gcc-package-sdk.inc -PR = "r3" +PR = "r4" DEPENDS += "gmp-nativesdk mpfr-nativesdk libmpc-nativesdk elfutils-nativesdk" RDEPENDS_${PN} += "mpfr-nativesdk libmpc-nativesdk elfutils-nativesdk" diff --git a/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb index 28ac1ab..ef52845 100644 --- a/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb +++ b/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb @@ -1,5 +1,5 @@ require gcc-cross_${PV}.bb require gcc-cross-initial.inc -PR = "r5" +PR = "r6" diff --git a/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb index b2c257d..38e0964 100644 --- a/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb +++ b/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb @@ -1,5 +1,5 @@ require gcc-cross_${PV}.bb require gcc-cross-initial.inc -PR = "r2" +PR = "r3" diff --git a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb index a8473b0..deeee37 100644 --- a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb +++ b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb @@ -1,4 +1,4 @@ require gcc-cross_${PV}.bb require gcc-cross-intermediate.inc -PR = "r5" +PR = "r6" diff --git a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb index e65d5df..9a30cb5 100644 --- a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb +++ b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb @@ -1,4 +1,4 @@ require gcc-cross_${PV}.bb require gcc-cross-intermediate.inc -PR = "r3" +PR = "r4" diff --git a/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb b/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb index 88e3842..462104f 100644 --- a/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb +++ b/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb @@ -9,7 +9,7 @@ require gcc-cross-kernel.inc DEFAULT_PREFERENCE = "-1" -PR = "r4" +PR = "r5" SRC_URI += "file://gcc-3.4.4-makefile-fix.patch;patch=1" diff --git a/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb index 5eaac5f..1a982f5 100644 --- a/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb +++ b/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb @@ -1,4 +1,4 @@ -PR = "r17" +PR = "r18" require gcc-${PV}.inc require gcc-cross4.inc diff --git a/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb index 399cdf9..78bb05a 100644 --- a/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb +++ b/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb @@ -1,4 +1,4 @@ -PR = "r2" +PR = "r3" require gcc-${PV}.inc require gcc-cross4.inc diff --git a/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb b/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb index 89534f1..0e7a1ee 100644 --- a/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb +++ b/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb @@ -1,4 +1,4 @@ -PR = "r5" +PR = "r6" require gcc-csl-arm-2008q1.inc require gcc-cross4.inc diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb index b42de47..d3ddcb1 100644 --- a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb @@ -1,3 +1,3 @@ require gcc-cross-initial_${PV}.bb require gcc-crosssdk-initial.inc -PR = "r6" +PR = "r7" diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb index 240caf5..fec53b9 100644 --- a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb @@ -1,4 +1,4 @@ require gcc-cross-initial_${PV}.bb require gcc-crosssdk-initial.inc -PR = "r2" +PR = "r3" diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb index cd1f966..2be05f1 100644 --- a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb @@ -1,3 +1,3 @@ require gcc-cross-intermediate_${PV}.bb require gcc-crosssdk-intermediate.inc -PR = "r8" +PR = "r9" diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb index a6653dd..161d870 100644 --- a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb @@ -1,4 +1,4 @@ require gcc-cross-intermediate_${PV}.bb require gcc-crosssdk-intermediate.inc -PR = "r2" +PR = "r3" diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb index 129e8d3..7069088 100644 --- a/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb +++ b/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb @@ -1,4 +1,4 @@ require gcc-cross_${PV}.bb require gcc-crosssdk.inc -PR = "r2" +PR = "r3" diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb index 99f927a..2f5cfb5 100644 --- a/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb @@ -1,4 +1,4 @@ -PR = "r18" +PR = "r19" require gcc-${PV}.inc require gcc-configure-runtime.inc diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb index 093f9bf..c1e680d 100644 --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb @@ -1,4 +1,4 @@ -PR = "r2" +PR = "r3" require gcc-${PV}.inc require gcc-configure-runtime.inc diff --git a/meta/recipes-devtools/gcc/gcc_4.3.3.bb b/meta/recipes-devtools/gcc/gcc_4.3.3.bb index f0471d4..ba6e7b2 100644 --- a/meta/recipes-devtools/gcc/gcc_4.3.3.bb +++ b/meta/recipes-devtools/gcc/gcc_4.3.3.bb @@ -1,4 +1,4 @@ -PR = "r11" +PR = "r12" require gcc-${PV}.inc require gcc-configure-target.inc diff --git a/meta/recipes-devtools/gcc/gcc_4.5.1.bb b/meta/recipes-devtools/gcc/gcc_4.5.1.bb index 919d4b0..25e455c 100644 --- a/meta/recipes-devtools/gcc/gcc_4.5.1.bb +++ b/meta/recipes-devtools/gcc/gcc_4.5.1.bb @@ -1,4 +1,4 @@ -PR = "r2" +PR = "r3" require gcc-${PV}.inc require gcc-configure-target.inc require gcc-package-target.inc diff --git a/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb b/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb index cc7540a..2df12ef 100644 --- a/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb +++ b/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb @@ -1,4 +1,4 @@ -PR = "r3" +PR = "r4" require gcc-${PV}.inc require gcc-configure-target.inc diff --git a/meta/recipes-devtools/gcc/libgcc_4.5.1.bb b/meta/recipes-devtools/gcc/libgcc_4.5.1.bb index b6cf268..3f7ce0a 100644 --- a/meta/recipes-devtools/gcc/libgcc_4.5.1.bb +++ b/meta/recipes-devtools/gcc/libgcc_4.5.1.bb @@ -1,6 +1,6 @@ require gcc-${PV}.inc -PR = "r0" +PR = "r1" INHIBIT_DEFAULT_DEPS = "1" DEPENDS = "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}g++" -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc. 2011-03-03 6:52 ` [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc Khem Raj @ 2011-03-08 6:38 ` Khem Raj 2011-03-08 18:53 ` Richard Purdie 0 siblings, 1 reply; 28+ messages in thread From: Khem Raj @ 2011-03-08 6:38 UTC (permalink / raw) To: openembedded-core ping any opinion on this patch ? On Wed, Mar 2, 2011 at 10:52 PM, Khem Raj <raj.khem@gmail.com> wrote: > * This is helpful to get consistent behaviour with gcc on different > hosts and linking the libraries in for cross gcc recipes should not > be increasing the binary size alarmingly > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/recipes-devtools/gcc/gcc-configure-common.inc | 7 +++++++ > meta/recipes-devtools/gcc/gcc-configure-cross.inc | 10 ++++++++++ > meta/recipes-devtools/gcc/gcc-configure-sdk.inc | 8 ++++++++ > .../gcc/gcc-cross-canadian_4.3.3.bb | 2 +- > .../gcc/gcc-cross-canadian_4.5.1.bb | 2 +- > .../gcc/gcc-cross-initial_4.3.3.bb | 2 +- > .../gcc/gcc-cross-initial_4.5.1.bb | 2 +- > .../gcc/gcc-cross-intermediate_4.3.3.bb | 2 +- > .../gcc/gcc-cross-intermediate_4.5.1.bb | 2 +- > .../gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb | 2 +- > meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb | 2 +- > meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb | 2 +- > .../gcc/gcc-cross_csl-arm-2008q1.bb | 2 +- > .../gcc/gcc-crosssdk-initial_4.3.3.bb | 2 +- > .../gcc/gcc-crosssdk-initial_4.5.1.bb | 2 +- > .../gcc/gcc-crosssdk-intermediate_4.3.3.bb | 2 +- > .../gcc/gcc-crosssdk-intermediate_4.5.1.bb | 2 +- > meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb | 2 +- > meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb | 2 +- > meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +- > meta/recipes-devtools/gcc/gcc_4.3.3.bb | 2 +- > meta/recipes-devtools/gcc/gcc_4.5.1.bb | 2 +- > meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb | 2 +- > meta/recipes-devtools/gcc/libgcc_4.5.1.bb | 2 +- > 24 files changed, 46 insertions(+), 21 deletions(-) > > diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc b/meta/recipes-devtools/gcc/gcc-configure-common.inc > index 4393777..cdb69fb 100644 > --- a/meta/recipes-devtools/gcc/gcc-configure-common.inc > +++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc > @@ -85,6 +85,11 @@ do_configure () { > export CXXFLAGS_FOR_BUILD="${BUILD_CXXFLAGS}" > export LDFLAGS_FOR_BUILD="${BUILD_LDFLAGS}" > export ARCH_FLAGS_FOR_TARGET="${ARCH_FLAGS_FOR_TARGET}" > + > + # Make sure LDFLAGS are honored. > + sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.in > + sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.tpl > + > (cd ${S} && gnu-configize) || die "failure running gnu-configize" > > # teach gcc to find correct target includedir when checking libc ssp support > @@ -108,5 +113,7 @@ do_configure () { > echo "#endif /* ! GCC_DEFAULTS_H */" >> ${S}/gcc/defaults.h.new > mv ${S}/gcc/defaults.h.new ${S}/gcc/defaults.h > oe_runconf > + # make sure that no @LDFLAG@ is left in the generated Makefile > + sed -i "s/@LDFLAGS@//g" ${B}/Makefile > } > > diff --git a/meta/recipes-devtools/gcc/gcc-configure-cross.inc b/meta/recipes-devtools/gcc/gcc-configure-cross.inc > index 346d164..200cbe2 100644 > --- a/meta/recipes-devtools/gcc/gcc-configure-cross.inc > +++ b/meta/recipes-devtools/gcc/gcc-configure-cross.inc > @@ -16,6 +16,16 @@ do_compile_prepend () { > export LD_FOR_TARGET="${TARGET_SYS}-ld" > export NM_FOR_TARGET="${TARGET_SYS}-nm" > export CC_FOR_TARGET="${CCACHE} ${TARGET_SYS}-gcc ${TARGET_CC_ARCH}" > + export OBJDUMP_FOR_TARGET="${TARGET_SYS}-objdump" > + export OBJCOPY_FOR_TARGET="${TARGET_SYS}-objcopy" > + export STRIP_FOR_TARGET="${TARGET_SYS}-strip" > + # Make sure we use GMP/MPFR statically > + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl > + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in > + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl > + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in > + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl > + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in > } > > LIBGCCS_VAR = "-lgcc_s" > diff --git a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc > index 756e74e..3eb8992 100644 > --- a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc > +++ b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc > @@ -39,6 +39,14 @@ do_configure () { > export CPPFLAGS_FOR_BUILD="${BUILD_CPPFLAGS}" > export CXXFLAGS_FOR_BUILD="${BUILD_CXXFLAGS}" > export LDFLAGS_FOR_BUILD="${BUILD_LDFLAGS}" > + export CC_FOR_TARGET="${CCACHE} ${TARGET_SYS}-gcc ${TARGET_CC_ARCH}" > + # Make sure we use GMP/MPFR statically > + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl > + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in > + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl > + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in > + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl > + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in > (cd ${S} && gnu-configize) || die "failure running gnu-configize" > oe_runconf > } > diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb > index d420f80..8bf07d7 100644 > --- a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb > +++ b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb > @@ -5,7 +5,7 @@ require gcc-cross-canadian.inc > require gcc-configure-sdk.inc > require gcc-package-sdk.inc > > -PR = "r20" > +PR = "r21" > > DEPENDS += "gmp-nativesdk mpfr-nativesdk" > RDEPENDS_${PN} += "mpfr-nativesdk" > diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb > index 3eea4bc..92708d4 100644 > --- a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb > +++ b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb > @@ -5,7 +5,7 @@ require gcc-cross-canadian.inc > require gcc-configure-sdk.inc > require gcc-package-sdk.inc > > -PR = "r3" > +PR = "r4" > > DEPENDS += "gmp-nativesdk mpfr-nativesdk libmpc-nativesdk elfutils-nativesdk" > RDEPENDS_${PN} += "mpfr-nativesdk libmpc-nativesdk elfutils-nativesdk" > diff --git a/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb > index 28ac1ab..ef52845 100644 > --- a/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb > +++ b/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb > @@ -1,5 +1,5 @@ > require gcc-cross_${PV}.bb > require gcc-cross-initial.inc > > -PR = "r5" > +PR = "r6" > > diff --git a/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb > index b2c257d..38e0964 100644 > --- a/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb > +++ b/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb > @@ -1,5 +1,5 @@ > require gcc-cross_${PV}.bb > require gcc-cross-initial.inc > > -PR = "r2" > +PR = "r3" > > diff --git a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb > index a8473b0..deeee37 100644 > --- a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb > +++ b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb > @@ -1,4 +1,4 @@ > require gcc-cross_${PV}.bb > require gcc-cross-intermediate.inc > -PR = "r5" > +PR = "r6" > > diff --git a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb > index e65d5df..9a30cb5 100644 > --- a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb > +++ b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb > @@ -1,4 +1,4 @@ > require gcc-cross_${PV}.bb > require gcc-cross-intermediate.inc > -PR = "r3" > +PR = "r4" > > diff --git a/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb b/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb > index 88e3842..462104f 100644 > --- a/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb > +++ b/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb > @@ -9,7 +9,7 @@ require gcc-cross-kernel.inc > > DEFAULT_PREFERENCE = "-1" > > -PR = "r4" > +PR = "r5" > > SRC_URI += "file://gcc-3.4.4-makefile-fix.patch;patch=1" > > diff --git a/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb > index 5eaac5f..1a982f5 100644 > --- a/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb > +++ b/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb > @@ -1,4 +1,4 @@ > -PR = "r17" > +PR = "r18" > > require gcc-${PV}.inc > require gcc-cross4.inc > diff --git a/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb > index 399cdf9..78bb05a 100644 > --- a/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb > +++ b/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb > @@ -1,4 +1,4 @@ > -PR = "r2" > +PR = "r3" > > require gcc-${PV}.inc > require gcc-cross4.inc > diff --git a/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb b/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb > index 89534f1..0e7a1ee 100644 > --- a/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb > +++ b/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb > @@ -1,4 +1,4 @@ > -PR = "r5" > +PR = "r6" > > require gcc-csl-arm-2008q1.inc > require gcc-cross4.inc > diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb > index b42de47..d3ddcb1 100644 > --- a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb > +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb > @@ -1,3 +1,3 @@ > require gcc-cross-initial_${PV}.bb > require gcc-crosssdk-initial.inc > -PR = "r6" > +PR = "r7" > diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb > index 240caf5..fec53b9 100644 > --- a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb > +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb > @@ -1,4 +1,4 @@ > require gcc-cross-initial_${PV}.bb > require gcc-crosssdk-initial.inc > > -PR = "r2" > +PR = "r3" > diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb > index cd1f966..2be05f1 100644 > --- a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb > +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb > @@ -1,3 +1,3 @@ > require gcc-cross-intermediate_${PV}.bb > require gcc-crosssdk-intermediate.inc > -PR = "r8" > +PR = "r9" > diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb > index a6653dd..161d870 100644 > --- a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb > +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb > @@ -1,4 +1,4 @@ > require gcc-cross-intermediate_${PV}.bb > require gcc-crosssdk-intermediate.inc > > -PR = "r2" > +PR = "r3" > diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb > index 129e8d3..7069088 100644 > --- a/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb > +++ b/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb > @@ -1,4 +1,4 @@ > require gcc-cross_${PV}.bb > require gcc-crosssdk.inc > > -PR = "r2" > +PR = "r3" > diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb > index 99f927a..2f5cfb5 100644 > --- a/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb > +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb > @@ -1,4 +1,4 @@ > -PR = "r18" > +PR = "r19" > > require gcc-${PV}.inc > require gcc-configure-runtime.inc > diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > index 093f9bf..c1e680d 100644 > --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > @@ -1,4 +1,4 @@ > -PR = "r2" > +PR = "r3" > > require gcc-${PV}.inc > require gcc-configure-runtime.inc > diff --git a/meta/recipes-devtools/gcc/gcc_4.3.3.bb b/meta/recipes-devtools/gcc/gcc_4.3.3.bb > index f0471d4..ba6e7b2 100644 > --- a/meta/recipes-devtools/gcc/gcc_4.3.3.bb > +++ b/meta/recipes-devtools/gcc/gcc_4.3.3.bb > @@ -1,4 +1,4 @@ > -PR = "r11" > +PR = "r12" > > require gcc-${PV}.inc > require gcc-configure-target.inc > diff --git a/meta/recipes-devtools/gcc/gcc_4.5.1.bb b/meta/recipes-devtools/gcc/gcc_4.5.1.bb > index 919d4b0..25e455c 100644 > --- a/meta/recipes-devtools/gcc/gcc_4.5.1.bb > +++ b/meta/recipes-devtools/gcc/gcc_4.5.1.bb > @@ -1,4 +1,4 @@ > -PR = "r2" > +PR = "r3" > require gcc-${PV}.inc > require gcc-configure-target.inc > require gcc-package-target.inc > diff --git a/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb b/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb > index cc7540a..2df12ef 100644 > --- a/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb > +++ b/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb > @@ -1,4 +1,4 @@ > -PR = "r3" > +PR = "r4" > > require gcc-${PV}.inc > require gcc-configure-target.inc > diff --git a/meta/recipes-devtools/gcc/libgcc_4.5.1.bb b/meta/recipes-devtools/gcc/libgcc_4.5.1.bb > index b6cf268..3f7ce0a 100644 > --- a/meta/recipes-devtools/gcc/libgcc_4.5.1.bb > +++ b/meta/recipes-devtools/gcc/libgcc_4.5.1.bb > @@ -1,6 +1,6 @@ > require gcc-${PV}.inc > > -PR = "r0" > +PR = "r1" > > INHIBIT_DEFAULT_DEPS = "1" > DEPENDS = "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}g++" > -- > 1.7.4.1 > > ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc. 2011-03-08 6:38 ` Khem Raj @ 2011-03-08 18:53 ` Richard Purdie 2011-03-08 19:04 ` Khem Raj 0 siblings, 1 reply; 28+ messages in thread From: Richard Purdie @ 2011-03-08 18:53 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Mon, 2011-03-07 at 22:38 -0800, Khem Raj wrote: > ping any opinion on this patch ? This change looks rather hacky and I'd really like to understand more about why this is needed and whether there is a better way we could ensure the right flags get passed around. Can you provide more details about whats going on with this. Obviously this change as it stands isn't acceptable to upstream gcc and I'd like to see if we could find one that was. Cheers, Richard > On Wed, Mar 2, 2011 at 10:52 PM, Khem Raj <raj.khem@gmail.com> wrote: > > * This is helpful to get consistent behaviour with gcc on different > > hosts and linking the libraries in for cross gcc recipes should not > > be increasing the binary size alarmingly > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > --- > > meta/recipes-devtools/gcc/gcc-configure-common.inc | 7 +++++++ > > meta/recipes-devtools/gcc/gcc-configure-cross.inc | 10 ++++++++++ > > meta/recipes-devtools/gcc/gcc-configure-sdk.inc | 8 ++++++++ > > .../gcc/gcc-cross-canadian_4.3.3.bb | 2 +- > > .../gcc/gcc-cross-canadian_4.5.1.bb | 2 +- > > .../gcc/gcc-cross-initial_4.3.3.bb | 2 +- > > .../gcc/gcc-cross-initial_4.5.1.bb | 2 +- > > .../gcc/gcc-cross-intermediate_4.3.3.bb | 2 +- > > .../gcc/gcc-cross-intermediate_4.5.1.bb | 2 +- > > .../gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb | 2 +- > > meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb | 2 +- > > meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb | 2 +- > > .../gcc/gcc-cross_csl-arm-2008q1.bb | 2 +- > > .../gcc/gcc-crosssdk-initial_4.3.3.bb | 2 +- > > .../gcc/gcc-crosssdk-initial_4.5.1.bb | 2 +- > > .../gcc/gcc-crosssdk-intermediate_4.3.3.bb | 2 +- > > .../gcc/gcc-crosssdk-intermediate_4.5.1.bb | 2 +- > > meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb | 2 +- > > meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb | 2 +- > > meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +- > > meta/recipes-devtools/gcc/gcc_4.3.3.bb | 2 +- > > meta/recipes-devtools/gcc/gcc_4.5.1.bb | 2 +- > > meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb | 2 +- > > meta/recipes-devtools/gcc/libgcc_4.5.1.bb | 2 +- > > 24 files changed, 46 insertions(+), 21 deletions(-) > > > > diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc b/meta/recipes-devtools/gcc/gcc-configure-common.inc > > index 4393777..cdb69fb 100644 > > --- a/meta/recipes-devtools/gcc/gcc-configure-common.inc > > +++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc > > @@ -85,6 +85,11 @@ do_configure () { > > export CXXFLAGS_FOR_BUILD="${BUILD_CXXFLAGS}" > > export LDFLAGS_FOR_BUILD="${BUILD_LDFLAGS}" > > export ARCH_FLAGS_FOR_TARGET="${ARCH_FLAGS_FOR_TARGET}" > > + > > + # Make sure LDFLAGS are honored. > > + sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.in > > + sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.tpl > > + > > (cd ${S} && gnu-configize) || die "failure running gnu-configize" > > > > # teach gcc to find correct target includedir when checking libc ssp support > > @@ -108,5 +113,7 @@ do_configure () { > > echo "#endif /* ! GCC_DEFAULTS_H */" >> ${S}/gcc/defaults.h.new > > mv ${S}/gcc/defaults.h.new ${S}/gcc/defaults.h > > oe_runconf > > + # make sure that no @LDFLAG@ is left in the generated Makefile > > + sed -i "s/@LDFLAGS@//g" ${B}/Makefile > > } > > > > diff --git a/meta/recipes-devtools/gcc/gcc-configure-cross.inc b/meta/recipes-devtools/gcc/gcc-configure-cross.inc > > index 346d164..200cbe2 100644 > > --- a/meta/recipes-devtools/gcc/gcc-configure-cross.inc > > +++ b/meta/recipes-devtools/gcc/gcc-configure-cross.inc > > @@ -16,6 +16,16 @@ do_compile_prepend () { > > export LD_FOR_TARGET="${TARGET_SYS}-ld" > > export NM_FOR_TARGET="${TARGET_SYS}-nm" > > export CC_FOR_TARGET="${CCACHE} ${TARGET_SYS}-gcc ${TARGET_CC_ARCH}" > > + export OBJDUMP_FOR_TARGET="${TARGET_SYS}-objdump" > > + export OBJCOPY_FOR_TARGET="${TARGET_SYS}-objcopy" > > + export STRIP_FOR_TARGET="${TARGET_SYS}-strip" > > + # Make sure we use GMP/MPFR statically > > + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl > > + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in > > + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl > > + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in > > + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl > > + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in > > } > > > > LIBGCCS_VAR = "-lgcc_s" > > diff --git a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc > > index 756e74e..3eb8992 100644 > > --- a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc > > +++ b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc > > @@ -39,6 +39,14 @@ do_configure () { > > export CPPFLAGS_FOR_BUILD="${BUILD_CPPFLAGS}" > > export CXXFLAGS_FOR_BUILD="${BUILD_CXXFLAGS}" > > export LDFLAGS_FOR_BUILD="${BUILD_LDFLAGS}" > > + export CC_FOR_TARGET="${CCACHE} ${TARGET_SYS}-gcc ${TARGET_CC_ARCH}" > > + # Make sure we use GMP/MPFR statically > > + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl > > + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in > > + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl > > + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in > > + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl > > + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in > > (cd ${S} && gnu-configize) || die "failure running gnu-configize" > > oe_runconf > > } > > diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb > > index d420f80..8bf07d7 100644 > > --- a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb > > +++ b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb > > @@ -5,7 +5,7 @@ require gcc-cross-canadian.inc > > require gcc-configure-sdk.inc > > require gcc-package-sdk.inc > > > > -PR = "r20" > > +PR = "r21" > > > > DEPENDS += "gmp-nativesdk mpfr-nativesdk" > > RDEPENDS_${PN} += "mpfr-nativesdk" > > diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb > > index 3eea4bc..92708d4 100644 > > --- a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb > > +++ b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb > > @@ -5,7 +5,7 @@ require gcc-cross-canadian.inc > > require gcc-configure-sdk.inc > > require gcc-package-sdk.inc > > > > -PR = "r3" > > +PR = "r4" > > > > DEPENDS += "gmp-nativesdk mpfr-nativesdk libmpc-nativesdk elfutils-nativesdk" > > RDEPENDS_${PN} += "mpfr-nativesdk libmpc-nativesdk elfutils-nativesdk" > > diff --git a/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb > > index 28ac1ab..ef52845 100644 > > --- a/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb > > +++ b/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb > > @@ -1,5 +1,5 @@ > > require gcc-cross_${PV}.bb > > require gcc-cross-initial.inc > > > > -PR = "r5" > > +PR = "r6" > > > > diff --git a/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb > > index b2c257d..38e0964 100644 > > --- a/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb > > +++ b/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb > > @@ -1,5 +1,5 @@ > > require gcc-cross_${PV}.bb > > require gcc-cross-initial.inc > > > > -PR = "r2" > > +PR = "r3" > > > > diff --git a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb > > index a8473b0..deeee37 100644 > > --- a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb > > +++ b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb > > @@ -1,4 +1,4 @@ > > require gcc-cross_${PV}.bb > > require gcc-cross-intermediate.inc > > -PR = "r5" > > +PR = "r6" > > > > diff --git a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb > > index e65d5df..9a30cb5 100644 > > --- a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb > > +++ b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb > > @@ -1,4 +1,4 @@ > > require gcc-cross_${PV}.bb > > require gcc-cross-intermediate.inc > > -PR = "r3" > > +PR = "r4" > > > > diff --git a/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb b/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb > > index 88e3842..462104f 100644 > > --- a/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb > > +++ b/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb > > @@ -9,7 +9,7 @@ require gcc-cross-kernel.inc > > > > DEFAULT_PREFERENCE = "-1" > > > > -PR = "r4" > > +PR = "r5" > > > > SRC_URI += "file://gcc-3.4.4-makefile-fix.patch;patch=1" > > > > diff --git a/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb > > index 5eaac5f..1a982f5 100644 > > --- a/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb > > +++ b/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb > > @@ -1,4 +1,4 @@ > > -PR = "r17" > > +PR = "r18" > > > > require gcc-${PV}.inc > > require gcc-cross4.inc > > diff --git a/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb > > index 399cdf9..78bb05a 100644 > > --- a/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb > > +++ b/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb > > @@ -1,4 +1,4 @@ > > -PR = "r2" > > +PR = "r3" > > > > require gcc-${PV}.inc > > require gcc-cross4.inc > > diff --git a/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb b/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb > > index 89534f1..0e7a1ee 100644 > > --- a/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb > > +++ b/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb > > @@ -1,4 +1,4 @@ > > -PR = "r5" > > +PR = "r6" > > > > require gcc-csl-arm-2008q1.inc > > require gcc-cross4.inc > > diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb > > index b42de47..d3ddcb1 100644 > > --- a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb > > +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb > > @@ -1,3 +1,3 @@ > > require gcc-cross-initial_${PV}.bb > > require gcc-crosssdk-initial.inc > > -PR = "r6" > > +PR = "r7" > > diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb > > index 240caf5..fec53b9 100644 > > --- a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb > > +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb > > @@ -1,4 +1,4 @@ > > require gcc-cross-initial_${PV}.bb > > require gcc-crosssdk-initial.inc > > > > -PR = "r2" > > +PR = "r3" > > diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb > > index cd1f966..2be05f1 100644 > > --- a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb > > +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb > > @@ -1,3 +1,3 @@ > > require gcc-cross-intermediate_${PV}.bb > > require gcc-crosssdk-intermediate.inc > > -PR = "r8" > > +PR = "r9" > > diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb > > index a6653dd..161d870 100644 > > --- a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb > > +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb > > @@ -1,4 +1,4 @@ > > require gcc-cross-intermediate_${PV}.bb > > require gcc-crosssdk-intermediate.inc > > > > -PR = "r2" > > +PR = "r3" > > diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb > > index 129e8d3..7069088 100644 > > --- a/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb > > +++ b/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb > > @@ -1,4 +1,4 @@ > > require gcc-cross_${PV}.bb > > require gcc-crosssdk.inc > > > > -PR = "r2" > > +PR = "r3" > > diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb > > index 99f927a..2f5cfb5 100644 > > --- a/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb > > +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb > > @@ -1,4 +1,4 @@ > > -PR = "r18" > > +PR = "r19" > > > > require gcc-${PV}.inc > > require gcc-configure-runtime.inc > > diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > > index 093f9bf..c1e680d 100644 > > --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > > +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > > @@ -1,4 +1,4 @@ > > -PR = "r2" > > +PR = "r3" > > > > require gcc-${PV}.inc > > require gcc-configure-runtime.inc > > diff --git a/meta/recipes-devtools/gcc/gcc_4.3.3.bb b/meta/recipes-devtools/gcc/gcc_4.3.3.bb > > index f0471d4..ba6e7b2 100644 > > --- a/meta/recipes-devtools/gcc/gcc_4.3.3.bb > > +++ b/meta/recipes-devtools/gcc/gcc_4.3.3.bb > > @@ -1,4 +1,4 @@ > > -PR = "r11" > > +PR = "r12" > > > > require gcc-${PV}.inc > > require gcc-configure-target.inc > > diff --git a/meta/recipes-devtools/gcc/gcc_4.5.1.bb b/meta/recipes-devtools/gcc/gcc_4.5.1.bb > > index 919d4b0..25e455c 100644 > > --- a/meta/recipes-devtools/gcc/gcc_4.5.1.bb > > +++ b/meta/recipes-devtools/gcc/gcc_4.5.1.bb > > @@ -1,4 +1,4 @@ > > -PR = "r2" > > +PR = "r3" > > require gcc-${PV}.inc > > require gcc-configure-target.inc > > require gcc-package-target.inc > > diff --git a/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb b/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb > > index cc7540a..2df12ef 100644 > > --- a/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb > > +++ b/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb > > @@ -1,4 +1,4 @@ > > -PR = "r3" > > +PR = "r4" > > > > require gcc-${PV}.inc > > require gcc-configure-target.inc > > diff --git a/meta/recipes-devtools/gcc/libgcc_4.5.1.bb b/meta/recipes-devtools/gcc/libgcc_4.5.1.bb > > index b6cf268..3f7ce0a 100644 > > --- a/meta/recipes-devtools/gcc/libgcc_4.5.1.bb > > +++ b/meta/recipes-devtools/gcc/libgcc_4.5.1.bb > > @@ -1,6 +1,6 @@ > > require gcc-${PV}.inc > > > > -PR = "r0" > > +PR = "r1" > > > > INHIBIT_DEFAULT_DEPS = "1" > > DEPENDS = "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}g++" > > -- > > 1.7.4.1 > > > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc. 2011-03-08 18:53 ` Richard Purdie @ 2011-03-08 19:04 ` Khem Raj 2011-03-12 12:50 ` Richard Purdie 0 siblings, 1 reply; 28+ messages in thread From: Khem Raj @ 2011-03-08 19:04 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Tue, Mar 8, 2011 at 10:53 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > On Mon, 2011-03-07 at 22:38 -0800, Khem Raj wrote: >> ping any opinion on this patch ? > > This change looks rather hacky and I'd really like to understand more > about why this is needed and whether there is a better way we could > ensure the right flags get passed around. Can you provide more details > about whats going on with this. Obviously this change as it stands isn't > acceptable to upstream gcc and I'd like to see if we could find one that > was. this is because the supporting libraries like mpc mpfr that are needed by gcc itself to run we might have different versions of these libraries. So depending upon shared objects would mean we need to find same shared objects where say the SDK is installed so either we ship the whole baggage or we link it in statically. This patch makes those libs to linked in statically and cross gcc wont have dependencies on these libs anymore so it can run on all hosts pretty much. Another different way to do it would be to build these libraries as part of gcc-cross build in unified tree and then gcc would automatically link in the static versions of these libraries. As a downside if the native versions of these libraries are needed elesewhere then we will build that lib twice. But it should be cleaner IMO to just build them intree with gcc. > > Cheers, > > Richard > >> On Wed, Mar 2, 2011 at 10:52 PM, Khem Raj <raj.khem@gmail.com> wrote: >> > * This is helpful to get consistent behaviour with gcc on different >> > hosts and linking the libraries in for cross gcc recipes should not >> > be increasing the binary size alarmingly >> > >> > Signed-off-by: Khem Raj <raj.khem@gmail.com> >> > --- >> > meta/recipes-devtools/gcc/gcc-configure-common.inc | 7 +++++++ >> > meta/recipes-devtools/gcc/gcc-configure-cross.inc | 10 ++++++++++ >> > meta/recipes-devtools/gcc/gcc-configure-sdk.inc | 8 ++++++++ >> > .../gcc/gcc-cross-canadian_4.3.3.bb | 2 +- >> > .../gcc/gcc-cross-canadian_4.5.1.bb | 2 +- >> > .../gcc/gcc-cross-initial_4.3.3.bb | 2 +- >> > .../gcc/gcc-cross-initial_4.5.1.bb | 2 +- >> > .../gcc/gcc-cross-intermediate_4.3.3.bb | 2 +- >> > .../gcc/gcc-cross-intermediate_4.5.1.bb | 2 +- >> > .../gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb | 2 +- >> > meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb | 2 +- >> > meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb | 2 +- >> > .../gcc/gcc-cross_csl-arm-2008q1.bb | 2 +- >> > .../gcc/gcc-crosssdk-initial_4.3.3.bb | 2 +- >> > .../gcc/gcc-crosssdk-initial_4.5.1.bb | 2 +- >> > .../gcc/gcc-crosssdk-intermediate_4.3.3.bb | 2 +- >> > .../gcc/gcc-crosssdk-intermediate_4.5.1.bb | 2 +- >> > meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb | 2 +- >> > meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb | 2 +- >> > meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +- >> > meta/recipes-devtools/gcc/gcc_4.3.3.bb | 2 +- >> > meta/recipes-devtools/gcc/gcc_4.5.1.bb | 2 +- >> > meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb | 2 +- >> > meta/recipes-devtools/gcc/libgcc_4.5.1.bb | 2 +- >> > 24 files changed, 46 insertions(+), 21 deletions(-) >> > >> > diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc b/meta/recipes-devtools/gcc/gcc-configure-common.inc >> > index 4393777..cdb69fb 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-configure-common.inc >> > +++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc >> > @@ -85,6 +85,11 @@ do_configure () { >> > export CXXFLAGS_FOR_BUILD="${BUILD_CXXFLAGS}" >> > export LDFLAGS_FOR_BUILD="${BUILD_LDFLAGS}" >> > export ARCH_FLAGS_FOR_TARGET="${ARCH_FLAGS_FOR_TARGET}" >> > + >> > + # Make sure LDFLAGS are honored. >> > + sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.in >> > + sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.tpl >> > + >> > (cd ${S} && gnu-configize) || die "failure running gnu-configize" >> > >> > # teach gcc to find correct target includedir when checking libc ssp support >> > @@ -108,5 +113,7 @@ do_configure () { >> > echo "#endif /* ! GCC_DEFAULTS_H */" >> ${S}/gcc/defaults.h.new >> > mv ${S}/gcc/defaults.h.new ${S}/gcc/defaults.h >> > oe_runconf >> > + # make sure that no @LDFLAG@ is left in the generated Makefile >> > + sed -i "s/@LDFLAGS@//g" ${B}/Makefile >> > } >> > >> > diff --git a/meta/recipes-devtools/gcc/gcc-configure-cross.inc b/meta/recipes-devtools/gcc/gcc-configure-cross.inc >> > index 346d164..200cbe2 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-configure-cross.inc >> > +++ b/meta/recipes-devtools/gcc/gcc-configure-cross.inc >> > @@ -16,6 +16,16 @@ do_compile_prepend () { >> > export LD_FOR_TARGET="${TARGET_SYS}-ld" >> > export NM_FOR_TARGET="${TARGET_SYS}-nm" >> > export CC_FOR_TARGET="${CCACHE} ${TARGET_SYS}-gcc ${TARGET_CC_ARCH}" >> > + export OBJDUMP_FOR_TARGET="${TARGET_SYS}-objdump" >> > + export OBJCOPY_FOR_TARGET="${TARGET_SYS}-objcopy" >> > + export STRIP_FOR_TARGET="${TARGET_SYS}-strip" >> > + # Make sure we use GMP/MPFR statically >> > + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl >> > + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in >> > + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl >> > + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in >> > + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl >> > + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in >> > } >> > >> > LIBGCCS_VAR = "-lgcc_s" >> > diff --git a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc >> > index 756e74e..3eb8992 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc >> > +++ b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc >> > @@ -39,6 +39,14 @@ do_configure () { >> > export CPPFLAGS_FOR_BUILD="${BUILD_CPPFLAGS}" >> > export CXXFLAGS_FOR_BUILD="${BUILD_CXXFLAGS}" >> > export LDFLAGS_FOR_BUILD="${BUILD_LDFLAGS}" >> > + export CC_FOR_TARGET="${CCACHE} ${TARGET_SYS}-gcc ${TARGET_CC_ARCH}" >> > + # Make sure we use GMP/MPFR statically >> > + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl >> > + sed -i 's/^\(HOST_GMPLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in >> > + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl >> > + sed -i 's/^\(HOST_PPLLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in >> > + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.tpl >> > + sed -i 's/^\(HOST_LIBELFLIBS =\) \(.*\)$/\1 -Wl,-Bstatic \2 -Wl,-Bdynamic/' ${S}/Makefile.in >> > (cd ${S} && gnu-configize) || die "failure running gnu-configize" >> > oe_runconf >> > } >> > diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb >> > index d420f80..8bf07d7 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.3.3.bb >> > @@ -5,7 +5,7 @@ require gcc-cross-canadian.inc >> > require gcc-configure-sdk.inc >> > require gcc-package-sdk.inc >> > >> > -PR = "r20" >> > +PR = "r21" >> > >> > DEPENDS += "gmp-nativesdk mpfr-nativesdk" >> > RDEPENDS_${PN} += "mpfr-nativesdk" >> > diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb >> > index 3eea4bc..92708d4 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-cross-canadian_4.5.1.bb >> > @@ -5,7 +5,7 @@ require gcc-cross-canadian.inc >> > require gcc-configure-sdk.inc >> > require gcc-package-sdk.inc >> > >> > -PR = "r3" >> > +PR = "r4" >> > >> > DEPENDS += "gmp-nativesdk mpfr-nativesdk libmpc-nativesdk elfutils-nativesdk" >> > RDEPENDS_${PN} += "mpfr-nativesdk libmpc-nativesdk elfutils-nativesdk" >> > diff --git a/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb >> > index 28ac1ab..ef52845 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-cross-initial_4.3.3.bb >> > @@ -1,5 +1,5 @@ >> > require gcc-cross_${PV}.bb >> > require gcc-cross-initial.inc >> > >> > -PR = "r5" >> > +PR = "r6" >> > >> > diff --git a/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb >> > index b2c257d..38e0964 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-cross-initial_4.5.1.bb >> > @@ -1,5 +1,5 @@ >> > require gcc-cross_${PV}.bb >> > require gcc-cross-initial.inc >> > >> > -PR = "r2" >> > +PR = "r3" >> > >> > diff --git a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb >> > index a8473b0..deeee37 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.3.3.bb >> > @@ -1,4 +1,4 @@ >> > require gcc-cross_${PV}.bb >> > require gcc-cross-intermediate.inc >> > -PR = "r5" >> > +PR = "r6" >> > >> > diff --git a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb >> > index e65d5df..9a30cb5 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-cross-intermediate_4.5.1.bb >> > @@ -1,4 +1,4 @@ >> > require gcc-cross_${PV}.bb >> > require gcc-cross-intermediate.inc >> > -PR = "r3" >> > +PR = "r4" >> > >> > diff --git a/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb b/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb >> > index 88e3842..462104f 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-cross-kernel-3.4.4_csl-arm-2005q3.bb >> > @@ -9,7 +9,7 @@ require gcc-cross-kernel.inc >> > >> > DEFAULT_PREFERENCE = "-1" >> > >> > -PR = "r4" >> > +PR = "r5" >> > >> > SRC_URI += "file://gcc-3.4.4-makefile-fix.patch;patch=1" >> > >> > diff --git a/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb >> > index 5eaac5f..1a982f5 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-cross_4.3.3.bb >> > @@ -1,4 +1,4 @@ >> > -PR = "r17" >> > +PR = "r18" >> > >> > require gcc-${PV}.inc >> > require gcc-cross4.inc >> > diff --git a/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb >> > index 399cdf9..78bb05a 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-cross_4.5.1.bb >> > @@ -1,4 +1,4 @@ >> > -PR = "r2" >> > +PR = "r3" >> > >> > require gcc-${PV}.inc >> > require gcc-cross4.inc >> > diff --git a/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb b/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb >> > index 89534f1..0e7a1ee 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-cross_csl-arm-2008q1.bb >> > @@ -1,4 +1,4 @@ >> > -PR = "r5" >> > +PR = "r6" >> > >> > require gcc-csl-arm-2008q1.inc >> > require gcc-cross4.inc >> > diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb >> > index b42de47..d3ddcb1 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.3.3.bb >> > @@ -1,3 +1,3 @@ >> > require gcc-cross-initial_${PV}.bb >> > require gcc-crosssdk-initial.inc >> > -PR = "r6" >> > +PR = "r7" >> > diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb >> > index 240caf5..fec53b9 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-initial_4.5.1.bb >> > @@ -1,4 +1,4 @@ >> > require gcc-cross-initial_${PV}.bb >> > require gcc-crosssdk-initial.inc >> > >> > -PR = "r2" >> > +PR = "r3" >> > diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb >> > index cd1f966..2be05f1 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.3.3.bb >> > @@ -1,3 +1,3 @@ >> > require gcc-cross-intermediate_${PV}.bb >> > require gcc-crosssdk-intermediate.inc >> > -PR = "r8" >> > +PR = "r9" >> > diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb >> > index a6653dd..161d870 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-crosssdk-intermediate_4.5.1.bb >> > @@ -1,4 +1,4 @@ >> > require gcc-cross-intermediate_${PV}.bb >> > require gcc-crosssdk-intermediate.inc >> > >> > -PR = "r2" >> > +PR = "r3" >> > diff --git a/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb >> > index 129e8d3..7069088 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-crosssdk_4.5.1.bb >> > @@ -1,4 +1,4 @@ >> > require gcc-cross_${PV}.bb >> > require gcc-crosssdk.inc >> > >> > -PR = "r2" >> > +PR = "r3" >> > diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb >> > index 99f927a..2f5cfb5 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.3.3.bb >> > @@ -1,4 +1,4 @@ >> > -PR = "r18" >> > +PR = "r19" >> > >> > require gcc-${PV}.inc >> > require gcc-configure-runtime.inc >> > diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb >> > index 093f9bf..c1e680d 100644 >> > --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb >> > +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb >> > @@ -1,4 +1,4 @@ >> > -PR = "r2" >> > +PR = "r3" >> > >> > require gcc-${PV}.inc >> > require gcc-configure-runtime.inc >> > diff --git a/meta/recipes-devtools/gcc/gcc_4.3.3.bb b/meta/recipes-devtools/gcc/gcc_4.3.3.bb >> > index f0471d4..ba6e7b2 100644 >> > --- a/meta/recipes-devtools/gcc/gcc_4.3.3.bb >> > +++ b/meta/recipes-devtools/gcc/gcc_4.3.3.bb >> > @@ -1,4 +1,4 @@ >> > -PR = "r11" >> > +PR = "r12" >> > >> > require gcc-${PV}.inc >> > require gcc-configure-target.inc >> > diff --git a/meta/recipes-devtools/gcc/gcc_4.5.1.bb b/meta/recipes-devtools/gcc/gcc_4.5.1.bb >> > index 919d4b0..25e455c 100644 >> > --- a/meta/recipes-devtools/gcc/gcc_4.5.1.bb >> > +++ b/meta/recipes-devtools/gcc/gcc_4.5.1.bb >> > @@ -1,4 +1,4 @@ >> > -PR = "r2" >> > +PR = "r3" >> > require gcc-${PV}.inc >> > require gcc-configure-target.inc >> > require gcc-package-target.inc >> > diff --git a/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb b/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb >> > index cc7540a..2df12ef 100644 >> > --- a/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb >> > +++ b/meta/recipes-devtools/gcc/gcc_csl-arm-2008q1.bb >> > @@ -1,4 +1,4 @@ >> > -PR = "r3" >> > +PR = "r4" >> > >> > require gcc-${PV}.inc >> > require gcc-configure-target.inc >> > diff --git a/meta/recipes-devtools/gcc/libgcc_4.5.1.bb b/meta/recipes-devtools/gcc/libgcc_4.5.1.bb >> > index b6cf268..3f7ce0a 100644 >> > --- a/meta/recipes-devtools/gcc/libgcc_4.5.1.bb >> > +++ b/meta/recipes-devtools/gcc/libgcc_4.5.1.bb >> > @@ -1,6 +1,6 @@ >> > require gcc-${PV}.inc >> > >> > -PR = "r0" >> > +PR = "r1" >> > >> > INHIBIT_DEFAULT_DEPS = "1" >> > DEPENDS = "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}g++" >> > -- >> > 1.7.4.1 >> > >> > >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc. 2011-03-08 19:04 ` Khem Raj @ 2011-03-12 12:50 ` Richard Purdie 2011-03-14 16:50 ` Tom Rini 2011-03-14 17:52 ` Khem Raj 0 siblings, 2 replies; 28+ messages in thread From: Richard Purdie @ 2011-03-12 12:50 UTC (permalink / raw) To: Khem Raj; +Cc: Patches and discussions about the oe-core layer On Tue, 2011-03-08 at 11:04 -0800, Khem Raj wrote: > On Tue, Mar 8, 2011 at 10:53 AM, Richard Purdie > <richard.purdie@linuxfoundation.org> wrote: > > On Mon, 2011-03-07 at 22:38 -0800, Khem Raj wrote: > >> ping any opinion on this patch ? > > > > This change looks rather hacky and I'd really like to understand more > > about why this is needed and whether there is a better way we could > > ensure the right flags get passed around. Can you provide more details > > about whats going on with this. Obviously this change as it stands isn't > > acceptable to upstream gcc and I'd like to see if we could find one that > > was. > > this is because the supporting libraries like mpc mpfr that are needed > by gcc itself to run > we might have different versions of these libraries. So depending upon > shared objects > would mean we need to find same shared objects where say the SDK is installed > so either we ship the whole baggage or we link it in statically. This > patch makes those libs to > linked in statically and cross gcc wont have dependencies on these > libs anymore so > it can run on all hosts pretty much. If you look at the way the SDK toolchain works in Poky, it automatically ships the versions of these libraries that it needs so we don't actually have this problem. Also, looking at the patch again, was the first LDFLAGS change meant to be in there, is that related or different to the shared/static mpfr/mpc/gmp issue? Cheers, Richard ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc. 2011-03-12 12:50 ` Richard Purdie @ 2011-03-14 16:50 ` Tom Rini 2011-03-14 19:54 ` Richard Purdie 2011-03-14 17:52 ` Khem Raj 1 sibling, 1 reply; 28+ messages in thread From: Tom Rini @ 2011-03-14 16:50 UTC (permalink / raw) To: openembedded-core On 03/12/2011 05:50 AM, Richard Purdie wrote: > On Tue, 2011-03-08 at 11:04 -0800, Khem Raj wrote: >> On Tue, Mar 8, 2011 at 10:53 AM, Richard Purdie >> <richard.purdie@linuxfoundation.org> wrote: >>> On Mon, 2011-03-07 at 22:38 -0800, Khem Raj wrote: >>>> ping any opinion on this patch ? >>> >>> This change looks rather hacky and I'd really like to understand more >>> about why this is needed and whether there is a better way we could >>> ensure the right flags get passed around. Can you provide more details >>> about whats going on with this. Obviously this change as it stands isn't >>> acceptable to upstream gcc and I'd like to see if we could find one that >>> was. >> >> this is because the supporting libraries like mpc mpfr that are needed >> by gcc itself to run >> we might have different versions of these libraries. So depending upon >> shared objects >> would mean we need to find same shared objects where say the SDK is installed >> so either we ship the whole baggage or we link it in statically. This >> patch makes those libs to >> linked in statically and cross gcc wont have dependencies on these >> libs anymore so >> it can run on all hosts pretty much. > > If you look at the way the SDK toolchain works in Poky, it automatically > ships the versions of these libraries that it needs so we don't actually > have this problem. > > Also, looking at the patch again, was the first LDFLAGS change meant to > be in there, is that related or different to the shared/static > mpfr/mpc/gmp issue? I think it's time for someone to build one at dig at it, but are you sure they're used and shipped and not just used? That was a problem before and unless the exported bits are using a relative $ORIGIN in the link path (or we've broken relocatability, which would be another problem) there's problems today. -- Tom Rini Mentor Graphics Corporation ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc. 2011-03-14 16:50 ` Tom Rini @ 2011-03-14 19:54 ` Richard Purdie 2011-03-15 17:33 ` Tom Rini 0 siblings, 1 reply; 28+ messages in thread From: Richard Purdie @ 2011-03-14 19:54 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Mon, 2011-03-14 at 09:50 -0700, Tom Rini wrote: > On 03/12/2011 05:50 AM, Richard Purdie wrote: > > On Tue, 2011-03-08 at 11:04 -0800, Khem Raj wrote: > >> On Tue, Mar 8, 2011 at 10:53 AM, Richard Purdie > >> <richard.purdie@linuxfoundation.org> wrote: > >>> On Mon, 2011-03-07 at 22:38 -0800, Khem Raj wrote: > >>>> ping any opinion on this patch ? > >>> > >>> This change looks rather hacky and I'd really like to understand more > >>> about why this is needed and whether there is a better way we could > >>> ensure the right flags get passed around. Can you provide more details > >>> about whats going on with this. Obviously this change as it stands isn't > >>> acceptable to upstream gcc and I'd like to see if we could find one that > >>> was. > >> > >> this is because the supporting libraries like mpc mpfr that are needed > >> by gcc itself to run > >> we might have different versions of these libraries. So depending upon > >> shared objects > >> would mean we need to find same shared objects where say the SDK is installed > >> so either we ship the whole baggage or we link it in statically. This > >> patch makes those libs to > >> linked in statically and cross gcc wont have dependencies on these > >> libs anymore so > >> it can run on all hosts pretty much. > > > > If you look at the way the SDK toolchain works in Poky, it automatically > > ships the versions of these libraries that it needs so we don't actually > > have this problem. > > > > Also, looking at the patch again, was the first LDFLAGS change meant to > > be in there, is that related or different to the shared/static > > mpfr/mpc/gmp issue? > > I think it's time for someone to build one at dig at it, but are you > sure they're used and shipped and not just used? That was a problem > before and unless the exported bits are using a relative $ORIGIN in the > link path (or we've broken relocatability, which would be another > problem) there's problems today. They are used and shipped. As evidence I submit: http://autobuilder.yoctoproject.org/nightly/20110311-1/toolchain/x86_64/poky-lsb-eglibc-x86_64-i586-toolchain-gmae-0.9+snapshot-20110313.tar.bz2 which I just inspected and it contains libmpc, libgmp and libmpfr. If it doesn't work, I'd like someone to demonstrate the bug :) Jsut to be clear, there is *one* hardcoded assumption in the way nativesdk works which is to do with the dynamic loader location. If we can link things against some generic common denominator ld.so (likely from LSB?), it should be possible to remove that limitation. Its always been intended to add that, just nobody has done it yet. Cheers, Richard ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc. 2011-03-14 19:54 ` Richard Purdie @ 2011-03-15 17:33 ` Tom Rini 2011-03-16 13:27 ` Richard Purdie 0 siblings, 1 reply; 28+ messages in thread From: Tom Rini @ 2011-03-15 17:33 UTC (permalink / raw) To: openembedded-core On 03/14/2011 12:54 PM, Richard Purdie wrote: > On Mon, 2011-03-14 at 09:50 -0700, Tom Rini wrote: >> On 03/12/2011 05:50 AM, Richard Purdie wrote: >>> On Tue, 2011-03-08 at 11:04 -0800, Khem Raj wrote: >>>> On Tue, Mar 8, 2011 at 10:53 AM, Richard Purdie >>>> <richard.purdie@linuxfoundation.org> wrote: >>>>> On Mon, 2011-03-07 at 22:38 -0800, Khem Raj wrote: >>>>>> ping any opinion on this patch ? >>>>> >>>>> This change looks rather hacky and I'd really like to understand more >>>>> about why this is needed and whether there is a better way we could >>>>> ensure the right flags get passed around. Can you provide more details >>>>> about whats going on with this. Obviously this change as it stands isn't >>>>> acceptable to upstream gcc and I'd like to see if we could find one that >>>>> was. >>>> >>>> this is because the supporting libraries like mpc mpfr that are needed >>>> by gcc itself to run >>>> we might have different versions of these libraries. So depending upon >>>> shared objects >>>> would mean we need to find same shared objects where say the SDK is installed >>>> so either we ship the whole baggage or we link it in statically. This >>>> patch makes those libs to >>>> linked in statically and cross gcc wont have dependencies on these >>>> libs anymore so >>>> it can run on all hosts pretty much. >>> >>> If you look at the way the SDK toolchain works in Poky, it automatically >>> ships the versions of these libraries that it needs so we don't actually >>> have this problem. >>> >>> Also, looking at the patch again, was the first LDFLAGS change meant to >>> be in there, is that related or different to the shared/static >>> mpfr/mpc/gmp issue? >> >> I think it's time for someone to build one at dig at it, but are you >> sure they're used and shipped and not just used? That was a problem >> before and unless the exported bits are using a relative $ORIGIN in the >> link path (or we've broken relocatability, which would be another >> problem) there's problems today. > > They are used and shipped. As evidence I submit: > > http://autobuilder.yoctoproject.org/nightly/20110311-1/toolchain/x86_64/poky-lsb-eglibc-x86_64-i586-toolchain-gmae-0.9+snapshot-20110313.tar.bz2 Is /opt/poky-lsb/0.9+snapshot/sysroots/x86_64-pokysdk-linux/usr/bin/i586-poky-linux/i586-poky-linux-gcc the runs on host targets the target cross compiler the user should use now? If so, you don't have relocation as the RPATH is hard-coded not $ORIGIN based. If not, can I have a pointer to the right gcc to poke at? Thanks :) -- Tom Rini Mentor Graphics Corporation ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc. 2011-03-15 17:33 ` Tom Rini @ 2011-03-16 13:27 ` Richard Purdie 2011-03-16 17:17 ` Tom Rini 0 siblings, 1 reply; 28+ messages in thread From: Richard Purdie @ 2011-03-16 13:27 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Tue, 2011-03-15 at 10:33 -0700, Tom Rini wrote: > On 03/14/2011 12:54 PM, Richard Purdie wrote: > > On Mon, 2011-03-14 at 09:50 -0700, Tom Rini wrote: > >> On 03/12/2011 05:50 AM, Richard Purdie wrote: > >>> On Tue, 2011-03-08 at 11:04 -0800, Khem Raj wrote: > >>>> On Tue, Mar 8, 2011 at 10:53 AM, Richard Purdie > >>>> <richard.purdie@linuxfoundation.org> wrote: > >>>>> On Mon, 2011-03-07 at 22:38 -0800, Khem Raj wrote: > >>>>>> ping any opinion on this patch ? > >>>>> > >>>>> This change looks rather hacky and I'd really like to understand more > >>>>> about why this is needed and whether there is a better way we could > >>>>> ensure the right flags get passed around. Can you provide more details > >>>>> about whats going on with this. Obviously this change as it stands isn't > >>>>> acceptable to upstream gcc and I'd like to see if we could find one that > >>>>> was. > >>>> > >>>> this is because the supporting libraries like mpc mpfr that are needed > >>>> by gcc itself to run > >>>> we might have different versions of these libraries. So depending upon > >>>> shared objects > >>>> would mean we need to find same shared objects where say the SDK is installed > >>>> so either we ship the whole baggage or we link it in statically. This > >>>> patch makes those libs to > >>>> linked in statically and cross gcc wont have dependencies on these > >>>> libs anymore so > >>>> it can run on all hosts pretty much. > >>> > >>> If you look at the way the SDK toolchain works in Poky, it automatically > >>> ships the versions of these libraries that it needs so we don't actually > >>> have this problem. > >>> > >>> Also, looking at the patch again, was the first LDFLAGS change meant to > >>> be in there, is that related or different to the shared/static > >>> mpfr/mpc/gmp issue? > >> > >> I think it's time for someone to build one at dig at it, but are you > >> sure they're used and shipped and not just used? That was a problem > >> before and unless the exported bits are using a relative $ORIGIN in the > >> link path (or we've broken relocatability, which would be another > >> problem) there's problems today. > > > > They are used and shipped. As evidence I submit: > > > > http://autobuilder.yoctoproject.org/nightly/20110311-1/toolchain/x86_64/poky-lsb-eglibc-x86_64-i586-toolchain-gmae-0.9+snapshot-20110313.tar.bz2 > > Is > /opt/poky-lsb/0.9+snapshot/sysroots/x86_64-pokysdk-linux/usr/bin/i586-poky-linux/i586-poky-linux-gcc > the runs on host targets the target cross compiler the user should use > now? If so, you don't have relocation as the RPATH is hard-coded not > $ORIGIN based. If not, can I have a pointer to the right gcc to poke > at? Thanks :) Hmm, this sounds like something is not working with the relocation. I could have sworn we'd made that relocatable :/. It shouldn't be hard to fix with the relocation class at least... I hope we at least agree it does find the right libraries to link against which is most of the problem solved :) Cheers, Richard ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc. 2011-03-16 13:27 ` Richard Purdie @ 2011-03-16 17:17 ` Tom Rini 0 siblings, 0 replies; 28+ messages in thread From: Tom Rini @ 2011-03-16 17:17 UTC (permalink / raw) To: openembedded-core On 03/16/2011 06:27 AM, Richard Purdie wrote: > On Tue, 2011-03-15 at 10:33 -0700, Tom Rini wrote: >> On 03/14/2011 12:54 PM, Richard Purdie wrote: >>> On Mon, 2011-03-14 at 09:50 -0700, Tom Rini wrote: >>>> On 03/12/2011 05:50 AM, Richard Purdie wrote: >>>>> On Tue, 2011-03-08 at 11:04 -0800, Khem Raj wrote: >>>>>> On Tue, Mar 8, 2011 at 10:53 AM, Richard Purdie >>>>>> <richard.purdie@linuxfoundation.org> wrote: >>>>>>> On Mon, 2011-03-07 at 22:38 -0800, Khem Raj wrote: >>>>>>>> ping any opinion on this patch ? >>>>>>> >>>>>>> This change looks rather hacky and I'd really like to understand more >>>>>>> about why this is needed and whether there is a better way we could >>>>>>> ensure the right flags get passed around. Can you provide more details >>>>>>> about whats going on with this. Obviously this change as it stands isn't >>>>>>> acceptable to upstream gcc and I'd like to see if we could find one that >>>>>>> was. >>>>>> >>>>>> this is because the supporting libraries like mpc mpfr that are needed >>>>>> by gcc itself to run >>>>>> we might have different versions of these libraries. So depending upon >>>>>> shared objects >>>>>> would mean we need to find same shared objects where say the SDK is installed >>>>>> so either we ship the whole baggage or we link it in statically. This >>>>>> patch makes those libs to >>>>>> linked in statically and cross gcc wont have dependencies on these >>>>>> libs anymore so >>>>>> it can run on all hosts pretty much. >>>>> >>>>> If you look at the way the SDK toolchain works in Poky, it automatically >>>>> ships the versions of these libraries that it needs so we don't actually >>>>> have this problem. >>>>> >>>>> Also, looking at the patch again, was the first LDFLAGS change meant to >>>>> be in there, is that related or different to the shared/static >>>>> mpfr/mpc/gmp issue? >>>> >>>> I think it's time for someone to build one at dig at it, but are you >>>> sure they're used and shipped and not just used? That was a problem >>>> before and unless the exported bits are using a relative $ORIGIN in the >>>> link path (or we've broken relocatability, which would be another >>>> problem) there's problems today. >>> >>> They are used and shipped. As evidence I submit: >>> >>> http://autobuilder.yoctoproject.org/nightly/20110311-1/toolchain/x86_64/poky-lsb-eglibc-x86_64-i586-toolchain-gmae-0.9+snapshot-20110313.tar.bz2 >> >> Is >> /opt/poky-lsb/0.9+snapshot/sysroots/x86_64-pokysdk-linux/usr/bin/i586-poky-linux/i586-poky-linux-gcc >> the runs on host targets the target cross compiler the user should use >> now? If so, you don't have relocation as the RPATH is hard-coded not >> $ORIGIN based. If not, can I have a pointer to the right gcc to poke >> at? Thanks :) > > Hmm, this sounds like something is not working with the relocation. I > could have sworn we'd made that relocatable :/. > > It shouldn't be hard to fix with the relocation class at least... Yes, hopefully we just need to add relocatable to the various new classes and that'll be that. -- Tom Rini Mentor Graphics Corporation ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc. 2011-03-12 12:50 ` Richard Purdie 2011-03-14 16:50 ` Tom Rini @ 2011-03-14 17:52 ` Khem Raj 2011-03-14 18:01 ` Richard Purdie 1 sibling, 1 reply; 28+ messages in thread From: Khem Raj @ 2011-03-14 17:52 UTC (permalink / raw) To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer On Sat, Mar 12, 2011 at 4:50 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > On Tue, 2011-03-08 at 11:04 -0800, Khem Raj wrote: >> On Tue, Mar 8, 2011 at 10:53 AM, Richard Purdie >> <richard.purdie@linuxfoundation.org> wrote: >> > On Mon, 2011-03-07 at 22:38 -0800, Khem Raj wrote: >> >> ping any opinion on this patch ? >> > >> > This change looks rather hacky and I'd really like to understand more >> > about why this is needed and whether there is a better way we could >> > ensure the right flags get passed around. Can you provide more details >> > about whats going on with this. Obviously this change as it stands isn't >> > acceptable to upstream gcc and I'd like to see if we could find one that >> > was. >> >> this is because the supporting libraries like mpc mpfr that are needed >> by gcc itself to run >> we might have different versions of these libraries. So depending upon >> shared objects >> would mean we need to find same shared objects where say the SDK is installed >> so either we ship the whole baggage or we link it in statically. This >> patch makes those libs to >> linked in statically and cross gcc wont have dependencies on these >> libs anymore so >> it can run on all hosts pretty much. > > If you look at the way the SDK toolchain works in Poky, it automatically > ships the versions of these libraries that it needs so we don't actually > have this problem. > Yes thats one way of doing it and if you got it working this is fine but there were issues when referencing due to ORIGIN mucking. So this was better and cleaner than we link in this libs into binary itself. From my POV even this solution can be improved by adding the support libs to gcc build itself as sources then we dont need to muck with gcc build configury at all. I have been doing that for non OE related SDKs and has been best so far. > Also, looking at the patch again, was the first LDFLAGS change meant to > be in there, is that related or different to the shared/static > mpfr/mpc/gmp issue? LDFLAGS are modified to get the LDFLAGS into gcc itself otherwise it would not honour the modified LDFLAGS to pass -static option. > > Cheers, > > Richard > > ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc. 2011-03-14 17:52 ` Khem Raj @ 2011-03-14 18:01 ` Richard Purdie 2011-03-14 18:42 ` Khem Raj 0 siblings, 1 reply; 28+ messages in thread From: Richard Purdie @ 2011-03-14 18:01 UTC (permalink / raw) To: Khem Raj; +Cc: Patches and discussions about the oe-core layer On Mon, 2011-03-14 at 10:52 -0700, Khem Raj wrote: > On Sat, Mar 12, 2011 at 4:50 AM, Richard Purdie > <richard.purdie@linuxfoundation.org> wrote: > > If you look at the way the SDK toolchain works in Poky, it automatically > > ships the versions of these libraries that it needs so we don't actually > > have this problem. > > > > Yes thats one way of doing it and if you got it working this is fine > but there were issues when referencing > due to ORIGIN mucking. So this was better and cleaner than we link in > this libs into binary itself. The $ORIGIN stuff should be working just fine, have you checked this? > From > my POV even this solution can be improved by adding the support libs > to gcc build itself as sources > then we dont need to muck with gcc build configury at all. I have been > doing that for non OE related > SDKs and has been best so far. As I mention above, I do think we have a solution for this which is working... > > Also, looking at the patch again, was the first LDFLAGS change meant to > > be in there, is that related or different to the shared/static > > mpfr/mpc/gmp issue? > > LDFLAGS are modified to get the LDFLAGS into gcc itself otherwise it > would not honour > the modified LDFLAGS to pass -static option. Hmm, I'll look at the patch again as that didn't seem to be the only LDFLAGS change but I could be wrong. Cheers, Richard ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc. 2011-03-14 18:01 ` Richard Purdie @ 2011-03-14 18:42 ` Khem Raj 0 siblings, 0 replies; 28+ messages in thread From: Khem Raj @ 2011-03-14 18:42 UTC (permalink / raw) To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer On Mon, Mar 14, 2011 at 11:01 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > On Mon, 2011-03-14 at 10:52 -0700, Khem Raj wrote: >> On Sat, Mar 12, 2011 at 4:50 AM, Richard Purdie >> <richard.purdie@linuxfoundation.org> wrote: >> > If you look at the way the SDK toolchain works in Poky, it automatically >> > ships the versions of these libraries that it needs so we don't actually >> > have this problem. >> > >> >> Yes thats one way of doing it and if you got it working this is fine >> but there were issues when referencing >> due to ORIGIN mucking. So this was better and cleaner than we link in >> this libs into binary itself. > > The $ORIGIN stuff should be working just fine, have you checked this? > >> From >> my POV even this solution can be improved by adding the support libs >> to gcc build itself as sources >> then we dont need to muck with gcc build configury at all. I have been >> doing that for non OE related >> SDKs and has been best so far. > > As I mention above, I do think we have a solution for this which is > working... OK I think then I should withdraw this patch. ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCHv3 4/6] sanity.bbclass: Check for /proc/sys/vm/mmap_min_addr to be >= 65536 2011-03-03 6:52 [PATCH V2 0/6] Fixes to get oe-core building Khem Raj ` (2 preceding siblings ...) 2011-03-03 6:52 ` [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc Khem Raj @ 2011-03-03 6:52 ` Khem Raj 2011-03-03 7:15 ` Martin Jansa 2011-03-03 6:52 ` [PATCHv3 5/6] poky-default.inc: Change LINUXLIBCVERSION "2.6.36" -> "2.6.37.2" Khem Raj 2011-03-03 6:52 ` [PATCHv3 6/6] rpm: Fix linking error encountered in rpm-native Khem Raj 5 siblings, 1 reply; 28+ messages in thread From: Khem Raj @ 2011-03-03 6:52 UTC (permalink / raw) To: openembedded-core * Now qemu can handle lower values we can chnage this sanity test to check of values if less than 65536 Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/classes/sanity.bbclass | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass index 13940f8..aae5028 100644 --- a/meta/classes/sanity.bbclass +++ b/meta/classes/sanity.bbclass @@ -170,10 +170,12 @@ def check_sanity(e): # This path is no longer user-readable in modern (very recent) Linux try: if os.path.exists("/proc/sys/vm/mmap_min_addr"): - f = file("/proc/sys/vm/mmap_min_addr", "r") - if (f.read().strip() != "0"): - messages = messages + "/proc/sys/vm/mmap_min_addr is not 0. This will cause problems with qemu so please fix the value (as root).\n\nTo fix this in later reboots, set vm.mmap_min_addr = 0 in /etc/sysctl.conf.\n" - f.close() + f = open("/proc/sys/vm/mmap_min_addr", "r") + try: + if (int(f.read().strip()) < 65536): + messages = messages + "/proc/sys/vm/mmap_min_addr is not >= 65536. This will cause problems with qemu so please fix the value (as root).\n\nTo fix this in later reboots, set vm.mmap_min_addr = 65536 in /etc/sysctl.conf.\n" + finally: + f.close() except: pass -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCHv3 4/6] sanity.bbclass: Check for /proc/sys/vm/mmap_min_addr to be >= 65536 2011-03-03 6:52 ` [PATCHv3 4/6] sanity.bbclass: Check for /proc/sys/vm/mmap_min_addr to be >= 65536 Khem Raj @ 2011-03-03 7:15 ` Martin Jansa 2011-03-03 12:13 ` Richard Purdie 0 siblings, 1 reply; 28+ messages in thread From: Martin Jansa @ 2011-03-03 7:15 UTC (permalink / raw) To: Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 2296 bytes --] On Wed, Mar 02, 2011 at 10:52:45PM -0800, Khem Raj wrote: > * Now qemu can handle lower values we can chnage this sanity test > to check of values if less than 65536 > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/classes/sanity.bbclass | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass > index 13940f8..aae5028 100644 > --- a/meta/classes/sanity.bbclass > +++ b/meta/classes/sanity.bbclass > @@ -170,10 +170,12 @@ def check_sanity(e): > # This path is no longer user-readable in modern (very recent) Linux > try: > if os.path.exists("/proc/sys/vm/mmap_min_addr"): > - f = file("/proc/sys/vm/mmap_min_addr", "r") > - if (f.read().strip() != "0"): > - messages = messages + "/proc/sys/vm/mmap_min_addr is not 0. This will cause problems with qemu so please fix the value (as root).\n\nTo fix this in later reboots, set vm.mmap_min_addr = 0 in /etc/sysctl.conf.\n" > - f.close() > + f = open("/proc/sys/vm/mmap_min_addr", "r") > + try: > + if (int(f.read().strip()) < 65536): > + messages = messages + "/proc/sys/vm/mmap_min_addr is not >= 65536. This will cause problems with qemu so please fix the value (as root).\n\nTo fix this in later reboots, set vm.mmap_min_addr = 65536 in /etc/sysctl.conf.\n" > + finally: > + f.close() > except: > pass > corner cases when it cannot be read are with kernel between http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0e1a6ef2dea88101b056b6d9984f3325c5efced3 2.6.33-rc2-0e1a6ef2dea88101b056b6d9984f3325c5efced3 and http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=822cceec7248013821d655545ea45d1c6a9d15b3 2.6.34-rc3-822cceec7248013821d655545ea45d1c6a9d15b3 see: http://www.mail-archive.com/openembedded-devel@lists.openembedded.org/msg02340.html Don't know if any large distribution is using 2.6.34 without that 2nd patch backported. Regards, -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 4/6] sanity.bbclass: Check for /proc/sys/vm/mmap_min_addr to be >= 65536 2011-03-03 7:15 ` Martin Jansa @ 2011-03-03 12:13 ` Richard Purdie 2011-03-03 15:48 ` Khem Raj 0 siblings, 1 reply; 28+ messages in thread From: Richard Purdie @ 2011-03-03 12:13 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Thu, 2011-03-03 at 08:15 +0100, Martin Jansa wrote: > On Wed, Mar 02, 2011 at 10:52:45PM -0800, Khem Raj wrote: > > * Now qemu can handle lower values we can chnage this sanity test > > to check of values if less than 65536 > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > --- > > meta/classes/sanity.bbclass | 10 ++++++---- > > 1 files changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass > > index 13940f8..aae5028 100644 > > --- a/meta/classes/sanity.bbclass > > +++ b/meta/classes/sanity.bbclass > > @@ -170,10 +170,12 @@ def check_sanity(e): > > # This path is no longer user-readable in modern (very recent) Linux > > try: > > if os.path.exists("/proc/sys/vm/mmap_min_addr"): > > - f = file("/proc/sys/vm/mmap_min_addr", "r") > > - if (f.read().strip() != "0"): > > - messages = messages + "/proc/sys/vm/mmap_min_addr is not 0. This will cause problems with qemu so please fix the value (as root).\n\nTo fix this in later reboots, set vm.mmap_min_addr = 0 in /etc/sysctl.conf.\n" > > - f.close() > > + f = open("/proc/sys/vm/mmap_min_addr", "r") > > + try: > > + if (int(f.read().strip()) < 65536): > > + messages = messages + "/proc/sys/vm/mmap_min_addr is not >= 65536. This will cause problems with qemu so please fix the value (as root).\n\nTo fix this in later reboots, set vm.mmap_min_addr = 65536 in /etc/sysctl.conf.\n" > > + finally: > > + f.close() > > except: > > pass > > > > corner cases when it cannot be read are with kernel between > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0e1a6ef2dea88101b056b6d9984f3325c5efced3 > 2.6.33-rc2-0e1a6ef2dea88101b056b6d9984f3325c5efced3 > > and > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=822cceec7248013821d655545ea45d1c6a9d15b3 > 2.6.34-rc3-822cceec7248013821d655545ea45d1c6a9d15b3 > > see: > http://www.mail-archive.com/openembedded-devel@lists.openembedded.org/msg02340.html > > Don't know if any large distribution is using 2.6.34 without that 2nd > patch backported. My laptop at least is running a kernel where that file isn't readable :/. It isn't a standard distro one though. Cheers, Richard ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 4/6] sanity.bbclass: Check for /proc/sys/vm/mmap_min_addr to be >= 65536 2011-03-03 12:13 ` Richard Purdie @ 2011-03-03 15:48 ` Khem Raj 0 siblings, 0 replies; 28+ messages in thread From: Khem Raj @ 2011-03-03 15:48 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Thu, Mar 3, 2011 at 4:13 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > On Thu, 2011-03-03 at 08:15 +0100, Martin Jansa wrote: >> On Wed, Mar 02, 2011 at 10:52:45PM -0800, Khem Raj wrote: >> > * Now qemu can handle lower values we can chnage this sanity test >> > to check of values if less than 65536 >> > >> > Signed-off-by: Khem Raj <raj.khem@gmail.com> >> > --- >> > meta/classes/sanity.bbclass | 10 ++++++---- >> > 1 files changed, 6 insertions(+), 4 deletions(-) >> > >> > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass >> > index 13940f8..aae5028 100644 >> > --- a/meta/classes/sanity.bbclass >> > +++ b/meta/classes/sanity.bbclass >> > @@ -170,10 +170,12 @@ def check_sanity(e): >> > # This path is no longer user-readable in modern (very recent) Linux >> > try: >> > if os.path.exists("/proc/sys/vm/mmap_min_addr"): >> > - f = file("/proc/sys/vm/mmap_min_addr", "r") >> > - if (f.read().strip() != "0"): >> > - messages = messages + "/proc/sys/vm/mmap_min_addr is not 0. This will cause problems with qemu so please fix the value (as root).\n\nTo fix this in later reboots, set vm.mmap_min_addr = 0 in /etc/sysctl.conf.\n" >> > - f.close() >> > + f = open("/proc/sys/vm/mmap_min_addr", "r") >> > + try: >> > + if (int(f.read().strip()) < 65536): >> > + messages = messages + "/proc/sys/vm/mmap_min_addr is not >= 65536. This will cause problems with qemu so please fix the value (as root).\n\nTo fix this in later reboots, set vm.mmap_min_addr = 65536 in /etc/sysctl.conf.\n" >> > + finally: >> > + f.close() >> > except: >> > pass >> > >> >> corner cases when it cannot be read are with kernel between >> >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0e1a6ef2dea88101b056b6d9984f3325c5efced3 >> 2.6.33-rc2-0e1a6ef2dea88101b056b6d9984f3325c5efced3 >> >> and >> >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=822cceec7248013821d655545ea45d1c6a9d15b3 >> 2.6.34-rc3-822cceec7248013821d655545ea45d1c6a9d15b3 >> >> see: >> http://www.mail-archive.com/openembedded-devel@lists.openembedded.org/msg02340.html >> >> Don't know if any large distribution is using 2.6.34 without that 2nd >> patch backported. > > My laptop at least is running a kernel where that file isn't > readable :/. It isn't a standard distro one though. > see v3 ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCHv3 5/6] poky-default.inc: Change LINUXLIBCVERSION "2.6.36" -> "2.6.37.2" 2011-03-03 6:52 [PATCH V2 0/6] Fixes to get oe-core building Khem Raj ` (3 preceding siblings ...) 2011-03-03 6:52 ` [PATCHv3 4/6] sanity.bbclass: Check for /proc/sys/vm/mmap_min_addr to be >= 65536 Khem Raj @ 2011-03-03 6:52 ` Khem Raj 2011-03-08 6:39 ` Khem Raj 2011-03-08 18:48 ` Richard Purdie 2011-03-03 6:52 ` [PATCHv3 6/6] rpm: Fix linking error encountered in rpm-native Khem Raj 5 siblings, 2 replies; 28+ messages in thread From: Khem Raj @ 2011-03-03 6:52 UTC (permalink / raw) To: openembedded-core Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/conf/distro/include/poky-default.inc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/meta/conf/distro/include/poky-default.inc b/meta/conf/distro/include/poky-default.inc index ef9f5cf..3ec5e1d 100644 --- a/meta/conf/distro/include/poky-default.inc +++ b/meta/conf/distro/include/poky-default.inc @@ -19,7 +19,7 @@ GCCVERSION ?= "4.5.1" SDKGCCVERSION ?= "4.5.1" BINUVERSION ?= "2.21" GLIBCVERSION ?= "2.10.1" -LINUXLIBCVERSION ?= "2.6.36" +LINUXLIBCVERSION ?= "2.6.37.2" # Temporary preferred version overrides for PPC PREFERRED_VERSION_u-boot-mkimage-native_powerpc ?= "2009.08" -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCHv3 5/6] poky-default.inc: Change LINUXLIBCVERSION "2.6.36" -> "2.6.37.2" 2011-03-03 6:52 ` [PATCHv3 5/6] poky-default.inc: Change LINUXLIBCVERSION "2.6.36" -> "2.6.37.2" Khem Raj @ 2011-03-08 6:39 ` Khem Raj 2011-03-08 18:48 ` Richard Purdie 1 sibling, 0 replies; 28+ messages in thread From: Khem Raj @ 2011-03-08 6:39 UTC (permalink / raw) To: openembedded-core ping On Wed, Mar 2, 2011 at 10:52 PM, Khem Raj <raj.khem@gmail.com> wrote: > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/conf/distro/include/poky-default.inc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/meta/conf/distro/include/poky-default.inc b/meta/conf/distro/include/poky-default.inc > index ef9f5cf..3ec5e1d 100644 > --- a/meta/conf/distro/include/poky-default.inc > +++ b/meta/conf/distro/include/poky-default.inc > @@ -19,7 +19,7 @@ GCCVERSION ?= "4.5.1" > SDKGCCVERSION ?= "4.5.1" > BINUVERSION ?= "2.21" > GLIBCVERSION ?= "2.10.1" > -LINUXLIBCVERSION ?= "2.6.36" > +LINUXLIBCVERSION ?= "2.6.37.2" > > # Temporary preferred version overrides for PPC > PREFERRED_VERSION_u-boot-mkimage-native_powerpc ?= "2009.08" > -- > 1.7.4.1 > > ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 5/6] poky-default.inc: Change LINUXLIBCVERSION "2.6.36" -> "2.6.37.2" 2011-03-03 6:52 ` [PATCHv3 5/6] poky-default.inc: Change LINUXLIBCVERSION "2.6.36" -> "2.6.37.2" Khem Raj 2011-03-08 6:39 ` Khem Raj @ 2011-03-08 18:48 ` Richard Purdie 1 sibling, 0 replies; 28+ messages in thread From: Richard Purdie @ 2011-03-08 18:48 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Wed, 2011-03-02 at 22:52 -0800, Khem Raj wrote: > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/conf/distro/include/poky-default.inc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/meta/conf/distro/include/poky-default.inc b/meta/conf/distro/include/poky-default.inc > index ef9f5cf..3ec5e1d 100644 > --- a/meta/conf/distro/include/poky-default.inc > +++ b/meta/conf/distro/include/poky-default.inc > @@ -19,7 +19,7 @@ GCCVERSION ?= "4.5.1" > SDKGCCVERSION ?= "4.5.1" > BINUVERSION ?= "2.21" > GLIBCVERSION ?= "2.10.1" > -LINUXLIBCVERSION ?= "2.6.36" > +LINUXLIBCVERSION ?= "2.6.37.2" > > # Temporary preferred version overrides for PPC > PREFERRED_VERSION_u-boot-mkimage-native_powerpc ?= "2009.08" Merged to master, thanks. Richard ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCHv3 6/6] rpm: Fix linking error encountered in rpm-native 2011-03-03 6:52 [PATCH V2 0/6] Fixes to get oe-core building Khem Raj ` (4 preceding siblings ...) 2011-03-03 6:52 ` [PATCHv3 5/6] poky-default.inc: Change LINUXLIBCVERSION "2.6.36" -> "2.6.37.2" Khem Raj @ 2011-03-03 6:52 ` Khem Raj 2011-03-03 12:07 ` Richard Purdie 5 siblings, 1 reply; 28+ messages in thread From: Khem Raj @ 2011-03-03 6:52 UTC (permalink / raw) To: openembedded-core * This patch passes the correct LDFLAGS to account for additional dependencies of librpmio on libbeecrypt and libsyck and hence fixes the build error. Signed-off-by: Khem Raj <raj.khem@gmail.com> --- .../rpm/rpm/rpm-tools-mtree-LDFLAGS.patch | 13 +++++++++++++ meta/recipes-devtools/rpm/rpm_5.4.0.bb | 3 ++- 2 files changed, 15 insertions(+), 1 deletions(-) create mode 100644 meta/recipes-devtools/rpm/rpm/rpm-tools-mtree-LDFLAGS.patch diff --git a/meta/recipes-devtools/rpm/rpm/rpm-tools-mtree-LDFLAGS.patch b/meta/recipes-devtools/rpm/rpm/rpm-tools-mtree-LDFLAGS.patch new file mode 100644 index 0000000..347d976 --- /dev/null +++ b/meta/recipes-devtools/rpm/rpm/rpm-tools-mtree-LDFLAGS.patch @@ -0,0 +1,13 @@ +Index: rpm-5.4.0/tools/Makefile.am +=================================================================== +--- rpm-5.4.0.orig/tools/Makefile.am ++++ rpm-5.4.0/tools/Makefile.am +@@ -169,7 +169,7 @@ grep_LDADD = $(RPMIO_LDADD_COMMON) + + mtree_SOURCES = rpmmtree.c + mtree_LDFLAGS = @LDFLAGS_STATIC@ $(LDFLAGS) +-mtree_LDADD = $(RPM_LDADD_COMMON) ++mtree_LDADD = $(RPMIO_LDADD_COMMON) + + rpmrepo_SOURCES = rpmrepo.c + rpmrepo_CPPFLAGS = $(AM_CPPFLAGS) -I$(top_srcdir)/scripts -I$(top_builddir)/scripts $(CPPFLAGS) diff --git a/meta/recipes-devtools/rpm/rpm_5.4.0.bb b/meta/recipes-devtools/rpm/rpm_5.4.0.bb index 0003f48..3704816 100644 --- a/meta/recipes-devtools/rpm/rpm_5.4.0.bb +++ b/meta/recipes-devtools/rpm/rpm_5.4.0.bb @@ -43,7 +43,7 @@ LICENSE = "LGPL 2.1" LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1" DEPENDS = "bzip2 zlib python perl db openssl elfutils expat libpcre attr acl popt" -PR = "r13" +PR = "r14" # rpm2cpio is a shell script, which is part of the rpm src.rpm. It is needed # in order to extract the distribution SRPM into a format we can extract... @@ -56,6 +56,7 @@ SRC_URI = "http://www.rpm5.org/files/rpm/rpm-5.4/rpm-5.4.0-0.20101229.src.rpm;ex file://rpm-showrc.patch \ file://rpm-nofsync.patch \ file://rpm-solvedb.patch \ + file://rpm-tools-mtree-LDFLAGS.patch \ " # file://hdraddorappend.patch \ -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCHv3 6/6] rpm: Fix linking error encountered in rpm-native 2011-03-03 6:52 ` [PATCHv3 6/6] rpm: Fix linking error encountered in rpm-native Khem Raj @ 2011-03-03 12:07 ` Richard Purdie 2011-03-03 12:43 ` Koen Kooi 0 siblings, 1 reply; 28+ messages in thread From: Richard Purdie @ 2011-03-03 12:07 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Hi Khem, On Wed, 2011-03-02 at 22:52 -0800, Khem Raj wrote: > * This patch passes the correct LDFLAGS to account for > additional dependencies of librpmio on libbeecrypt and libsyck > and hence fixes the build error. This change is fine in itself but I'm going to be a little critical here since we're just getting going and I want to start as we mean to go on. Could you add a description of the problem and why the fix is needed to the patch header please, also adding your name and a date. The reason why is so in six months time, someone looking at this can work out a) why the patch is needed, b) Who wrote it so they have some idea where it came from and who to talk to if they have a question and c) How long the issue has been around for. I appreciate some of this info can be got through the SCM but I've yet to see a good reason for not including it directly in the patch header. Cheers, Richard > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > .../rpm/rpm/rpm-tools-mtree-LDFLAGS.patch | 13 +++++++++++++ > meta/recipes-devtools/rpm/rpm_5.4.0.bb | 3 ++- > 2 files changed, 15 insertions(+), 1 deletions(-) > create mode 100644 meta/recipes-devtools/rpm/rpm/rpm-tools-mtree-LDFLAGS.patch > > diff --git a/meta/recipes-devtools/rpm/rpm/rpm-tools-mtree-LDFLAGS.patch b/meta/recipes-devtools/rpm/rpm/rpm-tools-mtree-LDFLAGS.patch > new file mode 100644 > index 0000000..347d976 > --- /dev/null > +++ b/meta/recipes-devtools/rpm/rpm/rpm-tools-mtree-LDFLAGS.patch > @@ -0,0 +1,13 @@ > +Index: rpm-5.4.0/tools/Makefile.am > +=================================================================== > +--- rpm-5.4.0.orig/tools/Makefile.am > ++++ rpm-5.4.0/tools/Makefile.am > +@@ -169,7 +169,7 @@ grep_LDADD = $(RPMIO_LDADD_COMMON) > + > + mtree_SOURCES = rpmmtree.c > + mtree_LDFLAGS = @LDFLAGS_STATIC@ $(LDFLAGS) > +-mtree_LDADD = $(RPM_LDADD_COMMON) > ++mtree_LDADD = $(RPMIO_LDADD_COMMON) > + > + rpmrepo_SOURCES = rpmrepo.c > + rpmrepo_CPPFLAGS = $(AM_CPPFLAGS) -I$(top_srcdir)/scripts -I$(top_builddir)/scripts $(CPPFLAGS) > diff --git a/meta/recipes-devtools/rpm/rpm_5.4.0.bb b/meta/recipes-devtools/rpm/rpm_5.4.0.bb > index 0003f48..3704816 100644 > --- a/meta/recipes-devtools/rpm/rpm_5.4.0.bb > +++ b/meta/recipes-devtools/rpm/rpm_5.4.0.bb > @@ -43,7 +43,7 @@ LICENSE = "LGPL 2.1" > LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1" > > DEPENDS = "bzip2 zlib python perl db openssl elfutils expat libpcre attr acl popt" > -PR = "r13" > +PR = "r14" > > # rpm2cpio is a shell script, which is part of the rpm src.rpm. It is needed > # in order to extract the distribution SRPM into a format we can extract... > @@ -56,6 +56,7 @@ SRC_URI = "http://www.rpm5.org/files/rpm/rpm-5.4/rpm-5.4.0-0.20101229.src.rpm;ex > file://rpm-showrc.patch \ > file://rpm-nofsync.patch \ > file://rpm-solvedb.patch \ > + file://rpm-tools-mtree-LDFLAGS.patch \ > " > > # file://hdraddorappend.patch \ ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCHv3 6/6] rpm: Fix linking error encountered in rpm-native 2011-03-03 12:07 ` Richard Purdie @ 2011-03-03 12:43 ` Koen Kooi 0 siblings, 0 replies; 28+ messages in thread From: Koen Kooi @ 2011-03-03 12:43 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Op 3 mrt 2011, om 13:07 heeft Richard Purdie het volgende geschreven: > Hi Khem, > > On Wed, 2011-03-02 at 22:52 -0800, Khem Raj wrote: >> * This patch passes the correct LDFLAGS to account for >> additional dependencies of librpmio on libbeecrypt and libsyck >> and hence fixes the build error. > > This change is fine in itself but I'm going to be a little critical here > since we're just getting going and I want to start as we mean to go on. > > Could you add a description of the problem and why the fix is needed to > the patch header please, also adding your name and a date. > > The reason why is so in six months time, someone looking at this can > work out a) why the patch is needed, b) Who wrote it so they have some > idea where it came from and who to talk to if they have a question and > c) How long the issue has been around for. > > I appreciate some of this info can be got through the SCM but I've yet > to see a good reason for not including it directly in the patch header. I have customers that make tarball snapshots of OE without the .git, so please put a lot of info in patch headers. regards, Koen ^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2011-03-16 17:19 UTC | newest] Thread overview: 28+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-03-03 6:52 [PATCH V2 0/6] Fixes to get oe-core building Khem Raj 2011-03-03 6:52 ` [PATCHv3 1/6] sqlite3: Update version 3.7.3 -> 3.7.5 Khem Raj 2011-03-03 6:52 ` [PATCHv3 2/6] distro_tracking_fields.inc: Use 2.6.37.2 instead of 2.6.36 for linux-libc-headers Khem Raj 2011-03-08 6:39 ` Khem Raj 2011-03-08 18:51 ` Richard Purdie 2011-03-03 6:52 ` [PATCHv3 3/6] gcc: Statically link in support libraries e.g. libmpfr libgmp etc Khem Raj 2011-03-08 6:38 ` Khem Raj 2011-03-08 18:53 ` Richard Purdie 2011-03-08 19:04 ` Khem Raj 2011-03-12 12:50 ` Richard Purdie 2011-03-14 16:50 ` Tom Rini 2011-03-14 19:54 ` Richard Purdie 2011-03-15 17:33 ` Tom Rini 2011-03-16 13:27 ` Richard Purdie 2011-03-16 17:17 ` Tom Rini 2011-03-14 17:52 ` Khem Raj 2011-03-14 18:01 ` Richard Purdie 2011-03-14 18:42 ` Khem Raj 2011-03-03 6:52 ` [PATCHv3 4/6] sanity.bbclass: Check for /proc/sys/vm/mmap_min_addr to be >= 65536 Khem Raj 2011-03-03 7:15 ` Martin Jansa 2011-03-03 12:13 ` Richard Purdie 2011-03-03 15:48 ` Khem Raj 2011-03-03 6:52 ` [PATCHv3 5/6] poky-default.inc: Change LINUXLIBCVERSION "2.6.36" -> "2.6.37.2" Khem Raj 2011-03-08 6:39 ` Khem Raj 2011-03-08 18:48 ` Richard Purdie 2011-03-03 6:52 ` [PATCHv3 6/6] rpm: Fix linking error encountered in rpm-native Khem Raj 2011-03-03 12:07 ` Richard Purdie 2011-03-03 12:43 ` Koen Kooi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox