* [PATCH 1/4] perl: Add auto/XS/Typemap in perl-doc package
@ 2013-02-16 21:20 Otavio Salvador
2013-02-16 21:20 ` [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature Otavio Salvador
` (2 more replies)
0 siblings, 3 replies; 16+ messages in thread
From: Otavio Salvador @ 2013-02-16 21:20 UTC (permalink / raw)
To: OpenEmbedded Core Mailing List; +Cc: Otavio Salvador
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
meta/recipes-devtools/perl/perl_5.14.3.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-devtools/perl/perl_5.14.3.bb b/meta/recipes-devtools/perl/perl_5.14.3.bb
index 2e33e66..6a3a170 100644
--- a/meta/recipes-devtools/perl/perl_5.14.3.bb
+++ b/meta/recipes-devtools/perl/perl_5.14.3.bb
@@ -269,6 +269,7 @@ FILES_${PN}-dbg += "${libdir}/perl/${PV}/auto/*/.debug \
${libdir}/perl/${PV}/*/*/*/.debug "
FILES_${PN}-doc = "${libdir}/perl/${PV}/*/*.txt \
${libdir}/perl/${PV}/*/*/*.txt \
+ ${libdir}/perl/${PV}/auto/XS/Typemap \
${libdir}/perl/${PV}/B/assemble \
${libdir}/perl/${PV}/B/cc_harness \
${libdir}/perl/${PV}/B/disassemble \
--
1.8.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature
2013-02-16 21:20 [PATCH 1/4] perl: Add auto/XS/Typemap in perl-doc package Otavio Salvador
@ 2013-02-16 21:20 ` Otavio Salvador
2013-02-17 7:47 ` Richard Purdie
2013-02-16 21:20 ` [PATCH 3/4] libsdl: Use 'virtual/libx11' instead of hardcoding nativesdk-libx11 Otavio Salvador
2013-02-16 21:20 ` [PATCH 4/4] qt4-tools: Drop libx11 dependency when building without 'x11' distro feature Otavio Salvador
2 siblings, 1 reply; 16+ messages in thread
From: Otavio Salvador @ 2013-02-16 21:20 UTC (permalink / raw)
To: OpenEmbedded Core Mailing List; +Cc: Otavio Salvador
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
meta/recipes-core/dbus/dbus.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
index 292ab29..cebab28 100644
--- a/meta/recipes-core/dbus/dbus.inc
+++ b/meta/recipes-core/dbus/dbus.inc
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
X11DEPENDS = "virtual/libx11 libsm"
DEPENDS = "expat virtual/libintl ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
DEPENDS_class-native = "expat-native virtual/libintl-native"
-DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl virtual/libx11"
+DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
RDEPENDS_class-native = ""
--
1.8.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 3/4] libsdl: Use 'virtual/libx11' instead of hardcoding nativesdk-libx11
2013-02-16 21:20 [PATCH 1/4] perl: Add auto/XS/Typemap in perl-doc package Otavio Salvador
2013-02-16 21:20 ` [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature Otavio Salvador
@ 2013-02-16 21:20 ` Otavio Salvador
2013-02-17 7:52 ` Richard Purdie
2013-02-16 21:20 ` [PATCH 4/4] qt4-tools: Drop libx11 dependency when building without 'x11' distro feature Otavio Salvador
2 siblings, 1 reply; 16+ messages in thread
From: Otavio Salvador @ 2013-02-16 21:20 UTC (permalink / raw)
To: OpenEmbedded Core Mailing List; +Cc: Otavio Salvador
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
meta/recipes-graphics/libsdl/libsdl_1.2.15.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
index e25c597..3dbe97a 100644
--- a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
+++ b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
@@ -16,7 +16,7 @@ DEPENDS = "${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)} \
${@base_contains('DISTRO_FEATURES', 'opengl', 'virtual/libgl', '', d)} \
${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxext libxrandr libxrender', '', d)} \
tslib"
-DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'nativesdk-libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}"
+DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}"
PR = "r1"
--
1.8.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 4/4] qt4-tools: Drop libx11 dependency when building without 'x11' distro feature
2013-02-16 21:20 [PATCH 1/4] perl: Add auto/XS/Typemap in perl-doc package Otavio Salvador
2013-02-16 21:20 ` [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature Otavio Salvador
2013-02-16 21:20 ` [PATCH 3/4] libsdl: Use 'virtual/libx11' instead of hardcoding nativesdk-libx11 Otavio Salvador
@ 2013-02-16 21:20 ` Otavio Salvador
2 siblings, 0 replies; 16+ messages in thread
From: Otavio Salvador @ 2013-02-16 21:20 UTC (permalink / raw)
To: OpenEmbedded Core Mailing List; +Cc: Otavio Salvador
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
meta/recipes-qt/qt4/nativesdk-qt4-tools.inc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc b/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
index cfc6fd8..564f1d2 100644
--- a/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
+++ b/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
@@ -1,10 +1,10 @@
DESCRIPTION = "SDK tools for Qt/[X11|Mac|Embedded] version 4.x"
-DEPENDS = "nativesdk-zlib nativesdk-dbus nativesdk-libx11 qt4-native"
+DEPENDS = "nativesdk-zlib nativesdk-dbus ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)} qt4-native"
SECTION = "libs"
HOMEPAGE = "http://qt.nokia.com"
LICENSE = "LGPLv2.1 | GPLv3"
-INC_PR = "r13"
+INC_PR = "r14"
FILESEXTRAPATHS =. "${FILE_DIRNAME}/qt4-${PV}:"
--
1.8.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature
2013-02-16 21:20 ` [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature Otavio Salvador
@ 2013-02-17 7:47 ` Richard Purdie
2013-02-17 13:40 ` Otavio Salvador
0 siblings, 1 reply; 16+ messages in thread
From: Richard Purdie @ 2013-02-17 7:47 UTC (permalink / raw)
To: Otavio Salvador; +Cc: OpenEmbedded Core Mailing List
On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> meta/recipes-core/dbus/dbus.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
> index 292ab29..cebab28 100644
> --- a/meta/recipes-core/dbus/dbus.inc
> +++ b/meta/recipes-core/dbus/dbus.inc
> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
> X11DEPENDS = "virtual/libx11 libsm"
> DEPENDS = "expat virtual/libintl ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
> DEPENDS_class-native = "expat-native virtual/libintl-native"
> -DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl virtual/libx11"
> +DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
> RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
> RDEPENDS_class-native = ""
This tends to be a really bad idea for dbus-nativesdk. If you install an
SDK compiled with these options into PATH only a system which does have
x11, it will break functionality in a way unacceptable to users.
I'm not sure we should ever ship dbus-launch with the SDK so perhaps we
should just delete it like we now do for the -native version, then we
could drop the x11 requirement in all cases.
Cheers,
Richard
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/4] libsdl: Use 'virtual/libx11' instead of hardcoding nativesdk-libx11
2013-02-16 21:20 ` [PATCH 3/4] libsdl: Use 'virtual/libx11' instead of hardcoding nativesdk-libx11 Otavio Salvador
@ 2013-02-17 7:52 ` Richard Purdie
2013-02-17 13:42 ` Otavio Salvador
0 siblings, 1 reply; 16+ messages in thread
From: Richard Purdie @ 2013-02-17 7:52 UTC (permalink / raw)
To: Otavio Salvador; +Cc: OpenEmbedded Core Mailing List
On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> meta/recipes-graphics/libsdl/libsdl_1.2.15.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
> index e25c597..3dbe97a 100644
> --- a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
> +++ b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
> @@ -16,7 +16,7 @@ DEPENDS = "${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)} \
> ${@base_contains('DISTRO_FEATURES', 'opengl', 'virtual/libgl', '', d)} \
> ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxext libxrandr libxrender', '', d)} \
> tslib"
> -DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'nativesdk-libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}"
> +DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}"
Don't you mean virtual/nativesdk-libx11 ?
Cheers,
Richard
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature
2013-02-17 7:47 ` Richard Purdie
@ 2013-02-17 13:40 ` Otavio Salvador
2013-02-17 13:44 ` Richard Purdie
0 siblings, 1 reply; 16+ messages in thread
From: Otavio Salvador @ 2013-02-17 13:40 UTC (permalink / raw)
To: Richard Purdie; +Cc: OpenEmbedded Core Mailing List
On Sun, Feb 17, 2013 at 4:47 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> meta/recipes-core/dbus/dbus.inc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
>> index 292ab29..cebab28 100644
>> --- a/meta/recipes-core/dbus/dbus.inc
>> +++ b/meta/recipes-core/dbus/dbus.inc
>> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
>> X11DEPENDS = "virtual/libx11 libsm"
>> DEPENDS = "expat virtual/libintl ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
>> DEPENDS_class-native = "expat-native virtual/libintl-native"
>> -DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl virtual/libx11"
>> +DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
>> RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
>> RDEPENDS_class-native = ""
>
> This tends to be a really bad idea for dbus-nativesdk. If you install an
> SDK compiled with these options into PATH only a system which does have
> x11, it will break functionality in a way unacceptable to users.
I don't see how it'd break anything being deployed in a toolchain. We
don't initialize the dbus daemon so it is mostly used to fulfill
dependencies.
> I'm not sure we should ever ship dbus-launch with the SDK so perhaps we
> should just delete it like we now do for the -native version, then we
> could drop the x11 requirement in all cases.
That could be an option (ignore x11 feature for nativesdk) and it does
make some sense.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/4] libsdl: Use 'virtual/libx11' instead of hardcoding nativesdk-libx11
2013-02-17 7:52 ` Richard Purdie
@ 2013-02-17 13:42 ` Otavio Salvador
2013-02-17 13:46 ` Richard Purdie
0 siblings, 1 reply; 16+ messages in thread
From: Otavio Salvador @ 2013-02-17 13:42 UTC (permalink / raw)
To: Richard Purdie; +Cc: OpenEmbedded Core Mailing List
On Sun, Feb 17, 2013 at 4:52 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> meta/recipes-graphics/libsdl/libsdl_1.2.15.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
>> index e25c597..3dbe97a 100644
>> --- a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
>> +++ b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
>> @@ -16,7 +16,7 @@ DEPENDS = "${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)} \
>> ${@base_contains('DISTRO_FEATURES', 'opengl', 'virtual/libgl', '', d)} \
>> ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxext libxrandr libxrender', '', d)} \
>> tslib"
>> -DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'nativesdk-libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}"
>> +DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}"
>
> Don't you mean virtual/nativesdk-libx11 ?
Other places are using virtual/libx11 so I sticked to it. For me it
has worked but I did not change if it'd choose the right package when
building with 'x11' (as my project now builds without it).
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature
2013-02-17 13:40 ` Otavio Salvador
@ 2013-02-17 13:44 ` Richard Purdie
2013-02-17 13:55 ` Otavio Salvador
0 siblings, 1 reply; 16+ messages in thread
From: Richard Purdie @ 2013-02-17 13:44 UTC (permalink / raw)
To: Otavio Salvador; +Cc: OpenEmbedded Core Mailing List
On Sun, 2013-02-17 at 10:40 -0300, Otavio Salvador wrote:
> On Sun, Feb 17, 2013 at 4:47 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> ---
> >> meta/recipes-core/dbus/dbus.inc | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
> >> index 292ab29..cebab28 100644
> >> --- a/meta/recipes-core/dbus/dbus.inc
> >> +++ b/meta/recipes-core/dbus/dbus.inc
> >> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
> >> X11DEPENDS = "virtual/libx11 libsm"
> >> DEPENDS = "expat virtual/libintl ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
> >> DEPENDS_class-native = "expat-native virtual/libintl-native"
> >> -DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl virtual/libx11"
> >> +DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
> >> RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
> >> RDEPENDS_class-native = ""
> >
> > This tends to be a really bad idea for dbus-nativesdk. If you install an
> > SDK compiled with these options into PATH only a system which does have
> > x11, it will break functionality in a way unacceptable to users.
>
> I don't see how it'd break anything being deployed in a toolchain. We
> don't initialize the dbus daemon so it is mostly used to fulfill
> dependencies.
Imagine you source the toolchain setup script. The limited functionality
dbus-launch just got into PATH. Now you run some X application. Things
break.
Cheers,
Richard
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/4] libsdl: Use 'virtual/libx11' instead of hardcoding nativesdk-libx11
2013-02-17 13:42 ` Otavio Salvador
@ 2013-02-17 13:46 ` Richard Purdie
2013-02-17 13:55 ` Otavio Salvador
0 siblings, 1 reply; 16+ messages in thread
From: Richard Purdie @ 2013-02-17 13:46 UTC (permalink / raw)
To: Otavio Salvador; +Cc: OpenEmbedded Core Mailing List
On Sun, 2013-02-17 at 10:42 -0300, Otavio Salvador wrote:
> On Sun, Feb 17, 2013 at 4:52 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> ---
> >> meta/recipes-graphics/libsdl/libsdl_1.2.15.bb | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
> >> index e25c597..3dbe97a 100644
> >> --- a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
> >> +++ b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
> >> @@ -16,7 +16,7 @@ DEPENDS = "${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)} \
> >> ${@base_contains('DISTRO_FEATURES', 'opengl', 'virtual/libgl', '', d)} \
> >> ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxext libxrandr libxrender', '', d)} \
> >> tslib"
> >> -DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'nativesdk-libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}"
> >> +DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}"
> >
> > Don't you mean virtual/nativesdk-libx11 ?
>
> Other places are using virtual/libx11 so I sticked to it.
Other places in nativesdk overrides?
> For me it
> has worked but I did not change if it'd choose the right package when
> building with 'x11' (as my project now builds without it).
That doesn't make it correct.
Cheers,
Richard
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature
2013-02-17 13:44 ` Richard Purdie
@ 2013-02-17 13:55 ` Otavio Salvador
2013-02-17 14:48 ` Richard Purdie
0 siblings, 1 reply; 16+ messages in thread
From: Otavio Salvador @ 2013-02-17 13:55 UTC (permalink / raw)
To: Richard Purdie; +Cc: OpenEmbedded Core Mailing List
On Sun, Feb 17, 2013 at 10:44 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Sun, 2013-02-17 at 10:40 -0300, Otavio Salvador wrote:
>> On Sun, Feb 17, 2013 at 4:47 AM, Richard Purdie
>> <richard.purdie@linuxfoundation.org> wrote:
>> > On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
>> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> >> ---
>> >> meta/recipes-core/dbus/dbus.inc | 2 +-
>> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
>> >> index 292ab29..cebab28 100644
>> >> --- a/meta/recipes-core/dbus/dbus.inc
>> >> +++ b/meta/recipes-core/dbus/dbus.inc
>> >> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
>> >> X11DEPENDS = "virtual/libx11 libsm"
>> >> DEPENDS = "expat virtual/libintl ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
>> >> DEPENDS_class-native = "expat-native virtual/libintl-native"
>> >> -DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl virtual/libx11"
>> >> +DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
>> >> RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
>> >> RDEPENDS_class-native = ""
>> >
>> > This tends to be a really bad idea for dbus-nativesdk. If you install an
>> > SDK compiled with these options into PATH only a system which does have
>> > x11, it will break functionality in a way unacceptable to users.
>>
>> I don't see how it'd break anything being deployed in a toolchain. We
>> don't initialize the dbus daemon so it is mostly used to fulfill
>> dependencies.
>
> Imagine you source the toolchain setup script. The limited functionality
> dbus-launch just got into PATH. Now you run some X application. Things
> break.
You usually to not source the env script and run your X server on top
of it, I think. Personally I source it in a terminal session inside of
X and use it to build things only.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/4] libsdl: Use 'virtual/libx11' instead of hardcoding nativesdk-libx11
2013-02-17 13:46 ` Richard Purdie
@ 2013-02-17 13:55 ` Otavio Salvador
0 siblings, 0 replies; 16+ messages in thread
From: Otavio Salvador @ 2013-02-17 13:55 UTC (permalink / raw)
To: Richard Purdie; +Cc: OpenEmbedded Core Mailing List
On Sun, Feb 17, 2013 at 10:46 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Sun, 2013-02-17 at 10:42 -0300, Otavio Salvador wrote:
>> On Sun, Feb 17, 2013 at 4:52 AM, Richard Purdie
>> <richard.purdie@linuxfoundation.org> wrote:
>> > On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
>> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> >> ---
>> >> meta/recipes-graphics/libsdl/libsdl_1.2.15.bb | 2 +-
>> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
>> >> index e25c597..3dbe97a 100644
>> >> --- a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
>> >> +++ b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
>> >> @@ -16,7 +16,7 @@ DEPENDS = "${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)} \
>> >> ${@base_contains('DISTRO_FEATURES', 'opengl', 'virtual/libgl', '', d)} \
>> >> ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxext libxrandr libxrender', '', d)} \
>> >> tslib"
>> >> -DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'nativesdk-libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}"
>> >> +DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}"
>> >
>> > Don't you mean virtual/nativesdk-libx11 ?
>>
>> Other places are using virtual/libx11 so I sticked to it.
>
> Other places in nativesdk overrides?
Yes; I can check it again.
>> For me it
>> has worked but I did not change if it'd choose the right package when
>> building with 'x11' (as my project now builds without it).
>
> That doesn't make it correct.
I will check and post v2.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature
2013-02-17 13:55 ` Otavio Salvador
@ 2013-02-17 14:48 ` Richard Purdie
2013-02-17 14:52 ` Otavio Salvador
0 siblings, 1 reply; 16+ messages in thread
From: Richard Purdie @ 2013-02-17 14:48 UTC (permalink / raw)
To: Otavio Salvador; +Cc: OpenEmbedded Core Mailing List
On Sun, 2013-02-17 at 10:55 -0300, Otavio Salvador wrote:
> On Sun, Feb 17, 2013 at 10:44 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Sun, 2013-02-17 at 10:40 -0300, Otavio Salvador wrote:
> >> On Sun, Feb 17, 2013 at 4:47 AM, Richard Purdie
> >> <richard.purdie@linuxfoundation.org> wrote:
> >> > On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
> >> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> >> ---
> >> >> meta/recipes-core/dbus/dbus.inc | 2 +-
> >> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >>
> >> >> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
> >> >> index 292ab29..cebab28 100644
> >> >> --- a/meta/recipes-core/dbus/dbus.inc
> >> >> +++ b/meta/recipes-core/dbus/dbus.inc
> >> >> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
> >> >> X11DEPENDS = "virtual/libx11 libsm"
> >> >> DEPENDS = "expat virtual/libintl ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
> >> >> DEPENDS_class-native = "expat-native virtual/libintl-native"
> >> >> -DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl virtual/libx11"
> >> >> +DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
> >> >> RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
> >> >> RDEPENDS_class-native = ""
> >> >
> >> > This tends to be a really bad idea for dbus-nativesdk. If you install an
> >> > SDK compiled with these options into PATH only a system which does have
> >> > x11, it will break functionality in a way unacceptable to users.
> >>
> >> I don't see how it'd break anything being deployed in a toolchain. We
> >> don't initialize the dbus daemon so it is mostly used to fulfill
> >> dependencies.
> >
> > Imagine you source the toolchain setup script. The limited functionality
> > dbus-launch just got into PATH. Now you run some X application. Things
> > break.
>
> You usually to not source the env script and run your X server on top
> of it, I think. Personally I source it in a terminal session inside of
> X and use it to build things only.
No, but people do open a terminal in X and then source the script there,
then run other X applications from within the terminal window. Those X
applications can use dbus activation. A dbus-launch without x11 support
causes problems in this situation.
Cheers,
Richard
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature
2013-02-17 14:48 ` Richard Purdie
@ 2013-02-17 14:52 ` Otavio Salvador
2013-02-17 15:10 ` Richard Purdie
0 siblings, 1 reply; 16+ messages in thread
From: Otavio Salvador @ 2013-02-17 14:52 UTC (permalink / raw)
To: Richard Purdie; +Cc: OpenEmbedded Core Mailing List
On Sun, Feb 17, 2013 at 11:48 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Sun, 2013-02-17 at 10:55 -0300, Otavio Salvador wrote:
>> On Sun, Feb 17, 2013 at 10:44 AM, Richard Purdie
>> <richard.purdie@linuxfoundation.org> wrote:
>> > On Sun, 2013-02-17 at 10:40 -0300, Otavio Salvador wrote:
>> >> On Sun, Feb 17, 2013 at 4:47 AM, Richard Purdie
>> >> <richard.purdie@linuxfoundation.org> wrote:
>> >> > On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
>> >> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> >> >> ---
>> >> >> meta/recipes-core/dbus/dbus.inc | 2 +-
>> >> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >> >>
>> >> >> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
>> >> >> index 292ab29..cebab28 100644
>> >> >> --- a/meta/recipes-core/dbus/dbus.inc
>> >> >> +++ b/meta/recipes-core/dbus/dbus.inc
>> >> >> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
>> >> >> X11DEPENDS = "virtual/libx11 libsm"
>> >> >> DEPENDS = "expat virtual/libintl ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
>> >> >> DEPENDS_class-native = "expat-native virtual/libintl-native"
>> >> >> -DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl virtual/libx11"
>> >> >> +DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
>> >> >> RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
>> >> >> RDEPENDS_class-native = ""
>> >> >
>> >> > This tends to be a really bad idea for dbus-nativesdk. If you install an
>> >> > SDK compiled with these options into PATH only a system which does have
>> >> > x11, it will break functionality in a way unacceptable to users.
>> >>
>> >> I don't see how it'd break anything being deployed in a toolchain. We
>> >> don't initialize the dbus daemon so it is mostly used to fulfill
>> >> dependencies.
>> >
>> > Imagine you source the toolchain setup script. The limited functionality
>> > dbus-launch just got into PATH. Now you run some X application. Things
>> > break.
>>
>> You usually to not source the env script and run your X server on top
>> of it, I think. Personally I source it in a terminal session inside of
>> X and use it to build things only.
>
> No, but people do open a terminal in X and then source the script there,
> then run other X applications from within the terminal window. Those X
> applications can use dbus activation. A dbus-launch without x11 support
> causes problems in this situation.
Yes; got it.
So your idea is to avoid x11 dependency altogether and drop
dbus-launch to avoid this errors?
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature
2013-02-17 14:52 ` Otavio Salvador
@ 2013-02-17 15:10 ` Richard Purdie
2013-02-17 15:31 ` Otavio Salvador
0 siblings, 1 reply; 16+ messages in thread
From: Richard Purdie @ 2013-02-17 15:10 UTC (permalink / raw)
To: Otavio Salvador; +Cc: OpenEmbedded Core Mailing List
On Sun, 2013-02-17 at 11:52 -0300, Otavio Salvador wrote:
> On Sun, Feb 17, 2013 at 11:48 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Sun, 2013-02-17 at 10:55 -0300, Otavio Salvador wrote:
> >> On Sun, Feb 17, 2013 at 10:44 AM, Richard Purdie
> >> <richard.purdie@linuxfoundation.org> wrote:
> >> > On Sun, 2013-02-17 at 10:40 -0300, Otavio Salvador wrote:
> >> >> On Sun, Feb 17, 2013 at 4:47 AM, Richard Purdie
> >> >> <richard.purdie@linuxfoundation.org> wrote:
> >> >> > On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
> >> >> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> >> >> ---
> >> >> >> meta/recipes-core/dbus/dbus.inc | 2 +-
> >> >> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >> >>
> >> >> >> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
> >> >> >> index 292ab29..cebab28 100644
> >> >> >> --- a/meta/recipes-core/dbus/dbus.inc
> >> >> >> +++ b/meta/recipes-core/dbus/dbus.inc
> >> >> >> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
> >> >> >> X11DEPENDS = "virtual/libx11 libsm"
> >> >> >> DEPENDS = "expat virtual/libintl ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
> >> >> >> DEPENDS_class-native = "expat-native virtual/libintl-native"
> >> >> >> -DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl virtual/libx11"
> >> >> >> +DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
> >> >> >> RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
> >> >> >> RDEPENDS_class-native = ""
> >> >> >
> >> >> > This tends to be a really bad idea for dbus-nativesdk. If you install an
> >> >> > SDK compiled with these options into PATH only a system which does have
> >> >> > x11, it will break functionality in a way unacceptable to users.
> >> >>
> >> >> I don't see how it'd break anything being deployed in a toolchain. We
> >> >> don't initialize the dbus daemon so it is mostly used to fulfill
> >> >> dependencies.
> >> >
> >> > Imagine you source the toolchain setup script. The limited functionality
> >> > dbus-launch just got into PATH. Now you run some X application. Things
> >> > break.
> >>
> >> You usually to not source the env script and run your X server on top
> >> of it, I think. Personally I source it in a terminal session inside of
> >> X and use it to build things only.
> >
> > No, but people do open a terminal in X and then source the script there,
> > then run other X applications from within the terminal window. Those X
> > applications can use dbus activation. A dbus-launch without x11 support
> > causes problems in this situation.
>
> Yes; got it.
>
> So your idea is to avoid x11 dependency altogether and drop
> dbus-launch to avoid this errors?
Yes, I did the same thing with dbus-native for exactly this reason (e.g.
X apps from within a devshell). I didn't touch dbus-nativesdk since it
has the X dependency and I didn't think it was bothering anyone.
Cheers,
Richard
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature
2013-02-17 15:10 ` Richard Purdie
@ 2013-02-17 15:31 ` Otavio Salvador
0 siblings, 0 replies; 16+ messages in thread
From: Otavio Salvador @ 2013-02-17 15:31 UTC (permalink / raw)
To: Richard Purdie; +Cc: OpenEmbedded Core Mailing List
On Sun, Feb 17, 2013 at 12:10 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Sun, 2013-02-17 at 11:52 -0300, Otavio Salvador wrote:
>> On Sun, Feb 17, 2013 at 11:48 AM, Richard Purdie
>> <richard.purdie@linuxfoundation.org> wrote:
>> > On Sun, 2013-02-17 at 10:55 -0300, Otavio Salvador wrote:
>> >> On Sun, Feb 17, 2013 at 10:44 AM, Richard Purdie
>> >> <richard.purdie@linuxfoundation.org> wrote:
>> >> > On Sun, 2013-02-17 at 10:40 -0300, Otavio Salvador wrote:
>> >> >> On Sun, Feb 17, 2013 at 4:47 AM, Richard Purdie
>> >> >> <richard.purdie@linuxfoundation.org> wrote:
>> >> >> > On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
>> >> >> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> >> >> >> ---
>> >> >> >> meta/recipes-core/dbus/dbus.inc | 2 +-
>> >> >> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >> >> >>
>> >> >> >> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
>> >> >> >> index 292ab29..cebab28 100644
>> >> >> >> --- a/meta/recipes-core/dbus/dbus.inc
>> >> >> >> +++ b/meta/recipes-core/dbus/dbus.inc
>> >> >> >> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
>> >> >> >> X11DEPENDS = "virtual/libx11 libsm"
>> >> >> >> DEPENDS = "expat virtual/libintl ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
>> >> >> >> DEPENDS_class-native = "expat-native virtual/libintl-native"
>> >> >> >> -DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl virtual/libx11"
>> >> >> >> +DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
>> >> >> >> RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
>> >> >> >> RDEPENDS_class-native = ""
>> >> >> >
>> >> >> > This tends to be a really bad idea for dbus-nativesdk. If you install an
>> >> >> > SDK compiled with these options into PATH only a system which does have
>> >> >> > x11, it will break functionality in a way unacceptable to users.
>> >> >>
>> >> >> I don't see how it'd break anything being deployed in a toolchain. We
>> >> >> don't initialize the dbus daemon so it is mostly used to fulfill
>> >> >> dependencies.
>> >> >
>> >> > Imagine you source the toolchain setup script. The limited functionality
>> >> > dbus-launch just got into PATH. Now you run some X application. Things
>> >> > break.
>> >>
>> >> You usually to not source the env script and run your X server on top
>> >> of it, I think. Personally I source it in a terminal session inside of
>> >> X and use it to build things only.
>> >
>> > No, but people do open a terminal in X and then source the script there,
>> > then run other X applications from within the terminal window. Those X
>> > applications can use dbus activation. A dbus-launch without x11 support
>> > causes problems in this situation.
>>
>> Yes; got it.
>>
>> So your idea is to avoid x11 dependency altogether and drop
>> dbus-launch to avoid this errors?
>
> Yes, I did the same thing with dbus-native for exactly this reason (e.g.
> X apps from within a devshell). I didn't touch dbus-nativesdk since it
> has the X dependency and I didn't think it was bothering anyone.
Ok; will make v2 with this change.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2013-02-17 15:48 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-16 21:20 [PATCH 1/4] perl: Add auto/XS/Typemap in perl-doc package Otavio Salvador
2013-02-16 21:20 ` [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature Otavio Salvador
2013-02-17 7:47 ` Richard Purdie
2013-02-17 13:40 ` Otavio Salvador
2013-02-17 13:44 ` Richard Purdie
2013-02-17 13:55 ` Otavio Salvador
2013-02-17 14:48 ` Richard Purdie
2013-02-17 14:52 ` Otavio Salvador
2013-02-17 15:10 ` Richard Purdie
2013-02-17 15:31 ` Otavio Salvador
2013-02-16 21:20 ` [PATCH 3/4] libsdl: Use 'virtual/libx11' instead of hardcoding nativesdk-libx11 Otavio Salvador
2013-02-17 7:52 ` Richard Purdie
2013-02-17 13:42 ` Otavio Salvador
2013-02-17 13:46 ` Richard Purdie
2013-02-17 13:55 ` Otavio Salvador
2013-02-16 21:20 ` [PATCH 4/4] qt4-tools: Drop libx11 dependency when building without 'x11' distro feature Otavio Salvador
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox