Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] stress-ng: add 0.05.09
@ 2016-01-26  3:34 Denys Dmytriyenko
  2016-01-26  4:36 ` Robert Yang
                   ` (2 more replies)
  0 siblings, 3 replies; 16+ messages in thread
From: Denys Dmytriyenko @ 2016-01-26  3:34 UTC (permalink / raw)
  To: openembedded-core; +Cc: Denys Dmytriyenko

From: Denys Dmytriyenko <denys@ti.com>

A clean room re-implementation and extension of the original stress tool.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
 meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb

diff --git a/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
new file mode 100644
index 0000000..2e92c53
--- /dev/null
+++ b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
@@ -0,0 +1,15 @@
+SUMMARY = "A tool to load and stress a computer system"
+HOMEPAGE = "http://kernel.ubuntu.com/~cking/stress-ng/"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+
+SRC_URI = "http://kernel.ubuntu.com/~cking/tarballs/${BPN}/${BP}.tar.gz"
+
+SRC_URI[md5sum] = "fe65047991f654ffaac3c59ea9537763"
+SRC_URI[sha256sum] = "d785b5f2df042d42c43ddfd5bbafa19151ed96f0c483d7f44c737f492b52ddd6"
+
+CFLAGS += "-Wall -Wextra -DVERSION='"$(VERSION)"' -O2"
+
+do_install() {
+	oe_runmake DESTDIR=${D} install
+}
-- 
2.2.0



^ permalink raw reply related	[flat|nested] 16+ messages in thread
* Re: [PATCH] stress-ng: add 0.05.09
  2016-01-26  3:34 [PATCH] stress-ng: add 0.05.09 Denys Dmytriyenko
@ 2016-01-26  4:36 ` Robert Yang
  2016-01-26  5:04   ` Denys Dmytriyenko
  2016-01-28  6:46   ` Mike Looijmans
  2016-01-26 11:24 ` Burton, Ross
  2016-01-26 16:01 ` Otavio Salvador
  2 siblings, 2 replies; 16+ messages in thread
From: Robert Yang @ 2016-01-26  4:36 UTC (permalink / raw)
  To: Denys Dmytriyenko, openembedded-core; +Cc: Denys Dmytriyenko



On 01/26/2016 11:34 AM, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko <denys@ti.com>
>
> A clean room re-implementation and extension of the original stress tool.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
>   meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
>   create mode 100644 meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
>
> diff --git a/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
> new file mode 100644
> index 0000000..2e92c53
> --- /dev/null
> +++ b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
> @@ -0,0 +1,15 @@
> +SUMMARY = "A tool to load and stress a computer system"
> +HOMEPAGE = "http://kernel.ubuntu.com/~cking/stress-ng/"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +
> +SRC_URI = "http://kernel.ubuntu.com/~cking/tarballs/${BPN}/${BP}.tar.gz"
> +
> +SRC_URI[md5sum] = "fe65047991f654ffaac3c59ea9537763"
> +SRC_URI[sha256sum] = "d785b5f2df042d42c43ddfd5bbafa19151ed96f0c483d7f44c737f492b52ddd6"
> +
> +CFLAGS += "-Wall -Wextra -DVERSION='"$(VERSION)"' -O2"

Why hardcode -O2, please ? It impacts the DEBUG_BUILD.

// Robert

> +
> +do_install() {
> +	oe_runmake DESTDIR=${D} install
> +}
>


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] stress-ng: add 0.05.09
  2016-01-26  4:36 ` Robert Yang
@ 2016-01-26  5:04   ` Denys Dmytriyenko
  2016-01-28  6:46   ` Mike Looijmans
  1 sibling, 0 replies; 16+ messages in thread
From: Denys Dmytriyenko @ 2016-01-26  5:04 UTC (permalink / raw)
  To: Robert Yang; +Cc: Denys Dmytriyenko, openembedded-core

On Tue, Jan 26, 2016 at 12:36:02PM +0800, Robert Yang wrote:
> 
> 
> On 01/26/2016 11:34 AM, Denys Dmytriyenko wrote:
> >From: Denys Dmytriyenko <denys@ti.com>
> >
> >A clean room re-implementation and extension of the original stress tool.
> >
> >Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> >---
> >  meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >  create mode 100644 meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
> >
> >diff --git a/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
> >new file mode 100644
> >index 0000000..2e92c53
> >--- /dev/null
> >+++ b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
> >@@ -0,0 +1,15 @@
> >+SUMMARY = "A tool to load and stress a computer system"
> >+HOMEPAGE = "http://kernel.ubuntu.com/~cking/stress-ng/"
> >+LICENSE = "GPLv2"
> >+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> >+
> >+SRC_URI = "http://kernel.ubuntu.com/~cking/tarballs/${BPN}/${BP}.tar.gz"
> >+
> >+SRC_URI[md5sum] = "fe65047991f654ffaac3c59ea9537763"
> >+SRC_URI[sha256sum] = "d785b5f2df042d42c43ddfd5bbafa19151ed96f0c483d7f44c737f492b52ddd6"
> >+
> >+CFLAGS += "-Wall -Wextra -DVERSION='"$(VERSION)"' -O2"
> 
> Why hardcode -O2, please ? It impacts the DEBUG_BUILD.

Those above are the same exact CFLAGS used by stress-ng own Makefile. In 
reality it only needs -DVERSION to build, but I decided to preserve all flags 
in order to simplify comparison with other published stress results...


> >+
> >+do_install() {
> >+	oe_runmake DESTDIR=${D} install
> >+}
> >
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] stress-ng: add 0.05.09
  2016-01-26  3:34 [PATCH] stress-ng: add 0.05.09 Denys Dmytriyenko
  2016-01-26  4:36 ` Robert Yang
@ 2016-01-26 11:24 ` Burton, Ross
  2016-01-26 14:20   ` Denys Dmytriyenko
  2016-01-26 16:01 ` Otavio Salvador
  2 siblings, 1 reply; 16+ messages in thread
From: Burton, Ross @ 2016-01-26 11:24 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: Denys Dmytriyenko, OE-core

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

On 26 January 2016 at 03:34, Denys Dmytriyenko <denis@denix.org> wrote:

> A clean room re-implementation and extension of the original stress tool.
>

What's the rationale for adding this to oe-core over another layer?

Ross

[-- Attachment #2: Type: text/html, Size: 641 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] stress-ng: add 0.05.09
  2016-01-26 11:24 ` Burton, Ross
@ 2016-01-26 14:20   ` Denys Dmytriyenko
  2016-01-26 16:02     ` Otavio Salvador
  2016-01-27 19:16     ` Denys Dmytriyenko
  0 siblings, 2 replies; 16+ messages in thread
From: Denys Dmytriyenko @ 2016-01-26 14:20 UTC (permalink / raw)
  To: Burton, Ross; +Cc: Denys Dmytriyenko, OE-core

On Tue, Jan 26, 2016 at 11:24:43AM +0000, Burton, Ross wrote:
> On 26 January 2016 at 03:34, Denys Dmytriyenko <denis@denix.org> wrote:
> 
> > A clean room re-implementation and extension of the original stress tool.
> >
> 
> What's the rationale for adding this to oe-core over another layer?

None, besides the original stress is in oe-core. What other layer would you 
suggest?

-- 
Denys


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] stress-ng: add 0.05.09
  2016-01-26  3:34 [PATCH] stress-ng: add 0.05.09 Denys Dmytriyenko
  2016-01-26  4:36 ` Robert Yang
  2016-01-26 11:24 ` Burton, Ross
@ 2016-01-26 16:01 ` Otavio Salvador
  2016-01-26 16:14   ` Denys Dmytriyenko
  2 siblings, 1 reply; 16+ messages in thread
From: Otavio Salvador @ 2016-01-26 16:01 UTC (permalink / raw)
  To: Denys Dmytriyenko
  Cc: Denys Dmytriyenko,
	Patches and discussions about the oe-core layer

On Tue, Jan 26, 2016 at 1:34 AM, Denys Dmytriyenko <denis@denix.org> wrote:
> From: Denys Dmytriyenko <denys@ti.com>
>
> A clean room re-implementation and extension of the original stress tool.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
>  meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
>
> diff --git a/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
> new file mode 100644
> index 0000000..2e92c53
> --- /dev/null
> +++ b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
> @@ -0,0 +1,15 @@
> +SUMMARY = "A tool to load and stress a computer system"
> +HOMEPAGE = "http://kernel.ubuntu.com/~cking/stress-ng/"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +
> +SRC_URI = "http://kernel.ubuntu.com/~cking/tarballs/${BPN}/${BP}.tar.gz"
> +
> +SRC_URI[md5sum] = "fe65047991f654ffaac3c59ea9537763"
> +SRC_URI[sha256sum] = "d785b5f2df042d42c43ddfd5bbafa19151ed96f0c483d7f44c737f492b52ddd6"
> +
> +CFLAGS += "-Wall -Wextra -DVERSION='"$(VERSION)"' -O2"

Where version comes from?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] stress-ng: add 0.05.09
  2016-01-26 14:20   ` Denys Dmytriyenko
@ 2016-01-26 16:02     ` Otavio Salvador
  2016-01-26 16:16       ` Maxin B. John
  2016-01-27 19:16     ` Denys Dmytriyenko
  1 sibling, 1 reply; 16+ messages in thread
From: Otavio Salvador @ 2016-01-26 16:02 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: OE-core, Denys Dmytriyenko

On Tue, Jan 26, 2016 at 12:20 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> On Tue, Jan 26, 2016 at 11:24:43AM +0000, Burton, Ross wrote:
>> On 26 January 2016 at 03:34, Denys Dmytriyenko <denis@denix.org> wrote:
>>
>> > A clean room re-implementation and extension of the original stress tool.
>> >
>>
>> What's the rationale for adding this to oe-core over another layer?
>
> None, besides the original stress is in oe-core. What other layer would you
> suggest?

I think meta-oe is better; in fact the 'stress' package could go there as well.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] stress-ng: add 0.05.09
  2016-01-26 16:01 ` Otavio Salvador
@ 2016-01-26 16:14   ` Denys Dmytriyenko
  2016-01-26 16:18     ` Otavio Salvador
  0 siblings, 1 reply; 16+ messages in thread
From: Denys Dmytriyenko @ 2016-01-26 16:14 UTC (permalink / raw)
  To: Otavio Salvador
  Cc: Denys Dmytriyenko,
	Patches and discussions about the oe-core layer

On Tue, Jan 26, 2016 at 02:01:14PM -0200, Otavio Salvador wrote:
> On Tue, Jan 26, 2016 at 1:34 AM, Denys Dmytriyenko <denis@denix.org> wrote:
> > From: Denys Dmytriyenko <denys@ti.com>
> >
> > A clean room re-implementation and extension of the original stress tool.
> >
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> >  meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >  create mode 100644 meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
> >
> > diff --git a/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
> > new file mode 100644
> > index 0000000..2e92c53
> > --- /dev/null
> > +++ b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
> > @@ -0,0 +1,15 @@
> > +SUMMARY = "A tool to load and stress a computer system"
> > +HOMEPAGE = "http://kernel.ubuntu.com/~cking/stress-ng/"
> > +LICENSE = "GPLv2"
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> > +
> > +SRC_URI = "http://kernel.ubuntu.com/~cking/tarballs/${BPN}/${BP}.tar.gz"
> > +
> > +SRC_URI[md5sum] = "fe65047991f654ffaac3c59ea9537763"
> > +SRC_URI[sha256sum] = "d785b5f2df042d42c43ddfd5bbafa19151ed96f0c483d7f44c737f492b52ddd6"
> > +
> > +CFLAGS += "-Wall -Wextra -DVERSION='"$(VERSION)"' -O2"
> 
> Where version comes from?

From the Makefile

-- 
Denys


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] stress-ng: add 0.05.09
  2016-01-26 16:02     ` Otavio Salvador
@ 2016-01-26 16:16       ` Maxin B. John
  0 siblings, 0 replies; 16+ messages in thread
From: Maxin B. John @ 2016-01-26 16:16 UTC (permalink / raw)
  To: Otavio Salvador; +Cc: Denys Dmytriyenko, OE-core

Hi Otavio,

On Tue, Jan 26, 2016 at 02:02:26PM -0200, Otavio Salvador wrote:
> On Tue, Jan 26, 2016 at 12:20 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> > On Tue, Jan 26, 2016 at 11:24:43AM +0000, Burton, Ross wrote:
> >> On 26 January 2016 at 03:34, Denys Dmytriyenko <denis@denix.org> wrote:
> >>
> >> > A clean room re-implementation and extension of the original stress tool.
> >> >
> >>
> >> What's the rationale for adding this to oe-core over another layer?
> >
> > None, besides the original stress is in oe-core. What other layer would you
> > suggest?
> 
> I think meta-oe is better; in fact the 'stress' package could go there as well.

"stress" package was moved from meta-linaro to oe-core as a dependency for rt-tests ptest.

> -- 
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Best Regards,
Maxin


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] stress-ng: add 0.05.09
  2016-01-26 16:14   ` Denys Dmytriyenko
@ 2016-01-26 16:18     ` Otavio Salvador
  2016-01-27 19:08       ` Denys Dmytriyenko
  0 siblings, 1 reply; 16+ messages in thread
From: Otavio Salvador @ 2016-01-26 16:18 UTC (permalink / raw)
  To: Denys Dmytriyenko
  Cc: Patches and discussions about the oe-core layer,
	Denys Dmytriyenko

On Tue, Jan 26, 2016 at 2:14 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> On Tue, Jan 26, 2016 at 02:01:14PM -0200, Otavio Salvador wrote:
>> On Tue, Jan 26, 2016 at 1:34 AM, Denys Dmytriyenko <denis@denix.org> wrote:
>> > From: Denys Dmytriyenko <denys@ti.com>
>> >
>> > A clean room re-implementation and extension of the original stress tool.
>> >
>> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>> > ---
>> >  meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb | 15 +++++++++++++++
>> >  1 file changed, 15 insertions(+)
>> >  create mode 100644 meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
>> >
>> > diff --git a/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
>> > new file mode 100644
>> > index 0000000..2e92c53
>> > --- /dev/null
>> > +++ b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
>> > @@ -0,0 +1,15 @@
>> > +SUMMARY = "A tool to load and stress a computer system"
>> > +HOMEPAGE = "http://kernel.ubuntu.com/~cking/stress-ng/"
>> > +LICENSE = "GPLv2"
>> > +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>> > +
>> > +SRC_URI = "http://kernel.ubuntu.com/~cking/tarballs/${BPN}/${BP}.tar.gz"
>> > +
>> > +SRC_URI[md5sum] = "fe65047991f654ffaac3c59ea9537763"
>> > +SRC_URI[sha256sum] = "d785b5f2df042d42c43ddfd5bbafa19151ed96f0c483d7f44c737f492b52ddd6"
>> > +
>> > +CFLAGS += "-Wall -Wextra -DVERSION='"$(VERSION)"' -O2"
>>
>> Where version comes from?
>
> From the Makefile

And $(VERSION) ? I think you need to use ${PV} here.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] stress-ng: add 0.05.09
  2016-01-26 16:18     ` Otavio Salvador
@ 2016-01-27 19:08       ` Denys Dmytriyenko
  0 siblings, 0 replies; 16+ messages in thread
From: Denys Dmytriyenko @ 2016-01-27 19:08 UTC (permalink / raw)
  To: Otavio Salvador
  Cc: Patches and discussions about the oe-core layer,
	Denys Dmytriyenko

On Tue, Jan 26, 2016 at 02:18:41PM -0200, Otavio Salvador wrote:
> On Tue, Jan 26, 2016 at 2:14 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> > On Tue, Jan 26, 2016 at 02:01:14PM -0200, Otavio Salvador wrote:
> >> On Tue, Jan 26, 2016 at 1:34 AM, Denys Dmytriyenko <denis@denix.org> wrote:
> >> > From: Denys Dmytriyenko <denys@ti.com>
> >> >
> >> > A clean room re-implementation and extension of the original stress tool.
> >> >
> >> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> >> > ---
> >> >  meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb | 15 +++++++++++++++
> >> >  1 file changed, 15 insertions(+)
> >> >  create mode 100644 meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
> >> >
> >> > diff --git a/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
> >> > new file mode 100644
> >> > index 0000000..2e92c53
> >> > --- /dev/null
> >> > +++ b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
> >> > @@ -0,0 +1,15 @@
> >> > +SUMMARY = "A tool to load and stress a computer system"
> >> > +HOMEPAGE = "http://kernel.ubuntu.com/~cking/stress-ng/"
> >> > +LICENSE = "GPLv2"
> >> > +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> >> > +
> >> > +SRC_URI = "http://kernel.ubuntu.com/~cking/tarballs/${BPN}/${BP}.tar.gz"
> >> > +
> >> > +SRC_URI[md5sum] = "fe65047991f654ffaac3c59ea9537763"
> >> > +SRC_URI[sha256sum] = "d785b5f2df042d42c43ddfd5bbafa19151ed96f0c483d7f44c737f492b52ddd6"
> >> > +
> >> > +CFLAGS += "-Wall -Wextra -DVERSION='"$(VERSION)"' -O2"
> >>
> >> Where version comes from?
> >
> > From the Makefile
> 
> And $(VERSION) ? I think you need to use ${PV} here.

Yes, $(VERSION) is defined by the Makefile. I'd rather avoid magling CFLAGS 
completely...

-- 
Denys


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] stress-ng: add 0.05.09
  2016-01-26 14:20   ` Denys Dmytriyenko
  2016-01-26 16:02     ` Otavio Salvador
@ 2016-01-27 19:16     ` Denys Dmytriyenko
  2016-01-27 19:28       ` Khem Raj
  1 sibling, 1 reply; 16+ messages in thread
From: Denys Dmytriyenko @ 2016-01-27 19:16 UTC (permalink / raw)
  To: Burton, Ross; +Cc: OE-core, Denys Dmytriyenko

On Tue, Jan 26, 2016 at 09:20:23AM -0500, Denys Dmytriyenko wrote:
> On Tue, Jan 26, 2016 at 11:24:43AM +0000, Burton, Ross wrote:
> > On 26 January 2016 at 03:34, Denys Dmytriyenko <denis@denix.org> wrote:
> > 
> > > A clean room re-implementation and extension of the original stress tool.
> > >
> > 
> > What's the rationale for adding this to oe-core over another layer?
> 
> None, besides the original stress is in oe-core. What other layer would you 
> suggest?

Ross,

Care do make your own suggestion? Do you think meta-oe would be a better fit? 
Are there any other considerations, since stress-ng is a replacement of the 
original stress and it was added to oe-core? Thanks.

-- 
Denys


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] stress-ng: add 0.05.09
  2016-01-27 19:16     ` Denys Dmytriyenko
@ 2016-01-27 19:28       ` Khem Raj
  2016-01-27 19:37         ` Paul Eggleton
  0 siblings, 1 reply; 16+ messages in thread
From: Khem Raj @ 2016-01-27 19:28 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: Denys Dmytriyenko, OE-core

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]


> On Jan 27, 2016, at 2:16 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> 
> On Tue, Jan 26, 2016 at 09:20:23AM -0500, Denys Dmytriyenko wrote:
>> On Tue, Jan 26, 2016 at 11:24:43AM +0000, Burton, Ross wrote:
>>> On 26 January 2016 at 03:34, Denys Dmytriyenko <denis@denix.org> wrote:
>>> 
>>>> A clean room re-implementation and extension of the original stress tool.
>>>> 
>>> 
>>> What's the rationale for adding this to oe-core over another layer?
>> 
>> None, besides the original stress is in oe-core. What other layer would you
>> suggest?
> 
> Ross,
> 
> Care do make your own suggestion? Do you think meta-oe would be a better fit?
> Are there any other considerations, since stress-ng is a replacement of the
> original stress and it was added to oe-core? Thanks.
> 

IIRC we had meta-benchmarking. They all should go there.

> --
> Denys
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] stress-ng: add 0.05.09
  2016-01-27 19:28       ` Khem Raj
@ 2016-01-27 19:37         ` Paul Eggleton
  2016-01-27 19:48           ` Khem Raj
  0 siblings, 1 reply; 16+ messages in thread
From: Paul Eggleton @ 2016-01-27 19:37 UTC (permalink / raw)
  To: Khem Raj; +Cc: Denys Dmytriyenko, openembedded-core

On Wed, 27 Jan 2016 14:28:47 Khem Raj wrote:
> > On Jan 27, 2016, at 2:16 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> > 
> > On Tue, Jan 26, 2016 at 09:20:23AM -0500, Denys Dmytriyenko wrote:
> >> On Tue, Jan 26, 2016 at 11:24:43AM +0000, Burton, Ross wrote:
> >>> On 26 January 2016 at 03:34, Denys Dmytriyenko <denis@denix.org> wrote:
> >>>> A clean room re-implementation and extension of the original stress
> >>>> tool.
> >>> 
> >>> What's the rationale for adding this to oe-core over another layer?
> >> 
> >> None, besides the original stress is in oe-core. What other layer would
> >> you
> >> suggest?
> > 
> > Ross,
> > 
> > Care do make your own suggestion? Do you think meta-oe would be a better
> > fit? Are there any other considerations, since stress-ng is a replacement
> > of the original stress and it was added to oe-core? Thanks.
> 
> IIRC we had meta-benchmarking. They all should go there.

I guess you mean meta-oe/recipes-benchmark (though an actual separate layer 
might be interesting.)

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] stress-ng: add 0.05.09
  2016-01-27 19:37         ` Paul Eggleton
@ 2016-01-27 19:48           ` Khem Raj
  0 siblings, 0 replies; 16+ messages in thread
From: Khem Raj @ 2016-01-27 19:48 UTC (permalink / raw)
  To: Paul Eggleton
  Cc: Denys Dmytriyenko,
	Patches and discussions about the oe-core layer

On Wed, Jan 27, 2016 at 2:37 PM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> On Wed, 27 Jan 2016 14:28:47 Khem Raj wrote:
>> > On Jan 27, 2016, at 2:16 PM, Denys Dmytriyenko <denis@denix.org> wrote:
>> >
>> > On Tue, Jan 26, 2016 at 09:20:23AM -0500, Denys Dmytriyenko wrote:
>> >> On Tue, Jan 26, 2016 at 11:24:43AM +0000, Burton, Ross wrote:
>> >>> On 26 January 2016 at 03:34, Denys Dmytriyenko <denis@denix.org> wrote:
>> >>>> A clean room re-implementation and extension of the original stress
>> >>>> tool.
>> >>>
>> >>> What's the rationale for adding this to oe-core over another layer?
>> >>
>> >> None, besides the original stress is in oe-core. What other layer would
>> >> you
>> >> suggest?
>> >
>> > Ross,
>> >
>> > Care do make your own suggestion? Do you think meta-oe would be a better
>> > fit? Are there any other considerations, since stress-ng is a replacement
>> > of the original stress and it was added to oe-core? Thanks.
>>
>> IIRC we had meta-benchmarking. They all should go there.
>
> I guess you mean meta-oe/recipes-benchmark (though an actual separate layer
> might be interesting.)

yes recipes-benchmarking.

>
> Cheers,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] stress-ng: add 0.05.09
  2016-01-26  4:36 ` Robert Yang
  2016-01-26  5:04   ` Denys Dmytriyenko
@ 2016-01-28  6:46   ` Mike Looijmans
  1 sibling, 0 replies; 16+ messages in thread
From: Mike Looijmans @ 2016-01-28  6:46 UTC (permalink / raw)
  To: Robert Yang, Denys Dmytriyenko, openembedded-core; +Cc: Denys Dmytriyenko

On 26-01-16 05:36, Robert Yang wrote:
>
>
> On 01/26/2016 11:34 AM, Denys Dmytriyenko wrote:
>> From: Denys Dmytriyenko <denys@ti.com>
>>
>> A clean room re-implementation and extension of the original stress tool.
>>
>> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>> ---
>>   meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>   create mode 100644 meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
>>
>> diff --git a/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
>> b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
>> new file mode 100644
>> index 0000000..2e92c53
>> --- /dev/null
>> +++ b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
>> @@ -0,0 +1,15 @@
>> +SUMMARY = "A tool to load and stress a computer system"
>> +HOMEPAGE = "http://kernel.ubuntu.com/~cking/stress-ng/"
>> +LICENSE = "GPLv2"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>> +
>> +SRC_URI = "http://kernel.ubuntu.com/~cking/tarballs/${BPN}/${BP}.tar.gz"
>> +
>> +SRC_URI[md5sum] = "fe65047991f654ffaac3c59ea9537763"
>> +SRC_URI[sha256sum] =
>> "d785b5f2df042d42c43ddfd5bbafa19151ed96f0c483d7f44c737f492b52ddd6"
>> +
>> +CFLAGS += "-Wall -Wextra -DVERSION='"$(VERSION)"' -O2"
>
> Why hardcode -O2, please ? It impacts the DEBUG_BUILD.

And while your at it, why force-feed "-Wall -Wextra" to the compiler? It will 
just make the compilation take longer and generate a bigger log file that no 
one will ever read, but it won't make a difference in the output.

>
> // Robert
>
>> +
>> +do_install() {
>> +    oe_runmake DESTDIR=${D} install
>> +}
>>



Kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

Visit us at: Embedded World 2016 Germany, Hall 1, stand number 220.
Click here to schedule an appointment with us at Embedded World, free ticket included

http://topicembeddedproducts.com/schedule-an-appointment/




^ permalink raw reply	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2016-01-28  6:46 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-26  3:34 [PATCH] stress-ng: add 0.05.09 Denys Dmytriyenko
2016-01-26  4:36 ` Robert Yang
2016-01-26  5:04   ` Denys Dmytriyenko
2016-01-28  6:46   ` Mike Looijmans
2016-01-26 11:24 ` Burton, Ross
2016-01-26 14:20   ` Denys Dmytriyenko
2016-01-26 16:02     ` Otavio Salvador
2016-01-26 16:16       ` Maxin B. John
2016-01-27 19:16     ` Denys Dmytriyenko
2016-01-27 19:28       ` Khem Raj
2016-01-27 19:37         ` Paul Eggleton
2016-01-27 19:48           ` Khem Raj
2016-01-26 16:01 ` Otavio Salvador
2016-01-26 16:14   ` Denys Dmytriyenko
2016-01-26 16:18     ` Otavio Salvador
2016-01-27 19:08       ` Denys Dmytriyenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox