[PATCH 0/1] Rebased - webkitgtk: fix compile error for arm64

[PATCH 0/1] Rebased - webkitgtk: fix compile error for arm64

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

Rebased on Alex's commit to update to 2.24.1.

Kai Kang (1):
  webkitgtk: fix compile error for arm64

 meta/recipes-sato/webkit/webkitgtk_2.24.1.bb | 2 --
 1 file changed, 2 deletions(-)

-- 
2.20.0

[PATCH 1/1] webkitgtk: fix compile error for arm64

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

It removes function JSC::AssemblerBuffer::data() for ARM64 in commit
https://trac.webkit.org/changeset/236589/webkit. But the function is
still required by Cortex A53 and fails to compile for arm64:

| .../tmp/work/aarch64-poky-linux/webkitgtk/2.24.1-r0/webkitgtk-2.24.1/Source/JavaScriptCore/assembler/ARM64Assembler.h:3769:100: error: 'class JSC::AssemblerBuffer' has no member named 'data'
|     if (UNLIKELY((*reinterpret_cast_ptr<int32_t*>(reinterpret_cast_ptr<char*>(m_buffer.data()) + m_buffer.codeSize() - sizeof(int32_t)) & 0x0a000000) == 0x08000000))

Not set WTF_CPU_ARM64_CORTEXA53 for arm64 to fix the failure.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.24.1.bb | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb b/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
index 771a893a6b..a57a3c058c 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
@@ -98,8 +98,6 @@ EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
 EXTRA_OECMAKE_append_mipsarch = " -DUSE_LD_GOLD=OFF "
 EXTRA_OECMAKE_append_powerpc = " -DUSE_LD_GOLD=OFF "
 
-EXTRA_OECMAKE_append_aarch64 = " -DWTF_CPU_ARM64_CORTEXA53=ON"
-
 # JIT not supported on MIPS either
 EXTRA_OECMAKE_append_mipsarch = " -DENABLE_JIT=OFF "
 
-- 
2.20.0

Re: [PATCH 1/1] webkitgtk: fix compile error for arm64

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1840 bytes --]

Can you test this on say rpi3 in 64bit mode and see all is ok ?

On Mon, May 13, 2019 at 2:53 AM <kai.kang@windriver.com> wrote:

> From: Kai Kang <kai.kang@windriver.com>
>
> It removes function JSC::AssemblerBuffer::data() for ARM64 in commit
> https://trac.webkit.org/changeset/236589/webkit. But the function is
> still required by Cortex A53 and fails to compile for arm64:
>
> |
> .../tmp/work/aarch64-poky-linux/webkitgtk/2.24.1-r0/webkitgtk-2.24.1/Source/JavaScriptCore/assembler/ARM64Assembler.h:3769:100:
> error: 'class JSC::AssemblerBuffer' has no member named 'data'
> |     if
> (UNLIKELY((*reinterpret_cast_ptr<int32_t*>(reinterpret_cast_ptr<char*>(m_buffer.data())
> + m_buffer.codeSize() - sizeof(int32_t)) & 0x0a000000) == 0x08000000))
>
> Not set WTF_CPU_ARM64_CORTEXA53 for arm64 to fix the failure.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  meta/recipes-sato/webkit/webkitgtk_2.24.1.bb | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
> b/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
> index 771a893a6b..a57a3c058c 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
> @@ -98,8 +98,6 @@ EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
>  EXTRA_OECMAKE_append_mipsarch = " -DUSE_LD_GOLD=OFF "
>  EXTRA_OECMAKE_append_powerpc = " -DUSE_LD_GOLD=OFF "
>
> -EXTRA_OECMAKE_append_aarch64 = " -DWTF_CPU_ARM64_CORTEXA53=ON"
> -
>  # JIT not supported on MIPS either
>  EXTRA_OECMAKE_append_mipsarch = " -DENABLE_JIT=OFF "
>
> --
> 2.20.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3066 bytes --]

Re: [PATCH 1/1] webkitgtk: fix compile error for arm64

[Kang Kai]

[-- Attachment #1: Type: text/plain, Size: 2618 bytes --]

On 2019/5/13 下午11:43, Khem Raj wrote:
> Can you test this on say rpi3 in 64bit mode and see all is ok ?

It is ok to build 64-bit rpi3 from layer 
git://git.yoctoproject.org/meta-raspberrypi
with configurations:

MACHINE = "raspberrypi3-64"
LICENSE_FLAGS_WHITELIST_append = " commercial"

Regards,
Kai


>
> On Mon, May 13, 2019 at 2:53 AM <kai.kang@windriver.com 
> <mailto:kai.kang@windriver.com>> wrote:
>
>     From: Kai Kang <kai.kang@windriver.com
>     <mailto:kai.kang@windriver.com>>
>
>     It removes function JSC::AssemblerBuffer::data() for ARM64 in commit
>     https://trac.webkit.org/changeset/236589/webkit. But the function is
>     still required by Cortex A53 and fails to compile for arm64:
>
>     |
>     .../tmp/work/aarch64-poky-linux/webkitgtk/2.24.1-r0/webkitgtk-2.24.1/Source/JavaScriptCore/assembler/ARM64Assembler.h:3769:100:
>     error: 'class JSC::AssemblerBuffer' has no member named 'data'
>     |     if
>     (UNLIKELY((*reinterpret_cast_ptr<int32_t*>(reinterpret_cast_ptr<char*>(m_buffer.data())
>     + m_buffer.codeSize() - sizeof(int32_t)) & 0x0a000000) == 0x08000000))
>
>     Not set WTF_CPU_ARM64_CORTEXA53 for arm64 to fix the failure.
>
>     Signed-off-by: Kai Kang <kai.kang@windriver.com
>     <mailto:kai.kang@windriver.com>>
>     ---
>      meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
>     <http://webkitgtk_2.24.1.bb> | 2 --
>      1 file changed, 2 deletions(-)
>
>     diff --git a/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
>     <http://webkitgtk_2.24.1.bb>
>     b/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
>     <http://webkitgtk_2.24.1.bb>
>     index 771a893a6b..a57a3c058c 100644
>     --- a/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
>     <http://webkitgtk_2.24.1.bb>
>     +++ b/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
>     <http://webkitgtk_2.24.1.bb>
>     @@ -98,8 +98,6 @@ EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
>      EXTRA_OECMAKE_append_mipsarch = " -DUSE_LD_GOLD=OFF "
>      EXTRA_OECMAKE_append_powerpc = " -DUSE_LD_GOLD=OFF "
>
>     -EXTRA_OECMAKE_append_aarch64 = " -DWTF_CPU_ARM64_CORTEXA53=ON"
>     -
>      # JIT not supported on MIPS either
>      EXTRA_OECMAKE_append_mipsarch = " -DENABLE_JIT=OFF "
>
>     -- 
>     2.20.0
>
>     -- 
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

-- 
Kai Kang


[-- Attachment #2: Type: text/html, Size: 5490 bytes --]