* [PATCH] ltp: getrlimit03: adjust-a-bit-of-code-to-compatiable-with mips32
@ 2019-07-17 9:50 Hongzhi.Song
2019-07-18 21:51 ` Petr Vorel
0 siblings, 1 reply; 6+ messages in thread
From: Hongzhi.Song @ 2019-07-17 9:50 UTC (permalink / raw)
To: openembedded-core
Error info:
getrlimit03.c:104: FAIL: __NR_prlimit64(0) had rlim_cur =
ffffffffffffffff but __NR_getrlimit(0) had rlim_cur = 7fffffff
According to kernel code: [arch/mips/include/uapi/asm/resource.h]
RLIM_INFINITY is set to 0x7fffffffUL instead of ULONG_MAX on mips32.
/*
* SuS says limits have to be unsigned.
* Which makes a ton more sense anyway,
* but we keep the old value on MIPS32,
* for compatibility:
*/
#ifndef __mips64
# define RLIM_INFINITY 0x7fffffffUL
#endif
Adding conditional statement about mips to fix this.
Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
---
...-adjust-a-bit-of-code-to-compatiable-with.patch | 62 ++++++++++++++++++
...efine-TST_ABI-32-64-to-detect-target-type.patch | 74 ++++++++++++++++++++++
meta/recipes-extended/ltp/ltp_20190115.bb | 2 +
3 files changed, 138 insertions(+)
create mode 100644 meta/recipes-extended/ltp/ltp/0001-getrlimit03-adjust-a-bit-of-code-to-compatiable-with.patch
create mode 100644 meta/recipes-extended/ltp/ltp/0001-lapi-Define-TST_ABI-32-64-to-detect-target-type.patch
diff --git a/meta/recipes-extended/ltp/ltp/0001-getrlimit03-adjust-a-bit-of-code-to-compatiable-with.patch b/meta/recipes-extended/ltp/ltp/0001-getrlimit03-adjust-a-bit-of-code-to-compatiable-with.patch
new file mode 100644
index 0000000..7b66229
--- /dev/null
+++ b/meta/recipes-extended/ltp/ltp/0001-getrlimit03-adjust-a-bit-of-code-to-compatiable-with.patch
@@ -0,0 +1,62 @@
+From e79652a3839869b1983d65999e5d5dcb50bc9cd7 Mon Sep 17 00:00:00 2001
+From: "Hongzhi.Song" <hongzhi.song@windriver.com>
+Date: Mon, 15 Jul 2019 03:39:06 -0400
+Subject: [PATCH] getrlimit03: adjust a bit of code to compatiable with mips32
+
+Error info:
+getrlimit03.c:104: FAIL: __NR_prlimit64(0) had rlim_cur =
+ffffffffffffffff but __NR_getrlimit(0) had rlim_cur = 7fffffff
+
+According to kernel code: [arch/mips/include/uapi/asm/resource.h]
+RLIM_INFINITY is set to 0x7fffffffUL instead of ULONG_MAX on mips32.
+
+ /*
+ * SuS says limits have to be unsigned.
+ * Which makes a ton more sense anyway,
+ * but we keep the old value on MIPS32,
+ * for compatibility:
+ */
+ #ifndef __mips64
+ # define RLIM_INFINITY 0x7fffffffUL
+ #endif
+
+Adding conditional statement about mips to fix this.
+
+Signed-off-by: Jan Stancek <jstancek@redhat.com>
+Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
+
+Upstream-Status: Backport
+Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
+---
+ testcases/kernel/syscalls/getrlimit/getrlimit03.c | 8 +++++++-
+ 1 file changed, 7 insertions(+), 1 deletion(-)
+
+diff --git a/testcases/kernel/syscalls/getrlimit/getrlimit03.c b/testcases/kernel/syscalls/getrlimit/getrlimit03.c
+index e4d56c4..03bd821 100644
+--- a/testcases/kernel/syscalls/getrlimit/getrlimit03.c
++++ b/testcases/kernel/syscalls/getrlimit/getrlimit03.c
+@@ -26,6 +26,7 @@
+
+ #include "tst_test.h"
+ #include "lapi/syscalls.h"
++#include "lapi/abisize.h"
+
+ /**
+ * Linux provides an "old" getrlimit syscall handler that uses signed long,
+@@ -61,7 +62,12 @@ struct rlimit_ulong {
+ unsigned long rlim_cur;
+ unsigned long rlim_max;
+ };
+-const unsigned long RLIM_INFINITY_UL = ULONG_MAX;
++
++#if defined(__mips__) && defined(TST_ABI32)
++ const unsigned long RLIM_INFINITY_UL = 0x7fffffffUL;
++#else
++ const unsigned long RLIM_INFINITY_UL = ULONG_MAX;
++#endif
+
+ static int getrlimit_ulong(int resource, struct rlimit_ulong *rlim)
+ {
+--
+2.8.1
+
diff --git a/meta/recipes-extended/ltp/ltp/0001-lapi-Define-TST_ABI-32-64-to-detect-target-type.patch b/meta/recipes-extended/ltp/ltp/0001-lapi-Define-TST_ABI-32-64-to-detect-target-type.patch
new file mode 100644
index 0000000..a6129d3
--- /dev/null
+++ b/meta/recipes-extended/ltp/ltp/0001-lapi-Define-TST_ABI-32-64-to-detect-target-type.patch
@@ -0,0 +1,74 @@
+From d5293d73b760268a6b200ab7d9323e37700e6a8c Mon Sep 17 00:00:00 2001
+From: Petr Vorel <petr.vorel@gmail.com>
+Date: Thu, 28 Mar 2019 07:11:25 +0100
+Subject: [PATCH] lapi: Define TST_ABI{,32,64} to detect target type
+
+This is meant to be a replacement of __WORDSIZE definition.
+
+Motivation was instead of finding, where all libc define
+__WORDSIZE, which is usually used for detecting target type
+(at least MUSL defines it in different place than other libc)
+we define our own constant.
+
+Suggested-by: Cyril Hrubis <chrubis@suse.cz>
+Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
+
+Upstream-Status: Backport
+Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
+---
+ include/lapi/abisize.h | 29 +++++++++++++----------------
+ 1 file changed, 13 insertions(+), 16 deletions(-)
+
+diff --git a/include/lapi/abisize.h b/include/lapi/abisize.h
+index 897bdfd..9e6622c 100644
+--- a/include/lapi/abisize.h
++++ b/include/lapi/abisize.h
+@@ -1,25 +1,22 @@
++// SPDX-License-Identifier: GPL-2.0-or-later
+ /*
+- * Copyright (c) 2014 Linux Test Project
++ * Copyright (c) 2014-2019 Linux Test Project
+ * Cyril Hrubis <chrubis@suse.cz>
+- *
+- * This program is free software; you can redistribute it and/or
+- * modify it under the terms of the GNU General Public License as
+- * published by the Free Software Foundation; either version 2 of
+- * the License, or (at your option) any later version.
+- *
+- * This program is distributed in the hope that it would be useful,
+- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+- * GNU General Public License for more details.
+- *
+- * You should have received a copy of the GNU General Public License
+- * along with this program; if not, write the Free Software Foundation,
+- * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
++ * Petr Vorel <petr.vorel@gmail.com>
+ */
+
+ #ifndef ABISIZE_H__
+ #define ABISIZE_H__
+
++/* __WORDSIZE replacement */
++#if defined(__LP64__) || defined(_LP64)
++# define TST_ABI64
++# define TST_ABI 64
++#else
++# define TST_ABI32
++# define TST_ABI 32
++#endif
++
+ /*
+ * Determines if we have to split up 64 bit arguments or not
+ *
+@@ -29,6 +26,6 @@
+ (defined(__mips__) && _MIPS_SIM == _ABIN32) || \
+ (defined(__x86_64__) && defined(__ILP32__)) || \
+ (defined(__aarch64__) && defined(__ILP32__)) || \
+- __WORDSIZE == 64
++ defined(TST_ABI64)
+
+ #endif /* ABISIZE_H__ */
+--
+2.8.1
+
diff --git a/meta/recipes-extended/ltp/ltp_20190115.bb b/meta/recipes-extended/ltp/ltp_20190115.bb
index b7b581f..f208b71 100644
--- a/meta/recipes-extended/ltp/ltp_20190115.bb
+++ b/meta/recipes-extended/ltp/ltp_20190115.bb
@@ -53,6 +53,8 @@ SRC_URI = "git://github.com/linux-test-project/ltp.git \
file://0001-shmctl01-don-t-use-hardcoded-index-0-for-SHM_STAT-te.patch \
file://0001-diotest4-Let-kernel-pick-an-address-when-calling-mma.patch \
file://0001-file01.sh-Fix-in-was-not-recognized.patch \
+ file://0001-lapi-Define-TST_ABI-32-64-to-detect-target-type.patch \
+ file://0001-getrlimit03-adjust-a-bit-of-code-to-compatiable-with.patch \
"
S = "${WORKDIR}/git"
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ltp: getrlimit03: adjust-a-bit-of-code-to-compatiable-with mips32
2019-07-17 9:50 [PATCH] ltp: getrlimit03: adjust-a-bit-of-code-to-compatiable-with mips32 Hongzhi.Song
@ 2019-07-18 21:51 ` Petr Vorel
2019-07-19 1:45 ` Hongzhi, Song
2019-07-19 8:06 ` Richard Purdie
0 siblings, 2 replies; 6+ messages in thread
From: Petr Vorel @ 2019-07-18 21:51 UTC (permalink / raw)
To: Hongzhi.Song; +Cc: openembedded-core
Hi Hongzhi,
...
> --- /dev/null
> +++ b/meta/recipes-extended/ltp/ltp/0001-getrlimit03-adjust-a-bit-of-code-to-compatiable-with.patch
> @@ -0,0 +1,62 @@
> +From e79652a3839869b1983d65999e5d5dcb50bc9cd7 Mon Sep 17 00:00:00 2001
> +From: "Hongzhi.Song" <hongzhi.song@windriver.com>
> +Date: Mon, 15 Jul 2019 03:39:06 -0400
> +Subject: [PATCH] getrlimit03: adjust a bit of code to compatiable with mips32
...
> +Signed-off-by: Jan Stancek <jstancek@redhat.com>
> +Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
> +
> +Upstream-Status: Backport
> +Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
> +---
> + testcases/kernel/syscalls/getrlimit/getrlimit03.c | 8 +++++++-
> + 1 file changed, 7 insertions(+), 1 deletion(-)
I have to say I prefer policy when only build fixes are backported / added.
(approach which e.g. buildroot has). Having many patches (25 atm) makes updating
a bit difficult (ok, not that much, 'Upstream-Status: Backport' shows what has
been merged since last release) and sometimes brings users patches which weren't
accepted by upstream (your mips patch [1] was not accepted [2]).
But I understand that LTP 3 months release cycle can be to
slow for some LTP users.
Kind regards,
Petr
PS: I'm slowly working on fixing all musl issues in LTP upstream. It's a long
term run but were moving towards that goal.
Patch "build: Add option to select libc implementation" [3] is a not a good
approach. Instead it's needed to find for each failure why it's not presented
in musl. Mostly because it uses non POSIX features or deprecated API, which
needs to be avoided or used kernel headers where it's available.
[1] http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-extended/ltp/ltp/0001-open_posix_testsuite-mmap24-2-Relax-condition-a-bit.patch
[2] https://patchwork.ozlabs.org/patch/982194/#2012168
[3] http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-extended/ltp/ltp/0004-build-Add-option-to-select-libc-implementation.patch
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ltp: getrlimit03: adjust-a-bit-of-code-to-compatiable-with mips32
2019-07-18 21:51 ` Petr Vorel
@ 2019-07-19 1:45 ` Hongzhi, Song
2019-07-19 6:41 ` Petr Vorel
2019-07-19 8:06 ` Richard Purdie
1 sibling, 1 reply; 6+ messages in thread
From: Hongzhi, Song @ 2019-07-19 1:45 UTC (permalink / raw)
To: Petr Vorel; +Cc: openembedded-core
On 7/19/19 5:51 AM, Petr Vorel wrote:
> Hi Hongzhi,
>
> ...
>> --- /dev/null
>> +++ b/meta/recipes-extended/ltp/ltp/0001-getrlimit03-adjust-a-bit-of-code-to-compatiable-with.patch
>> @@ -0,0 +1,62 @@
>> +From e79652a3839869b1983d65999e5d5dcb50bc9cd7 Mon Sep 17 00:00:00 2001
>> +From: "Hongzhi.Song" <hongzhi.song@windriver.com>
>> +Date: Mon, 15 Jul 2019 03:39:06 -0400
>> +Subject: [PATCH] getrlimit03: adjust a bit of code to compatiable with mips32
> ...
>> +Signed-off-by: Jan Stancek <jstancek@redhat.com>
>> +Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
>> +
>> +Upstream-Status: Backport
>> +Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
>> +---
>> + testcases/kernel/syscalls/getrlimit/getrlimit03.c | 8 +++++++-
>> + 1 file changed, 7 insertions(+), 1 deletion(-)
> I have to say I prefer policy when only build fixes are backported / added.
> (approach which e.g. buildroot has). Having many patches (25 atm) makes updating
> a bit difficult (ok, not that much, 'Upstream-Status: Backport' shows what has
> been merged since last release) and sometimes brings users patches which weren't
> accepted by upstream (your mips patch [1] was not accepted [2]
Thanks for your kindly remind.
Agree with you. It's time to uprev ltp recipe.
From now, if the "Submitting or Backport" is appropriate,
I will make sure the patch was merged by ltp before it was sent to oe-core.
> ).
>
> But I understand that LTP 3 months release cycle can be to
> slow for some LTP users.
>
> Kind regards,
> Petr
>
> PS: I'm slowly working on fixing all musl issues in LTP upstream. It's a long
> term run but were moving towards that goal.
> Patch "build: Add option to select libc implementation" [3] is a not a good
> approach. Instead it's needed to find for each failure why it's not presented
> in musl. Mostly because it uses non POSIX features or deprecated API, which
> needs to be avoided or used kernel headers where it's available.
>
> [1] http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-extended/ltp/ltp/0001-open_posix_testsuite-mmap24-2-Relax-condition-a-bit.patch
I am working on this patch.
> [2] https://patchwork.ozlabs.org/patch/982194/#2012168
This patch has been merge by ltp finally.
--Hongzhi
> [3] http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-extended/ltp/ltp/0004-build-Add-option-to-select-libc-implementation.patch
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ltp: getrlimit03: adjust-a-bit-of-code-to-compatiable-with mips32
2019-07-19 1:45 ` Hongzhi, Song
@ 2019-07-19 6:41 ` Petr Vorel
2019-07-19 7:46 ` Hongzhi, Song
0 siblings, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2019-07-19 6:41 UTC (permalink / raw)
To: Hongzhi, Song; +Cc: openembedded-core
Hi Hongzhi,
> > ...
> > > --- /dev/null
> > > +++ b/meta/recipes-extended/ltp/ltp/0001-getrlimit03-adjust-a-bit-of-code-to-compatiable-with.patch
> > > @@ -0,0 +1,62 @@
> > > +From e79652a3839869b1983d65999e5d5dcb50bc9cd7 Mon Sep 17 00:00:00 2001
> > > +From: "Hongzhi.Song" <hongzhi.song@windriver.com>
> > > +Date: Mon, 15 Jul 2019 03:39:06 -0400
> > > +Subject: [PATCH] getrlimit03: adjust a bit of code to compatiable with mips32
> > ...
> > > +Signed-off-by: Jan Stancek <jstancek@redhat.com>
> > > +Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
> > > +
> > > +Upstream-Status: Backport
> > > +Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
> > > +---
> > > + testcases/kernel/syscalls/getrlimit/getrlimit03.c | 8 +++++++-
> > > + 1 file changed, 7 insertions(+), 1 deletion(-)
> > I have to say I prefer policy when only build fixes are backported / added.
> > (approach which e.g. buildroot has). Having many patches (25 atm) makes updating
> > a bit difficult (ok, not that much, 'Upstream-Status: Backport' shows what has
> > been merged since last release) and sometimes brings users patches which weren't
> > accepted by upstream (your mips patch [1] was not accepted [2]
> Thanks for your kindly remind.
> Agree with you. It's time to uprev ltp recipe.
> From now, if the "Submitting or Backport" is appropriate,
> I will make sure the patch was merged by ltp before it was sent to oe-core.
Great! Feel free to Cc me when sending patches.
> > ).
> > But I understand that LTP 3 months release cycle can be to
> > slow for some LTP users.
> > Kind regards,
> > Petr
> > PS: I'm slowly working on fixing all musl issues in LTP upstream. It's a long
> > term run but were moving towards that goal.
> > Patch "build: Add option to select libc implementation" [3] is a not a good
> > approach. Instead it's needed to find for each failure why it's not presented
> > in musl. Mostly because it uses non POSIX features or deprecated API, which
> > needs to be avoided or used kernel headers where it's available.
> > [1] http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-extended/ltp/ltp/0001-open_posix_testsuite-mmap24-2-Relax-condition-a-bit.patch
> I am working on this patch.
Good.
> > [2] https://patchwork.ozlabs.org/patch/982194/#2012168
> This patch has been merge by ltp finally.
To LTP upstream? I don't see it [4]. That's the patch you working on.
> --Hongzhi
> > [3] http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-extended/ltp/ltp/0004-build-Add-option-to-select-libc-implementation.patch
[4] https://github.com/linux-test-project/ltp/commits/master/testcases/open_posix_testsuite/conformance/interfaces/mmap/24-2.c
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ltp: getrlimit03: adjust-a-bit-of-code-to-compatiable-with mips32
2019-07-19 6:41 ` Petr Vorel
@ 2019-07-19 7:46 ` Hongzhi, Song
0 siblings, 0 replies; 6+ messages in thread
From: Hongzhi, Song @ 2019-07-19 7:46 UTC (permalink / raw)
To: Petr Vorel; +Cc: openembedded-core
On 7/19/19 2:41 PM, Petr Vorel wrote:
> Hi Hongzhi,
>
>>> ...
>>>> --- /dev/null
>>>> +++ b/meta/recipes-extended/ltp/ltp/0001-getrlimit03-adjust-a-bit-of-code-to-compatiable-with.patch
>>>> @@ -0,0 +1,62 @@
>>>> +From e79652a3839869b1983d65999e5d5dcb50bc9cd7 Mon Sep 17 00:00:00 2001
>>>> +From: "Hongzhi.Song" <hongzhi.song@windriver.com>
>>>> +Date: Mon, 15 Jul 2019 03:39:06 -0400
>>>> +Subject: [PATCH] getrlimit03: adjust a bit of code to compatiable with mips32
>>> ...
>>>> +Signed-off-by: Jan Stancek <jstancek@redhat.com>
>>>> +Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
>>>> +
>>>> +Upstream-Status: Backport
>>>> +Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
>>>> +---
>>>> + testcases/kernel/syscalls/getrlimit/getrlimit03.c | 8 +++++++-
>>>> + 1 file changed, 7 insertions(+), 1 deletion(-)
>>> I have to say I prefer policy when only build fixes are backported / added.
>>> (approach which e.g. buildroot has). Having many patches (25 atm) makes updating
>>> a bit difficult (ok, not that much, 'Upstream-Status: Backport' shows what has
>>> been merged since last release) and sometimes brings users patches which weren't
>>> accepted by upstream (your mips patch [1] was not accepted [2]
>> Thanks for your kindly remind.
>> Agree with you. It's time to uprev ltp recipe.
>
>> From now, if the "Submitting or Backport" is appropriate,
>> I will make sure the patch was merged by ltp before it was sent to oe-core.
> Great! Feel free to Cc me when sending patches.
>
>>> ).
>>> But I understand that LTP 3 months release cycle can be to
>>> slow for some LTP users.
>>> Kind regards,
>>> Petr
>>> PS: I'm slowly working on fixing all musl issues in LTP upstream. It's a long
>>> term run but were moving towards that goal.
>>> Patch "build: Add option to select libc implementation" [3] is a not a good
>>> approach. Instead it's needed to find for each failure why it's not presented
>>> in musl. Mostly because it uses non POSIX features or deprecated API, which
>>> needs to be avoided or used kernel headers where it's available.
>>> [1] http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-extended/ltp/ltp/0001-open_posix_testsuite-mmap24-2-Relax-condition-a-bit.patch
>> I am working on this patch.
> Good.
>
>
>>> [2] https://patchwork.ozlabs.org/patch/982194/#2012168
>> This patch has been merge by ltp finally.
> To LTP upstream? I don't see it [4]. That's the patch you working on.
Hi Petr,
quote your statement above : "[2]
https://patchwork.ozlabs.org/patch/982194/#2012168"
https://github.com/linux-test-project/ltp/commit/7a3bca63cd7f059d490b6274f0fdf3247be93fde
--Hongzhi
>
>> --Hongzhi
>>> [3] http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-extended/ltp/ltp/0004-build-Add-option-to-select-libc-implementation.patch
> [4] https://github.com/linux-test-project/ltp/commits/master/testcases/open_posix_testsuite/conformance/interfaces/mmap/24-2.c
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ltp: getrlimit03: adjust-a-bit-of-code-to-compatiable-with mips32
2019-07-18 21:51 ` Petr Vorel
2019-07-19 1:45 ` Hongzhi, Song
@ 2019-07-19 8:06 ` Richard Purdie
1 sibling, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2019-07-19 8:06 UTC (permalink / raw)
To: Petr Vorel, Hongzhi.Song; +Cc: openembedded-core
Hi Petr,
On Thu, 2019-07-18 at 23:51 +0200, Petr Vorel wrote:
> I have to say I prefer policy when only build fixes are backported /
> added. (approach which e.g. buildroot has). Having many patches (25
> atm) makes updating a bit difficult (ok, not that much, 'Upstream-
> Status: Backport' shows what has been merged since last release) and
> sometimes brings users patches which weren't accepted by upstream
> (your mips patch [1] was not accepted [2]).
>
> But I understand that LTP 3 months release cycle can be to
> slow for some LTP users.
FWIW our policy does vary a lot depending on the upstream. Where we can
have an open dialog with active projects I'm very keen to figure out
how to get our patch set to zero, we really don't want patches.
Backports don't worry me so much because as you say, we clearly mark
them and those are easy to drop upon upgrade.
I see we have an ltp upgrade which looks to remove 50% of the patches
which is a good start.
That leaves 12 of them, of which 6 are musl and 6 appear to be other
test 'fixes' of various kinds.
Of the other 6, 3 say they're backports, one submitted and two pending.
Figuring out the two pending and the submitted would set us up for a
cleaner upgrade in future outside of musl.
> Kind regards,
> Petr
>
> PS: I'm slowly working on fixing all musl issues in LTP upstream.
> It's a long term run but were moving towards that goal. Patch "build:
> Add option to select libc implementation" [3] is a nota good
> approach. Instead it's needed to find for each failure why it's not
> presented in musl. Mostly because it uses non POSIX features or
> deprecated API, which needs to be avoided or used kernel headers
> where it's available.
This sounds great, I think what we have right now can only be described
as a bit of a hack. It lets us build and run tests but clearly isn't
appropriate to merge upstream. We can at the very least help with
testing and certainly want to drop our patch if/as/when we can.
Also, I'm not sure if you've seen it but our "full" builds now run ltp
for x86 and arm under qemu and report the results:
https://autobuilder.yocto.io/pub/non-release/20190712-13/testresults/testresult-report.txt
(see the Ltp and Ltp Posix sections)
I'm actually quite worried about the numbers of failures we see there.
Up to now I've been focusing on sorting out our ptest results but ltp
would be something we need to focus on next.
There should be more raw log data in
https://autobuilder.yocto.io/pub/non-release/20190712-13/testresults/qemux86-64-ltp/
and
https://autobuilder.yocto.io/pub/non-release/20190712-13/testresults/qemuarm64-ltp/testresults.json
but I've not had a chance to look at the ltp side of things at all
myself, Armin has done the integration work so far.
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-19 8:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-17 9:50 [PATCH] ltp: getrlimit03: adjust-a-bit-of-code-to-compatiable-with mips32 Hongzhi.Song
2019-07-18 21:51 ` Petr Vorel
2019-07-19 1:45 ` Hongzhi, Song
2019-07-19 6:41 ` Petr Vorel
2019-07-19 7:46 ` Hongzhi, Song
2019-07-19 8:06 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox