* [PATCH] tune-cortexa72: Enable the crc extension by default for cortexa72 @ 2022-01-12 9:07 Kevin Hao 2022-01-12 17:30 ` [OE-core] " Khem Raj 2022-01-12 19:23 ` Jon Mason 0 siblings, 2 replies; 8+ messages in thread From: Kevin Hao @ 2022-01-12 9:07 UTC (permalink / raw) To: openembedded-core; +Cc: Richard Purdie The crc extension is optional for the ARMv8.0 but is mandatory for the cortexa72, so there is no reason not to enable it for the cortexa72 tune. With this change, the cortexa72-crc seems redundant. But we had better to keep it to be compatible with the BSP which already used that tune. Signed-off-by: Kevin Hao <kexin.hao@windriver.com> --- .../machine/include/arm/armv8a/tune-cortexa72.inc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc index 3651cf6e802b..4c9add32f5f5 100644 --- a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc +++ b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc @@ -10,12 +10,12 @@ AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto" ARMPKGARCH:tune-cortexa72 = "cortexa72" ARMPKGARCH:tune-cortexa72-crc = "cortexa72" ARMPKGARCH:tune-cortexa72-crc-crypto = "cortexa72" -TUNE_FEATURES:tune-cortexa72 = "${TUNE_FEATURES:tune-armv8a} cortexa72" -TUNE_FEATURES:tune-cortexa72-crc = "${TUNE_FEATURES:tune-cortexa72} crc" -TUNE_FEATURES:tune-cortexa72-crc-crypto = "${TUNE_FEATURES:tune-cortexa72} crc crypto" -PACKAGE_EXTRA_ARCHS:tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72" -PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72 cortexa72-crc" -PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc cortexa72-crc-crypto" +TUNE_FEATURES:tune-cortexa72 = "${TUNE_FEATURES:tune-armv8a-crc} cortexa72" +TUNE_FEATURES:tune-cortexa72-crc = "${TUNE_FEATURES:tune-cortexa72}" +TUNE_FEATURES:tune-cortexa72-crc-crypto = "${TUNE_FEATURES:tune-cortexa72} crypto" +PACKAGE_EXTRA_ARCHS:tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS:tune-armv8-crc} cortexa72" +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72" +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc-crypto" BASE_LIB:tune-cortexa72 = "lib64" BASE_LIB:tune-cortexa72-crc = "lib64" BASE_LIB:tune-cortexa72-crc-crypto = "lib64" -- 2.31.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH] tune-cortexa72: Enable the crc extension by default for cortexa72 2022-01-12 9:07 [PATCH] tune-cortexa72: Enable the crc extension by default for cortexa72 Kevin Hao @ 2022-01-12 17:30 ` Khem Raj 2022-01-12 19:24 ` Jon Mason 2022-01-12 19:23 ` Jon Mason 1 sibling, 1 reply; 8+ messages in thread From: Khem Raj @ 2022-01-12 17:30 UTC (permalink / raw) To: Kevin Hao, openembedded-core; +Cc: Richard Purdie On 1/12/22 1:07 AM, Kevin Hao wrote: > The crc extension is optional for the ARMv8.0 but is mandatory for the > cortexa72, so there is no reason not to enable it for the cortexa72 > tune. With this change, the cortexa72-crc seems redundant. But we > had better to keep it to be compatible with the BSP which already used > that tune. this looks good. Is there a way to warn such users to migrate to better option ? > > Signed-off-by: Kevin Hao <kexin.hao@windriver.com> > --- > .../machine/include/arm/armv8a/tune-cortexa72.inc | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc > index 3651cf6e802b..4c9add32f5f5 100644 > --- a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc > +++ b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc > @@ -10,12 +10,12 @@ AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto" > ARMPKGARCH:tune-cortexa72 = "cortexa72" > ARMPKGARCH:tune-cortexa72-crc = "cortexa72" > ARMPKGARCH:tune-cortexa72-crc-crypto = "cortexa72" > -TUNE_FEATURES:tune-cortexa72 = "${TUNE_FEATURES:tune-armv8a} cortexa72" > -TUNE_FEATURES:tune-cortexa72-crc = "${TUNE_FEATURES:tune-cortexa72} crc" > -TUNE_FEATURES:tune-cortexa72-crc-crypto = "${TUNE_FEATURES:tune-cortexa72} crc crypto" > -PACKAGE_EXTRA_ARCHS:tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72" > -PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72 cortexa72-crc" > -PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc cortexa72-crc-crypto" > +TUNE_FEATURES:tune-cortexa72 = "${TUNE_FEATURES:tune-armv8a-crc} cortexa72" > +TUNE_FEATURES:tune-cortexa72-crc = "${TUNE_FEATURES:tune-cortexa72}" > +TUNE_FEATURES:tune-cortexa72-crc-crypto = "${TUNE_FEATURES:tune-cortexa72} crypto" > +PACKAGE_EXTRA_ARCHS:tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS:tune-armv8-crc} cortexa72" > +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72" > +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc-crypto" > BASE_LIB:tune-cortexa72 = "lib64" > BASE_LIB:tune-cortexa72-crc = "lib64" > BASE_LIB:tune-cortexa72-crc-crypto = "lib64" > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#160480): https://lists.openembedded.org/g/openembedded-core/message/160480 > Mute This Topic: https://lists.openembedded.org/mt/88369540/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH] tune-cortexa72: Enable the crc extension by default for cortexa72 2022-01-12 17:30 ` [OE-core] " Khem Raj @ 2022-01-12 19:24 ` Jon Mason 0 siblings, 0 replies; 8+ messages in thread From: Jon Mason @ 2022-01-12 19:24 UTC (permalink / raw) To: Khem Raj; +Cc: Kevin Hao, openembedded-core, Richard Purdie On Wed, Jan 12, 2022 at 12:30 PM Khem Raj <raj.khem@gmail.com> wrote: > > > > On 1/12/22 1:07 AM, Kevin Hao wrote: > > The crc extension is optional for the ARMv8.0 but is mandatory for the > > cortexa72, so there is no reason not to enable it for the cortexa72 > > tune. With this change, the cortexa72-crc seems redundant. But we > > had better to keep it to be compatible with the BSP which already used > > that tune. > > this looks good. Is there a way to warn such users to migrate to better > option ? We could just remove the crc and when it breaks they'll look.... > > > > > Signed-off-by: Kevin Hao <kexin.hao@windriver.com> > > --- > > .../machine/include/arm/armv8a/tune-cortexa72.inc | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc > > index 3651cf6e802b..4c9add32f5f5 100644 > > --- a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc > > +++ b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc > > @@ -10,12 +10,12 @@ AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto" > > ARMPKGARCH:tune-cortexa72 = "cortexa72" > > ARMPKGARCH:tune-cortexa72-crc = "cortexa72" > > ARMPKGARCH:tune-cortexa72-crc-crypto = "cortexa72" > > -TUNE_FEATURES:tune-cortexa72 = "${TUNE_FEATURES:tune-armv8a} cortexa72" > > -TUNE_FEATURES:tune-cortexa72-crc = "${TUNE_FEATURES:tune-cortexa72} crc" > > -TUNE_FEATURES:tune-cortexa72-crc-crypto = "${TUNE_FEATURES:tune-cortexa72} crc crypto" > > -PACKAGE_EXTRA_ARCHS:tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72" > > -PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72 cortexa72-crc" > > -PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc cortexa72-crc-crypto" > > +TUNE_FEATURES:tune-cortexa72 = "${TUNE_FEATURES:tune-armv8a-crc} cortexa72" > > +TUNE_FEATURES:tune-cortexa72-crc = "${TUNE_FEATURES:tune-cortexa72}" > > +TUNE_FEATURES:tune-cortexa72-crc-crypto = "${TUNE_FEATURES:tune-cortexa72} crypto" > > +PACKAGE_EXTRA_ARCHS:tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS:tune-armv8-crc} cortexa72" > > +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72" > > +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc-crypto" > > BASE_LIB:tune-cortexa72 = "lib64" > > BASE_LIB:tune-cortexa72-crc = "lib64" > > BASE_LIB:tune-cortexa72-crc-crypto = "lib64" > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#160496): https://lists.openembedded.org/g/openembedded-core/message/160496 > Mute This Topic: https://lists.openembedded.org/mt/88369540/3616920 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [jdmason@kudzu.us] > -=-=-=-=-=-=-=-=-=-=-=- > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH] tune-cortexa72: Enable the crc extension by default for cortexa72 2022-01-12 9:07 [PATCH] tune-cortexa72: Enable the crc extension by default for cortexa72 Kevin Hao 2022-01-12 17:30 ` [OE-core] " Khem Raj @ 2022-01-12 19:23 ` Jon Mason 2022-01-12 21:58 ` Richard Purdie 2022-01-13 22:58 ` Jon Mason 1 sibling, 2 replies; 8+ messages in thread From: Jon Mason @ 2022-01-12 19:23 UTC (permalink / raw) To: Kevin Hao; +Cc: openembedded-core, Richard Purdie On Wed, Jan 12, 2022 at 4:11 AM Kevin Hao <kexin.hao@windriver.com> wrote: > > The crc extension is optional for the ARMv8.0 but is mandatory for the > cortexa72, so there is no reason not to enable it for the cortexa72 > tune. With this change, the cortexa72-crc seems redundant. But we > had better to keep it to be compatible with the BSP which already used > that tune. > > Signed-off-by: Kevin Hao <kexin.hao@windriver.com> Acked-by: Jon Mason <jdmason@kudzu.us> From the GCC sources, it's hard coded for A34, A35, A53, A57, A72, A73, and almost all of the others listed. I can patch the rest. Thanks, Jon > --- > .../machine/include/arm/armv8a/tune-cortexa72.inc | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc > index 3651cf6e802b..4c9add32f5f5 100644 > --- a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc > +++ b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc > @@ -10,12 +10,12 @@ AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto" > ARMPKGARCH:tune-cortexa72 = "cortexa72" > ARMPKGARCH:tune-cortexa72-crc = "cortexa72" > ARMPKGARCH:tune-cortexa72-crc-crypto = "cortexa72" > -TUNE_FEATURES:tune-cortexa72 = "${TUNE_FEATURES:tune-armv8a} cortexa72" > -TUNE_FEATURES:tune-cortexa72-crc = "${TUNE_FEATURES:tune-cortexa72} crc" > -TUNE_FEATURES:tune-cortexa72-crc-crypto = "${TUNE_FEATURES:tune-cortexa72} crc crypto" > -PACKAGE_EXTRA_ARCHS:tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72" > -PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72 cortexa72-crc" > -PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc cortexa72-crc-crypto" > +TUNE_FEATURES:tune-cortexa72 = "${TUNE_FEATURES:tune-armv8a-crc} cortexa72" > +TUNE_FEATURES:tune-cortexa72-crc = "${TUNE_FEATURES:tune-cortexa72}" > +TUNE_FEATURES:tune-cortexa72-crc-crypto = "${TUNE_FEATURES:tune-cortexa72} crypto" > +PACKAGE_EXTRA_ARCHS:tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS:tune-armv8-crc} cortexa72" > +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72" > +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc-crypto" > BASE_LIB:tune-cortexa72 = "lib64" > BASE_LIB:tune-cortexa72-crc = "lib64" > BASE_LIB:tune-cortexa72-crc-crypto = "lib64" > -- > 2.31.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#160480): https://lists.openembedded.org/g/openembedded-core/message/160480 > Mute This Topic: https://lists.openembedded.org/mt/88369540/3616920 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [jdmason@kudzu.us] > -=-=-=-=-=-=-=-=-=-=-=- > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH] tune-cortexa72: Enable the crc extension by default for cortexa72 2022-01-12 19:23 ` Jon Mason @ 2022-01-12 21:58 ` Richard Purdie 2022-01-13 0:14 ` Khem Raj 2022-01-13 22:58 ` Jon Mason 1 sibling, 1 reply; 8+ messages in thread From: Richard Purdie @ 2022-01-12 21:58 UTC (permalink / raw) To: Jon Mason, Kevin Hao; +Cc: openembedded-core On Wed, 2022-01-12 at 14:23 -0500, Jon Mason wrote: > On Wed, Jan 12, 2022 at 4:11 AM Kevin Hao <kexin.hao@windriver.com> wrote: > > > > The crc extension is optional for the ARMv8.0 but is mandatory for the > > cortexa72, so there is no reason not to enable it for the cortexa72 > > tune. With this change, the cortexa72-crc seems redundant. But we > > had better to keep it to be compatible with the BSP which already used > > that tune. > > > > Signed-off-by: Kevin Hao <kexin.hao@windriver.com> > > Acked-by: Jon Mason <jdmason@kudzu.us> > > From the GCC sources, it's hard coded for A34, A35, A53, A57, A72, > A73, and almost all of the others listed. I can patch the rest. I did wonder if we should just drop the duplicate tune too. It will cause an error but it is an error that should be quickly/easily fixed... Cheers, Richard ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH] tune-cortexa72: Enable the crc extension by default for cortexa72 2022-01-12 21:58 ` Richard Purdie @ 2022-01-13 0:14 ` Khem Raj 2022-01-13 13:42 ` Kevin Hao 0 siblings, 1 reply; 8+ messages in thread From: Khem Raj @ 2022-01-13 0:14 UTC (permalink / raw) To: Richard Purdie; +Cc: Jon Mason, Kevin Hao, openembedded-core [-- Attachment #1: Type: text/plain, Size: 1631 bytes --] On Wed, Jan 12, 2022 at 1:58 PM Richard Purdie < richard.purdie@linuxfoundation.org> wrote: > On Wed, 2022-01-12 at 14:23 -0500, Jon Mason wrote: > > On Wed, Jan 12, 2022 at 4:11 AM Kevin Hao <kexin.hao@windriver.com> > wrote: > > > > > > The crc extension is optional for the ARMv8.0 but is mandatory for the > > > cortexa72, so there is no reason not to enable it for the cortexa72 > > > tune. With this change, the cortexa72-crc seems redundant. But we > > > had better to keep it to be compatible with the BSP which already used > > > that tune. > > > > > > Signed-off-by: Kevin Hao <kexin.hao@windriver.com> > > > > Acked-by: Jon Mason <jdmason@kudzu.us> > > > > From the GCC sources, it's hard coded for A34, A35, A53, A57, A72, > > A73, and almost all of the others listed. I can patch the rest. > > I did wonder if we should just drop the duplicate tune too. It will cause > an > error but it is an error that should be quickly/easily fixed... I am good with that problem is only for bsp layers which support multiple releases with a single branch but I guess that’s something less of a concern for me > > > Cheers, > > Richard > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#160501): > https://lists.openembedded.org/g/openembedded-core/message/160501 > Mute This Topic: https://lists.openembedded.org/mt/88369540/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > > [-- Attachment #2: Type: text/html, Size: 2852 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH] tune-cortexa72: Enable the crc extension by default for cortexa72 2022-01-13 0:14 ` Khem Raj @ 2022-01-13 13:42 ` Kevin Hao 0 siblings, 0 replies; 8+ messages in thread From: Kevin Hao @ 2022-01-13 13:42 UTC (permalink / raw) To: Khem Raj; +Cc: Richard Purdie, Jon Mason, openembedded-core [-- Attachment #1: Type: text/plain, Size: 2001 bytes --] On Wed, Jan 12, 2022 at 04:14:36PM -0800, Khem Raj wrote: > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > > On Wed, Jan 12, 2022 at 1:58 PM Richard Purdie < > richard.purdie@linuxfoundation.org> wrote: > > On Wed, 2022-01-12 at 14:23 -0500, Jon Mason wrote: > > On Wed, Jan 12, 2022 at 4:11 AM Kevin Hao <kexin.hao@windriver.com> > wrote: > > > > > > The crc extension is optional for the ARMv8.0 but is mandatory for the > > > cortexa72, so there is no reason not to enable it for the cortexa72 > > > tune. With this change, the cortexa72-crc seems redundant. But we > > > had better to keep it to be compatible with the BSP which already used > > > that tune. > > > > > > Signed-off-by: Kevin Hao <kexin.hao@windriver.com> > > > > Acked-by: Jon Mason <jdmason@kudzu.us> > > > > From the GCC sources, it's hard coded for A34, A35, A53, A57, A72, > > A73, and almost all of the others listed. I can patch the rest. > > I did wonder if we should just drop the duplicate tune too. It will cause > an > error but it is an error that should be quickly/easily fixed... > > > I am good with that problem is only for bsp layers which support multiple > releases with a single branch but I guess that’s something less of a concern > for me OK, I will send a add-on patch to drop the cortexa72-crc tune. Thanks, Kevin > > > > Cheers, > > Richard > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#160501): https://lists.openembedded.org/g/ > openembedded-core/message/160501 > Mute This Topic: https://lists.openembedded.org/mt/88369540/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [OE-core] [PATCH] tune-cortexa72: Enable the crc extension by default for cortexa72 2022-01-12 19:23 ` Jon Mason 2022-01-12 21:58 ` Richard Purdie @ 2022-01-13 22:58 ` Jon Mason 1 sibling, 0 replies; 8+ messages in thread From: Jon Mason @ 2022-01-13 22:58 UTC (permalink / raw) To: Kevin Hao; +Cc: openembedded-core, Richard Purdie On Wed, Jan 12, 2022 at 02:23:38PM -0500, Jon Mason wrote: > On Wed, Jan 12, 2022 at 4:11 AM Kevin Hao <kexin.hao@windriver.com> wrote: > > > > The crc extension is optional for the ARMv8.0 but is mandatory for the > > cortexa72, so there is no reason not to enable it for the cortexa72 > > tune. With this change, the cortexa72-crc seems redundant. But we > > had better to keep it to be compatible with the BSP which already used > > that tune. > > > > Signed-off-by: Kevin Hao <kexin.hao@windriver.com> > > Acked-by: Jon Mason <jdmason@kudzu.us> > > From the GCC sources, it's hard coded for A34, A35, A53, A57, A72, > A73, and almost all of the others listed. I can patch the rest. Looking over the other ARMv8.0 that we have tunes for, there are none that have CRC except A72 (which is now removed). And `git blame` shows I didn't add that (much to my relief). So please disregard my comment about about needing to make additional changes. Thanks, Jon > > Thanks, > Jon > > > > --- > > .../machine/include/arm/armv8a/tune-cortexa72.inc | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc > > index 3651cf6e802b..4c9add32f5f5 100644 > > --- a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc > > +++ b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc > > @@ -10,12 +10,12 @@ AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto" > > ARMPKGARCH:tune-cortexa72 = "cortexa72" > > ARMPKGARCH:tune-cortexa72-crc = "cortexa72" > > ARMPKGARCH:tune-cortexa72-crc-crypto = "cortexa72" > > -TUNE_FEATURES:tune-cortexa72 = "${TUNE_FEATURES:tune-armv8a} cortexa72" > > -TUNE_FEATURES:tune-cortexa72-crc = "${TUNE_FEATURES:tune-cortexa72} crc" > > -TUNE_FEATURES:tune-cortexa72-crc-crypto = "${TUNE_FEATURES:tune-cortexa72} crc crypto" > > -PACKAGE_EXTRA_ARCHS:tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72" > > -PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72 cortexa72-crc" > > -PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc cortexa72-crc-crypto" > > +TUNE_FEATURES:tune-cortexa72 = "${TUNE_FEATURES:tune-armv8a-crc} cortexa72" > > +TUNE_FEATURES:tune-cortexa72-crc = "${TUNE_FEATURES:tune-cortexa72}" > > +TUNE_FEATURES:tune-cortexa72-crc-crypto = "${TUNE_FEATURES:tune-cortexa72} crypto" > > +PACKAGE_EXTRA_ARCHS:tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS:tune-armv8-crc} cortexa72" > > +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72" > > +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc-crypto" > > BASE_LIB:tune-cortexa72 = "lib64" > > BASE_LIB:tune-cortexa72-crc = "lib64" > > BASE_LIB:tune-cortexa72-crc-crypto = "lib64" > > -- > > 2.31.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#160480): https://lists.openembedded.org/g/openembedded-core/message/160480 > > Mute This Topic: https://lists.openembedded.org/mt/88369540/3616920 > > Group Owner: openembedded-core+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [jdmason@kudzu.us] > > -=-=-=-=-=-=-=-=-=-=-=- > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-01-13 22:58 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-01-12 9:07 [PATCH] tune-cortexa72: Enable the crc extension by default for cortexa72 Kevin Hao 2022-01-12 17:30 ` [OE-core] " Khem Raj 2022-01-12 19:24 ` Jon Mason 2022-01-12 19:23 ` Jon Mason 2022-01-12 21:58 ` Richard Purdie 2022-01-13 0:14 ` Khem Raj 2022-01-13 13:42 ` Kevin Hao 2022-01-13 22:58 ` Jon Mason
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox