* [OE-core][PATCH] fixup! runqemu: restore support to run inside SDK
@ 2026-03-19 4:36 Qi.Chen
2026-03-19 11:38 ` Paul Barker
2026-03-20 7:15 ` [OE-core][PATCH V2] runqemu: fix the checking of STAGING_BINDIR_NATIVE Qi.Chen
0 siblings, 2 replies; 4+ messages in thread
From: Qi.Chen @ 2026-03-19 4:36 UTC (permalink / raw)
To: openembedded-core
From: Chen Qi <Qi.Chen@windriver.com>
In previous patch[1], the os.path.exists was accidently called twice.
This is incorrect.
[1] https://git.openembedded.org/openembedded-core/commit/?id=972155bbee02dd8061fee9c07a40f8e9034b9a3c
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
scripts/runqemu | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/runqemu b/scripts/runqemu
index 5587d47865..d84c6fdc1e 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -1005,7 +1005,7 @@ to your build configuration.
# If the STAGING_BINDIR_NATIVE directories from the config file don't exist
# and we're in a sourced OE build directory try to extract the paths
# from `bitbake -e`
- havenative = os.path.exists(os.path.exists(self.get('STAGING_BINDIR_NATIVE')))
+ havenative = os.path.exists(self.get('STAGING_BINDIR_NATIVE'))
if not havenative:
if not self.bitbake_e:
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [OE-core][PATCH] fixup! runqemu: restore support to run inside SDK
2026-03-19 4:36 [OE-core][PATCH] fixup! runqemu: restore support to run inside SDK Qi.Chen
@ 2026-03-19 11:38 ` Paul Barker
2026-03-20 7:10 ` ChenQi
2026-03-20 7:15 ` [OE-core][PATCH V2] runqemu: fix the checking of STAGING_BINDIR_NATIVE Qi.Chen
1 sibling, 1 reply; 4+ messages in thread
From: Paul Barker @ 2026-03-19 11:38 UTC (permalink / raw)
To: Qi.Chen, openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]
On Wed, 2026-03-18 at 21:36 -0700, Chen Qi via lists.openembedded.org
wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> In previous patch[1], the os.path.exists was accidently called twice.
> This is incorrect.
>
> [1] https://git.openembedded.org/openembedded-core/commit/?id=972155bbee02dd8061fee9c07a40f8e9034b9a3c
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> scripts/runqemu | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 5587d47865..d84c6fdc1e 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -1005,7 +1005,7 @@ to your build configuration.
> # If the STAGING_BINDIR_NATIVE directories from the config file don't exist
> # and we're in a sourced OE build directory try to extract the paths
> # from `bitbake -e`
> - havenative = os.path.exists(os.path.exists(self.get('STAGING_BINDIR_NATIVE')))
> + havenative = os.path.exists(self.get('STAGING_BINDIR_NATIVE'))
>
> if not havenative:
> if not self.bitbake_e:
Hi,
The commit title contains "fixup!", please could you re-send with a
proper title for this patch?
Best regards,
--
Paul Barker
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [OE-core][PATCH] fixup! runqemu: restore support to run inside SDK
2026-03-19 11:38 ` Paul Barker
@ 2026-03-20 7:10 ` ChenQi
0 siblings, 0 replies; 4+ messages in thread
From: ChenQi @ 2026-03-20 7:10 UTC (permalink / raw)
To: Paul Barker, openembedded-core
On 3/19/26 19:38, Paul Barker wrote:
> On Wed, 2026-03-18 at 21:36 -0700, Chen Qi via lists.openembedded.org
> wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> In previous patch[1], the os.path.exists was accidently called twice.
>> This is incorrect.
>>
>> [1] https://git.openembedded.org/openembedded-core/commit/?id=972155bbee02dd8061fee9c07a40f8e9034b9a3c
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>> scripts/runqemu | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/runqemu b/scripts/runqemu
>> index 5587d47865..d84c6fdc1e 100755
>> --- a/scripts/runqemu
>> +++ b/scripts/runqemu
>> @@ -1005,7 +1005,7 @@ to your build configuration.
>> # If the STAGING_BINDIR_NATIVE directories from the config file don't exist
>> # and we're in a sourced OE build directory try to extract the paths
>> # from `bitbake -e`
>> - havenative = os.path.exists(os.path.exists(self.get('STAGING_BINDIR_NATIVE')))
>> + havenative = os.path.exists(self.get('STAGING_BINDIR_NATIVE'))
>>
>> if not havenative:
>> if not self.bitbake_e:
> Hi,
>
> The commit title contains "fixup!", please could you re-send with a
> proper title for this patch?
>
> Best regards,
>
Got it. I'll send out V2 with another title.
Regards,
Qi
^ permalink raw reply [flat|nested] 4+ messages in thread
* [OE-core][PATCH V2] runqemu: fix the checking of STAGING_BINDIR_NATIVE
2026-03-19 4:36 [OE-core][PATCH] fixup! runqemu: restore support to run inside SDK Qi.Chen
2026-03-19 11:38 ` Paul Barker
@ 2026-03-20 7:15 ` Qi.Chen
1 sibling, 0 replies; 4+ messages in thread
From: Qi.Chen @ 2026-03-20 7:15 UTC (permalink / raw)
To: openembedded-core
From: Chen Qi <Qi.Chen@windriver.com>
In previous patch[1], the os.path.exists was accidently called twice.
This is incorrect.
[1] https://git.openembedded.org/openembedded-core/commit/?id=972155bbee02dd8061fee9c07a40f8e9034b9a3c
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
scripts/runqemu | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/runqemu b/scripts/runqemu
index 00ff77a0ed..2c126e7f54 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -1004,7 +1004,7 @@ to your build configuration.
# If the STAGING_BINDIR_NATIVE directories from the config file don't exist
# and we're in a sourced OE build directory try to extract the paths
# from `bitbake -e`
- havenative = os.path.exists(os.path.exists(self.get('STAGING_BINDIR_NATIVE')))
+ havenative = os.path.exists(self.get('STAGING_BINDIR_NATIVE'))
if not havenative:
if not self.bitbake_e:
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-20 7:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-19 4:36 [OE-core][PATCH] fixup! runqemu: restore support to run inside SDK Qi.Chen
2026-03-19 11:38 ` Paul Barker
2026-03-20 7:10 ` ChenQi
2026-03-20 7:15 ` [OE-core][PATCH V2] runqemu: fix the checking of STAGING_BINDIR_NATIVE Qi.Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox