Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] externalsrc: fix dependency chain issues
@ 2023-07-31  9:34 Peter Suti
  2023-07-31 10:15 ` [OE-core] " Richard Purdie
  0 siblings, 1 reply; 12+ messages in thread
From: Peter Suti @ 2023-07-31  9:34 UTC (permalink / raw)
  To: openembedded-core; +Cc: Peter Suti

Fixes [YOCTO #15164]

Instead of deleting setscene tasks, now SSTATE_SKIP_CREATION is set instead.

This seems to fix the compile issues where the populate_sysroot task was
not run when an externalsrc recipe was built as a dependency.

Signed-off-by: Peter Suti <peter.suti@streamunlimited.com>
---
 meta/classes/externalsrc.bbclass | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/meta/classes/externalsrc.bbclass b/meta/classes/externalsrc.bbclass
index a649bcdff8..12f2718850 100644
--- a/meta/classes/externalsrc.bbclass
+++ b/meta/classes/externalsrc.bbclass
@@ -76,6 +76,8 @@ python () {
 
         # Dummy value because the default function can't be called with blank SRC_URI
         d.setVar('SRCPV', '999')
+        # sstate is never going to work for external source trees, disable it
+        d.setVar('SSTATE_SKIP_CREATION', '1')
 
         if d.getVar('CONFIGUREOPT_DEPTRACK') == '--disable-dependency-tracking':
             d.setVar('CONFIGUREOPT_DEPTRACK', '')
@@ -83,10 +85,7 @@ python () {
         tasks = filter(lambda k: d.getVarFlag(k, "task"), d.keys())
 
         for task in tasks:
-            if task.endswith("_setscene"):
-                # sstate is never going to work for external source trees, disable it
-                bb.build.deltask(task, d)
-            elif os.path.realpath(d.getVar('S')) == os.path.realpath(d.getVar('B')):
+            if os.path.realpath(d.getVar('S')) == os.path.realpath(d.getVar('B')):
                 # Since configure will likely touch ${S}, ensure only we lock so one task has access at a time
                 d.appendVarFlag(task, "lockfiles", " ${S}/singletask.lock")
 
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2023-08-08  7:21 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-31  9:34 [PATCH] externalsrc: fix dependency chain issues Peter Suti
2023-07-31 10:15 ` [OE-core] " Richard Purdie
2023-07-31 10:43   ` Peter Suti
2023-07-31 11:06     ` Richard Purdie
2023-07-31 12:08       ` Peter Suti
2023-07-31 12:33         ` Richard Purdie
2023-08-02  9:26           ` Peter Suti
2023-08-04 14:47             ` Richard Purdie
2023-08-07 11:19               ` Peter Suti
2023-08-07 12:55                 ` Richard Purdie
2023-08-07 14:15                   ` Peter Suti
2023-08-08  7:21                     ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox