* [PATCH] ia32-base.inc: remove inapropriate grub dependency
@ 2013-04-26 15:50 tf+lists.yocto
2013-04-27 8:52 ` tf+lists.yocto
0 siblings, 1 reply; 5+ messages in thread
From: tf+lists.yocto @ 2013-04-26 15:50 UTC (permalink / raw)
To: openembedded-core
From: Tomas Frydrych <tomas@sleepfive.com>
There is no good reason for ia32 machines to have hard dependency on grub,
as there are other bootloaders available for ia32 platforms.
---
meta/conf/machine/include/ia32-base.inc | 1 -
1 file changed, 1 deletion(-)
diff --git a/meta/conf/machine/include/ia32-base.inc b/meta/conf/machine/include/ia32-base.inc
index 921c740..cb542a5 100644
--- a/meta/conf/machine/include/ia32-base.inc
+++ b/meta/conf/machine/include/ia32-base.inc
@@ -9,7 +9,6 @@ MACHINE_FEATURES += "screen keyboard pci usbhost ext2 ext3 x86 \
acpi serial usbgadget alsa"
MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts"
-MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub"
IMAGE_FSTYPES += "ext3 cpio.gz live"
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ia32-base.inc: remove inapropriate grub dependency
2013-04-26 15:50 [PATCH] ia32-base.inc: remove inapropriate grub dependency tf+lists.yocto
@ 2013-04-27 8:52 ` tf+lists.yocto
2013-05-01 20:25 ` Darren Hart
0 siblings, 1 reply; 5+ messages in thread
From: tf+lists.yocto @ 2013-04-27 8:52 UTC (permalink / raw)
To: openembedded-core; +Cc: Tomas Frydrych
From: Tomas Frydrych <tomas@sleepfive.com>
There is no good reason for ia32 machines to have hard dependency on grub,
as there are other bootloaders available for ia32 platforms.
Signed-off-by: Tomas Frydrych <tomas@sleepfive.com>
---
meta/conf/machine/include/ia32-base.inc | 1 -
1 file changed, 1 deletion(-)
diff --git a/meta/conf/machine/include/ia32-base.inc b/meta/conf/machine/include/ia32-base.inc
index 921c740..cb542a5 100644
--- a/meta/conf/machine/include/ia32-base.inc
+++ b/meta/conf/machine/include/ia32-base.inc
@@ -9,7 +9,6 @@ MACHINE_FEATURES += "screen keyboard pci usbhost ext2 ext3 x86 \
acpi serial usbgadget alsa"
MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts"
-MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub"
IMAGE_FSTYPES += "ext3 cpio.gz live"
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ia32-base.inc: remove inapropriate grub dependency
2013-04-27 8:52 ` tf+lists.yocto
@ 2013-05-01 20:25 ` Darren Hart
2013-05-01 20:51 ` Tomas Frydrych
0 siblings, 1 reply; 5+ messages in thread
From: Darren Hart @ 2013-05-01 20:25 UTC (permalink / raw)
To: tf+lists.yocto; +Cc: Tomas Frydrych, openembedded-core
On 04/27/2013 01:52 AM, tf+lists.yocto@r-finger.com wrote:
> From: Tomas Frydrych <tomas@sleepfive.com>
>
> There is no good reason for ia32 machines to have hard dependency on grub,
> as there are other bootloaders available for ia32 platforms.
>
> Signed-off-by: Tomas Frydrych <tomas@sleepfive.com>
> ---
> meta/conf/machine/include/ia32-base.inc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/meta/conf/machine/include/ia32-base.inc b/meta/conf/machine/include/ia32-base.inc
> index 921c740..cb542a5 100644
> --- a/meta/conf/machine/include/ia32-base.inc
> +++ b/meta/conf/machine/include/ia32-base.inc
> @@ -9,7 +9,6 @@ MACHINE_FEATURES += "screen keyboard pci usbhost ext2 ext3 x86 \
> acpi serial usbgadget alsa"
>
> MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts"
> -MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub"
Agreed - but do the images still build as currently written after you
remove it here?
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ia32-base.inc: remove inapropriate grub dependency
2013-05-01 20:25 ` Darren Hart
@ 2013-05-01 20:51 ` Tomas Frydrych
2013-05-01 20:56 ` Darren Hart
0 siblings, 1 reply; 5+ messages in thread
From: Tomas Frydrych @ 2013-05-01 20:51 UTC (permalink / raw)
To: Darren Hart; +Cc: openembedded-core
On 01/05/13 21:25, Darren Hart wrote:
>
>
> On 04/27/2013 01:52 AM, tf+lists.yocto@r-finger.com wrote:
>> From: Tomas Frydrych <tomas@sleepfive.com>
>>
>> There is no good reason for ia32 machines to have hard dependency on grub,
>> as there are other bootloaders available for ia32 platforms.
>>
>> Signed-off-by: Tomas Frydrych <tomas@sleepfive.com>
>> ---
>> meta/conf/machine/include/ia32-base.inc | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/meta/conf/machine/include/ia32-base.inc b/meta/conf/machine/include/ia32-base.inc
>> index 921c740..cb542a5 100644
>> --- a/meta/conf/machine/include/ia32-base.inc
>> +++ b/meta/conf/machine/include/ia32-base.inc
>> @@ -9,7 +9,6 @@ MACHINE_FEATURES += "screen keyboard pci usbhost ext2 ext3 x86 \
>> acpi serial usbgadget alsa"
>>
>> MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts"
>> -MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub"
>
> Agreed - but do the images still build as currently written after you
> remove it here?
I have not tested the efi path, though I think the grub-efi.bbclass
takes care of the grub dependency. In the non-efi case the grub
dependency is taken care of by initramfs-live-install.bb.
Tomas
--
http://sleepfive.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ia32-base.inc: remove inapropriate grub dependency
2013-05-01 20:51 ` Tomas Frydrych
@ 2013-05-01 20:56 ` Darren Hart
0 siblings, 0 replies; 5+ messages in thread
From: Darren Hart @ 2013-05-01 20:56 UTC (permalink / raw)
To: Tomas Frydrych; +Cc: openembedded-core
On 05/01/2013 01:51 PM, Tomas Frydrych wrote:
> On 01/05/13 21:25, Darren Hart wrote:
>>
>>
>> On 04/27/2013 01:52 AM, tf+lists.yocto@r-finger.com wrote:
>>> From: Tomas Frydrych <tomas@sleepfive.com>
>>>
>>> There is no good reason for ia32 machines to have hard dependency on grub,
>>> as there are other bootloaders available for ia32 platforms.
>>>
>>> Signed-off-by: Tomas Frydrych <tomas@sleepfive.com>
>>> ---
>>> meta/conf/machine/include/ia32-base.inc | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/meta/conf/machine/include/ia32-base.inc b/meta/conf/machine/include/ia32-base.inc
>>> index 921c740..cb542a5 100644
>>> --- a/meta/conf/machine/include/ia32-base.inc
>>> +++ b/meta/conf/machine/include/ia32-base.inc
>>> @@ -9,7 +9,6 @@ MACHINE_FEATURES += "screen keyboard pci usbhost ext2 ext3 x86 \
>>> acpi serial usbgadget alsa"
>>>
>>> MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts"
>>> -MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub"
>>
>> Agreed - but do the images still build as currently written after you
>> remove it here?
>
> I have not tested the efi path, though I think the grub-efi.bbclass
> takes care of the grub dependency. In the non-efi case the grub
> dependency is taken care of by initramfs-live-install.bb.
grub-efi is properly managed via the bootimg.bbclass and
MACHINE_FEATURES ~= efi.
Acked-by: Darren Hart <dvhart@linux.intel.com>
Thanks Tomas!
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-01 21:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-26 15:50 [PATCH] ia32-base.inc: remove inapropriate grub dependency tf+lists.yocto
2013-04-27 8:52 ` tf+lists.yocto
2013-05-01 20:25 ` Darren Hart
2013-05-01 20:51 ` Tomas Frydrych
2013-05-01 20:56 ` Darren Hart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox