[PATCH 0/4] fix some packages (kconfig-frontends/lttng-tools/lttng-ust/qemu) loss RDEPENDS on python

[PATCH 0/4] fix some packages (kconfig-frontends/lttng-tools/lttng-ust/qemu) loss RDEPENDS on python

[Hongxu Jia]

The following changes since commit 725fae65810c477882f7f9d02561362b3f603db0:

  bitbake: toasterui: fix typo (2013-11-20 14:06:49 +0000)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib hongxu/fix-add-python
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-add-python

Hongxu Jia (4):
  kconfig-frontends:  add python to kconfig-frontends's RDEPENDS
  lttng-ust:  add python to lttng-ust's RDEPENDS
  lttng-tools: add PACKAGECONFIG to support --enable-python-bindings and
    lttng-ust
  qemu: add bash and python to qemu's RDEPENDS

 .../kconfig-frontends/kconfig-frontends_3.12.0.0.bb  |  1 +
 meta/recipes-devtools/qemu/qemu.inc                  |  1 +
 meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb       | 20 ++++++++++++++++----
 meta/recipes-kernel/lttng/lttng-ust_2.3.1.bb         |  1 +
 4 files changed, 19 insertions(+), 4 deletions(-)

-- 
1.8.1.2

[PATCH 1/4] kconfig-frontends: add python to kconfig-frontends's RDEPENDS

[Hongxu Jia]

| Note: adding Smart RPM DB channel
|
| Note: to be installed:  kconfig-frontends@x86_64 run-postinsts@x86_64 kernel-modules@qemux86_64 packagegroup-core-boot@qemux86_64
| Loading cache...
| Updating cache...               ######################################## [100%]
|
| Computing transaction...error: Can't install kconfig-frontends-3.10.0.0-r0.0@x86_64: no package provides /usr/bin/python
|
| Saving cache...
|
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_rootfs (log file is located at tmp/work/qemux86_64-wrs-linux/wrlinux-image-glibc-small/1.0-r1/temp/do_rootfs/log.do_rootfs.30959)

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/recipes-devtools/kconfig-frontends/kconfig-frontends_3.12.0.0.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/kconfig-frontends/kconfig-frontends_3.12.0.0.bb b/meta/recipes-devtools/kconfig-frontends/kconfig-frontends_3.12.0.0.bb
index 1cebd64..f225af0 100644
--- a/meta/recipes-devtools/kconfig-frontends/kconfig-frontends_3.12.0.0.bb
+++ b/meta/recipes-devtools/kconfig-frontends/kconfig-frontends_3.12.0.0.bb
@@ -11,6 +11,7 @@ LICENSE = "GPL-2.0"
 LIC_FILES_CHKSUM = "file://COPYING;md5=9b8cf60ff39767ff04b671fca8302408"
 SECTION = "devel"
 DEPENDS += "ncurses flex bison gperf pkgconfig-native"
+RDEPENDS_${PN} += "python"
 SRC_URI = "http://ymorin.is-a-geek.org/download/${BPN}/${BP}.tar.xz"
 
 SRC_URI[md5sum] = "b939280dcc83f8feabd87a1d5f9b00c2"
-- 
1.8.1.2

[PATCH 2/4] lttng-ust: add python to lttng-ust's RDEPENDS

[Hongxu Jia]

| Note: adding Smart RPM DB channel
|
| Note: to be installed:  run-postinsts@x86_64 kernel-modules@qemux86_64 packagegroup-core-boot@qemux86_64 lttng-ust@x86_64
| Loading cache...
| Updating cache...               ######################################## [100%]
|
| Computing transaction...error: Can't install lttng-ust-2:2.3.0-r0.0@x86_64: no package provides /usr/bin/python
|
| Saving cache...
|
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_rootfs (log file is located at tmp/work/qemux86_64-wrs-linux/wrlinux-image-glibc-small/1.0-r1/temp/do_rootfs/log.do_rootfs.13619)

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/recipes-kernel/lttng/lttng-ust_2.3.1.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-kernel/lttng/lttng-ust_2.3.1.bb b/meta/recipes-kernel/lttng/lttng-ust_2.3.1.bb
index ae52ee8..228054e 100644
--- a/meta/recipes-kernel/lttng/lttng-ust_2.3.1.bb
+++ b/meta/recipes-kernel/lttng/lttng-ust_2.3.1.bb
@@ -11,6 +11,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=c963eb366b781252b0bf0fdf1624d9e9 \
 inherit autotools
 
 DEPENDS = "liburcu util-linux"
+RDEPENDS_${PN} = "python"
 
 # For backwards compatibility after rename
 RPROVIDES_${PN} = "lttng2-ust"
-- 
1.8.1.2

[PATCH 3/4] lttng-tools: add PACKAGECONFIG to support --enable-python-bindings and lttng-ust

[Hongxu Jia]

Add PACKAGECONFIG to support --enable-python-bindings
Add PACKAGECONFIG to support lttng-ust

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb b/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
index 2f6e504..64b6e02 100644
--- a/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
+++ b/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
@@ -9,9 +9,18 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=01d7fc4496aacf37d90df90b90b0cac1 \
                     file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
                     file://lgpl-2.1.txt;md5=0f0d71500e6a57fd24d825f33242b9ca"
 
-DEPENDS = "liburcu popt lttng-ust"
+DEPENDS = "liburcu popt"
 RDEPENDS_${PN}-ptest += "make"
 
+PYTHON_OPTION = "am_cv_python_pyexecdir='${libdir}/python${PYTHON_BASEVERSION}/site-packages' \
+                 am_cv_python_pythondir='${libdir}/python${PYTHON_BASEVERSION}/site-packages' \
+                 PYTHON_INCLUDE='-I${STAGING_INCDIR}/python${PYTHON_BASEVERSION}' \
+"
+PACKAGECONFIG = "python lttng-ust"
+PACKAGECONFIG[python] = "--enable-python-bindings ${PYTHON_OPTION}, \
+                         --disable-python-bindings, python swig-native"
+PACKAGECONFIG[lttng-ust] = "--enable-lttng-ust, --disable-lttng-ust, lttng-ust"
+
 SRCREV = "5d985544a7ad54afa0514ea7f522a89d8d844860"
 PV = "v2.3.1"
 
@@ -26,12 +35,15 @@ inherit autotools ptest
 
 export KERNELDIR="${STAGING_KERNEL_DIR}"
 
-FILES_${PN} += "${libdir}/lttng/libexec/*"
-FILES_${PN}-dbg += "${libdir}/lttng/libexec/.debug"
+FILES_${PN} += "${libdir}/lttng/libexec/* ${libdir}/python${PYTHON_BASEVERSION}/site-packages/*"
+FILES_${PN}-dbg += "${libdir}/lttng/libexec/.debug ${libdir}/python2.7/site-packages/.debug"
+FILES_${PN}-staticdev += "${libdir}/python${PYTHON_BASEVERSION}/site-packages/*.a"
+FILES_${PN}-dev += "${libdir}/python${PYTHON_BASEVERSION}/site-packages/*.la"
 
 # Since files are installed into ${libdir}/lttng/libexec we match 
 # the libexec insane test so skip it.
-INSANE_SKIP_${PN} = "libexec"
+# Python module needs to keep _lttng.so
+INSANE_SKIP_${PN} = "libexec dev-so"
 INSANE_SKIP_${PN}-dbg = "libexec"
 
 
-- 
1.8.1.2

[PATCH 4/4] qemu: add bash and python to qemu's RDEPENDS

[Hongxu Jia]

| Note: adding Smart RPM DB channel
|
| Note: to be installed:  qemu@x86_64 run-postinsts@x86_64 kernel-modules@qemux86_64 packagegroup-core-boot@qemux86_64
| Loading cache...
| Updating cache...               ######################################## [100%]
|
| Computing transaction...error: Can't install qemu-1.5.0-r0.0@x86_64: no package provides /usr/bin/python
|
| Saving cache...
|
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_rootfs (log file is located at tmp/work/qemux86_64-wrs-linux/wrlinux-image-glibc-small/1.0-r1/temp/do_rootfs/log.do_rootfs.21373)

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/recipes-devtools/qemu/qemu.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc
index 21ce489..3f3431d 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -5,6 +5,7 @@ DEPENDS = "glib-2.0 zlib alsa-lib virtual/libx11 pixman dtc libsdl"
 DEPENDS_class-native = "zlib-native alsa-lib-native glib-2.0-native pixman-native dtc-native"
 DEPENDS_class-nativesdk = "nativesdk-zlib nativesdk-libsdl nativesdk-glib-2.0 nativesdk-pixman nativesdk-dtc"
 RDEPENDS_${PN}_class-nativesdk = "nativesdk-libsdl"
+RDEPENDS_${PN}_class-target += "bash python"
 
 require qemu-targets.inc
 inherit autotools
-- 
1.8.1.2

Re: [PATCH 4/4] qemu: add bash and python to qemu's RDEPENDS

[Saul Wold]

Why are you adding bash to qemu?

Sau!


On 11/21/2013 05:14 AM, Hongxu Jia wrote:
> | Note: adding Smart RPM DB channel
> |
> | Note: to be installed:  qemu@x86_64 run-postinsts@x86_64 kernel-modules@qemux86_64 packagegroup-core-boot@qemux86_64
> | Loading cache...
> | Updating cache...               ######################################## [100%]
> |
> | Computing transaction...error: Can't install qemu-1.5.0-r0.0@x86_64: no package provides /usr/bin/python
> |
> | Saving cache...
> |
> | WARNING: exit code 1 from a shell command.
> | ERROR: Function failed: do_rootfs (log file is located at tmp/work/qemux86_64-wrs-linux/wrlinux-image-glibc-small/1.0-r1/temp/do_rootfs/log.do_rootfs.21373)
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>   meta/recipes-devtools/qemu/qemu.inc | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc
> index 21ce489..3f3431d 100644
> --- a/meta/recipes-devtools/qemu/qemu.inc
> +++ b/meta/recipes-devtools/qemu/qemu.inc
> @@ -5,6 +5,7 @@ DEPENDS = "glib-2.0 zlib alsa-lib virtual/libx11 pixman dtc libsdl"
>   DEPENDS_class-native = "zlib-native alsa-lib-native glib-2.0-native pixman-native dtc-native"
>   DEPENDS_class-nativesdk = "nativesdk-zlib nativesdk-libsdl nativesdk-glib-2.0 nativesdk-pixman nativesdk-dtc"
>   RDEPENDS_${PN}_class-nativesdk = "nativesdk-libsdl"
> +RDEPENDS_${PN}_class-target += "bash python"
>
>   require qemu-targets.inc
>   inherit autotools
>

Re: [PATCH 4/4] qemu: add bash and python to qemu's RDEPENDS

[Mark Hatle]

On 11/21/13, 12:42 PM, Saul Wold wrote:
>
> Why are you adding bash to qemu?

My understanding is that there was a bash script that was added as well, once 
the python rdepends was resolved.

--Mark

> Sau!
>
>
> On 11/21/2013 05:14 AM, Hongxu Jia wrote:
>> | Note: adding Smart RPM DB channel
>> |
>> | Note: to be installed:  qemu@x86_64 run-postinsts@x86_64 kernel-modules@qemux86_64 packagegroup-core-boot@qemux86_64
>> | Loading cache...
>> | Updating cache...               ######################################## [100%]
>> |
>> | Computing transaction...error: Can't install qemu-1.5.0-r0.0@x86_64: no package provides /usr/bin/python
>> |
>> | Saving cache...
>> |
>> | WARNING: exit code 1 from a shell command.
>> | ERROR: Function failed: do_rootfs (log file is located at tmp/work/qemux86_64-wrs-linux/wrlinux-image-glibc-small/1.0-r1/temp/do_rootfs/log.do_rootfs.21373)
>>
>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>> ---
>>    meta/recipes-devtools/qemu/qemu.inc | 1 +
>>    1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc
>> index 21ce489..3f3431d 100644
>> --- a/meta/recipes-devtools/qemu/qemu.inc
>> +++ b/meta/recipes-devtools/qemu/qemu.inc
>> @@ -5,6 +5,7 @@ DEPENDS = "glib-2.0 zlib alsa-lib virtual/libx11 pixman dtc libsdl"
>>    DEPENDS_class-native = "zlib-native alsa-lib-native glib-2.0-native pixman-native dtc-native"
>>    DEPENDS_class-nativesdk = "nativesdk-zlib nativesdk-libsdl nativesdk-glib-2.0 nativesdk-pixman nativesdk-dtc"
>>    RDEPENDS_${PN}_class-nativesdk = "nativesdk-libsdl"
>> +RDEPENDS_${PN}_class-target += "bash python"
>>
>>    require qemu-targets.inc
>>    inherit autotools
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

Re: [PATCH 4/4] qemu: add bash and python to qemu's RDEPENDS

[Saul Wold]

On 11/21/2013 11:40 AM, Mark Hatle wrote:
> On 11/21/13, 12:42 PM, Saul Wold wrote:
>>
>> Why are you adding bash to qemu?
>
> My understanding is that there was a bash script that was added as well,
> once the python rdepends was resolved.
>
Any chance of "de-bashing" the script?

Sau!
> --Mark
>
>> Sau!
>>
>>
>> On 11/21/2013 05:14 AM, Hongxu Jia wrote:
>>> | Note: adding Smart RPM DB channel
>>> |
>>> | Note: to be installed:  qemu@x86_64 run-postinsts@x86_64
>>> kernel-modules@qemux86_64 packagegroup-core-boot@qemux86_64
>>> | Loading cache...
>>> | Updating cache...
>>> ######################################## [100%]
>>> |
>>> | Computing transaction...error: Can't install
>>> qemu-1.5.0-r0.0@x86_64: no package provides /usr/bin/python
>>> |
>>> | Saving cache...
>>> |
>>> | WARNING: exit code 1 from a shell command.
>>> | ERROR: Function failed: do_rootfs (log file is located at
>>> tmp/work/qemux86_64-wrs-linux/wrlinux-image-glibc-small/1.0-r1/temp/do_rootfs/log.do_rootfs.21373)
>>>
>>>
>>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>>> ---
>>>    meta/recipes-devtools/qemu/qemu.inc | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/meta/recipes-devtools/qemu/qemu.inc
>>> b/meta/recipes-devtools/qemu/qemu.inc
>>> index 21ce489..3f3431d 100644
>>> --- a/meta/recipes-devtools/qemu/qemu.inc
>>> +++ b/meta/recipes-devtools/qemu/qemu.inc
>>> @@ -5,6 +5,7 @@ DEPENDS = "glib-2.0 zlib alsa-lib virtual/libx11
>>> pixman dtc libsdl"
>>>    DEPENDS_class-native = "zlib-native alsa-lib-native
>>> glib-2.0-native pixman-native dtc-native"
>>>    DEPENDS_class-nativesdk = "nativesdk-zlib nativesdk-libsdl
>>> nativesdk-glib-2.0 nativesdk-pixman nativesdk-dtc"
>>>    RDEPENDS_${PN}_class-nativesdk = "nativesdk-libsdl"
>>> +RDEPENDS_${PN}_class-target += "bash python"
>>>
>>>    require qemu-targets.inc
>>>    inherit autotools
>>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

Re: [PATCH 4/4] qemu: add bash and python to qemu's RDEPENDS

[Hongxu Jia]

On 11/22/2013 03:42 AM, Saul Wold wrote:
> On 11/21/2013 11:40 AM, Mark Hatle wrote:
>> On 11/21/13, 12:42 PM, Saul Wold wrote:
>>>
>>> Why are you adding bash to qemu?
>>
>> My understanding is that there was a bash script that was added as well,
>> once the python rdepends was resolved.
Actually the bash script break the build first, and then the python's.

>>
> Any chance of "de-bashing" the script?
I will try it.

//Hongxu

>
> Sau!
>> --Mark
>>
>>> Sau!
>>>
>>>
>>> On 11/21/2013 05:14 AM, Hongxu Jia wrote:
>>>> | Note: adding Smart RPM DB channel
>>>> |
>>>> | Note: to be installed:  qemu@x86_64 run-postinsts@x86_64
>>>> kernel-modules@qemux86_64 packagegroup-core-boot@qemux86_64
>>>> | Loading cache...
>>>> | Updating cache...
>>>> ######################################## [100%]
>>>> |
>>>> | Computing transaction...error: Can't install
>>>> qemu-1.5.0-r0.0@x86_64: no package provides /usr/bin/python
>>>> |
>>>> | Saving cache...
>>>> |
>>>> | WARNING: exit code 1 from a shell command.
>>>> | ERROR: Function failed: do_rootfs (log file is located at
>>>> tmp/work/qemux86_64-wrs-linux/wrlinux-image-glibc-small/1.0-r1/temp/do_rootfs/log.do_rootfs.21373) 
>>>>
>>>>
>>>>
>>>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>>>> ---
>>>>    meta/recipes-devtools/qemu/qemu.inc | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/meta/recipes-devtools/qemu/qemu.inc
>>>> b/meta/recipes-devtools/qemu/qemu.inc
>>>> index 21ce489..3f3431d 100644
>>>> --- a/meta/recipes-devtools/qemu/qemu.inc
>>>> +++ b/meta/recipes-devtools/qemu/qemu.inc
>>>> @@ -5,6 +5,7 @@ DEPENDS = "glib-2.0 zlib alsa-lib virtual/libx11
>>>> pixman dtc libsdl"
>>>>    DEPENDS_class-native = "zlib-native alsa-lib-native
>>>> glib-2.0-native pixman-native dtc-native"
>>>>    DEPENDS_class-nativesdk = "nativesdk-zlib nativesdk-libsdl
>>>> nativesdk-glib-2.0 nativesdk-pixman nativesdk-dtc"
>>>>    RDEPENDS_${PN}_class-nativesdk = "nativesdk-libsdl"
>>>> +RDEPENDS_${PN}_class-target += "bash python"
>>>>
>>>>    require qemu-targets.inc
>>>>    inherit autotools
>>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH 4/4] qemu: add bash and python to qemu's RDEPENDS

[Hongxu Jia]

On 11/22/2013 03:42 AM, Saul Wold wrote:
> On 11/21/2013 11:40 AM, Mark Hatle wrote:
>> On 11/21/13, 12:42 PM, Saul Wold wrote:
>>>
>>> Why are you adding bash to qemu?
>>
>> My understanding is that there was a bash script that was added as well,
>> once the python rdepends was resolved.
>>
> Any chance of "de-bashing" the script?
>

Hi Saul,

How about to de-bash the script by the following patch:
...
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -5,6 +5,7 @@ DEPENDS = "glib-2.0 zlib alsa-lib virtual/libx11 pixman 
dtc libsdl"
  DEPENDS_class-native = "zlib-native alsa-lib-native glib-2.0-native 
pixman-native dtc-native"
  DEPENDS_class-nativesdk = "nativesdk-zlib nativesdk-libsdl 
nativesdk-glib-2.0 nativesdk-pixman nativesdk-dtc"
  RDEPENDS_${PN}_class-nativesdk = "nativesdk-libsdl"
+RDEPENDS_${PN}_class-target += "python"

  require qemu-targets.inc
  inherit autotools
@@ -76,6 +77,12 @@ do_install_append() {
                 create_wrapper ${D}/${bindir}/qemu-mips \
                         QEMU_RESERVED_VA=0x0
         fi
+
+       # De-bashing the script
+       files=`grep "^\#\! *.*\/bash" ${D} -rl`
+       for f in $files; do
+                 sed -i "s:^#! *.*/bash:#! /bin/sh:" $f
+       done
  }
  # END of qemu-mips workaround
...

The build test is ok.

//Hongxu

> Sau!
>> --Mark
>>
>>> Sau!
>>>
>>>
>>> On 11/21/2013 05:14 AM, Hongxu Jia wrote:
>>>> | Note: adding Smart RPM DB channel
>>>> |
>>>> | Note: to be installed:  qemu@x86_64 run-postinsts@x86_64
>>>> kernel-modules@qemux86_64 packagegroup-core-boot@qemux86_64
>>>> | Loading cache...
>>>> | Updating cache...
>>>> ######################################## [100%]
>>>> |
>>>> | Computing transaction...error: Can't install
>>>> qemu-1.5.0-r0.0@x86_64: no package provides /usr/bin/python
>>>> |
>>>> | Saving cache...
>>>> |
>>>> | WARNING: exit code 1 from a shell command.
>>>> | ERROR: Function failed: do_rootfs (log file is located at
>>>> tmp/work/qemux86_64-wrs-linux/wrlinux-image-glibc-small/1.0-r1/temp/do_rootfs/log.do_rootfs.21373) 
>>>>
>>>>
>>>>
>>>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>>>> ---
>>>>    meta/recipes-devtools/qemu/qemu.inc | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/meta/recipes-devtools/qemu/qemu.inc
>>>> b/meta/recipes-devtools/qemu/qemu.inc
>>>> index 21ce489..3f3431d 100644
>>>> --- a/meta/recipes-devtools/qemu/qemu.inc
>>>> +++ b/meta/recipes-devtools/qemu/qemu.inc
>>>> @@ -5,6 +5,7 @@ DEPENDS = "glib-2.0 zlib alsa-lib virtual/libx11
>>>> pixman dtc libsdl"
>>>>    DEPENDS_class-native = "zlib-native alsa-lib-native
>>>> glib-2.0-native pixman-native dtc-native"
>>>>    DEPENDS_class-nativesdk = "nativesdk-zlib nativesdk-libsdl
>>>> nativesdk-glib-2.0 nativesdk-pixman nativesdk-dtc"
>>>>    RDEPENDS_${PN}_class-nativesdk = "nativesdk-libsdl"
>>>> +RDEPENDS_${PN}_class-target += "bash python"
>>>>
>>>>    require qemu-targets.inc
>>>>    inherit autotools
>>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH 4/4] qemu: add bash and python to qemu's RDEPENDS

[Hongxu Jia]

[-- Attachment #1: Type: text/plain, Size: 4471 bytes --]

On 11/22/2013 01:58 PM, Hongxu Jia wrote:
> On 11/22/2013 03:42 AM, Saul Wold wrote:
>> On 11/21/2013 11:40 AM, Mark Hatle wrote:
>>> On 11/21/13, 12:42 PM, Saul Wold wrote:
>>>>
>>>> Why are you adding bash to qemu?
>>>
>>> My understanding is that there was a bash script that was added as 
>>> well,
>>> once the python rdepends was resolved.
>>>
>> Any chance of "de-bashing" the script?
>>
>

Hi Saul,

The script could not be de-bashed,  it was made by create_wrapper
which is bashism:
Vim image/usr/bin/qemu-mips
...
#! /bin/bash
realpath=`readlink -fn $0`
export QEMU_RESERVED_VA=0x0
exec -a `dirname $realpath`/qemu-mips `dirname $realpath`/qemu-mips.real 
"$@"
...

The exec's -a option is bashism, so we need to add bash to RDEPENDS.

//Hongxu

> Hi Saul,
>
> How about to de-bash the script by the following patch:
> ...
> --- a/meta/recipes-devtools/qemu/qemu.inc
> +++ b/meta/recipes-devtools/qemu/qemu.inc
> @@ -5,6 +5,7 @@ DEPENDS = "glib-2.0 zlib alsa-lib virtual/libx11 
> pixman dtc libsdl"
>  DEPENDS_class-native = "zlib-native alsa-lib-native glib-2.0-native 
> pixman-native dtc-native"
>  DEPENDS_class-nativesdk = "nativesdk-zlib nativesdk-libsdl 
> nativesdk-glib-2.0 nativesdk-pixman nativesdk-dtc"
>  RDEPENDS_${PN}_class-nativesdk = "nativesdk-libsdl"
> +RDEPENDS_${PN}_class-target += "python"
>
>  require qemu-targets.inc
>  inherit autotools
> @@ -76,6 +77,12 @@ do_install_append() {
>                 create_wrapper ${D}/${bindir}/qemu-mips \
>                         QEMU_RESERVED_VA=0x0
>         fi
> +
> +       # De-bashing the script
> +       files=`grep "^\#\! *.*\/bash" ${D} -rl`
> +       for f in $files; do
> +                 sed -i "s:^#! *.*/bash:#! /bin/sh:" $f
> +       done
>  }
>  # END of qemu-mips workaround
> ...
>
> The build test is ok.
>
> //Hongxu
>
>> Sau!
>>> --Mark
>>>
>>>> Sau!
>>>>
>>>>
>>>> On 11/21/2013 05:14 AM, Hongxu Jia wrote:
>>>>> | Note: adding Smart RPM DB channel
>>>>> |
>>>>> | Note: to be installed:  qemu@x86_64 run-postinsts@x86_64
>>>>> kernel-modules@qemux86_64 packagegroup-core-boot@qemux86_64
>>>>> | Loading cache...
>>>>> | Updating cache...
>>>>> ######################################## [100%]
>>>>> |
>>>>> | Computing transaction...error: Can't install
>>>>> qemu-1.5.0-r0.0@x86_64: no package provides /usr/bin/python
>>>>> |
>>>>> | Saving cache...
>>>>> |
>>>>> | WARNING: exit code 1 from a shell command.
>>>>> | ERROR: Function failed: do_rootfs (log file is located at
>>>>> tmp/work/qemux86_64-wrs-linux/wrlinux-image-glibc-small/1.0-r1/temp/do_rootfs/log.do_rootfs.21373) 
>>>>>
>>>>>
>>>>>
>>>>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>>>>> ---
>>>>>    meta/recipes-devtools/qemu/qemu.inc | 1 +
>>>>>    1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/meta/recipes-devtools/qemu/qemu.inc
>>>>> b/meta/recipes-devtools/qemu/qemu.inc
>>>>> index 21ce489..3f3431d 100644
>>>>> --- a/meta/recipes-devtools/qemu/qemu.inc
>>>>> +++ b/meta/recipes-devtools/qemu/qemu.inc
>>>>> @@ -5,6 +5,7 @@ DEPENDS = "glib-2.0 zlib alsa-lib virtual/libx11
>>>>> pixman dtc libsdl"
>>>>>    DEPENDS_class-native = "zlib-native alsa-lib-native
>>>>> glib-2.0-native pixman-native dtc-native"
>>>>>    DEPENDS_class-nativesdk = "nativesdk-zlib nativesdk-libsdl
>>>>> nativesdk-glib-2.0 nativesdk-pixman nativesdk-dtc"
>>>>>    RDEPENDS_${PN}_class-nativesdk = "nativesdk-libsdl"
>>>>> +RDEPENDS_${PN}_class-target += "bash python"
>>>>>
>>>>>    require qemu-targets.inc
>>>>>    inherit autotools
>>>>>
>>>>
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


[-- Attachment #2: Type: text/html, Size: 9191 bytes --]

Re: [PATCH 3/4] lttng-tools: add PACKAGECONFIG to support --enable-python-bindings and lttng-ust

[Hongxu Jia]

On 11/21/2013 09:14 PM, Hongxu Jia wrote:
> Add PACKAGECONFIG to support --enable-python-bindings
> Add PACKAGECONFIG to support lttng-ust
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>   meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb | 20 ++++++++++++++++----
>   1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb b/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
> index 2f6e504..64b6e02 100644
> --- a/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
> +++ b/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
> @@ -9,9 +9,18 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=01d7fc4496aacf37d90df90b90b0cac1 \
>                       file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
>                       file://lgpl-2.1.txt;md5=0f0d71500e6a57fd24d825f33242b9ca"
>   
> -DEPENDS = "liburcu popt lttng-ust"
> +DEPENDS = "liburcu popt"
>   RDEPENDS_${PN}-ptest += "make"
>   
> +PYTHON_OPTION = "am_cv_python_pyexecdir='${libdir}/python${PYTHON_BASEVERSION}/site-packages' \
> +                 am_cv_python_pythondir='${libdir}/python${PYTHON_BASEVERSION}/site-packages' \
> +                 PYTHON_INCLUDE='-I${STAGING_INCDIR}/python${PYTHON_BASEVERSION}' \
> +"
> +PACKAGECONFIG = "python lttng-ust"

s/=/??=/

I have updated the git branch

   git://git.pokylinux.org/poky-contrib hongxu/fix-add-python
   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-add-python


//Hongxu

> +PACKAGECONFIG[python] = "--enable-python-bindings ${PYTHON_OPTION}, \
> +                         --disable-python-bindings, python swig-native"
> +PACKAGECONFIG[lttng-ust] = "--enable-lttng-ust, --disable-lttng-ust, lttng-ust"
> +
>   SRCREV = "5d985544a7ad54afa0514ea7f522a89d8d844860"
>   PV = "v2.3.1"
>   
> @@ -26,12 +35,15 @@ inherit autotools ptest
>   
>   export KERNELDIR="${STAGING_KERNEL_DIR}"
>   
> -FILES_${PN} += "${libdir}/lttng/libexec/*"
> -FILES_${PN}-dbg += "${libdir}/lttng/libexec/.debug"
> +FILES_${PN} += "${libdir}/lttng/libexec/* ${libdir}/python${PYTHON_BASEVERSION}/site-packages/*"
> +FILES_${PN}-dbg += "${libdir}/lttng/libexec/.debug ${libdir}/python2.7/site-packages/.debug"
> +FILES_${PN}-staticdev += "${libdir}/python${PYTHON_BASEVERSION}/site-packages/*.a"
> +FILES_${PN}-dev += "${libdir}/python${PYTHON_BASEVERSION}/site-packages/*.la"
>   
>   # Since files are installed into ${libdir}/lttng/libexec we match
>   # the libexec insane test so skip it.
> -INSANE_SKIP_${PN} = "libexec"
> +# Python module needs to keep _lttng.so
> +INSANE_SKIP_${PN} = "libexec dev-so"
>   INSANE_SKIP_${PN}-dbg = "libexec"
>   
>   

Re: [PATCH 4/4] qemu: add bash and python to qemu's RDEPENDS

[Olof Johansson]

On 13-11-22 07:25 +0100, Hongxu Jia wrote:
> Hi Saul,
> 
> The script could not be de-bashed,  it was made by create_wrapper
> which is bashism:
> Vim image/usr/bin/qemu-mips
> ...
> #! /bin/bash
> realpath=`readlink -fn $0`
> export QEMU_RESERVED_VA=0x0
> exec -a `dirname $realpath`/qemu-mips `dirname $realpath`/qemu-mips.real "$@"
> ...
> 
> The exec's -a option is bashism, so we need to add bash to RDEPENDS.

1) Is the wrapper still necessary?

The comment above the do_install_append in the recipe:

# The following fragment will create a wrapper for qemu-mips user emulation
# binary in order to work around a segmentation fault issue. Basically, by
# default, the reserved virtual address space for 32-on-64 bit is set to 4GB.
# This will trigger a MMU access fault in the virtual CPU. With this change,
# the qemu-mips works fine.
# IMPORTANT: This piece needs to be removed once the root cause is fixed!

2) More generally, is -a generally necessary when exec'ing like this? Can't
   this be solved in another way?

-- 
olofjn

Re: [PATCH 4/4] qemu: add bash and python to qemu's RDEPENDS

[Richard Purdie]

On Fri, 2013-11-22 at 09:32 +0100, Olof Johansson wrote:
> On 13-11-22 07:25 +0100, Hongxu Jia wrote:
> > Hi Saul,
> > 
> > The script could not be de-bashed,  it was made by create_wrapper
> > which is bashism:
> > Vim image/usr/bin/qemu-mips
> > ...
> > #! /bin/bash
> > realpath=`readlink -fn $0`
> > export QEMU_RESERVED_VA=0x0
> > exec -a `dirname $realpath`/qemu-mips `dirname $realpath`/qemu-mips.real "$@"
> > ...
> > 
> > The exec's -a option is bashism, so we need to add bash to RDEPENDS.
> 
> 1) Is the wrapper still necessary?
> 
> The comment above the do_install_append in the recipe:
> 
> # The following fragment will create a wrapper for qemu-mips user emulation
> # binary in order to work around a segmentation fault issue. Basically, by
> # default, the reserved virtual address space for 32-on-64 bit is set to 4GB.
> # This will trigger a MMU access fault in the virtual CPU. With this change,
> # the qemu-mips works fine.
> # IMPORTANT: This piece needs to be removed once the root cause is fixed!

Someone could retest it but as far as I know the issue still exists.

> 2) More generally, is -a generally necessary when exec'ing like this? Can't
>    this be solved in another way?

We've gone around in circles on this and yes, execing using -a is needed
and if we don't do that we hit other bugs. See the history of the
create_wrapper function.

Cheers,

Richard

Re: [PATCH 3/4] lttng-tools: add PACKAGECONFIG to support --enable-python-bindings and lttng-ust

[Saul Wold]

On 11/21/2013 05:14 AM, Hongxu Jia wrote:
> Add PACKAGECONFIG to support --enable-python-bindings
> Add PACKAGECONFIG to support lttng-ust
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>   meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb | 20 ++++++++++++++++----
>   1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb b/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
> index 2f6e504..64b6e02 100644
> --- a/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
> +++ b/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
> @@ -9,9 +9,18 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=01d7fc4496aacf37d90df90b90b0cac1 \
>                       file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
>                       file://lgpl-2.1.txt;md5=0f0d71500e6a57fd24d825f33242b9ca"
>
> -DEPENDS = "liburcu popt lttng-ust"
> +DEPENDS = "liburcu popt"
>   RDEPENDS_${PN}-ptest += "make"
>
> +PYTHON_OPTION = "am_cv_python_pyexecdir='${libdir}/python${PYTHON_BASEVERSION}/site-packages' \
> +                 am_cv_python_pythondir='${libdir}/python${PYTHON_BASEVERSION}/site-packages' \
> +                 PYTHON_INCLUDE='-I${STAGING_INCDIR}/python${PYTHON_BASEVERSION}' \
> +"
> +PACKAGECONFIG = "python lttng-ust"
> +PACKAGECONFIG[python] = "--enable-python-bindings ${PYTHON_OPTION}, \
> +                         --disable-python-bindings, python swig-native"

This seems to bring in a new dependency on "swig", which is not part of 
OE-Core.

Sau!

> +PACKAGECONFIG[lttng-ust] = "--enable-lttng-ust, --disable-lttng-ust, lttng-ust"
> +
>   SRCREV = "5d985544a7ad54afa0514ea7f522a89d8d844860"
>   PV = "v2.3.1"
>
> @@ -26,12 +35,15 @@ inherit autotools ptest
>
>   export KERNELDIR="${STAGING_KERNEL_DIR}"
>
> -FILES_${PN} += "${libdir}/lttng/libexec/*"
> -FILES_${PN}-dbg += "${libdir}/lttng/libexec/.debug"
> +FILES_${PN} += "${libdir}/lttng/libexec/* ${libdir}/python${PYTHON_BASEVERSION}/site-packages/*"
> +FILES_${PN}-dbg += "${libdir}/lttng/libexec/.debug ${libdir}/python2.7/site-packages/.debug"
> +FILES_${PN}-staticdev += "${libdir}/python${PYTHON_BASEVERSION}/site-packages/*.a"
> +FILES_${PN}-dev += "${libdir}/python${PYTHON_BASEVERSION}/site-packages/*.la"
>
>   # Since files are installed into ${libdir}/lttng/libexec we match
>   # the libexec insane test so skip it.
> -INSANE_SKIP_${PN} = "libexec"
> +# Python module needs to keep _lttng.so
> +INSANE_SKIP_${PN} = "libexec dev-so"
>   INSANE_SKIP_${PN}-dbg = "libexec"
>
>
>

Re: [PATCH 3/4] lttng-tools: add PACKAGECONFIG to support --enable-python-bindings and lttng-ust

[Hongxu Jia]

On 11/23/2013 06:30 AM, Saul Wold wrote:
> On 11/21/2013 05:14 AM, Hongxu Jia wrote:
>> Add PACKAGECONFIG to support --enable-python-bindings
>> Add PACKAGECONFIG to support lttng-ust
>>
>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>> ---
>>   meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb | 20 
>> ++++++++++++++++----
>>   1 file changed, 16 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb 
>> b/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
>> index 2f6e504..64b6e02 100644
>> --- a/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
>> +++ b/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
>> @@ -9,9 +9,18 @@ LIC_FILES_CHKSUM = 
>> "file://LICENSE;md5=01d7fc4496aacf37d90df90b90b0cac1 \
>> file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
>> file://lgpl-2.1.txt;md5=0f0d71500e6a57fd24d825f33242b9ca"
>>
>> -DEPENDS = "liburcu popt lttng-ust"
>> +DEPENDS = "liburcu popt"
>>   RDEPENDS_${PN}-ptest += "make"
>>
>> +PYTHON_OPTION = 
>> "am_cv_python_pyexecdir='${libdir}/python${PYTHON_BASEVERSION}/site-packages' 
>> \
>> + 
>> am_cv_python_pythondir='${libdir}/python${PYTHON_BASEVERSION}/site-packages' 
>> \
>> + PYTHON_INCLUDE='-I${STAGING_INCDIR}/python${PYTHON_BASEVERSION}' \
>> +"
>> +PACKAGECONFIG = "python lttng-ust"
>> +PACKAGECONFIG[python] = "--enable-python-bindings ${PYTHON_OPTION}, \
>> +                         --disable-python-bindings, python swig-native"
>
> This seems to bring in a new dependency on "swig", which is not part 
> of OE-Core.
>

Oh, The Windriver Linux have swig by default, we should
disable python for OE-Core.

s/PACKAGECONFIG = "python lttng-ust" /PACKAGECONFIG ??= "lttng-ust"/

//Hongxu
> Sau!
>
>> +PACKAGECONFIG[lttng-ust] = "--enable-lttng-ust, --disable-lttng-ust, 
>> lttng-ust"
>> +
>>   SRCREV = "5d985544a7ad54afa0514ea7f522a89d8d844860"
>>   PV = "v2.3.1"
>>
>> @@ -26,12 +35,15 @@ inherit autotools ptest
>>
>>   export KERNELDIR="${STAGING_KERNEL_DIR}"
>>
>> -FILES_${PN} += "${libdir}/lttng/libexec/*"
>> -FILES_${PN}-dbg += "${libdir}/lttng/libexec/.debug"
>> +FILES_${PN} += "${libdir}/lttng/libexec/* 
>> ${libdir}/python${PYTHON_BASEVERSION}/site-packages/*"
>> +FILES_${PN}-dbg += "${libdir}/lttng/libexec/.debug 
>> ${libdir}/python2.7/site-packages/.debug"
>> +FILES_${PN}-staticdev += 
>> "${libdir}/python${PYTHON_BASEVERSION}/site-packages/*.a"
>> +FILES_${PN}-dev += 
>> "${libdir}/python${PYTHON_BASEVERSION}/site-packages/*.la"
>>
>>   # Since files are installed into ${libdir}/lttng/libexec we match
>>   # the libexec insane test so skip it.
>> -INSANE_SKIP_${PN} = "libexec"
>> +# Python module needs to keep _lttng.so
>> +INSANE_SKIP_${PN} = "libexec dev-so"
>>   INSANE_SKIP_${PN}-dbg = "libexec"
>>
>>
>>
>

Re: [PATCH 3/4] lttng-tools: add PACKAGECONFIG to support --enable-python-bindings and lttng-ust

[Hongxu Jia]

On 11/23/2013 09:56 AM, Hongxu Jia wrote:
> On 11/23/2013 06:30 AM, Saul Wold wrote:
>> On 11/21/2013 05:14 AM, Hongxu Jia wrote:
>>> Add PACKAGECONFIG to support --enable-python-bindings
>>> Add PACKAGECONFIG to support lttng-ust
>>>
>>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>>> ---
>>>   meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb | 20 
>>> ++++++++++++++++----
>>>   1 file changed, 16 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb 
>>> b/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
>>> index 2f6e504..64b6e02 100644
>>> --- a/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
>>> +++ b/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
>>> @@ -9,9 +9,18 @@ LIC_FILES_CHKSUM = 
>>> "file://LICENSE;md5=01d7fc4496aacf37d90df90b90b0cac1 \
>>> file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
>>> file://lgpl-2.1.txt;md5=0f0d71500e6a57fd24d825f33242b9ca"
>>>
>>> -DEPENDS = "liburcu popt lttng-ust"
>>> +DEPENDS = "liburcu popt"
>>>   RDEPENDS_${PN}-ptest += "make"
>>>
>>> +PYTHON_OPTION = 
>>> "am_cv_python_pyexecdir='${libdir}/python${PYTHON_BASEVERSION}/site-packages' 
>>> \
>>> + 
>>> am_cv_python_pythondir='${libdir}/python${PYTHON_BASEVERSION}/site-packages' 
>>> \
>>> + PYTHON_INCLUDE='-I${STAGING_INCDIR}/python${PYTHON_BASEVERSION}' \
>>> +"
>>> +PACKAGECONFIG = "python lttng-ust"
>>> +PACKAGECONFIG[python] = "--enable-python-bindings ${PYTHON_OPTION}, \
>>> +                         --disable-python-bindings, python 
>>> swig-native"
>>
>> This seems to bring in a new dependency on "swig", which is not part 
>> of OE-Core.
>>
>
> Oh, The Windriver Linux have swig by default, we should
> disable python for OE-Core.
>
> s/PACKAGECONFIG = "python lttng-ust" /PACKAGECONFIG ??= "lttng-ust"/
>

Have updated the git tree to do this.

//Hongxu


> //Hongxu
>> Sau!
>>
>>> +PACKAGECONFIG[lttng-ust] = "--enable-lttng-ust, 
>>> --disable-lttng-ust, lttng-ust"
>>> +
>>>   SRCREV = "5d985544a7ad54afa0514ea7f522a89d8d844860"
>>>   PV = "v2.3.1"
>>>
>>> @@ -26,12 +35,15 @@ inherit autotools ptest
>>>
>>>   export KERNELDIR="${STAGING_KERNEL_DIR}"
>>>
>>> -FILES_${PN} += "${libdir}/lttng/libexec/*"
>>> -FILES_${PN}-dbg += "${libdir}/lttng/libexec/.debug"
>>> +FILES_${PN} += "${libdir}/lttng/libexec/* 
>>> ${libdir}/python${PYTHON_BASEVERSION}/site-packages/*"
>>> +FILES_${PN}-dbg += "${libdir}/lttng/libexec/.debug 
>>> ${libdir}/python2.7/site-packages/.debug"
>>> +FILES_${PN}-staticdev += 
>>> "${libdir}/python${PYTHON_BASEVERSION}/site-packages/*.a"
>>> +FILES_${PN}-dev += 
>>> "${libdir}/python${PYTHON_BASEVERSION}/site-packages/*.la"
>>>
>>>   # Since files are installed into ${libdir}/lttng/libexec we match
>>>   # the libexec insane test so skip it.
>>> -INSANE_SKIP_${PN} = "libexec"
>>> +# Python module needs to keep _lttng.so
>>> +INSANE_SKIP_${PN} = "libexec dev-so"
>>>   INSANE_SKIP_${PN}-dbg = "libexec"
>>>
>>>
>>>
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH 3/4] lttng-tools: add PACKAGECONFIG to support --enable-python-bindings and lttng-ust

[Saul Wold]

On 11/22/2013 06:02 PM, Hongxu Jia wrote:
> On 11/23/2013 09:56 AM, Hongxu Jia wrote:
>> On 11/23/2013 06:30 AM, Saul Wold wrote:
>>> On 11/21/2013 05:14 AM, Hongxu Jia wrote:
>>>> Add PACKAGECONFIG to support --enable-python-bindings
>>>> Add PACKAGECONFIG to support lttng-ust
>>>>
>>>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>>>> ---
>>>>   meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb | 20
>>>> ++++++++++++++++----
>>>>   1 file changed, 16 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
>>>> b/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
>>>> index 2f6e504..64b6e02 100644
>>>> --- a/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
>>>> +++ b/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb
>>>> @@ -9,9 +9,18 @@ LIC_FILES_CHKSUM =
>>>> "file://LICENSE;md5=01d7fc4496aacf37d90df90b90b0cac1 \
>>>> file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
>>>> file://lgpl-2.1.txt;md5=0f0d71500e6a57fd24d825f33242b9ca"
>>>>
>>>> -DEPENDS = "liburcu popt lttng-ust"
>>>> +DEPENDS = "liburcu popt"
>>>>   RDEPENDS_${PN}-ptest += "make"
>>>>
>>>> +PYTHON_OPTION =
>>>> "am_cv_python_pyexecdir='${libdir}/python${PYTHON_BASEVERSION}/site-packages'
>>>> \
>>>> +
>>>> am_cv_python_pythondir='${libdir}/python${PYTHON_BASEVERSION}/site-packages'
>>>> \
>>>> + PYTHON_INCLUDE='-I${STAGING_INCDIR}/python${PYTHON_BASEVERSION}' \
>>>> +"
>>>> +PACKAGECONFIG = "python lttng-ust"
>>>> +PACKAGECONFIG[python] = "--enable-python-bindings ${PYTHON_OPTION}, \
>>>> +                         --disable-python-bindings, python
>>>> swig-native"
>>>
>>> This seems to bring in a new dependency on "swig", which is not part
>>> of OE-Core.
>>>
>>
>> Oh, The Windriver Linux have swig by default, we should
>> disable python for OE-Core.
>>
>> s/PACKAGECONFIG = "python lttng-ust" /PACKAGECONFIG ??= "lttng-ust"/
>>
>
> Have updated the git tree to do this.
>

There still seems to be an issue with this patch, but it might be a 
problem with lttng-tool's configure.ac.  When --disable-python-bindings 
is set, it still tries to check for SWIG (which you might have in your 
build).

Please verify this.

Thanks
> //Hongxu
>
>
>> //Hongxu
>>> Sau!
>>>
>>>> +PACKAGECONFIG[lttng-ust] = "--enable-lttng-ust,
>>>> --disable-lttng-ust, lttng-ust"
>>>> +
>>>>   SRCREV = "5d985544a7ad54afa0514ea7f522a89d8d844860"
>>>>   PV = "v2.3.1"
>>>>
>>>> @@ -26,12 +35,15 @@ inherit autotools ptest
>>>>
>>>>   export KERNELDIR="${STAGING_KERNEL_DIR}"
>>>>
>>>> -FILES_${PN} += "${libdir}/lttng/libexec/*"
>>>> -FILES_${PN}-dbg += "${libdir}/lttng/libexec/.debug"
>>>> +FILES_${PN} += "${libdir}/lttng/libexec/*
>>>> ${libdir}/python${PYTHON_BASEVERSION}/site-packages/*"
>>>> +FILES_${PN}-dbg += "${libdir}/lttng/libexec/.debug
>>>> ${libdir}/python2.7/site-packages/.debug"
>>>> +FILES_${PN}-staticdev +=
>>>> "${libdir}/python${PYTHON_BASEVERSION}/site-packages/*.a"
>>>> +FILES_${PN}-dev +=
>>>> "${libdir}/python${PYTHON_BASEVERSION}/site-packages/*.la"
>>>>
>>>>   # Since files are installed into ${libdir}/lttng/libexec we match
>>>>   # the libexec insane test so skip it.
>>>> -INSANE_SKIP_${PN} = "libexec"
>>>> +# Python module needs to keep _lttng.so
>>>> +INSANE_SKIP_${PN} = "libexec dev-so"
>>>>   INSANE_SKIP_${PN}-dbg = "libexec"
>>>>
>>>>
>>>>
>>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
>